109672 2013-02-13 02:10:47 -0800 [Chromium] Lingering GLib references in chromium build files 2013-03-01 02:53:21 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 atwilson atwilson mrobinson oldest_to_newest 831734 0 atwilson 2013-02-13 02:10:47 -0800 There are lingering GLib references in chromium build files as fallout from r142724. 831736 1 188034 atwilson 2013-02-13 02:12:17 -0800 Created attachment 188034 Patch 834307 2 mrobinson 2013-02-15 13:07:14 -0800 Committed r143039: <http://trac.webkit.org/changeset/143039> 834313 3 mrobinson 2013-02-15 13:15:12 -0800 (In reply to comment #2) > Committed r143039: <http://trac.webkit.org/changeset/143039> I rolled out parts of this patch related to the GTK+ gyp build. We still depend on glib, we just use ICU for unicode now. :) 844997 4 188034 eric 2013-03-01 02:53:21 -0800 Comment on attachment 188034 Patch Cleared review? from attachment 188034 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 188034 2013-02-13 02:12:17 -0800 2013-03-01 02:53:21 -0800 Patch bug-109672-20130213110845.patch text/plain 6394 atwilson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNzI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGU3MDYzZWRhZTc2NzA1ZDUwZjhjZWMx NTUxODBkZjdmZDI2ZGY1YzAuLmUwOWU5MWM0MTg5NTQwNmVhZmQ2MDVkMDIyNDAwN2I2NTg3M2Qx ZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDItMTMgIEFuZHJldyBXaWxzb24gIDxhdHdp bHNvbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVW5yZXZpZXdlZCBDaHJvbWl1bSBneXAtZmls ZSBjbGVhbnVwIGFmdGVyIGdsaWIgYmFja2VuZCByZW1vdmFsLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5NjcyCisKKyAgICAgICAgUmVtb3ZlZCBy ZWZlcmVuY2VzIHRvIEdMaWIgdW5pY29kZSBiYWNrZW5kOgorCisgICAgICAgICogV1RGLmd5cC9X VEYuZ3lwOgorICAgICAgICAqIFdURi5neXBpOgorCiAyMDEzLTAyLTEyICBNYXJ0aW4gUm9iaW5z b24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBSZW1vdmUgdGhlIEdM aWIgdW5pY29kZSBiYWNrZW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTExZTJlOGM2MWQxNDUzMDI4ODAwZTYx Yzc0YzRhMWI1ODIyZDRlMi4uMDAwYTM5NjEzNmM4MWY0MDU4YzUyMTc4NWJiOGIzNzlkMGZmMDk3 ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAyLTEzICBBbmRyZXcgV2lsc29u ICA8YXR3aWxzb25AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFVucmV2aWV3ZWQgQ2hyb21pdW0g Z3lwLWZpbGUgY2xlYW51cCBhZnRlciBnbGliIGJhY2tlbmQgcmVtb3ZhbC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTY3MgorCisgICAgICAgIFJl bW92ZWQgcmVmZXJlbmNlcyB0byBHTGliIHVuaWNvZGUgYmFja2VuZDoKKworICAgICAgICAqIFdl YkNvcmUuZ3lwaToKKwogMjAxMy0wMi0xMyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJv dEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE0MjYxMS4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCAyNTFlMmNiNTQ3ZTMxNDM4MjQyOWUzMTYwNTZlNTZiYmVhMGJm ZmQ1Li5hOWI4ZThiYTZmZDUwMWZjZjNjYjA4ODk1YmJmYzJjNDQwNjgzYTY3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDItMTMgIEFuZHJldyBXaWxzb24gIDxhdHdp bHNvbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVW5yZXZpZXdlZCBDaHJvbWl1bSBneXAtZmls ZSBjbGVhbnVwIGFmdGVyIGdsaWIgYmFja2VuZCByZW1vdmFsLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5NjcyCisKKyAgICAgICAgUmVtb3ZlZCBy ZWZlcmVuY2VzIHRvIEdMaWIgdW5pY29kZSBiYWNrZW5kOgorCisgICAgICAgICogZ3lwL0NvbmZp Z3VyYXRpb24uZ3lwaS5pbjoKKyAgICAgICAgKiBneXAvRGVwZW5kZW5jaWVzLmd5cDoKKyAgICAg ICAgKiBneXAvSmF2YVNjcmlwdENvcmUuZ3lwOgorICAgICAgICAqIGd5cC9XVEYuZ3lwOgorCiAy MDEzLTAyLTEyICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAg ICAgICAyMDEzLTAyLTEwICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvV1RGLmd5cC9XVEYuZ3lwIGIvU291cmNlL1dURi9XVEYu Z3lwL1dURi5neXAKaW5kZXggZmRjNTM4NTFhMjY0NTQ1ZWFhYjdkZDUzYmYzMWM4OWVmNDIyYmQz Ny4uMzM1ZDg1ZmM2MjdhY2I0NjAxNTE4OWFmNTk5YTBkYTMxNTY0M2FkYSAxMDA2NDQKLS0tIGEv U291cmNlL1dURi9XVEYuZ3lwL1dURi5neXAKKysrIGIvU291cmNlL1dURi9XVEYuZ3lwL1dURi5n eXAKQEAgLTExMywxMSArMTEzLDkgQEAKICAgICAgICAgWydleGNsdWRlJywgJy4uL3d0Zi91cmwn XSwKICAgICAgICAgWydleGNsdWRlJywgJy4uL3d0Zi93aW5jZSddLAogICAgICAgICBbJ2V4Y2x1 ZGUnLCAnLi4vd3RmL3d4J10sCi0gICAgICAgIFsnZXhjbHVkZScsICcuLi93dGYvdW5pY29kZS9n bGliJ10sCiAgICAgICAgIFsnZXhjbHVkZScsICcuLi93dGYvdW5pY29kZS9xdDQnXSwKICAgICAg ICAgWydleGNsdWRlJywgJy4uL3d0Zi91bmljb2RlL3djaGFyJ10sCi0gICAgICAgICMgR0xpYi9H VEssIGV2ZW4gdGhvdWdoIGl0cyBuYW1lIGRvZXNuJ3QgcmVhbGx5IGluZGljYXRlLgotICAgICAg ICBbJ2V4Y2x1ZGUnLCAnLyhndGt8Z2xpYnxnb2JqZWN0KS8uKlxcLihjcHB8aCkkJ10sCisgICAg ICAgIFsnZXhjbHVkZScsICcvKGd0a3xnb2JqZWN0KS8uKlxcLihjcHB8aCkkJ10sCiAgICAgICAg IFsnZXhjbHVkZScsICcoRGVmYXVsdHxHdGt8TWFjfE5vbmV8UXR8V2lufFd4fEVmbClcXC4oY3Bw fG1tKSQnXSwKICAgICAgICAgWydleGNsdWRlJywgJ3d0Zi9PU1JhbmRvbVNvdXJjZVxcLmNwcCQn XSwKICAgICAgICAgWydleGNsdWRlJywgJ3d0Zi9NYWluVGhyZWFkLmNwcCQnXSwKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvV1RGLmd5cGkgYi9Tb3VyY2UvV1RGL1dURi5neXBpCmluZGV4IGM5NWJl ZGI2ZTQ4N2U1YWUwZjExYTgxOTFjNmVhM2RkNmZmYTgyMjYuLmQyMDdiNmUzN2I2MmJmOGI4OTkx OGQyMjdiOGMwZTc1YzgzYzRkMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvV1RGLmd5cGkKKysr IGIvU291cmNlL1dURi9XVEYuZ3lwaQpAQCAtMjU1LDggKzI1NSw2IEBACiAgICAgICAgICAgICAn d3RmL3VuaWNvZGUvU2NyaXB0Q29kZXNGcm9tSUNVLmgnLAogICAgICAgICAgICAgJ3d0Zi91bmlj b2RlL1VURjguY3BwJywKICAgICAgICAgICAgICd3dGYvdW5pY29kZS9Vbmljb2RlTWFjcm9zRnJv bUlDVS5oJywKLSAgICAgICAgICAgICd3dGYvdW5pY29kZS9nbGliL1VuaWNvZGVHTGliLmNwcCcs Ci0gICAgICAgICAgICAnd3RmL3VuaWNvZGUvZ2xpYi9Vbmljb2RlR0xpYi5oJywKICAgICAgICAg ICAgICd3dGYvdW5pY29kZS9pY3UvQ29sbGF0b3JJQ1UuY3BwJywKICAgICAgICAgICAgICd3dGYv dW5pY29kZS93Y2hhci9Vbmljb2RlV2NoYXIuY3BwJywKICAgICAgICAgICAgICd3dGYvdW5pY29k ZS93Y2hhci9Vbmljb2RlV2NoYXIuaCcsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJD b3JlLmd5cGkgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cGkKaW5kZXggODk5M2QxNWY4ODJh MjE0ZDRjM2RkMDJmZWZmODY1Njg0Zjk0OWMwMi4uNGMzNzFiY2U1MDVmZjBkMDNiOTkyM2U0YWFi M2NhOGYxYzRmZGI1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXBpCisr KyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwaQpAQCAtNDYwMSwxMCArNDYwMSw3IEBACiAg ICAgICAgICAgICAncGxhdGZvcm0vdGV4dC9jZi9TdHJpbmdJbXBsQ0YuY3BwJywKICAgICAgICAg ICAgICdwbGF0Zm9ybS90ZXh0L2Nocm9taXVtL0h5cGhlbmF0aW9uLmNwcCcsCiAgICAgICAgICAg ICAncGxhdGZvcm0vdGV4dC9jaHJvbWl1bS9UZXh0QnJlYWtJdGVyYXRvckludGVybmFsSUNVQ2hy b21pdW0uY3BwJywKLSAgICAgICAgICAgICdwbGF0Zm9ybS90ZXh0L2d0ay9UZXh0QnJlYWtJdGVy YXRvckd0ay5jcHAnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL3RleHQvZ3RrL1RleHRCcmVha0l0 ZXJhdG9ySW50ZXJuYWxJQ1VHdGsuY3BwJywKLSAgICAgICAgICAgICdwbGF0Zm9ybS90ZXh0L2d0 ay9UZXh0Q29kZWNHdGsuY3BwJywKLSAgICAgICAgICAgICdwbGF0Zm9ybS90ZXh0L2d0ay9UZXh0 Q29kZWNHdGsuaCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vdGV4dC9tYWMvSHlwaGVuYXRpb25N YWMubW0nLAogICAgICAgICAgICAgJ3BsYXRmb3JtL3RleHQvbWFjL0xvY2FsZU1hYy5oJywKICAg ICAgICAgICAgICdwbGF0Zm9ybS90ZXh0L21hYy9Mb2NhbGVNYWMubW0nLApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ndGsvZ3lwL0NvbmZpZ3VyYXRpb24uZ3lwaS5pbiBiL1NvdXJjZS9XZWJL aXQvZ3RrL2d5cC9Db25maWd1cmF0aW9uLmd5cGkuaW4KaW5kZXggYTRlOTE2MjQwMWZkNGFlNDA5 MWJjZDFjZWU5OTU1MmE3ZGVjZWViNi4uZTExNWRhNGQwZDVmZTc1YzBmNzA0NWZkN2EwYjU1Mjgz NTRhNzdkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvZ3lwL0NvbmZpZ3VyYXRpb24u Z3lwaS5pbgorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9neXAvQ29uZmlndXJhdGlvbi5neXBpLmlu CkBAIC0zMSw3ICszMSw1IEBACiAKICAgICAnVU5JQ09ERV9DRkxBR1MnOiAnQFVOSUNPREVfQ0ZM QUdTQCcsCiAgICAgJ1VOSUNPREVfTElCUyc6ICdAVU5JQ09ERV9MSUJTQCcsCi0gICAgJ0dMSUJf Q0ZMQUdTJzogJ0BHTElCX0NGTEFHU0AnLAotICAgICdHTElCX0xJQlMnOiAnQEdMSUJfTElCU0An LAogICB9CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9neXAvRGVwZW5kZW5jaWVz Lmd5cCBiL1NvdXJjZS9XZWJLaXQvZ3RrL2d5cC9EZXBlbmRlbmNpZXMuZ3lwCmluZGV4IGU3ODY1 NTRlMDVhNDdlMmQ4NTZjMGFlY2E2OWNmMmE0MWZjNTY4NTMuLjRmYTcxOWJiMzc3ZjFjNGQ1YTgw NDgzM2MzMzMxOGY2MTIxYzYyN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL2d5cC9E ZXBlbmRlbmNpZXMuZ3lwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL2d5cC9EZXBlbmRlbmNpZXMu Z3lwCkBAIC0xLDE2ICsxLDYgQEAKIHsKICAgJ3RhcmdldHMnOiBbCiAgICAgewotICAgICAgJ3Rh cmdldF9uYW1lJzogJ2dsaWInLAotICAgICAgJ3R5cGUnOiAnbm9uZScsCi0gICAgICAnZGlyZWN0 X2RlcGVuZGVudF9zZXR0aW5ncyc6IHsKLSAgICAgICAgJ2NmbGFncyc6IFsgJzxAKEdMSUJfQ0ZM QUdTKScgXSwKLSAgICAgICAgJ2xpbmtfc2V0dGluZ3MnOiB7Ci0gICAgICAgICAgJ2xpYnJhcmll cycgOiBbICc8QChHTElCX0xJQlMpJyBdLAotICAgICAgICB9LAotICAgICAgfSwKLSAgICB9LAot ICAgIHsKICAgICAgICd0YXJnZXRfbmFtZSc6ICdpY3UnLAogICAgICAgJ3R5cGUnOiAnbm9uZScs CiAgICAgICAnZGlyZWN0X2RlcGVuZGVudF9zZXR0aW5ncyc6IHsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvZ3RrL2d5cC9KYXZhU2NyaXB0Q29yZS5neXAgYi9Tb3VyY2UvV2ViS2l0L2d0ay9n eXAvSmF2YVNjcmlwdENvcmUuZ3lwCmluZGV4IDc3NGRmOGExZWFiNWEzNDRhYTQyYTQ0ZTBiNDll NzMyZGM1YTJhZjkuLjE5MjY4NWE4MjlkNGM3ZGNlMWZmNDE5Yjc3NjRjZjU2ZGNiMjYzZDggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL2d5cC9KYXZhU2NyaXB0Q29yZS5neXAKKysrIGIv U291cmNlL1dlYktpdC9ndGsvZ3lwL0phdmFTY3JpcHRDb3JlLmd5cApAQCAtNjksNyArNjksNiBA QAogICAgICAgICAnZGVwZW5kZW5jaWVzJzogWwogICAgICAgICAgICdXVEYuZ3lwOnd0ZicsCiAg ICAgICAgICAgJ0xMSW50T2Zmc2V0RXh0cmFjdG9yJywKLSAgICAgICAgICAnRGVwZW5kZW5jaWVz Lmd5cDpnbGliJywKICAgICAgICAgICAnRGVwZW5kZW5jaWVzLmd5cDppY3UnLAogICAgICAgICBd LAogICAgICAgICAncHJvZHVjdF9leHRlbnNpb24nOiAnc28uPEAoamF2YXNjcmlwdGNvcmVfc29u YW1lX3ZlcnNpb24pJywKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL2d5cC9XVEYuZ3lw IGIvU291cmNlL1dlYktpdC9ndGsvZ3lwL1dURi5neXAKaW5kZXggZGNiOTRiN2M0ZWE4NmFlN2M1 NTMzMzM1ZDE0NjI0ZDU0MTk2NTk1Yy4uMGY0YmVkMzVlMDJiNWFiZWQ1ZDIzODg5ZGYwZDdlY2Uw ZDU1MmJhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvZ3lwL1dURi5neXAKKysrIGIv U291cmNlL1dlYktpdC9ndGsvZ3lwL1dURi5neXAKQEAgLTExLDcgKzExLDYgQEAKICAgICAgICd0 YXJnZXRfbmFtZSc6ICd3dGYnLAogICAgICAgJ3R5cGUnOiAnc3RhdGljX2xpYnJhcnknLAogICAg ICAgJ2RlcGVuZGVuY2llcyc6IFsKLSAgICAgICAgJ0RlcGVuZGVuY2llcy5neXA6Z2xpYicsCiAg ICAgICAgICdEZXBlbmRlbmNpZXMuZ3lwOmljdScsCiAgICAgICAgXSwKICAgICAgICdpbmNsdWRl X2RpcnMnOiBbCg==