109667 2013-02-12 23:37:02 -0800 [V8] There is no XXXConstructor that requires a custom getter 2013-02-13 00:11:44 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 831676 0 haraken 2013-02-12 23:37:02 -0800 Currently '[Custom] attribute XXXConstructor xxx' generates XXXAttrGetter(). However, there is no XXXConstructor with [Custom]. In addition, it does make no sense to generate XXXAttrGetter() for such cases. We can remove the logic from CodeGeneratorV8.pm. 831677 1 188021 haraken 2013-02-12 23:38:22 -0800 Created attachment 188021 Patch 831695 2 188021 webkit.review.bot 2013-02-13 00:11:41 -0800 Comment on attachment 188021 Patch Clearing flags on attachment: 188021 Committed r142727: <http://trac.webkit.org/changeset/142727> 831696 3 webkit.review.bot 2013-02-13 00:11:44 -0800 All reviewed patches have been landed. Closing bug. 188021 2013-02-12 23:38:22 -0800 2013-02-13 00:11:40 -0800 Patch bug-109667-20130213163451.patch text/plain 2205 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjYwYzBhYzAyODYyOWMx Zjc3ZjZmZDcwYmVjNmQ2Mzk5MzkzMWViNS4uMDQ1ZjU5YjE2NjBmNDAyODJhNzM2MDg5ZWJmNTNm ZWRmMTYzNTMwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAyLTEyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFRoZXJlIGlz IG5vIFhYWENvbnN0cnVjdG9yIHRoYXQgcmVxdWlyZXMgYSBjdXN0b20gZ2V0dGVyCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk2NjcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50bHkgJ1tDdXN0 b21dIGF0dHJpYnV0ZSBYWFhDb25zdHJ1Y3RvciB4eHgnIGdlbmVyYXRlcworICAgICAgICBYWFhB dHRyR2V0dGVyKCkuIEhvd2V2ZXIsIHRoZXJlIGlzIG5vIFhYWENvbnN0cnVjdG9yIHdpdGggW0N1 c3RvbV0uCisgICAgICAgIEluIGFkZGl0aW9uLCBpdCBkb2VzIG1ha2Ugbm8gc2Vuc2UgdG8gZ2Vu ZXJhdGUgWFhYQXR0ckdldHRlcigpIGZvciBzdWNoIGNhc2VzLgorICAgICAgICBXZSBjYW4gcmVt b3ZlIHRoZSBsb2dpYyBmcm9tIENvZGVHZW5lcmF0b3JWOC5wbS4KKworICAgICAgICAqIGJpbmRp bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtOgorICAgICAgICAoR2VuZXJhdGVTaW5nbGVC YXRjaGVkQXR0cmlidXRlKToKKwogMjAxMy0wMi0xMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jh cm9AYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEVuYWJsZSBQQUdFX1ZJU0lCSUxJVFlfQVBJ CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0 b3JWOC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4 LnBtCmluZGV4IDg2ZjhlYWJmZjFhZjFhMWE0YzZmNTY4NmJjMjhmNWU3YTZmNTI3NDYuLjE4N2Yw ZjEwYTZmZGRjNmNjN2QzNjE1NTJiNGMxYWY3YzEyMGQ1MWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0yMjk2LDEyICsy Mjk2LDggQEAgc3ViIEdlbmVyYXRlU2luZ2xlQmF0Y2hlZEF0dHJpYnV0ZQogICAgICAgICBpZiAo JGNvbnN0cnVjdG9yVHlwZSAhfiAvQ29uc3RydWN0b3IkLyB8fCAkYXR0cmlidXRlLT5zaWduYXR1 cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJWOEN1c3RvbUNvbnN0cnVjdG9yIn0gfHwgJGF0dHJp YnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ3VzdG9tQ29uc3RydWN0b3Ii fSkgewogICAgICAgICAgICAgQWRkVG9JbXBsSW5jbHVkZXMoIlY4JHtjb25zdHJ1Y3RvclR5cGV9 LmgiLCAkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDb25kaXRp b25hbCJ9KTsKICAgICAgICAgfQotICAgICAgICBpZiAoJGN1c3RvbUFjY2Vzc29yKSB7Ci0gICAg ICAgICAgICAkZ2V0dGVyID0gIlY4JHtjdXN0b21BY2Nlc3Nvcn1BY2Nlc3NvckdldHRlciI7Ci0g ICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAkZGF0YSA9ICImVjgke2NvbnN0cnVjdG9yVHlw ZX06OmluZm8iOwotICAgICAgICAgICAgJGdldHRlciA9ICIke2ludGVyZmFjZU5hbWV9VjhJbnRl cm5hbDo6JHtpbnRlcmZhY2VOYW1lfUNvbnN0cnVjdG9yR2V0dGVyIjsKLSAgICAgICAgfQorICAg ICAgICAkZGF0YSA9ICImVjgke2NvbnN0cnVjdG9yVHlwZX06OmluZm8iOworICAgICAgICAkZ2V0 dGVyID0gIiR7aW50ZXJmYWNlTmFtZX1WOEludGVybmFsOjoke2ludGVyZmFjZU5hbWV9Q29uc3Ry dWN0b3JHZXR0ZXIiOwogICAgICAgICAkc2V0dGVyID0gIiR7aW50ZXJmYWNlTmFtZX1WOEludGVy bmFsOjoke2ludGVyZmFjZU5hbWV9UmVwbGFjZWFibGVBdHRyU2V0dGVyIjsKICAgICB9IGVsc2Ug ewogICAgICAgICAjIERlZmF1bHQgR2V0dGVyIGFuZCBTZXR0ZXIK