109660 2013-02-12 21:22:07 -0800 Eradicate fast/js/dfg-poison-fuzz.html 2013-02-12 22:23:17 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dgorbik dgorbik barraclough benjamin dgorbik fpizlo ggaren mark.lam mhahnenberg msaboff oliver webkit.review.bot oldest_to_newest 831604 0 dgorbik 2013-02-12 21:22:07 -0800 Skipping the flacky test fast/js/dfg-poison-fuzz.html 831605 1 188004 dgorbik 2013-02-12 21:22:35 -0800 Created attachment 188004 Patch 831612 2 webkit.review.bot 2013-02-12 21:34:52 -0800 Attachment 188004 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac/TestExpectations']" exit_code: 1 LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 831626 3 188004 benjamin 2013-02-12 22:01:05 -0800 Comment on attachment 188004 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188004&action=review > LayoutTests/platform/mac/TestExpectations:1339 > +# Timing out or crashing. > +webkit.org/b/109657 fast/js/dfg-poison-fuzz.html [ Crash Timeout Pass ] I think this needs [ Debug ]. It looks like the test works fine webkit.org/b/109657 [ Debug ] fast/js/dfg-poison-fuzz.html [ Timeout Pass ] The test seems to Pass fairly reliably in release. 831635 4 fpizlo 2013-02-12 22:17:28 -0800 Actually, I haven't seen this test fail in *ages*. And I've seen a lot of DFG bugs! This is a super expensive test for one bug that used to be in the DFG but that has since been thoroughly eradicated. Likely the plethora of other DFG tests cover that bug. Heck, I'm not even sure if the code that this covers is even in the repository anymore. I will remove it. 831636 5 fpizlo 2013-02-12 22:18:05 -0800 (In reply to comment #4) > Actually, I haven't seen this test fail in *ages*. And I've seen a lot of DFG bugs! > > This is a super expensive test for one bug that used to be in the DFG but that has since been thoroughly eradicated. Likely the plethora of other DFG tests cover that bug. Heck, I'm not even sure if the code that this covers is even in the repository anymore. > > I will remove it. (If anyone disagrees feel free to roll out my eradication patch.) 831643 6 fpizlo 2013-02-12 22:23:03 -0800 Landed in http://trac.webkit.org/changeset/142723 831644 7 188004 fpizlo 2013-02-12 22:23:17 -0800 Comment on attachment 188004 Patch Clearing flags for obsolete patch. 188004 2013-02-12 21:22:35 -0800 2013-02-12 22:23:16 -0800 Patch bug-109660-20130212211905.patch text/plain 1203 dgorbik U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNzE0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzNmNzNmMjNhZTJkZTQ0ZjVmZjI3 MWRiZDg5MTliZmYwOGFjYzJmOS4uM2E1ZGJhMzZkNGY1YWE2MDA5OGRmZmMzYmI0NTU4NWViZTZl ZWRmMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDExIEBACisyMDEzLTAyLTEyICBEaW1hIEdvcmJpayAgPGRn b3JiaWtAYXBwbGUuY29tPgorCisgICAgICAgIFNraXBwaW5nIHRoZSBmbGFja3kgdGVzdAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v bWFjL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTMtMDItMTIgIE5hdGUgQ2hhcGluICA8amFwaGV0 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OOiBSZWxvYWRpbmcgYSBsb2NhbCBm aWxlIGRvZXNuJ3QgcGljayB1cCBjaGFuZ2VzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0 RXhwZWN0YXRpb25zCmluZGV4IDViZjA4ZmYzODI3M2NmZjliMzE0ZGVjZmFmNDJhZjc4ZDFlZTUx ZGQuLmJiOTI3Y2JhNzdlZDAzMGZiMTdkYzZmMzM5ZTNlNTMyZDRhZmRjZGMgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRl c3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMzM0LDMgKzEzMzQsNiBAQCB3 ZWJraXQub3JnL2IvMTA5MjA5IGZhc3QvdGV4dC9pbnRlcm5hdGlvbmFsL2JpZGktaWdub3JlZC1m b3ItZmlyc3QtY2hpbGQtaW5saW5lLgogCiAjIENyYXNoaW5nIGFmdGVyIGh0dHBzOi8vd2Via2l0 Lm9yZy9iLzEwNTY2Nwogd2Via2l0Lm9yZy9iLzEwOTIzMiBbIERlYnVnIF0gaW5zcGVjdG9yL2Rl YnVnZ2VyL2RlYnVnZ2VyLXJlbG9hZC1vbi1wYXVzZS5odG1sIFsgQ3Jhc2ggXQorCisjIFRpbWlu ZyBvdXQgb3IgY3Jhc2hpbmcuCit3ZWJraXQub3JnL2IvMTA5NjU3IGZhc3QvanMvZGZnLXBvaXNv bi1mdXp6Lmh0bWwgWyBDcmFzaCBUaW1lb3V0IFBhc3MgXQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9m IGZpbGUK