109652 2013-02-12 19:57:59 -0800 Unnecessary and confusing includes in StreamBuffer.h 2013-02-12 21:18:59 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 tyoshino tyoshino benjamin cmarcelo ojan.autocc toyoshim webkit.review.bot oldest_to_newest 831553 0 tyoshino 2013-02-12 19:57:59 -0800 StreamBuffer.h is using OwnPtr for storing Vectors into a Deque. FixedArray.h and PassOwnPtr.h are included but not used. VectorTraits defines how to move OwnPtr in Vector. It's done by memcpy. So, there's no need for PassOwnPtr (Deque<PassOwnPtr<Vector<char> > > is even slower). 831557 1 187995 tyoshino 2013-02-12 20:10:52 -0800 Created attachment 187995 Patch 831602 2 187995 webkit.review.bot 2013-02-12 21:18:56 -0800 Comment on attachment 187995 Patch Clearing flags on attachment: 187995 Committed r142718: <http://trac.webkit.org/changeset/142718> 831603 3 webkit.review.bot 2013-02-12 21:18:59 -0800 All reviewed patches have been landed. Closing bug. 187995 2013-02-12 20:10:52 -0800 2013-02-12 21:18:56 -0800 Patch bug-109652-20130213130721.patch text/plain 1324 tyoshino U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDJmZGI2NmUwYTM0NjExOTBmMTJlYjlh ZjM3NDE4M2FlNjMyZGI4ODguLjc4MmY0ODM5NDczNjUzODlkZWRmZTI1MWRmYTY4MzQwMTQ4ZGU2 MTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTMtMDItMTIgIFRha2VzaGkgWW9zaGlubyAgPHR5 b3NoaW5vQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVubmVjZXNzYXJ5IGFuZCBjb25m dXNpbmcgaW5jbHVkZXMgZnJvbSBTdHJlYW1CdWZmZXIuaC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTY1MgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0cmVhbUJ1ZmZlci5oIGlzIHVzaW5nIE93blB0 ciBmb3Igc3RvcmluZyBWZWN0b3JzIGludG8gYSBEZXF1ZS4KKyAgICAgICAgRml4ZWRBcnJheS5o IGFuZCBQYXNzT3duUHRyLmggYXJlIGluY2x1ZGVkIGJ1dCBub3QgdXNlZC4KKworICAgICAgICBW ZWN0b3JUcmFpdHMgZGVmaW5lcyBob3cgdG8gbW92ZSBPd25QdHIgaW4gVmVjdG9yLiBJdCdzIGRv bmUgYnkgbWVtY3B5LgorICAgICAgICBTbywgdGhlcmUncyBubyBuZWVkIGZvciBQYXNzT3duUHRy IChEZXF1ZTxQYXNzT3duUHRyPFZlY3RvcjxjaGFyPiA+ID4KKyAgICAgICAgaXMgZXZlbiBzbG93 ZXIpLgorCisgICAgICAgICogd3RmL1N0cmVhbUJ1ZmZlci5oOgorCiAyMDEzLTAyLTExICBPbGl2 ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQgZml4LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvU3RyZWFtQnVmZmVyLmggYi9Tb3VyY2UvV1RGL3d0Zi9TdHJl YW1CdWZmZXIuaAppbmRleCBlN2Q5NThmNjljMzJmYzkyNTFmY2UxYTAzYTNkOWYzY2ViZGU2M2Vm Li4zMDE1ZmMyNzk3ODYzNDc2YTMwYTg4YTMwYjU2MWM1MjczZThkZWYyIDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi9TdHJlYW1CdWZmZXIuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9TdHJlYW1C dWZmZXIuaApAQCAtMzIsOSArMzIsNyBAQAogI2RlZmluZSBXVEZfU3RyZWFtQnVmZmVyX2gKIAog I2luY2x1ZGUgPHd0Zi9EZXF1ZS5oPgotI2luY2x1ZGUgPHd0Zi9GaXhlZEFycmF5Lmg+CiAjaW5j bHVkZSA8d3RmL093blB0ci5oPgotI2luY2x1ZGUgPHd0Zi9QYXNzT3duUHRyLmg+CiAKIG5hbWVz cGFjZSBXVEYgewogCg==