109646 2013-02-12 18:20:18 -0800 Constrain fixed layers to the viewport, not the document 2013-02-17 11:20:13 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser bdakin benjamin cdumez dglazkov eric noam ojan.autocc simon.fraser webkit.review.bot oldest_to_newest 831494 0 simon.fraser 2013-02-12 18:20:18 -0800 RenderLayerBacking::updateCompositedBounds() has code to constrain composited layer positions to the document rect. This is bad for fixed-position elements, because this constrained rect will change every time the scroll offset changes. This means that whenever layout happens (which causes us to update compositing layers), we'll recompute the fixed layer bounds, and change it if we scrolled, and that will result in jiggles. 831502 1 187984 simon.fraser 2013-02-12 18:26:19 -0800 Created attachment 187984 Patch 831615 2 187984 webkit.review.bot 2013-02-12 21:36:55 -0800 Comment on attachment 187984 Patch Attachment 187984 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16522575 New failing tests: compositing/geometry/limit-layer-bounds-fixed.html platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-fixed.html 831651 3 187984 benjamin 2013-02-12 22:40:42 -0800 Comment on attachment 187984 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187984&action=review > LayoutTests/ChangeLog:11 > + Constrain fixed layers to the viewport, not the document > + https://bugs.webkit.org/show_bug.cgi?id=109646 > + > + Reviewed by NOBODY (OOPS!). > + > + Test with a big fixed element in a compositing layer. > + > + * compositing/geometry/limit-layer-bounds-fixed-expected.txt: Added. > + * compositing/geometry/limit-layer-bounds-fixed.html: Added. Wouldn't it be better to test this with a ref-test? 831654 4 simon.fraser 2013-02-12 22:45:48 -0800 (In reply to comment #3) > Wouldn't it be better to test this with a ref-test? No; the visible appearance is the unchanged (unless we ref-test the layerTreeAsText output, which is weird!). 831659 5 benjamin 2013-02-12 23:00:20 -0800 (In reply to comment #4) > No; the visible appearance is the unchanged (unless we ref-test the layerTreeAsText output, which is weird!). I think I fail to see how the output verify the change. Would you mind explaining a bit how the layers differed before the change? 833259 6 187984 bdakin 2013-02-14 11:18:29 -0800 Comment on attachment 187984 Patch Looks good! You should address Benjamin's question though. 833263 7 simon.fraser 2013-02-14 11:21:03 -0800 (In reply to comment #5) > (In reply to comment #4) > > No; the visible appearance is the unchanged (unless we ref-test the layerTreeAsText output, which is weird!). > > I think I fail to see how the output verify the change. Would you mind explaining a bit how the layers differed before the change? The (bounds 300.00 200.00) for the fixed layer are different (smaller) with the patch. 834494 8 simon.fraser 2013-02-15 16:43:36 -0800 *** Bug 108556 has been marked as a duplicate of this bug. *** 834519 9 simon.fraser 2013-02-15 17:11:16 -0800 http://trac.webkit.org/changeset/143073 834987 10 cdumez 2013-02-17 07:33:17 -0800 The new test appears to be failing on WK2 EFL: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r143117%20(9569)/compositing/geometry/limit-layer-bounds-fixed-pretty-diff.html 835011 11 simon.fraser 2013-02-17 11:20:13 -0800 EFL might not do compositing for fixed pos. It should just get a new baseline. 187984 2013-02-12 18:26:19 -0800 2013-02-14 11:18:28 -0800 Patch bug-109646-20130212182247.patch text/plain 5918 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDBhMGYxNWVhMmU2YTE3 N2Q3MzI1OGI1ZDVkZDA0MDQ1MzEwMjEwNi4uNGMyOTQ2ODY2ODY5NDkwMTM2ZTFjYWZmMTk5NTlh ODZmNTk2OWY2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEzLTAyLTEyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIENvbnN0cmFpbiBm aXhlZCBsYXllcnMgdG8gdGhlIHZpZXdwb3J0LCBub3QgdGhlIGRvY3VtZW50CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk2NDYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEl0J3MgYmFkIHRv IGNvbnN0cmFpbiBwb3NpdGlvbjpmaXhlZCBjb21wb3NpdGluZyBsYXllcnMgdG8gdGhlCisgICAg ICAgIGRvY3VtZW50IHJlY3QsIGJlY2F1c2UgdGhlaXIgYm91bmRzIHdpbGwgY2hhbmdlIGV2ZXJ5 IHRpbWUgdGhlIHNjcm9sbAorICAgICAgICBwb3NpdGlvbiBjaGFuZ2VzLCBhbmQgd2UncmUgbm90 IGdvb2QgY3VycmVudGx5IGF0IHN5bmNocm9uaXppbmcgc2Nyb2xsaW5nCisgICAgICAgIHRocmVh ZCBsYXllciB1cGRhdGVzIHdpdGggbWFpbiB0aHJlYWQgbGF5ZXIgdXBkYXRlcywgc28gamlnZ2xl cyBlbnN1ZS4KKyAgICAgICAgCisgICAgICAgIEZpeCBieSBjb25zdHJhaW5pbmcgcG9zaXRpb246 Zml4ZWQgbGF5ZXJzIHRvIHRoZSB2aWV3cG9ydC4KKworICAgICAgICBUZXN0OiBjb21wb3NpdGlu Zy9nZW9tZXRyeS9saW1pdC1sYXllci1ib3VuZHMtZml4ZWQuaHRtbAorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJM YXllckJhY2tpbmc6OnVwZGF0ZUNvbXBvc2l0ZWRCb3VuZHMpOgorCisyMDEzLTAyLTEyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCiAgICAgICAgIENyYXNoIHdoZW4g c2Nyb2xsaW5nIHNvb24gYWZ0ZXIgcGFnZSBzdGFydHMgbG9hZGluZwogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5NjMxCiAgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8xMzE1NzUzMyYxMzE1OTYyNyYxMzE5NjcyNz4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKaW5kZXggN2ExMjYwYzM1ZjVmNWE3YTg4 Y2FjMTZkOWVlZmZjMTZjZWRjYzMzMi4uNDBmZjVlMzA2YzkwNDY4ODVhNzQ3NDFiMjg3ZTUyYWVi MzMzZTA3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVy QmFja2luZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFj a2luZy5jcHAKQEAgLTQwNSw4ICs0MDUsMTEgQEAgdm9pZCBSZW5kZXJMYXllckJhY2tpbmc6OnVw ZGF0ZUNvbXBvc2l0ZWRCb3VuZHMoKQogICAgICAgICBSZW5kZXJWaWV3KiB2aWV3ID0gbV9vd25p bmdMYXllci0+cmVuZGVyZXIoKS0+dmlldygpOwogICAgICAgICBSZW5kZXJMYXllciogcm9vdExh eWVyID0gdmlldy0+bGF5ZXIoKTsKIAotICAgICAgICAvLyBTdGFydCBieSBjbGlwcGluZyB0byB0 aGUgZG9jdW1lbnQncyBib3VuZHMuCi0gICAgICAgIExheW91dFJlY3QgY2xpcHBpbmdCb3VuZHMg PSB2aWV3LT51bnNjYWxlZERvY3VtZW50UmVjdCgpOworICAgICAgICBMYXlvdXRSZWN0IGNsaXBw aW5nQm91bmRzOworICAgICAgICBpZiAocmVuZGVyZXIoKS0+c3R5bGUoKS0+cG9zaXRpb24oKSA9 PSBGaXhlZFBvc2l0aW9uICYmIHJlbmRlcmVyKCktPmNvbnRhaW5lcigpID09IHZpZXcpCisgICAg ICAgICAgICBjbGlwcGluZ0JvdW5kcyA9IHZpZXctPmZyYW1lVmlldygpLT52aWV3cG9ydENvbnN0 cmFpbmVkVmlzaWJsZUNvbnRlbnRSZWN0KCk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIGNs aXBwaW5nQm91bmRzID0gdmlldy0+dW5zY2FsZWREb2N1bWVudFJlY3QoKTsKIAogICAgICAgICBp ZiAobV9vd25pbmdMYXllciAhPSByb290TGF5ZXIpCiAgICAgICAgICAgICBjbGlwcGluZ0JvdW5k cy5pbnRlcnNlY3QobV9vd25pbmdMYXllci0+YmFja2dyb3VuZENsaXBSZWN0KFJlbmRlckxheWVy OjpDbGlwUmVjdHNDb250ZXh0KHJvb3RMYXllciwgMCwgQWJzb2x1dGVDbGlwUmVjdHMpKS5yZWN0 KCkpOyAvLyBGSVhNRTogSW5jb3JyZWN0IGZvciBDU1MgcmVnaW9ucy4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlYmI0Zjkx YTE1YjYwYzVmYWU0MjJjYjhhODk0MzhhNTA3YzYyNGIzLi42MTY0YTVlZGNhZDRhOTkwNzNhZjQw ZjY1ZmYyY2Y5MWJiMjQ3MGNkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDItMTIgIFNp bW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgQ29uc3RyYWlu IGZpeGVkIGxheWVycyB0byB0aGUgdmlld3BvcnQsIG5vdCB0aGUgZG9jdW1lbnQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTY0NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGVzdCB3aXRo IGEgYmlnIGZpeGVkIGVsZW1lbnQgaW4gYSBjb21wb3NpdGluZyBsYXllci4KKworICAgICAgICAq IGNvbXBvc2l0aW5nL2dlb21ldHJ5L2xpbWl0LWxheWVyLWJvdW5kcy1maXhlZC1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIGNvbXBvc2l0aW5nL2dlb21ldHJ5L2xpbWl0LWxheWVyLWJv dW5kcy1maXhlZC5odG1sOiBBZGRlZC4KKwogMjAxMy0wMi0xMiAgRGVhbiBKYWNrc29uICA8ZGlu b0BhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gUmVtb3ZlIHdlYmludGVudHMgZnJv bSBUZXN0RXhwZWN0YXRpb25zIG9uIG1hYyAtIGRpcmVjdG9yeSBubyBsb25nZXIgZXhpc3RzLgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvZ2VvbWV0cnkvbGltaXQtbGF5ZXIt Ym91bmRzLWZpeGVkLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2dlb21l dHJ5L2xpbWl0LWxheWVyLWJvdW5kcy1maXhlZC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYWVj ZjYwMTdhODI1ZGFkNzRiMzVmNTc2N2I1YjRmYmIxODQ1ZmE4YgotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2dlb21ldHJ5L2xpbWl0LWxheWVyLWJvdW5kcy1maXhl ZC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyMSBAQAorKEdyYXBoaWNzTGF5ZXIKKyAgKGJvdW5k cyA3ODUuMDAgNTAxMy4wMCkKKyAgKGNoaWxkcmVuIDEKKyAgICAoR3JhcGhpY3NMYXllcgorICAg ICAgKGJvdW5kcyA3ODUuMDAgNTAxMy4wMCkKKyAgICAgIChjb250ZW50c09wYXF1ZSAxKQorICAg ICAgKGNoaWxkcmVuIDIKKyAgICAgICAgKEdyYXBoaWNzTGF5ZXIKKyAgICAgICAgICAocG9zaXRp b24gMTAwLjAwIDMxMDAuMDApCisgICAgICAgICAgKGJvdW5kcyAxMDAuMDAgMTAwLjAwKQorICAg ICAgICApCisgICAgICAgIChHcmFwaGljc0xheWVyCisgICAgICAgICAgKHBvc2l0aW9uIDAuMDAg MzAwMC4wMCkKKyAgICAgICAgICAoYm91bmRzIDMwMC4wMCAyMDAuMDApCisgICAgICAgICAgKGRy YXdzQ29udGVudCAxKQorICAgICAgICApCisgICAgICApCisgICAgKQorICApCispCisKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2dlb21ldHJ5L2xpbWl0LWxheWVyLWJvdW5k cy1maXhlZC5odG1sIGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvZ2VvbWV0cnkvbGltaXQtbGF5 ZXItYm91bmRzLWZpeGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMzFmOWEwZTNhMWFhMDZlZTZiZTE2MmY2 MTEyNDg2MTgwYjcyODU5MwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2NvbXBvc2l0 aW5nL2dlb21ldHJ5L2xpbWl0LWxheWVyLWJvdW5kcy1maXhlZC5odG1sCkBAIC0wLDAgKzEsNzAg QEAKKzwhRE9DVFlQRSBodG1sPgorCis8aHRtbD4KKzxoZWFkPgorICA8c3R5bGUgdHlwZT0idGV4 dC9jc3MiIG1lZGlhPSJzY3JlZW4iPgorICAgIGJvZHkgeworICAgICAgaGVpZ2h0OiA1MDAwcHg7 CisgICAgICBtYXJnaW46IDA7CisgICAgfQorICAgIC5maXhlZCB7CisgICAgICAgIHBvc2l0aW9u OiBmaXhlZDsKKyAgICAgICAgbGVmdDogMTAwcHg7CisgICAgICAgIHRvcDogMTAwcHg7CisgICAg ICAgIHdpZHRoOiAyMDBweDsKKyAgICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgICAgYmFja2dy b3VuZC1jb2xvcjogZ3JlZW47CisgICAgfQorICAgIAorICAgIC5mb3JjZXIgeworICAgICAgICBw b3NpdGlvbjogYWJzb2x1dGU7CisgICAgICAgIHRvcDogMzEwMHB4OworICAgICAgICBsZWZ0OiAx MDBweDsKKyAgICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgICAgd2lkdGg6IDEwMHB4OworICAg ICAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7CisgICAgICAgIC13ZWJraXQtdHJhbnNmb3JtOiB0 cmFuc2xhdGVaKDApOworICAgIH0KKyAgICAKKyAgICAuY2hpbGQgeworICAgICAgICBwb3NpdGlv bjogYWJzb2x1dGU7CisgICAgICAgIGxlZnQ6IC05MDAwcHg7CisgICAgICAgIHRvcDogLTkwMDBw eDsKKyAgICAgICAgaGVpZ2h0OiAxMHB4OworICAgICAgICB3aWR0aDogMTBweDsKKyAgICAgICAg YmFja2dyb3VuZC1jb2xvcjogcmVkOworICAgIH0KKyAgPC9zdHlsZT4KKyAgPHNjcmlwdCB0eXBl PSJ0ZXh0L2phdmFzY3JpcHQiIGNoYXJzZXQ9InV0Zi04Ij4KKyAgICBpZiAod2luZG93LnRlc3RS dW5uZXIpIHsKKyAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAgICAgdGVzdFJ1bm5l ci53YWl0VW50aWxEb25lKCk7CisgICAgfQorCisgICAgZnVuY3Rpb24gZG9UZXN0KCkKKyAgICB7 CisgICAgICAgIHdpbmRvdy5zY3JvbGxUbygwLCAzMDAwKTsKKyAgICAgICAgLy8gRm9yY2UgbGF5 b3V0LCB3aGljaCB1cGRhdGVzIHRoZSBmaXhlZCBsYXllciBib3VuZHMuCisgICAgICAgIGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdsYXllcnMnKS5pbm5lclRleHQgPSAnJzsKKyAgICAgICAgaWYg KHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgnbGF5ZXJzJykuaW5uZXJUZXh0ID0gd2luZG93LmludGVybmFscy5sYXllclRyZWVBc1RleHQo ZG9jdW1lbnQpOworICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisgICAgICAg IH0KKyAgICB9CisKKyAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIGRvVGVzdCwg ZmFsc2UpOworICA8L3NjcmlwdD4KKzwvaGVhZD4KKworPGJvZHk+CisgIAorICA8ZGl2IGNsYXNz PSJmb3JjZXIiPjwvZGl2PgorCisgIDxkaXYgY2xhc3M9ImZpeGVkIj4KKyAgICAgIDxkaXYgY2xh c3M9ImNoaWxkIj48L2Rpdj4KKyAgPC9kaXY+CisgIAorPHByZSBpZD0ibGF5ZXJzIj5MYXllciB0 cmVlIGdvZXMgaGVyZSBpbiBEUlQ8L3ByZT4KKzwvYm9keT4KKzwvaHRtbD4KKwo=