109643 2013-02-12 18:06:23 -0800 Remove Element::ensureAttributeData(). 2013-02-12 20:29:23 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 109505 1 kling kling cmarcelo d-r fmalita ojan.autocc pdr schenney webkit.review.bot oldest_to_newest 831488 0 kling 2013-02-12 18:06:23 -0800 One less of these getters would be nice. 831503 1 187985 kling 2013-02-12 18:26:23 -0800 Created attachment 187985 Patch 831545 2 187985 andersca 2013-02-12 19:37:28 -0800 Comment on attachment 187985 Patch r=bogs 831571 3 187985 webkit.review.bot 2013-02-12 20:29:19 -0800 Comment on attachment 187985 Patch Clearing flags on attachment: 187985 Committed r142714: <http://trac.webkit.org/changeset/142714> 831572 4 webkit.review.bot 2013-02-12 20:29:23 -0800 All reviewed patches have been landed. Closing bug. 187985 2013-02-12 18:26:23 -0800 2013-02-12 20:29:19 -0800 Patch bug-109643.diff text/plain 5446 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NzM1ZWJlLi42N2E3YTllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjcg QEAKIDIwMTMtMDItMTIgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIFJlbW92ZSBFbGVtZW50OjplbnN1cmVBdHRyaWJ1dGVEYXRhKCkuCisgICAgICAgIDxodHRw Oi8vd2Via2l0Lm9yZy9iLzEwOTY0Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGRvbS9FbGVtZW50Lmg6CisgICAgICAgICogZG9tL0VsZW1lbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6Y2xhc3NBdHRyaWJ1dGVDaGFuZ2VkKToK KyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OnNob3VsZEludmFsaWRhdGVEaXN0cmlidXRpb25X aGVuQXR0cmlidXRlQ2hhbmdlZCk6CisKKyAgICAgICAgICAgIFVzZSBhdHRyaWJ1dGVEYXRhKCkg aW5zdGVhZCBvZiBlbnN1cmVBdHRyaWJ1dGVEYXRhKCksIGl0J3MgYWxyZWFkeSBndWFyYW50ZWVk IHRvIGV4aXN0IGluCisgICAgICAgICAgICBib3RoIHRoZXNlIGZ1bmN0aW9ucyBhcyB0aGV5IGFy ZSBjYWxsZWQgaW4gcmVzcG9uc2UgdG8gYXR0cmlidXRlIGNoYW5nZXMuCisKKyAgICAgICAgKiBz dmcvU1ZHRWxlbWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6U1ZHRWxlbWVudDo6aW52YWxpZGF0 ZVNWR0F0dHJpYnV0ZXMpOgorCisgICAgICAgICAgICBVc2UgbXV0YWJsZUF0dHJpYnV0ZURhdGEo KSBpbnN0ZWFkIG9mIGVuc3VyZUF0dHJpYnV0ZURhdGEoKSB3aGVuIGludmFsaWRhdGluZyBhbmlt YXRlZAorICAgICAgICAgICAgU1ZHIGF0dHJpYnV0ZXMuIFdoaWxlIEkgY2FuJ3QgZmluZCBhbnkg YnVncyBjYXVzZWQgYnkgdGhpcywgYW4gZWxlbWVudCB3aXRoIHByb3BlcnR5IGFuaW1hdGlvbnMK KyAgICAgICAgICAgIHNob3VsZG4ndCBzaGFyZSBhdHRyaWJ1dGUgZGF0YSB3aXRoIG90aGVyIGVs ZW1lbnRzLgorCisyMDEzLTAyLTEyICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4K KwogICAgICAgICBNb3ZlIEVsZW1lbnRBdHRyaWJ1dGVEYXRhIGludG8gRWxlbWVudC5jcHAvaAog ICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMDk2MTA+CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNw cAppbmRleCAwYTViZGRhLi45NTA1MThkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC05MjEs MTkgKzkyMSwxNSBAQCB2b2lkIEVsZW1lbnQ6OmNsYXNzQXR0cmlidXRlQ2hhbmdlZChjb25zdCBB dG9taWNTdHJpbmcmIG5ld0NsYXNzU3RyaW5nKQogICAgIGJvb2wgc2hvdWxkSW52YWxpZGF0ZVN0 eWxlID0gZmFsc2U7CiAKICAgICBpZiAoY2xhc3NTdHJpbmdIYXNDbGFzc05hbWUobmV3Q2xhc3NT dHJpbmcpKSB7Ci0gICAgICAgIGNvbnN0IEVsZW1lbnRBdHRyaWJ1dGVEYXRhKiBhdHRyaWJ1dGVE YXRhID0gZW5zdXJlQXR0cmlidXRlRGF0YSgpOwogICAgICAgICBjb25zdCBib29sIHNob3VsZEZv bGRDYXNlID0gZG9jdW1lbnQoKS0+aW5RdWlya3NNb2RlKCk7Ci0gICAgICAgIGNvbnN0IFNwYWNl U3BsaXRTdHJpbmcgb2xkQ2xhc3NlcyA9IGF0dHJpYnV0ZURhdGEtPmNsYXNzTmFtZXMoKTsKLQot ICAgICAgICBhdHRyaWJ1dGVEYXRhLT5zZXRDbGFzcyhuZXdDbGFzc1N0cmluZywgc2hvdWxkRm9s ZENhc2UpOwotCi0gICAgICAgIGNvbnN0IFNwYWNlU3BsaXRTdHJpbmcmIG5ld0NsYXNzZXMgPSBh dHRyaWJ1dGVEYXRhLT5jbGFzc05hbWVzKCk7CisgICAgICAgIGNvbnN0IFNwYWNlU3BsaXRTdHJp bmcgb2xkQ2xhc3NlcyA9IGF0dHJpYnV0ZURhdGEoKS0+Y2xhc3NOYW1lcygpOworICAgICAgICBh dHRyaWJ1dGVEYXRhKCktPnNldENsYXNzKG5ld0NsYXNzU3RyaW5nLCBzaG91bGRGb2xkQ2FzZSk7 CisgICAgICAgIGNvbnN0IFNwYWNlU3BsaXRTdHJpbmcmIG5ld0NsYXNzZXMgPSBhdHRyaWJ1dGVE YXRhKCktPmNsYXNzTmFtZXMoKTsKICAgICAgICAgc2hvdWxkSW52YWxpZGF0ZVN0eWxlID0gdGVz dFNob3VsZEludmFsaWRhdGVTdHlsZSAmJiBjaGVja1NlbGVjdG9yRm9yQ2xhc3NDaGFuZ2Uob2xk Q2xhc3NlcywgbmV3Q2xhc3NlcywgKnN0eWxlUmVzb2x2ZXIpOwotICAgIH0gZWxzZSBpZiAoY29u c3QgRWxlbWVudEF0dHJpYnV0ZURhdGEqIGF0dHJpYnV0ZURhdGEgPSB0aGlzLT5hdHRyaWJ1dGVE YXRhKCkpIHsKLSAgICAgICAgY29uc3QgU3BhY2VTcGxpdFN0cmluZyYgb2xkQ2xhc3NlcyA9IGF0 dHJpYnV0ZURhdGEtPmNsYXNzTmFtZXMoKTsKKyAgICB9IGVsc2UgeworICAgICAgICBjb25zdCBT cGFjZVNwbGl0U3RyaW5nJiBvbGRDbGFzc2VzID0gYXR0cmlidXRlRGF0YSgpLT5jbGFzc05hbWVz KCk7CiAgICAgICAgIHNob3VsZEludmFsaWRhdGVTdHlsZSA9IHRlc3RTaG91bGRJbnZhbGlkYXRl U3R5bGUgJiYgY2hlY2tTZWxlY3RvckZvckNsYXNzQ2hhbmdlKG9sZENsYXNzZXMsICpzdHlsZVJl c29sdmVyKTsKLQotICAgICAgICBhdHRyaWJ1dGVEYXRhLT5jbGVhckNsYXNzKCk7CisgICAgICAg IGF0dHJpYnV0ZURhdGEoKS0+Y2xlYXJDbGFzcygpOwogICAgIH0KIAogICAgIGlmIChoYXNSYXJl RGF0YSgpKQpAQCAtOTYyLDE0ICs5NTgsMTMgQEAgYm9vbCBFbGVtZW50OjpzaG91bGRJbnZhbGlk YXRlRGlzdHJpYnV0aW9uV2hlbkF0dHJpYnV0ZUNoYW5nZWQoRWxlbWVudFNoYWRvdyogZWwKICAg ICBpZiAobmFtZSA9PSBIVE1MTmFtZXM6OmNsYXNzQXR0cikgewogICAgICAgICBjb25zdCBBdG9t aWNTdHJpbmcmIG5ld0NsYXNzU3RyaW5nID0gbmV3VmFsdWU7CiAgICAgICAgIGlmIChjbGFzc1N0 cmluZ0hhc0NsYXNzTmFtZShuZXdDbGFzc1N0cmluZykpIHsKLSAgICAgICAgICAgIGNvbnN0IEVs ZW1lbnRBdHRyaWJ1dGVEYXRhKiBhdHRyaWJ1dGVEYXRhID0gZW5zdXJlQXR0cmlidXRlRGF0YSgp OwogICAgICAgICAgICAgY29uc3QgYm9vbCBzaG91bGRGb2xkQ2FzZSA9IGRvY3VtZW50KCktPmlu UXVpcmtzTW9kZSgpOwotICAgICAgICAgICAgY29uc3QgU3BhY2VTcGxpdFN0cmluZyYgb2xkQ2xh c3NlcyA9IGF0dHJpYnV0ZURhdGEtPmNsYXNzTmFtZXMoKTsKKyAgICAgICAgICAgIGNvbnN0IFNw YWNlU3BsaXRTdHJpbmcmIG9sZENsYXNzZXMgPSBhdHRyaWJ1dGVEYXRhKCktPmNsYXNzTmFtZXMo KTsKICAgICAgICAgICAgIGNvbnN0IFNwYWNlU3BsaXRTdHJpbmcgbmV3Q2xhc3NlcyhuZXdDbGFz c1N0cmluZywgc2hvdWxkRm9sZENhc2UpOwogICAgICAgICAgICAgaWYgKGNoZWNrU2VsZWN0b3JG b3JDbGFzc0NoYW5nZShvbGRDbGFzc2VzLCBuZXdDbGFzc2VzLCBmZWF0dXJlU2V0KSkKICAgICAg ICAgICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICAgICAgfSBlbHNlIGlmIChjb25zdCBFbGVtZW50 QXR0cmlidXRlRGF0YSogYXR0cmlidXRlRGF0YSA9IHRoaXMtPmF0dHJpYnV0ZURhdGEoKSkgewot ICAgICAgICAgICAgY29uc3QgU3BhY2VTcGxpdFN0cmluZyYgb2xkQ2xhc3NlcyA9IGF0dHJpYnV0 ZURhdGEtPmNsYXNzTmFtZXMoKTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGNvbnN0 IFNwYWNlU3BsaXRTdHJpbmcmIG9sZENsYXNzZXMgPSBhdHRyaWJ1dGVEYXRhKCktPmNsYXNzTmFt ZXMoKTsKICAgICAgICAgICAgIGlmIChjaGVja1NlbGVjdG9yRm9yQ2xhc3NDaGFuZ2Uob2xkQ2xh c3NlcywgZmVhdHVyZVNldCkpCiAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAg IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmggYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRWxlbWVudC5oCmluZGV4IGE3NTU2MTkuLjUzZDNiZTYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1l bnQuaApAQCAtMzczLDcgKzM3Myw2IEBAIHB1YmxpYzoKIAogICAgIGNvbnN0IEVsZW1lbnRBdHRy aWJ1dGVEYXRhKiBhdHRyaWJ1dGVEYXRhKCkgY29uc3QgeyByZXR1cm4gbV9hdHRyaWJ1dGVEYXRh LmdldCgpOyB9CiAgICAgRWxlbWVudEF0dHJpYnV0ZURhdGEqIG11dGFibGVBdHRyaWJ1dGVEYXRh KCk7Ci0gICAgY29uc3QgRWxlbWVudEF0dHJpYnV0ZURhdGEqIGVuc3VyZUF0dHJpYnV0ZURhdGEo KTsKICAgICBjb25zdCBFbGVtZW50QXR0cmlidXRlRGF0YSogdXBkYXRlZEF0dHJpYnV0ZURhdGEo KSBjb25zdDsKICAgICBjb25zdCBFbGVtZW50QXR0cmlidXRlRGF0YSogZW5zdXJlVXBkYXRlZEF0 dHJpYnV0ZURhdGEoKSBjb25zdDsKIApAQCAtNzg0LDEzICs3ODMsNiBAQCBpbmxpbmUgY29uc3Qg RWxlbWVudEF0dHJpYnV0ZURhdGEqIEVsZW1lbnQ6OnVwZGF0ZWRBdHRyaWJ1dGVEYXRhKCkgY29u c3QKICAgICByZXR1cm4gYXR0cmlidXRlRGF0YSgpOwogfQogCi1pbmxpbmUgY29uc3QgRWxlbWVu dEF0dHJpYnV0ZURhdGEqIEVsZW1lbnQ6OmVuc3VyZUF0dHJpYnV0ZURhdGEoKQotewotICAgIGlm IChhdHRyaWJ1dGVEYXRhKCkpCi0gICAgICAgIHJldHVybiBhdHRyaWJ1dGVEYXRhKCk7Ci0gICAg cmV0dXJuIG11dGFibGVBdHRyaWJ1dGVEYXRhKCk7Ci19Ci0KIGlubGluZSBjb25zdCBFbGVtZW50 QXR0cmlidXRlRGF0YSogRWxlbWVudDo6ZW5zdXJlVXBkYXRlZEF0dHJpYnV0ZURhdGEoKSBjb25z dAogewogICAgIHVwZGF0ZUludmFsaWRBdHRyaWJ1dGVzKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9zdmcvU1ZHRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnQu aAppbmRleCA3ZjYzMTJmLi44Zjg5MDBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcv U1ZHRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50LmgKQEAgLTc5 LDcgKzc5LDcgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCBBZmZpbmVUcmFuc2Zvcm0qIHN1cHBs ZW1lbnRhbFRyYW5zZm9ybSgpIHsgcmV0dXJuIDA7IH0KIAotICAgIHZvaWQgaW52YWxpZGF0ZVNW R0F0dHJpYnV0ZXMoKSB7IGVuc3VyZUF0dHJpYnV0ZURhdGEoKS0+bV9hbmltYXRlZFNWR0F0dHJp YnV0ZXNBcmVEaXJ0eSA9IHRydWU7IH0KKyAgICB2b2lkIGludmFsaWRhdGVTVkdBdHRyaWJ1dGVz KCkgeyBtdXRhYmxlQXR0cmlidXRlRGF0YSgpLT5tX2FuaW1hdGVkU1ZHQXR0cmlidXRlc0FyZURp cnR5ID0gdHJ1ZTsgfQogCiAgICAgY29uc3QgSGFzaFNldDxTVkdFbGVtZW50SW5zdGFuY2UqPiYg aW5zdGFuY2VzRm9yRWxlbWVudCgpIGNvbnN0OwogCg==