109623 2013-02-12 15:31:55 -0800 Fix signedness in WebTestProxy 2013-02-12 15:54:41 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alecflett alecflett webkit.review.bot oldest_to_newest 831349 0 alecflett 2013-02-12 15:31:55 -0800 Fix signedness in WebTestProxy 831354 1 187949 alecflett 2013-02-12 15:33:20 -0800 Created attachment 187949 Patch 831356 2 187949 abarth 2013-02-12 15:33:57 -0800 Comment on attachment 187949 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187949&action=review > Tools/ChangeLog:19 > +2013-02-12 Alec Flett <alecflett@chromium.org> > + > + Fix signedness in WebTestProxy > + https://bugs.webkit.org/show_bug.cgi?id=109623 > + > + Reviewed by NOBODY (OOPS!). > + > + Fix signedness problem, using size_t instead of int. > + > + * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: > + > +2013-02-12 Alec Flett <alecflett@chromium.org> > + > + Fix signedness in WebTestProxy > + https://bugs.webkit.org/show_bug.cgi?id=109623 > + > + Reviewed by NOBODY (OOPS!). > + > + * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: You have a goofy looking changelog 831358 3 187950 alecflett 2013-02-12 15:37:59 -0800 Created attachment 187950 Patch for landing 831363 4 187952 alecflett 2013-02-12 15:39:50 -0800 Created attachment 187952 Patch for landing 831372 5 187952 webkit.review.bot 2013-02-12 15:54:38 -0800 Comment on attachment 187952 Patch for landing Clearing flags on attachment: 187952 Committed r142684: <http://trac.webkit.org/changeset/142684> 831373 6 webkit.review.bot 2013-02-12 15:54:41 -0800 All reviewed patches have been landed. Closing bug. 187949 2013-02-12 15:33:20 -0800 2013-02-12 15:37:58 -0800 Patch bug-109623-20130212152950.patch text/plain 1877 alecflett U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNjc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzI0ZjI0OWNmN2VmMGNjYmQ3ZTA3NzBjMmQ0Njc0ODFm NjM0NjhkMS4uYjA5MDkxMjhiNGI0MDVmYTJkYWZkMWY3NGVjNzk1ZTc1YmI2YjIxNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDEzLTAyLTEyICBBbGVjIEZsZXR0ICA8YWxlY2ZsZXR0QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBGaXggc2lnbmVkbmVzcyBpbiBXZWJUZXN0UHJveHkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTYyMworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBzaWduZWRuZXNzIHByb2JsZW0sIHVz aW5nIHNpemVfdCBpbnN0ZWFkIG9mIGludC4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2No cm9taXVtL1Rlc3RSdW5uZXIvc3JjL1dlYlRlc3RQcm94eS5jcHA6CisKKzIwMTMtMDItMTIgIEFs ZWMgRmxldHQgIDxhbGVjZmxldHRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBzaWduZWRu ZXNzIGluIFdlYlRlc3RQcm94eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTA5NjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL3NyYy9XZWJU ZXN0UHJveHkuY3BwOgorCiAyMDEzLTAyLTEyICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gbW92ZSB0ZXh0IGR1bXAgZ2VuZXJhdGlv biB0byBUZXN0UnVubmVyIGxpYnJhcnkKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL1Rlc3RSdW5uZXIvc3JjL1dlYlRlc3RQcm94eS5jcHAgYi9Ub29scy9EdW1wUmVu ZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL3NyYy9XZWJUZXN0UHJveHkuY3BwCmluZGV4IGM5 NzcwNTc1NmRhM2VlYzk4MTYyM2IyZTA1MWJlZGU4MGEwM2NmNTUuLjM5OGIzMjJiMTFmZTUzNTJl OTZmMTdkNjYyMmRmYjYzY2VmM2QxNDIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL1Rlc3RSdW5uZXIvc3JjL1dlYlRlc3RQcm94eS5jcHAKKysrIGIvVG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9zcmMvV2ViVGVzdFByb3h5LmNwcApAQCAt Mzg5LDcgKzM4OSw3IEBAIHN0cmluZyBkdW1wSGlzdG9yeUl0ZW0oY29uc3QgV2ViSGlzdG9yeUl0 ZW0mIGl0ZW0sIGludCBpbmRlbnQsIGJvb2wgaXNDdXJyZW50KQogdm9pZCBkdW1wQmFja0Zvcndh cmRMaXN0KGNvbnN0IFdlYlZlY3RvcjxXZWJIaXN0b3J5SXRlbT4mIGhpc3RvcnksIHNpemVfdCBj dXJyZW50RW50cnlJbmRleCwgc3RyaW5nJiByZXN1bHQpCiB7CiAgICAgcmVzdWx0LmFwcGVuZCgi XG49PT09PT09PT09PT09PSBCYWNrIEZvcndhcmQgTGlzdCA9PT09PT09PT09PT09PVxuIik7Ci0g ICAgZm9yIChpbnQgaW5kZXggPSAwOyBpbmRleCA8IGhpc3Rvcnkuc2l6ZSgpOyArK2luZGV4KQor ICAgIGZvciAoc2l6ZV90IGluZGV4ID0gMDsgaW5kZXggPCBoaXN0b3J5LnNpemUoKTsgKytpbmRl eCkKICAgICAgICAgcmVzdWx0LmFwcGVuZChkdW1wSGlzdG9yeUl0ZW0oaGlzdG9yeVtpbmRleF0s IDgsIGluZGV4ID09IGN1cnJlbnRFbnRyeUluZGV4KSk7CiAgICAgcmVzdWx0LmFwcGVuZCgiPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT1cbiIpOwogfQo= 187950 2013-02-12 15:37:59 -0800 2013-02-12 15:39:49 -0800 Patch for landing bug-109623-20130212153429.patch text/plain 1668 alecflett U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNjc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzI0ZjI0OWNmN2VmMGNjYmQ3ZTA3NzBjMmQ0Njc0ODFm NjM0NjhkMS4uNDEzN2U2NmFmYzYxMWEyZTU2ZDcxOWY3MzhmMWM4OGY0NGYyMzFlNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw0ICsxLDEz IEBACi0yMDEzLTAyLTEyICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor MjAxMy0wMi0xMiAgQWxlYyBGbGV0dCAgPGFsZWNmbGV0dEBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgRml4IHNpZ25lZG5lc3MgaW4gV2ViVGVzdFByb3h5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk2MjMKKworICAgICAgICBSZXZpZXdlZCBieSBB ZGFtIEJhcnRoLgorCisgICAgICAgIEZpeCBzaWduZWRuZXNzIHByb2JsZW0sIHVzaW5nIHNpemVf dCBpbnN0ZWFkIG9mIGludC4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rl c3RSdW5uZXIvc3JjL1dlYlRlc3RQcm94eS5jcHA6CiAKICAgICAgICAgW2Nocm9taXVtXSBtb3Zl IHRleHQgZHVtcCBnZW5lcmF0aW9uIHRvIFRlc3RSdW5uZXIgbGlicmFyeQogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5NTc1CmRpZmYgLS1naXQgYS9U b29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL3NyYy9XZWJUZXN0UHJveHku Y3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9zcmMvV2ViVGVz dFByb3h5LmNwcAppbmRleCBjOTc3MDU3NTZkYTNlZWM5ODE2MjNiMmUwNTFiZWRlODBhMDNjZjU1 Li4zOThiMzIyYjExZmU1MzUyZTk2ZjE3ZDY2MjJkZmI2M2NlZjNkMTQyIDEwMDY0NAotLS0gYS9U b29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL3NyYy9XZWJUZXN0UHJveHku Y3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvc3JjL1dl YlRlc3RQcm94eS5jcHAKQEAgLTM4OSw3ICszODksNyBAQCBzdHJpbmcgZHVtcEhpc3RvcnlJdGVt KGNvbnN0IFdlYkhpc3RvcnlJdGVtJiBpdGVtLCBpbnQgaW5kZW50LCBib29sIGlzQ3VycmVudCkK IHZvaWQgZHVtcEJhY2tGb3J3YXJkTGlzdChjb25zdCBXZWJWZWN0b3I8V2ViSGlzdG9yeUl0ZW0+ JiBoaXN0b3J5LCBzaXplX3QgY3VycmVudEVudHJ5SW5kZXgsIHN0cmluZyYgcmVzdWx0KQogewog ICAgIHJlc3VsdC5hcHBlbmQoIlxuPT09PT09PT09PT09PT0gQmFjayBGb3J3YXJkIExpc3QgPT09 PT09PT09PT09PT1cbiIpOwotICAgIGZvciAoaW50IGluZGV4ID0gMDsgaW5kZXggPCBoaXN0b3J5 LnNpemUoKTsgKytpbmRleCkKKyAgICBmb3IgKHNpemVfdCBpbmRleCA9IDA7IGluZGV4IDwgaGlz dG9yeS5zaXplKCk7ICsraW5kZXgpCiAgICAgICAgIHJlc3VsdC5hcHBlbmQoZHVtcEhpc3RvcnlJ dGVtKGhpc3RvcnlbaW5kZXhdLCA4LCBpbmRleCA9PSBjdXJyZW50RW50cnlJbmRleCkpOwogICAg IHJlc3VsdC5hcHBlbmQoIj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09XG4iKTsKIH0K 187952 2013-02-12 15:39:50 -0800 2013-02-12 15:54:38 -0800 Patch for landing bug-109623-20130212153620.patch text/plain 1614 alecflett U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNjc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzI0ZjI0OWNmN2VmMGNjYmQ3ZTA3NzBjMmQ0Njc0ODFm NjM0NjhkMS4uZjNkMGQ4MjA0YTUzMzYxMDcwNzQwMGFlZjUwNGQxNWVhODAzZjk4MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEzLTAyLTEyICBBbGVjIEZsZXR0ICA8YWxlY2ZsZXR0QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBGaXggc2lnbmVkbmVzcyBpbiBXZWJUZXN0UHJveHkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTYyMworCisgICAgICAgIFJldmlld2Vk IGJ5IEFkYW0gQmFydGguCisKKyAgICAgICAgRml4IHNpZ25lZG5lc3MgcHJvYmxlbSwgdXNpbmcg c2l6ZV90IGluc3RlYWQgb2YgaW50LgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21p dW0vVGVzdFJ1bm5lci9zcmMvV2ViVGVzdFByb3h5LmNwcDoKKwogMjAxMy0wMi0xMiAgSm9jaGVu IEVpc2luZ2VyICA8am9jaGVuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIG1v dmUgdGV4dCBkdW1wIGdlbmVyYXRpb24gdG8gVGVzdFJ1bm5lciBsaWJyYXJ5CmRpZmYgLS1naXQg YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL3NyYy9XZWJUZXN0UHJv eHkuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9zcmMvV2Vi VGVzdFByb3h5LmNwcAppbmRleCBjOTc3MDU3NTZkYTNlZWM5ODE2MjNiMmUwNTFiZWRlODBhMDNj ZjU1Li4zOThiMzIyYjExZmU1MzUyZTk2ZjE3ZDY2MjJkZmI2M2NlZjNkMTQyIDEwMDY0NAotLS0g YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL3NyYy9XZWJUZXN0UHJv eHkuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvc3Jj L1dlYlRlc3RQcm94eS5jcHAKQEAgLTM4OSw3ICszODksNyBAQCBzdHJpbmcgZHVtcEhpc3RvcnlJ dGVtKGNvbnN0IFdlYkhpc3RvcnlJdGVtJiBpdGVtLCBpbnQgaW5kZW50LCBib29sIGlzQ3VycmVu dCkKIHZvaWQgZHVtcEJhY2tGb3J3YXJkTGlzdChjb25zdCBXZWJWZWN0b3I8V2ViSGlzdG9yeUl0 ZW0+JiBoaXN0b3J5LCBzaXplX3QgY3VycmVudEVudHJ5SW5kZXgsIHN0cmluZyYgcmVzdWx0KQog ewogICAgIHJlc3VsdC5hcHBlbmQoIlxuPT09PT09PT09PT09PT0gQmFjayBGb3J3YXJkIExpc3Qg PT09PT09PT09PT09PT1cbiIpOwotICAgIGZvciAoaW50IGluZGV4ID0gMDsgaW5kZXggPCBoaXN0 b3J5LnNpemUoKTsgKytpbmRleCkKKyAgICBmb3IgKHNpemVfdCBpbmRleCA9IDA7IGluZGV4IDwg aGlzdG9yeS5zaXplKCk7ICsraW5kZXgpCiAgICAgICAgIHJlc3VsdC5hcHBlbmQoZHVtcEhpc3Rv cnlJdGVtKGhpc3RvcnlbaW5kZXhdLCA4LCBpbmRleCA9PSBjdXJyZW50RW50cnlJbmRleCkpOwog ICAgIHJlc3VsdC5hcHBlbmQoIj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09XG4iKTsKIH0K