109599 2013-02-12 11:01:51 -0800 Synchronize setting of panner node model and processing 2013-02-12 16:12:27 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rtoy rtoy crogers eric.carlson feature-media-reviews levin+threading webkit.review.bot oldest_to_newest 831091 0 rtoy 2013-02-12 11:01:51 -0800 Synchronize setting of panner node model and processing 831106 1 187903 rtoy 2013-02-12 11:18:02 -0800 Created attachment 187903 Patch 831197 2 187903 crogers 2013-02-12 13:25:15 -0800 Comment on attachment 187903 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187903&action=review some nits - looks good overall > Source/WebCore/Modules/webaudio/PannerNode.cpp:115 > + } you need an else clause similar (but not identical) to AudioBufferSourceNode: } else { // Too bad - the tryLock() failed. We must be in the middle of changing buffers and were already outputting silence anyway. outputBus->zero(); } > Source/WebCore/Modules/webaudio/PannerNode.cpp:192 > + // This synchronizes with process() nit: period at end of sentence > Source/WebCore/Modules/webaudio/PannerNode.h:158 > + // Synchronize process() and setPanningModel() which can change the panner nit: period at end of sentence 831208 3 187922 rtoy 2013-02-12 13:36:41 -0800 Created attachment 187922 Patch 831209 4 rtoy 2013-02-12 13:37:56 -0800 (In reply to comment #2) > (From update of attachment 187903 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=187903&action=review > > some nits - looks good overall > > > Source/WebCore/Modules/webaudio/PannerNode.cpp:115 > > + } > > you need an else clause similar (but not identical) to AudioBufferSourceNode: > > } else { > // Too bad - the tryLock() failed. We must be in the middle of changing buffers and were already outputting silence anyway. > outputBus->zero(); > } > > > Source/WebCore/Modules/webaudio/PannerNode.cpp:192 > > + // This synchronizes with process() > > nit: period at end of sentence > > > Source/WebCore/Modules/webaudio/PannerNode.h:158 > > + // Synchronize process() and setPanningModel() which can change the panner > > nit: period at end of sentence Fixed according to your comments. 831269 5 187922 crogers 2013-02-12 14:35:55 -0800 Comment on attachment 187922 Patch thanks! 831276 6 187922 webkit.review.bot 2013-02-12 14:44:04 -0800 Comment on attachment 187922 Patch Rejecting attachment 187922 from commit-queue. rtoy@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 831384 7 187922 webkit.review.bot 2013-02-12 16:12:23 -0800 Comment on attachment 187922 Patch Clearing flags on attachment: 187922 Committed r142687: <http://trac.webkit.org/changeset/142687> 831385 8 webkit.review.bot 2013-02-12 16:12:27 -0800 All reviewed patches have been landed. Closing bug. 187903 2013-02-12 11:18:02 -0800 2013-02-12 13:36:39 -0800 Patch bug-109599-20130212111431.patch text/plain 2911 rtoy U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNDI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2QwOGRkNmM3OWUyOTYw ZDBjMWQyYzdkMjM2OGZlNzRiMmViMGM4Mi4uNTRkOTVkYjMyODFlMzJlZGZjZTA2MDcwNTU0NWM0 ZjZmNGQ2NWExNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAyLTEyICBSYXlt b25kIFRveSAgPHJ0b3lAZ29vZ2xlLmNvbT4KKworICAgICAgICBTeW5jaHJvbml6ZSBzZXR0aW5n IG9mIHBhbm5lciBub2RlIG1vZGVsIGFuZCBwcm9jZXNzaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk1OTkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBN b2R1bGVzL3dlYmF1ZGlvL1Bhbm5lck5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFubmVy Tm9kZTo6cHJvY2Vzcyk6CisgICAgICAgIChXZWJDb3JlOjpQYW5uZXJOb2RlOjpzZXRQYW5uaW5n TW9kZWwpOgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vUGFubmVyTm9kZS5oOgorCiAyMDEz LTAyLTA2ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBb VjhdIFJlbmFtZSBpc29sYXRlZCgpIHRvIGdldFdvcmxkKCksIHJlbmFtZSB3b3JsZEZvckVudGVy ZWRDb250ZXh0SWZJc29sYXRlZCgpIHRvIHdvcmxkRm9yRW50ZXJlZENvbnRleHQoKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9QYW5uZXJOb2RlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vUGFubmVyTm9kZS5jcHAKaW5kZXggMzEyNDk5 YjkxMGExZjQ3YTgyODcwOTE4N2RlOGJjODQ2MTExYjY5My4uNGQ4YjRjYWMwYmVmYTJhNjg2OTQ2 NDQ4N2ZhNTcxMzEwYmY2ZDk1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93 ZWJhdWRpby9QYW5uZXJOb2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1 ZGlvL1Bhbm5lck5vZGUuY3BwCkBAIC0xMDQsMTEgKzEwNCwxNSBAQCB2b2lkIFBhbm5lck5vZGU6 OnByb2Nlc3Moc2l6ZV90IGZyYW1lc1RvUHJvY2VzcykKICAgICAgICAgcmV0dXJuOwogICAgIH0K IAotICAgIC8vIEFwcGx5IHRoZSBwYW5uaW5nIGVmZmVjdC4KLSAgICBkb3VibGUgYXppbXV0aDsK LSAgICBkb3VibGUgZWxldmF0aW9uOwotICAgIGdldEF6aW11dGhFbGV2YXRpb24oJmF6aW11dGgs ICZlbGV2YXRpb24pOwotICAgIG1fcGFubmVyLT5wYW4oYXppbXV0aCwgZWxldmF0aW9uLCBzb3Vy Y2UsIGRlc3RpbmF0aW9uLCBmcmFtZXNUb1Byb2Nlc3MpOworICAgIC8vIFRoZSBhdWRpbyB0aHJl YWQgY2FuJ3QgYmxvY2sgb24gdGhpcyBsb2NrLCBzbyB3ZSBjYWxsIHRyeUxvY2soKSBpbnN0ZWFk LgorICAgIE11dGV4VHJ5TG9ja2VyIHRyeUxvY2tlcihtX3Bhbm5lckxvY2spOworICAgIGlmICh0 cnlMb2NrZXIubG9ja2VkKCkpIHsKKyAgICAgICAgLy8gQXBwbHkgdGhlIHBhbm5pbmcgZWZmZWN0 LgorICAgICAgICBkb3VibGUgYXppbXV0aDsKKyAgICAgICAgZG91YmxlIGVsZXZhdGlvbjsKKyAg ICAgICAgZ2V0QXppbXV0aEVsZXZhdGlvbigmYXppbXV0aCwgJmVsZXZhdGlvbik7CisgICAgICAg IG1fcGFubmVyLT5wYW4oYXppbXV0aCwgZWxldmF0aW9uLCBzb3VyY2UsIGRlc3RpbmF0aW9uLCBm cmFtZXNUb1Byb2Nlc3MpOworICAgIH0KIAogICAgIC8vIEdldCB0aGUgZGlzdGFuY2UgYW5kIGNv bmUgZ2Fpbi4KICAgICBkb3VibGUgdG90YWxHYWluID0gZGlzdGFuY2VDb25lR2FpbigpOwpAQCAt MTg1LDYgKzE4OSw5IEBAIGJvb2wgUGFubmVyTm9kZTo6c2V0UGFubmluZ01vZGVsKHVuc2lnbmVk IG1vZGVsKQogICAgIGNhc2UgRVFVQUxQT1dFUjoKICAgICBjYXNlIEhSVEY6CiAgICAgICAgIGlm ICghbV9wYW5uZXIuZ2V0KCkgfHwgbW9kZWwgIT0gbV9wYW5uaW5nTW9kZWwpIHsKKyAgICAgICAg ICAgIC8vIFRoaXMgc3luY2hyb25pemVzIHdpdGggcHJvY2VzcygpCisgICAgICAgICAgICBNdXRl eExvY2tlciBwcm9jZXNzTG9ja2VyKG1fcGFubmVyTG9jayk7CisgICAgICAgICAgICAKICAgICAg ICAgICAgIE93blB0cjxQYW5uZXI+IG5ld1Bhbm5lciA9IFBhbm5lcjo6Y3JlYXRlKG1vZGVsLCBz YW1wbGVSYXRlKCkpOwogICAgICAgICAgICAgbV9wYW5uZXIgPSBuZXdQYW5uZXIucmVsZWFzZSgp OwogICAgICAgICAgICAgbV9wYW5uaW5nTW9kZWwgPSBtb2RlbDsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vUGFubmVyTm9kZS5oIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy93ZWJhdWRpby9QYW5uZXJOb2RlLmgKaW5kZXggNTJmNDRkZWJkMjI3YjA0ZjQxZjI4 YmU5YmEyNzc2MzFjMTdiYTI2ZC4uMjhlNGQ5MTFkODNiYmY3M2Y5NzkyMmI5ZmQ5YzhiZDUxZTYx ZGNhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9QYW5uZXJO b2RlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9QYW5uZXJOb2RlLmgK QEAgLTE1NCw2ICsxNTQsOSBAQCBwcml2YXRlOgogICAgIGZsb2F0IG1fbGFzdEdhaW47CiAKICAg ICB1bnNpZ25lZCBtX2Nvbm5lY3Rpb25Db3VudDsKKworICAgIC8vIFN5bmNocm9uaXplIHByb2Nl c3MoKSBhbmQgc2V0UGFubmluZ01vZGVsKCkgd2hpY2ggY2FuIGNoYW5nZSB0aGUgcGFubmVyCisg ICAgbXV0YWJsZSBNdXRleCBtX3Bhbm5lckxvY2s7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCg== 187922 2013-02-12 13:36:41 -0800 2013-02-12 16:12:23 -0800 Patch bug-109599-20130212133311.patch text/plain 3669 rtoy U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNDI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2QwOGRkNmM3OWUyOTYw ZDBjMWQyYzdkMjM2OGZlNzRiMmViMGM4Mi4uNTRkOTVkYjMyODFlMzJlZGZjZTA2MDcwNTU0NWM0 ZjZmNGQ2NWExNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAyLTEyICBSYXlt b25kIFRveSAgPHJ0b3lAZ29vZ2xlLmNvbT4KKworICAgICAgICBTeW5jaHJvbml6ZSBzZXR0aW5n IG9mIHBhbm5lciBub2RlIG1vZGVsIGFuZCBwcm9jZXNzaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk1OTkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBN b2R1bGVzL3dlYmF1ZGlvL1Bhbm5lck5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFubmVy Tm9kZTo6cHJvY2Vzcyk6CisgICAgICAgIChXZWJDb3JlOjpQYW5uZXJOb2RlOjpzZXRQYW5uaW5n TW9kZWwpOgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vUGFubmVyTm9kZS5oOgorCiAyMDEz LTAyLTA2ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBb VjhdIFJlbmFtZSBpc29sYXRlZCgpIHRvIGdldFdvcmxkKCksIHJlbmFtZSB3b3JsZEZvckVudGVy ZWRDb250ZXh0SWZJc29sYXRlZCgpIHRvIHdvcmxkRm9yRW50ZXJlZENvbnRleHQoKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9QYW5uZXJOb2RlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vUGFubmVyTm9kZS5jcHAKaW5kZXggMzEyNDk5 YjkxMGExZjQ3YTgyODcwOTE4N2RlOGJjODQ2MTExYjY5My4uYzk3MGNiMGI5ZjE1ODYzMjY5OGZk NDI3MGY3ODk3NDBhNzAxMGRmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93 ZWJhdWRpby9QYW5uZXJOb2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1 ZGlvL1Bhbm5lck5vZGUuY3BwCkBAIC0xMDQsMjEgKzEwNCwyOCBAQCB2b2lkIFBhbm5lck5vZGU6 OnByb2Nlc3Moc2l6ZV90IGZyYW1lc1RvUHJvY2VzcykKICAgICAgICAgcmV0dXJuOwogICAgIH0K IAotICAgIC8vIEFwcGx5IHRoZSBwYW5uaW5nIGVmZmVjdC4KLSAgICBkb3VibGUgYXppbXV0aDsK LSAgICBkb3VibGUgZWxldmF0aW9uOwotICAgIGdldEF6aW11dGhFbGV2YXRpb24oJmF6aW11dGgs ICZlbGV2YXRpb24pOwotICAgIG1fcGFubmVyLT5wYW4oYXppbXV0aCwgZWxldmF0aW9uLCBzb3Vy Y2UsIGRlc3RpbmF0aW9uLCBmcmFtZXNUb1Byb2Nlc3MpOwotCi0gICAgLy8gR2V0IHRoZSBkaXN0 YW5jZSBhbmQgY29uZSBnYWluLgotICAgIGRvdWJsZSB0b3RhbEdhaW4gPSBkaXN0YW5jZUNvbmVH YWluKCk7Ci0KLSAgICAvLyBTbmFwIHRvIGRlc2lyZWQgZ2FpbiBhdCB0aGUgYmVnaW5uaW5nLgot ICAgIGlmIChtX2xhc3RHYWluID09IC0xLjApCi0gICAgICAgIG1fbGFzdEdhaW4gPSB0b3RhbEdh aW47CisgICAgLy8gVGhlIGF1ZGlvIHRocmVhZCBjYW4ndCBibG9jayBvbiB0aGlzIGxvY2ssIHNv IHdlIGNhbGwgdHJ5TG9jaygpIGluc3RlYWQuCisgICAgTXV0ZXhUcnlMb2NrZXIgdHJ5TG9ja2Vy KG1fcGFubmVyTG9jayk7CisgICAgaWYgKHRyeUxvY2tlci5sb2NrZWQoKSkgeworICAgICAgICAv LyBBcHBseSB0aGUgcGFubmluZyBlZmZlY3QuCisgICAgICAgIGRvdWJsZSBhemltdXRoOworICAg ICAgICBkb3VibGUgZWxldmF0aW9uOworICAgICAgICBnZXRBemltdXRoRWxldmF0aW9uKCZhemlt dXRoLCAmZWxldmF0aW9uKTsKKyAgICAgICAgbV9wYW5uZXItPnBhbihhemltdXRoLCBlbGV2YXRp b24sIHNvdXJjZSwgZGVzdGluYXRpb24sIGZyYW1lc1RvUHJvY2Vzcyk7CisKKyAgICAgICAgLy8g R2V0IHRoZSBkaXN0YW5jZSBhbmQgY29uZSBnYWluLgorICAgICAgICBkb3VibGUgdG90YWxHYWlu ID0gZGlzdGFuY2VDb25lR2FpbigpOworCisgICAgICAgIC8vIFNuYXAgdG8gZGVzaXJlZCBnYWlu IGF0IHRoZSBiZWdpbm5pbmcuCisgICAgICAgIGlmIChtX2xhc3RHYWluID09IC0xLjApCisgICAg ICAgICAgICBtX2xhc3RHYWluID0gdG90YWxHYWluOwogICAgICAgICAKLSAgICAvLyBBcHBseSBn YWluIGluLXBsYWNlIHdpdGggZGUtemlwcGVyaW5nLgotICAgIGRlc3RpbmF0aW9uLT5jb3B5V2l0 aEdhaW5Gcm9tKCpkZXN0aW5hdGlvbiwgJm1fbGFzdEdhaW4sIHRvdGFsR2Fpbik7CisgICAgICAg IC8vIEFwcGx5IGdhaW4gaW4tcGxhY2Ugd2l0aCBkZS16aXBwZXJpbmcuCisgICAgICAgIGRlc3Rp bmF0aW9uLT5jb3B5V2l0aEdhaW5Gcm9tKCpkZXN0aW5hdGlvbiwgJm1fbGFzdEdhaW4sIHRvdGFs R2Fpbik7CisgICAgfSBlbHNlIHsKKyAgICAgICAgLy8gVG9vIGJhZCAtIFRoZSB0cnlMb2NrKCkg ZmFpbGVkLiBXZSBtdXN0IGJlIGluIHRoZSBtaWRkbGUgb2YgY2hhbmdpbmcgdGhlIHBhbm5lci4K KyAgICAgICAgZGVzdGluYXRpb24tPnplcm8oKTsKKyAgICB9CiB9CiAKIHZvaWQgUGFubmVyTm9k ZTo6cmVzZXQoKQpAQCAtMTg1LDYgKzE5Miw5IEBAIGJvb2wgUGFubmVyTm9kZTo6c2V0UGFubmlu Z01vZGVsKHVuc2lnbmVkIG1vZGVsKQogICAgIGNhc2UgRVFVQUxQT1dFUjoKICAgICBjYXNlIEhS VEY6CiAgICAgICAgIGlmICghbV9wYW5uZXIuZ2V0KCkgfHwgbW9kZWwgIT0gbV9wYW5uaW5nTW9k ZWwpIHsKKyAgICAgICAgICAgIC8vIFRoaXMgc3luY2hyb25pemVzIHdpdGggcHJvY2VzcygpLgor ICAgICAgICAgICAgTXV0ZXhMb2NrZXIgcHJvY2Vzc0xvY2tlcihtX3Bhbm5lckxvY2spOworICAg ICAgICAgICAgCiAgICAgICAgICAgICBPd25QdHI8UGFubmVyPiBuZXdQYW5uZXIgPSBQYW5uZXI6 OmNyZWF0ZShtb2RlbCwgc2FtcGxlUmF0ZSgpKTsKICAgICAgICAgICAgIG1fcGFubmVyID0gbmV3 UGFubmVyLnJlbGVhc2UoKTsKICAgICAgICAgICAgIG1fcGFubmluZ01vZGVsID0gbW9kZWw7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1Bhbm5lck5vZGUuaCBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vUGFubmVyTm9kZS5oCmluZGV4IDUyZjQ0 ZGViZDIyN2IwNGY0MWYyOGJlOWJhMjc3NjMxYzE3YmEyNmQuLjM3NWM4OTgzZDBjNmQ0MDVlODc2 YzBhNDFiMTBjMDExZGJlNGY4YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv d2ViYXVkaW8vUGFubmVyTm9kZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVk aW8vUGFubmVyTm9kZS5oCkBAIC0xNTQsNiArMTU0LDkgQEAgcHJpdmF0ZToKICAgICBmbG9hdCBt X2xhc3RHYWluOwogCiAgICAgdW5zaWduZWQgbV9jb25uZWN0aW9uQ291bnQ7CisKKyAgICAvLyBT eW5jaHJvbml6ZSBwcm9jZXNzKCkgYW5kIHNldFBhbm5pbmdNb2RlbCgpIHdoaWNoIGNhbiBjaGFu Z2UgdGhlIHBhbm5lci4KKyAgICBtdXRhYmxlIE11dGV4IG1fcGFubmVyTG9jazsKIH07CiAKIH0g Ly8gbmFtZXNwYWNlIFdlYkNvcmUK