109593 2013-02-12 09:30:50 -0800 [GTK] Remove support for compiling with GStreamer 0.10 2013-02-14 06:36:20 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 109734 1 mrobinson mrobinson cgarcia d-r gustavo gyuyoung.kim pnormand s.choi webkit.review.bot oldest_to_newest 831009 0 mrobinson 2013-02-12 09:30:50 -0800 We are about to commit to supporting dependencies until WebKitGTK+ 3.0, so we need to remove dependencies that we don't want to support that long. 831015 1 pnormand 2013-02-12 09:34:35 -0800 You mean the configure.ac bits I guess? 831016 2 mrobinson 2013-02-12 09:35:05 -0800 Yep. The code will stay. I've got a patch cooking locally. 831214 3 187923 mrobinson 2013-02-12 13:42:36 -0800 Created attachment 187923 Patch 831670 4 pnormand 2013-02-12 23:29:55 -0800 So, while I agree with the rationale, this won't help us maintain the 0.10 code until gst 1.2 is fixed and we can drop the 0.10 support all together :( Maybe we can take a less extreme approach for now? Issue an error is configure is called with --with-gstreamer=0.10 ? 831968 5 187923 webkit.review.bot 2013-02-13 09:26:18 -0800 Comment on attachment 187923 Patch Clearing flags on attachment: 187923 Committed r142756: <http://trac.webkit.org/changeset/142756> 831969 6 webkit.review.bot 2013-02-13 09:26:23 -0800 All reviewed patches have been landed. Closing bug. 832208 7 webkit.review.bot 2013-02-13 12:38:49 -0800 Re-opened since this is blocked by bug 109734 187923 2013-02-12 13:42:36 -0800 2013-02-13 09:26:18 -0800 Patch bug-109593-20130212133906.patch text/plain 6547 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvYXV0b3Rvb2xz L0ZpbmREZXBlbmRlbmNpZXMubTQgYi9Tb3VyY2UvYXV0b3Rvb2xzL0ZpbmREZXBlbmRlbmNpZXMu bTQKaW5kZXggZjFlZTRiZGIyYzNmYTcwZTE4NTE1MmY2NDI3OTNjYmUzMDUxOGY2MC4uYjhlYTBl NzhmODVkYWYzMmE4MGE2NDMwNzY4NGQ4YzM2NmI5NWViZiAxMDA2NDQKLS0tIGEvU291cmNlL2F1 dG90b29scy9GaW5kRGVwZW5kZW5jaWVzLm00CisrKyBiL1NvdXJjZS9hdXRvdG9vbHMvRmluZERl cGVuZGVuY2llcy5tNApAQCAtMzE5LDM0ICszMTksNiBAQCBpZiB0ZXN0ICIkZW5hYmxlX3N2Z19m b250cyIgPSAieWVzIiAmJiB0ZXN0ICIkZW5hYmxlX3N2ZyIgPSAibm8iOyB0aGVuCiAgICAgZW5h YmxlX3N2Zz15ZXMKIGZpCiAKLWlmIHRlc3QgIiRlbmFibGVfdmlkZW8iID0gInllcyIgfHwgdGVz dCAiJGVuYWJsZV93ZWJfYXVkaW8iID0gInllcyI7IHRoZW4KLSAgICBpZiB0ZXN0ICIkd2l0aF9n c3RyZWFtZXIiID0gImF1dG8iOyB0aGVuCi0gICAgICAgIGdzdHJlYW1lcl9tb2R1bGVzPSJnc3Ry ZWFtZXItMS4wID49IGdzdHJlYW1lcl8xXzBfcmVxdWlyZWRfdmVyc2lvbiBnc3RyZWFtZXItYXBw LTEuMCBnc3RyZWFtZXItYXVkaW8tMS4wCi0gICAgICAgICAgICBnc3RyZWFtZXItZmZ0LTEuMCBn c3RyZWFtZXItYmFzZS0xLjAgZ3N0cmVhbWVyLXBidXRpbHMtMS4wCi0gICAgICAgICAgICBnc3Ry ZWFtZXItcGx1Z2lucy1iYXNlLTEuMCA+PSBnc3RyZWFtZXJfMV8wX3BsdWdpbnNfYmFzZV9yZXF1 aXJlZF92ZXJzaW9uIGdzdHJlYW1lci12aWRlby0xLjAiOwotICAgICAgICBQS0dfQ0hFQ0tfTU9E VUxFUyhbR1NUUkVBTUVSXzFfMF0sIFskZ3N0cmVhbWVyX21vZHVsZXNdLCBbd2l0aF9nc3RyZWFt ZXI9MS4wXSwgW3dpdGhfZ3N0cmVhbWVyPTAuMTBdKQotICAgICAgICBBQ19NU0dfTk9USUNFKFtT ZWxlY3RlZCBHU3RyZWFtZXIgJHdpdGhfZ3N0cmVhbWVyXSkKLSAgICBmaQotZWxzZQotICAgIGlm IHRlc3QgIiR3aXRoX2dzdHJlYW1lciIgIT0gImF1dG8iOyB0aGVuCi0gICAgICAgIEFDX01TR19X QVJOKFtZb3UgaGF2ZSBzcGVjaWZpZWQgR1N0cmVhbWVyICR3aXRoX2dzdHJlYW1lciB2ZXJzaW9u IGJ1dCBpdCB3aWxsIG5vdCBiZSB1c2VkCi0gICAgICAgICAgICBiZWNhdXNlIG5laXRoZXIgSFRN TDUgVmlkZW8gbm9yIFdlYiBBdWRpbyBhcmUgZW5hYmxlZF0pCi0gICAgZmkKLWZpCi0KLWNhc2Ug IiR3aXRoX2dzdHJlYW1lciIgaW4KLSAgICAwLjEwKSBHU1RSRUFNRVJfUkVRVUlSRURfVkVSU0lP Tj1nc3RyZWFtZXJfMF8xMF9yZXF1aXJlZF92ZXJzaW9uCi0gICAgICAgIEdTVFJFQU1FUl9QTFVH SU5TX0JBU0VfUkVRVUlSRURfVkVSU0lPTj1nc3RyZWFtZXJfMF8xMF9wbHVnaW5zX2Jhc2VfcmVx dWlyZWRfdmVyc2lvbgotICAgICAgICBHU1RfQVBJX1ZFUlNJT049MC4xMAotICAgICAgICA7Owot ICAgIDEuMCkgR1NUUkVBTUVSX1JFUVVJUkVEX1ZFUlNJT049Z3N0cmVhbWVyXzFfMF9yZXF1aXJl ZF92ZXJzaW9uCi0gICAgICAgIEdTVFJFQU1FUl9QTFVHSU5TX0JBU0VfUkVRVUlSRURfVkVSU0lP Tj1nc3RyZWFtZXJfMV8wX3BsdWdpbnNfYmFzZV9yZXF1aXJlZF92ZXJzaW9uCi0gICAgICAgIEdT VF9BUElfVkVSU0lPTj0xLjAKLSAgICAgICAgOzsKLWVzYWMKLQotQUNfU1VCU1QoW0dTVF9BUElf VkVSU0lPTl0pCi0KIGlmIHRlc3QgIiRlbmFibGVfb3Bjb2RlX3N0YXRzIiA9ICJ5ZXMiOyB0aGVu CiAgICAgaWYgdGVzdCAiJGVuYWJsZV9qaXQiID0gInllcyI7IHRoZW4KICAgICAgICAgQUNfTVNH X0VSUk9SKFtKSVQgbXVzdCBiZSBkaXNhYmxlZCBmb3IgT3Bjb2RlIHN0YXRzIHRvIHdvcmsuXSkK QEAgLTQ0NCwxNiArNDE2LDE2IEBAIGlmIHRlc3QgIiRvc193aW4zMiIgPSAibm8iOyB0aGVuCiAg ICAgQUNfU1VCU1QoW1hSRU5ERVJfTElCU10pCiBmaQogCi0jIENoZWNrIGlmIEdzdHJlYW1lciBp cyBhdmFpbGFibGUuCiBpZiB0ZXN0ICIkZW5hYmxlX3ZpZGVvIiA9ICJ5ZXMiIHx8IHRlc3QgIiRl bmFibGVfd2ViX2F1ZGlvIiA9ICJ5ZXMiOyB0aGVuCi0gICAgZ3N0cmVhbWVyX21vZHVsZXM9Imdz dHJlYW1lci0kR1NUX0FQSV9WRVJTSU9OID49ICRHU1RSRUFNRVJfUkVRVUlSRURfVkVSU0lPTiBn c3RyZWFtZXItYXBwLSRHU1RfQVBJX1ZFUlNJT04KLSAgICAgICAgZ3N0cmVhbWVyLWF1ZGlvLSRH U1RfQVBJX1ZFUlNJT04gZ3N0cmVhbWVyLWZmdC0kR1NUX0FQSV9WRVJTSU9OIGdzdHJlYW1lci1i YXNlLSRHU1RfQVBJX1ZFUlNJT04KLSAgICAgICAgZ3N0cmVhbWVyLXBidXRpbHMtJEdTVF9BUElf VkVSU0lPTiBnc3RyZWFtZXItcGx1Z2lucy1iYXNlLSRHU1RfQVBJX1ZFUlNJT04gPj0gJEdTVFJF QU1FUl9QTFVHSU5TX0JBU0VfUkVRVUlSRURfVkVSU0lPTgotICAgICAgICBnc3RyZWFtZXItdmlk ZW8tJEdTVF9BUElfVkVSU0lPTiI7Ci0gICAgaWYgdGVzdCAiJEdTVF9BUElfVkVSU0lPTiIgIT0g IjEuMCI7IHRoZW4KLSAgICAgICAgZ3N0cmVhbWVyX21vZHVsZXM9IiRnc3RyZWFtZXJfbW9kdWxl cyBnc3RyZWFtZXItaW50ZXJmYWNlcy0kR1NUX0FQSV9WRVJTSU9OIjsKLSAgICBmaQotICAgIFBL R19DSEVDS19NT0RVTEVTKFtHU1RSRUFNRVJdLCBbJGdzdHJlYW1lcl9tb2R1bGVzXSwgW2hhdmVf Z3N0cmVhbWVyPXllc10pCisgICAgUEtHX0NIRUNLX01PRFVMRVMoW0dTVFJFQU1FUl0sIFsKKyAg ICAgICAgZ3N0cmVhbWVyLTEuMCA+PSBnc3RyZWFtZXJfcmVxdWlyZWRfdmVyc2lvbgorICAgICAg ICBnc3RyZWFtZXItcGx1Z2lucy1iYXNlLTEuMCA+PSBnc3RyZWFtZXJfcGx1Z2luc19iYXNlX3Jl cXVpcmVkX3ZlcnNpb24KKyAgICAgICAgZ3N0cmVhbWVyLWFwcC0xLjAKKyAgICAgICAgZ3N0cmVh bWVyLWF1ZGlvLTEuMCwKKyAgICAgICAgZ3N0cmVhbWVyLWZmdC0xLjAsCisgICAgICAgIGdzdHJl YW1lci1iYXNlLTEuMCwKKyAgICAgICAgZ3N0cmVhbWVyLXBidXRpbHMtMS4wLAorICAgICAgICBn c3RyZWFtZXItdmlkZW8tMS4wXSkKICAgICBBQ19TVUJTVChbR1NUUkVBTUVSX0NGTEFHU10pCiAg ICAgQUNfU1VCU1QoW0dTVFJFQU1FUl9MSUJTXSkKIGZpCmRpZmYgLS1naXQgYS9Tb3VyY2UvYXV0 b3Rvb2xzL1JlYWRDb21tYW5kTGluZUFyZ3VtZW50cy5tNCBiL1NvdXJjZS9hdXRvdG9vbHMvUmVh ZENvbW1hbmRMaW5lQXJndW1lbnRzLm00CmluZGV4IGYxNmExODVjZmFkMzFhZDEwYzc4MTRkZDE4 YTRmNzk1MjNkMzE5MTQuLmFiY2RhYThmYTQ0OGYyYzRhYWU2OTc4YzE1NDkzOTVlNWE4MDk5Mjgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9hdXRvdG9vbHMvUmVhZENvbW1hbmRMaW5lQXJndW1lbnRzLm00 CisrKyBiL1NvdXJjZS9hdXRvdG9vbHMvUmVhZENvbW1hbmRMaW5lQXJndW1lbnRzLm00CkBAIC0x ODEsMTggKzE4MSw2IEBAIEFDX0FSR19FTkFCTEUoZGVidWdfc3ltYm9scywKICAgICBdKQogQUNf TVNHX1JFU1VMVChbJGVuYWJsZV9kZWJ1Z19zeW1ib2xzXSkKIAotQUNfTVNHX0NIRUNLSU5HKFt0 aGUgR1N0cmVhbWVyIHZlcnNpb24gdG8gdXNlXSkKLUFDX0FSR19XSVRIKFtnc3RyZWFtZXJdLAot ICAgIEFTX0hFTFBfU1RSSU5HKFstLXdpdGgtZ3N0cmVhbWVyPTEuMHwwLjEwfGF1dG9dLCBbdGhl IEdTdHJlYW1lciB2ZXJzaW9uIHRvIHVzZSAoZGVmYXVsdDogYXV0bywgdHJpZXMgMS4wIGZpcnN0 LCAwLjEwIGlzIGZhbGxiYWNrKV0pLAotICAgIFsKLSAgICAgICAgY2FzZSAiJHdpdGhfZ3N0cmVh bWVyIiBpbgotICAgICAgICAgICAgMC4xMHwxLjB8YXV0bykgOzsKLSAgICAgICAgICAgICopIEFD X01TR19FUlJPUihbaW52YWxpZCBHU3RyZWFtZXIgdmVyc2lvbiBzcGVjaWZpZWRdKSA7OwotICAg ICAgICBlc2FjCi0gICAgXSwKLSAgICBbd2l0aF9nc3RyZWFtZXI9YXV0b10pCi1BQ19NU0dfUkVT VUxUKFskd2l0aF9nc3RyZWFtZXJdKQotCiBBQ19NU0dfQ0hFQ0tJTkcoW3doaWNoIEdQVSBhY2Nl bGVyYXRpb24gYmFja2VuZCB0byB1c2VdKQogQUNfQVJHX1dJVEgoYWNjZWxlcmF0aW9uX2JhY2tl bmQsCiAgICAgQUNfSEVMUF9TVFJJTkcoWy0td2l0aC1hY2NlbGVyYXRpb24tYmFja2VuZD1APDpA b3BlbmdsL2NsdXR0ZXIvbm9uZUA6PkBdLApkaWZmIC0tZ2l0IGEvU291cmNlL2F1dG90b29scy9T ZXR1cEF1dG9jb25mSGVhZGVyLm00IGIvU291cmNlL2F1dG90b29scy9TZXR1cEF1dG9jb25mSGVh ZGVyLm00CmluZGV4IDA4YjU4M2UzNzJlMmNiNjFlMTk0N2ZhNDE5MjkwNzY1ZWJlNDQ0YzguLmVm ZDQ0MmI1YTExMTk2YWVmZTJhYzVlZmQ4Y2QzNmNjZjY0NTY5OWEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9hdXRvdG9vbHMvU2V0dXBBdXRvY29uZkhlYWRlci5tNAorKysgYi9Tb3VyY2UvYXV0b3Rvb2xz L1NldHVwQXV0b2NvbmZIZWFkZXIubTQKQEAgLTc3LDkgKzc3LDcgQEAgaWYgdGVzdCAiJGhhdmVf Z3N0cmVhbWVyIiA9ICJ5ZXMiOyB0aGVuCiAgICAgZmkKIGZpCiAKLWlmIHRlc3QgIiRHU1RfQVBJ X1ZFUlNJT04iID0gIjEuMCI7IHRoZW4KLSAgICBBQ19ERUZJTkUoW0dTVF9BUElfVkVSU0lPTl8x XSwgWzFdLCBbVXNpbmcgR1N0cmVhbWVyIDEuMF0pCi1maQorQUNfREVGSU5FKFtHU1RfQVBJX1ZF UlNJT05fMV0sIFsxXSwgW1VzaW5nIEdTdHJlYW1lciAxLjBdKQogCiBpZiB0ZXN0ICIkZW5hYmxl X3dlYl9hdWRpbyIgPSAieWVzIjsgdGhlbgogICAgIEFDX0RFRklORShbV1RGX1VTRV9XRUJBVURJ T19HU1RSRUFNRVJdLCBbMV0sIFsxXSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9hdXRvdG9vbHMvVmVy c2lvbnMubTQgYi9Tb3VyY2UvYXV0b3Rvb2xzL1ZlcnNpb25zLm00CmluZGV4IDBiNjI2YzYxOWJj MTY3ZjA1ZTIzNGNlYWFhNGE5M2EwYTNkNGVhMjkuLjNkYTMwOTczZTZmOTY5Njg1NWFkODExNzAx ZGJlNmE4MjE0MGQ5NzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9hdXRvdG9vbHMvVmVyc2lvbnMubTQK KysrIGIvU291cmNlL2F1dG90b29scy9WZXJzaW9ucy5tNApAQCAtMjgsOSArMjgsNyBAQCBtNF9k ZWZpbmUoW2xpYnNvdXBfcmVxdWlyZWRfdmVyc2lvbl0sIFsyLjQwLjBdKQogbTRfZGVmaW5lKFts aWJ4bWxfcmVxdWlyZWRfdmVyc2lvbl0sIFsyLjZdKQogbTRfZGVmaW5lKFtwYW5nb19yZXF1aXJl ZF92ZXJzaW9uXSwgWzEuMjEuMF0pCiAKLW00X2RlZmluZShbZ3N0cmVhbWVyXzBfMTBfcmVxdWly ZWRfdmVyc2lvbl0sIFswLjEwXSkKLW00X2RlZmluZShbZ3N0cmVhbWVyXzBfMTBfcGx1Z2luc19i YXNlX3JlcXVpcmVkX3ZlcnNpb25dLCBbMC4xMC4zMF0pCi1tNF9kZWZpbmUoW2dzdHJlYW1lcl8x XzBfcmVxdWlyZWRfdmVyc2lvbl0sIFsxLjAuM10pCi1tNF9kZWZpbmUoW2dzdHJlYW1lcl8xXzBf cGx1Z2luc19iYXNlX3JlcXVpcmVkX3ZlcnNpb25dLCBbMS4wLjNdKQorbTRfZGVmaW5lKFtnc3Ry ZWFtZXJfcmVxdWlyZWRfdmVyc2lvbl0sIFsxLjAuM10pCittNF9kZWZpbmUoW2dzdHJlYW1lcl9w bHVnaW5zX2Jhc2VfcmVxdWlyZWRfdmVyc2lvbl0sIFsxLjAuM10pCiAKIG00X2RlZmluZShbZ29i amVjdF9pbnRyb3NwZWN0aW9uX3JlcXVpcmVkXSwgWzAuOS41XSkKZGlmZiAtLWdpdCBhL0NoYW5n ZUxvZyBiL0NoYW5nZUxvZwppbmRleCA0YWM3MWQ0NjBkODA5MzhiMzJkYThkMmJmYWUxM2Y5Y2Qx YzhlODc2Li5kNmU2MTE3MmRlZGJiMDY3MTY5ZGEyZWFmZjBkZWEwMzUwMzgwMTU3IDEwMDY0NAot LS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTMtMDIt MTIgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCisgICAgICAgIFtH VEtdIFJlbW92ZSBzdXBwb3J0IGZvciBjb21waWxpbmcgd2l0aCBHU3RyZWFtZXIgMC4xMAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5NTkzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHN1cHBv cnQgZm9yIGJ1aWxkaW5nIFdlYktpdEdUSysgd2l0aCBHU3RyZWFtZXIgMC4xMC4gV2UKKyAgICAg ICAgY2FuIHNpbXBsaWZ5IHRoaW5ncyBncmVhdGx5IGJlY2F1c2Ugd2UgZG9uJ3QgaGF2ZSB0byB3 b3JyeSBhbnkKKyAgICAgICAgbG9uZ2VyIGFib3V0IHNlbGVjdGluZyBvbmUgR1N0cmVhbWVyIEFQ SSBzZXQuCisKKyAgICAgICAgKiBTb3VyY2UvYXV0b3Rvb2xzL0ZpbmREZXBlbmRlbmNpZXMubTQ6 CisgICAgICAgICogU291cmNlL2F1dG90b29scy9SZWFkQ29tbWFuZExpbmVBcmd1bWVudHMubTQ6 CisgICAgICAgICogU291cmNlL2F1dG90b29scy9TZXR1cEF1dG9jb25mSGVhZGVyLm00OgorICAg ICAgICAqIFNvdXJjZS9hdXRvdG9vbHMvVmVyc2lvbnMubTQ6CisKKzIwMTMtMDItMTIgIE1hcnRp biBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIFJlbW92 ZSB0aGUgZW5hYmxlLWRlYnVnLWZlYXR1cmUgY29uZmlndXJhdGlvbiBvcHRpb24KICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTUzOQogCg==