<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>109584</bug_id>
          
          <creation_ts>2013-02-12 07:20:10 -0800</creation_ts>
          <short_desc>[Chromium] Add support for emulating legacy Android WebView &apos;LoadWithOverviewMode&apos; setting</short_desc>
          <delta_ts>2013-02-14 09:36:41 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Android</rep_platform>
          <op_sys>Android</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mikhail Naganov">mnaganov</reporter>
          <assigned_to name="Mikhail Naganov">mnaganov</assigned_to>
          <cc>abarth</cc>
    
    <cc>aelias</cc>
    
    <cc>benm</cc>
    
    <cc>dglazkov</cc>
    
    <cc>eric</cc>
    
    <cc>fishd</cc>
    
    <cc>jamesr</cc>
    
    <cc>tkent+wkapi</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>830926</commentid>
    <comment_count>0</comment_count>
    <who name="Mikhail Naganov">mnaganov</who>
    <bug_when>2013-02-12 07:20:10 -0800</bug_when>
    <thetext>The &apos;LoadWithOverviewMode&apos; setting controls, whether the page needs to be scaled to fit contents into the viewport. Chrome on Android always adjusts page scale to fit contents. We need to make this behavior controllable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>830929</commentid>
    <comment_count>1</comment_count>
      <attachid>187864</attachid>
    <who name="Mikhail Naganov">mnaganov</who>
    <bug_when>2013-02-12 07:24:44 -0800</bug_when>
    <thetext>Created attachment 187864
Patch

Alexandre, Adam, please take a look!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>830935</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-02-12 07:35:25 -0800</bug_when>
    <thetext>Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>831004</commentid>
    <comment_count>3</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2013-02-12 09:17:12 -0800</bug_when>
    <thetext>Can we test this?  I worry if it&apos;s not tested its going to be broken.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>831007</commentid>
    <comment_count>4</comment_count>
    <who name="Mikhail Naganov">mnaganov</who>
    <bug_when>2013-02-12 09:25:05 -0800</bug_when>
    <thetext>I have tests in Chromium: https://codereview.chromium.org/12217134/

Do you think we need a separate test in WebKit?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>831162</commentid>
    <comment_count>5</comment_count>
    <who name="Alexandre Elias">aelias</who>
    <bug_when>2013-02-12 12:47:22 -0800</bug_when>
    <thetext>Could you rename this setting to &quot;initializeAtMinimumPageScale&quot;?

WebFrameTest is a good place to test this, take a look at the test csae &quot;FixedLayoutInitializeAtMinimumPageScale&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>831767</commentid>
    <comment_count>6</comment_count>
      <attachid>188046</attachid>
    <who name="Mikhail Naganov">mnaganov</who>
    <bug_when>2013-02-13 03:02:15 -0800</bug_when>
    <thetext>Created attachment 188046
Alexandre&apos;s comments addressed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>832096</commentid>
    <comment_count>7</comment_count>
      <attachid>188046</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2013-02-13 11:22:56 -0800</bug_when>
    <thetext>Comment on attachment 188046
Alexandre&apos;s comments addressed

View in context: https://bugs.webkit.org/attachment.cgi?id=188046&amp;action=review

&gt; Source/WebKit/chromium/public/WebSettings.h:57
&gt; +    virtual bool initializeAtMinimumPageScale() const = 0;

Why do you need a getter in the public API?  Most settings don&apos;t need one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>832099</commentid>
    <comment_count>8</comment_count>
    <who name="Alexandre Elias">aelias</who>
    <bug_when>2013-02-13 11:24:39 -0800</bug_when>
    <thetext>LGTM modulo Adam&apos;s last comment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>832327</commentid>
    <comment_count>9</comment_count>
    <who name="Mikhail Naganov">mnaganov</who>
    <bug_when>2013-02-13 14:06:12 -0800</bug_when>
    <thetext>(In reply to comment #7)
&gt; (From update of attachment 188046 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=188046&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/chromium/public/WebSettings.h:57
&gt; &gt; +    virtual bool initializeAtMinimumPageScale() const = 0;
&gt; 
&gt; Why do you need a getter in the public API?  Most settings don&apos;t need one.

Thanks for the review!

I&apos;m using it in Chromium glue layer to find out whether the setting was actually changed, see https://codereview.chromium.org/12217134/diff/1/webkit/glue/webpreferences.cc. The legacy implementation allows the setting to be applied on the next page reload. But WebViewImpl only allows to reset page scale on a new navigation, not on a reload. WebSettingsImpl, on the other hand, doesn&apos;t have an access to WebView, so it can&apos;t call resetScrollAndScaleState when the setting has changed. So I&apos;ve ended up calling it from the Chromium glue layer.

Do you think there is any better way for solving this other than exposing a getter?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>832999</commentid>
    <comment_count>10</comment_count>
    <who name="Mikhail Naganov">mnaganov</who>
    <bug_when>2013-02-14 05:43:53 -0800</bug_when>
    <thetext>(In reply to comment #9)
&gt; (In reply to comment #7)
&gt; &gt; (From update of attachment 188046 [details] [details])
&gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=188046&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; Source/WebKit/chromium/public/WebSettings.h:57
&gt; &gt; &gt; +    virtual bool initializeAtMinimumPageScale() const = 0;
&gt; &gt; 
&gt; &gt; Why do you need a getter in the public API?  Most settings don&apos;t need one.
&gt; 
&gt; Thanks for the review!
&gt; 
&gt; I&apos;m using it in Chromium glue layer to find out whether the setting was actually changed, see https://codereview.chromium.org/12217134/diff/1/webkit/glue/webpreferences.cc. The legacy implementation allows the setting to be applied on the next page reload. But WebViewImpl only allows to reset page scale on a new navigation, not on a reload. WebSettingsImpl, on the other hand, doesn&apos;t have an access to WebView, so it can&apos;t call resetScrollAndScaleState when the setting has changed. So I&apos;ve ended up calling it from the Chromium glue layer.
&gt; 
&gt; Do you think there is any better way for solving this other than exposing a getter?

OK, I&apos;ve found a workaround--I&apos;ll be using cached WebPreferences in RenderViewImpl in order to catch the moment the flag is being flipped. I&apos;ll submit the patch having the private getter removed from WebView.h as you have advised.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>833004</commentid>
    <comment_count>11</comment_count>
      <attachid>188331</attachid>
    <who name="Mikhail Naganov">mnaganov</who>
    <bug_when>2013-02-14 05:51:14 -0800</bug_when>
    <thetext>Created attachment 188331
Removed the getter from the public API</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>833006</commentid>
    <comment_count>12</comment_count>
    <who name="Mikhail Naganov">mnaganov</who>
    <bug_when>2013-02-14 05:55:29 -0800</bug_when>
    <thetext>Committed r142875: &lt;http://trac.webkit.org/changeset/142875&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>833155</commentid>
    <comment_count>13</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2013-02-14 09:36:41 -0800</bug_when>
    <thetext>(Having a getter isn&apos;t such a horrible thing.  I just wanted to make sure you weren&apos;t just copy/pasting it.)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>187864</attachid>
            <date>2013-02-12 07:24:44 -0800</date>
            <delta_ts>2013-02-13 03:02:15 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>wk-109584.patch</filename>
            <type>text/plain</type>
            <size>5429</size>
            <attacher name="Mikhail Naganov">mnaganov</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl
YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggODNmMjJlMS4uOTJmMTMxOCAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j
aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAxMy0wMi0xMiAgTWlraGFpbCBO
YWdhbm92ICA8bW5hZ2Fub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gQWRk
IGEgc2V0dGluZyB0byBjb250cm9sIHNjYWxpbmcgY29udGVudCB0byBmaXQgdmlld3BvcnQKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTU4NAorCisg
ICAgICAgIEFkZHMgYSBzZXR0aW5nIGNhbGxlZCAndmlld3BvcnRTY2FsZUNvbnRlbnRUb0ZpdCcu
IEJ5IGRlZmF1bHQsCisgICAgICAgIGl0IGlzIHNldCB0byAndHJ1ZScgd2hpY2ggY29ycmVzcG9u
ZHMgdG8gQ2hyb21lIG9uIEFuZHJvaWQgYmVoYXZpb3IuCisgICAgICAgIFdoZW4gc2V0IHRvIGZh
bHNlLCB0aGUgc2V0dGluZyBpbnN0cnVjdHMgQ2hyb21lQ2xpZW50SW1wbCB0bworICAgICAgICBz
ZXQgcGFnZSBzY2FsZSB0byAxLjAsIHVubGVzcyB0aGUgc2NhbGUgdmFsdWUgaXMgc2V0IGJ5IHRo
ZSBwYWdlCisgICAgICAgIGluIHRoZSB2aWV3cG9ydCBtZXRhLXRhZy4KKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHB1YmxpYy9XZWJTZXR0aW5ncy5o
OgorICAgICAgICAqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6
Q2hyb21lQ2xpZW50SW1wbDo6ZGlzcGF0Y2hWaWV3cG9ydFByb3BlcnRpZXNEaWRDaGFuZ2UpOgor
ICAgICAgICAqIHNyYy9XZWJTZXR0aW5nc0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJT
ZXR0aW5nc0ltcGw6OldlYlNldHRpbmdzSW1wbCk6CisgICAgICAgIChXZWJLaXQ6OldlYlNldHRp
bmdzSW1wbDo6c2V0Vmlld3BvcnRTY2FsZUNvbnRlbnRUb0ZpdCk6CisgICAgICAgIChXZWJLaXQp
OgorICAgICAgICAqIHNyYy9XZWJTZXR0aW5nc0ltcGwuaDoKKyAgICAgICAgKFdlYktpdDo6V2Vi
U2V0dGluZ3NJbXBsOjp2aWV3cG9ydFNjYWxlQ29udGVudFRvRml0KToKKyAgICAgICAgKFdlYlNl
dHRpbmdzSW1wbCk6CisKIDIwMTMtMDItMTIgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2Fs
aWEuY29tPgogCiAgICAgICAgIFJlbW92ZSBFTkFCTEVfWEhSX1JFU1BPTlNFX0JMT0IgaGFuZGxp
bmcgZnJvbSB2YXJpb3VzIGJ1aWxkIHN5c3RlbXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv
Y2hyb21pdW0vcHVibGljL1dlYlNldHRpbmdzLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1
YmxpYy9XZWJTZXR0aW5ncy5oCmluZGV4IGZlOTgzYmYuLmFiN2RjZWIgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNldHRpbmdzLmgKKysrIGIvU291cmNlL1dl
YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU2V0dGluZ3MuaApAQCAtNTQsNiArNTQsNyBAQCBwdWJs
aWM6CiAKICAgICB2aXJ0dWFsIGJvb2wgc2Nyb2xsQW5pbWF0b3JFbmFibGVkKCkgY29uc3QgPSAw
OwogICAgIHZpcnR1YWwgYm9vbCB2aWV3cG9ydEVuYWJsZWQoKSBjb25zdCA9IDA7CisgICAgdmly
dHVhbCBib29sIHZpZXdwb3J0U2NhbGVDb250ZW50VG9GaXQoKSBjb25zdCA9IDA7CiAgICAgdmly
dHVhbCB2b2lkIHNldEFjY2VsZXJhdGVkMmRDYW52YXNFbmFibGVkKGJvb2wpID0gMDsKICAgICB2
aXJ0dWFsIHZvaWQgc2V0QWNjZWxlcmF0ZWRBbmltYXRpb25FbmFibGVkKGJvb2wpID0gMDsKICAg
ICB2aXJ0dWFsIHZvaWQgc2V0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQoYm9vbCkgPSAw
OwpAQCAtMTcwLDYgKzE3MSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgc2V0VXNlc1Bh
Z2VDYWNoZShib29sKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNldFZhbGlkYXRpb25NZXNzYWdl
VGltZXJNYWduaWZpY2F0aW9uKGludCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRWaWV3cG9y
dEVuYWJsZWQoYm9vbCkgPSAwOworICAgIHZpcnR1YWwgdm9pZCBzZXRWaWV3cG9ydFNjYWxlQ29u
dGVudFRvRml0KGJvb2wpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0VmlzdWFsV29yZE1vdmVt
ZW50RW5hYmxlZChib29sKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNldFdlYkF1ZGlvRW5hYmxl
ZChib29sKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNldFdlYkdMRXJyb3JzVG9Db25zb2xlRW5h
YmxlZChib29sKSA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9D
aHJvbWVDbGllbnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNs
aWVudEltcGwuY3BwCmluZGV4IDhjYjZjOGEuLjJhNDA3ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
ZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJL
aXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCkBAIC02NjYsNiArNjY2LDggQEAg
dm9pZCBDaHJvbWVDbGllbnRJbXBsOjpkaXNwYXRjaFZpZXdwb3J0UHJvcGVydGllc0RpZENoYW5n
ZShjb25zdCBWaWV3cG9ydEFyZ3VtZW4KICAgICAgICAgY29tcHV0ZWQubWF4aW11bVNjYWxlID0g
bWF4KGNvbXB1dGVkLm1heGltdW1TY2FsZSwgbV93ZWJWaWV3LT5tYXhQYWdlU2NhbGVGYWN0b3Ip
OwogICAgICAgICBjb21wdXRlZC51c2VyU2NhbGFibGUgPSB0cnVlOwogICAgIH0KKyAgICBpZiAo
YXJndW1lbnRzLnpvb20gPT0gVmlld3BvcnRBcmd1bWVudHM6OlZhbHVlQXV0byAmJiAhbV93ZWJW
aWV3LT5zZXR0aW5nc0ltcGwoKS0+dmlld3BvcnRTY2FsZUNvbnRlbnRUb0ZpdCgpKQorICAgICAg
ICBjb21wdXRlZC5pbml0aWFsU2NhbGUgPSAxLjBmOwogICAgIGlmICghbV93ZWJWaWV3LT5zZXR0
aW5nc0ltcGwoKS0+YXBwbHlEZXZpY2VTY2FsZUZhY3RvckluQ29tcG9zaXRvcigpKQogICAgICAg
ICBjb21wdXRlZC5pbml0aWFsU2NhbGUgKj0gZGV2aWNlU2NhbGVGYWN0b3I7CiAKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5jcHAgYi9Tb3Vy
Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuY3BwCmluZGV4IGMxOWRhYWEu
LmYzYWNkZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRp
bmdzSW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJ
bXBsLmNwcApAQCAtNTQsNiArNTQsNyBAQCBXZWJTZXR0aW5nc0ltcGw6OldlYlNldHRpbmdzSW1w
bChTZXR0aW5ncyogc2V0dGluZ3MpCiAgICAgLCBtX3JlbmRlclZTeW5jRW5hYmxlZCh0cnVlKQog
ICAgICwgbV9yZW5kZXJWU3luY05vdGlmaWNhdGlvbkVuYWJsZWQoZmFsc2UpCiAgICAgLCBtX3Zp
ZXdwb3J0RW5hYmxlZChmYWxzZSkKKyAgICAsIG1fdmlld3BvcnRTY2FsZUNvbnRlbnRUb0ZpdCh0
cnVlKQogICAgICwgbV9nZXN0dXJlVGFwSGlnaGxpZ2h0RW5hYmxlZCh0cnVlKQogICAgICwgbV9h
dXRvWm9vbUZvY3VzZWROb2RlVG9MZWdpYmxlU2NhbGUoZmFsc2UpCiAgICAgLCBtX2RlZmVycmVk
SW1hZ2VEZWNvZGluZ0VuYWJsZWQoZmFsc2UpCkBAIC03MTAsNiArNzExLDExIEBAIHZvaWQgV2Vi
U2V0dGluZ3NJbXBsOjpzZXRWaWV3cG9ydEVuYWJsZWQoYm9vbCBlbmFibGVkKQogICAgIG1fdmll
d3BvcnRFbmFibGVkID0gZW5hYmxlZDsKIH0KIAordm9pZCBXZWJTZXR0aW5nc0ltcGw6OnNldFZp
ZXdwb3J0U2NhbGVDb250ZW50VG9GaXQoYm9vbCBlbmFibGVkKQoreworICAgIG1fdmlld3BvcnRT
Y2FsZUNvbnRlbnRUb0ZpdCA9IGVuYWJsZWQ7Cit9CisKIHZvaWQgV2ViU2V0dGluZ3NJbXBsOjpz
ZXREZWZhdWx0VGlsZVNpemUoV2ViU2l6ZSBzaXplKQogewogICAgIG1fZGVmYXVsdFRpbGVTaXpl
ID0gc2l6ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRp
bmdzSW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmgK
aW5kZXggYzRkNzIzYS4uNjJiNDgzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1
bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv
V2ViU2V0dGluZ3NJbXBsLmgKQEAgLTQ3LDYgKzQ3LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwg
Ym9vbCBkZXZpY2VTdXBwb3J0c1RvdWNoKCk7CiAgICAgdmlydHVhbCBib29sIHNjcm9sbEFuaW1h
dG9yRW5hYmxlZCgpIGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCB2aWV3cG9ydEVuYWJsZWQoKSBj
b25zdCB7IHJldHVybiBtX3ZpZXdwb3J0RW5hYmxlZDsgfQorICAgIHZpcnR1YWwgYm9vbCB2aWV3
cG9ydFNjYWxlQ29udGVudFRvRml0KCkgY29uc3QgeyByZXR1cm4gbV92aWV3cG9ydFNjYWxlQ29u
dGVudFRvRml0OyB9CiAgICAgdmlydHVhbCB2b2lkIHNldEFjY2VsZXJhdGVkMmRDYW52YXNFbmFi
bGVkKGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRBY2NlbGVyYXRlZEFuaW1hdGlvbkVuYWJs
ZWQoYm9vbCk7CiAgICAgdmlydHVhbCB2b2lkIHNldEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFi
bGVkKGJvb2wpOwpAQCAtMTY2LDYgKzE2Nyw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQg
c2V0VXNlc1BhZ2VDYWNoZShib29sKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0VmFsaWRhdGlvbk1l
c3NhZ2VUaW1lck1hZ25pZmljYXRpb24oaW50KTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0Vmlld3Bv
cnRFbmFibGVkKGJvb2wpOworICAgIHZpcnR1YWwgdm9pZCBzZXRWaWV3cG9ydFNjYWxlQ29udGVu
dFRvRml0KGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRWaXN1YWxXb3JkTW92ZW1lbnRFbmFi
bGVkKGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRXZWJBdWRpb0VuYWJsZWQoYm9vbCk7CiAg
ICAgdmlydHVhbCB2b2lkIHNldFdlYkdMRXJyb3JzVG9Db25zb2xlRW5hYmxlZChib29sKTsKQEAg
LTE5Niw2ICsxOTgsNyBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9yZW5kZXJWU3luY0VuYWJsZWQ7
CiAgICAgYm9vbCBtX3JlbmRlclZTeW5jTm90aWZpY2F0aW9uRW5hYmxlZDsKICAgICBib29sIG1f
dmlld3BvcnRFbmFibGVkOworICAgIGJvb2wgbV92aWV3cG9ydFNjYWxlQ29udGVudFRvRml0Owog
ICAgIGJvb2wgbV9nZXN0dXJlVGFwSGlnaGxpZ2h0RW5hYmxlZDsKICAgICBib29sIG1fYXV0b1pv
b21Gb2N1c2VkTm9kZVRvTGVnaWJsZVNjYWxlOwogICAgIGJvb2wgbV9kZWZlcnJlZEltYWdlRGVj
b2RpbmdFbmFibGVkOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>188046</attachid>
            <date>2013-02-13 03:02:15 -0800</date>
            <delta_ts>2013-02-14 05:51:14 -0800</delta_ts>
            <desc>Alexandre&apos;s comments addressed</desc>
            <filename>wk-109584.patch</filename>
            <type>text/plain</type>
            <size>8969</size>
            <attacher name="Mikhail Naganov">mnaganov</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl
YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNjczZWIyMC4uOGY3MzMyZSAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j
aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMSBAQAorMjAxMy0wMi0xMyAgTWlraGFpbCBO
YWdhbm92ICA8bW5hZ2Fub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gQWRk
IGEgc2V0dGluZyB0byBjb250cm9sIHNjYWxpbmcgY29udGVudCB0byBmaXQgdmlld3BvcnQKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTU4NAorCisg
ICAgICAgIEFkZHMgYSBzZXR0aW5nIGNhbGxlZCAnaW5pdGlhbGl6ZUF0TWluaW11bVBhZ2VTY2Fs
ZScuIEJ5IGRlZmF1bHQsCisgICAgICAgIGl0IGlzIHNldCB0byAndHJ1ZScgd2hpY2ggY29ycmVz
cG9uZHMgdG8gQ2hyb21lIG9uIEFuZHJvaWQgYmVoYXZpb3ItLQorICAgICAgICBhZGp1c3QgdGhl
IHBhZ2Ugc2NhbGUgdG8gbWFrZSB0aGUgY29udGVudCBmaXQgaW50byB0aGUgdmlld3BvcnQKKyAg
ICAgICAgYnkgd2lkdGguIFdoZW4gc2V0IHRvIGZhbHNlLCB0aGUgc2V0dGluZyBpbnN0cnVjdHMg
Q2hyb21lQ2xpZW50SW1wbCB0bworICAgICAgICBzZXQgcGFnZSBzY2FsZSB0byAxLjAsIHVubGVz
cyB0aGUgc2NhbGUgdmFsdWUgaXMgc2V0IGJ5IHRoZSBwYWdlCisgICAgICAgIGluIHRoZSB2aWV3
cG9ydCBtZXRhLXRhZy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICAqIHB1YmxpYy9XZWJTZXR0aW5ncy5oOgorICAgICAgICAqIHNyYy9DaHJvbWVDbGll
bnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50SW1wbDo6ZGlzcGF0Y2hW
aWV3cG9ydFByb3BlcnRpZXNEaWRDaGFuZ2UpOgorICAgICAgICAqIHNyYy9XZWJTZXR0aW5nc0lt
cGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJTZXR0aW5nc0ltcGw6OldlYlNldHRpbmdzSW1w
bCk6CisgICAgICAgIChXZWJLaXQ6OldlYlNldHRpbmdzSW1wbDo6c2V0SW5pdGlhbGl6ZUF0TWlu
aW11bVBhZ2VTY2FsZSk6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAqIHNyYy9XZWJTZXR0
aW5nc0ltcGwuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViU2V0dGluZ3NJbXBsOjppbml0aWFsaXpl
QXRNaW5pbXVtUGFnZVNjYWxlKToKKyAgICAgICAgKFdlYlNldHRpbmdzSW1wbCk6CisgICAgICAg
ICogdGVzdHMvV2ViRnJhbWVUZXN0LmNwcDoKKyAgICAgICAgKiB0ZXN0cy9kYXRhL3ZpZXdwb3J0
LTJ4LWluaXRpYWwtc2NhbGUuaHRtbDogQWRkZWQuCisgICAgICAgICogdGVzdHMvZGF0YS92aWV3
cG9ydC1hdXRvLWluaXRpYWwtc2NhbGUuaHRtbDogQWRkZWQuCisKIDIwMTMtMDItMTIgIFlvc2hp
ZnVtaSBJbm91ZSAgPHlvc2luQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiBC
dWlsZCBmaXggZm9yIENocm9taXVtLVdpbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vcHVibGljL1dlYlNldHRpbmdzLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp
Yy9XZWJTZXR0aW5ncy5oCmluZGV4IGZlOTgzYmYuLjQyYTBkNmEgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNldHRpbmdzLmgKKysrIGIvU291cmNlL1dlYktp
dC9jaHJvbWl1bS9wdWJsaWMvV2ViU2V0dGluZ3MuaApAQCAtNTQsNiArNTQsNyBAQCBwdWJsaWM6
CiAKICAgICB2aXJ0dWFsIGJvb2wgc2Nyb2xsQW5pbWF0b3JFbmFibGVkKCkgY29uc3QgPSAwOwog
ICAgIHZpcnR1YWwgYm9vbCB2aWV3cG9ydEVuYWJsZWQoKSBjb25zdCA9IDA7CisgICAgdmlydHVh
bCBib29sIGluaXRpYWxpemVBdE1pbmltdW1QYWdlU2NhbGUoKSBjb25zdCA9IDA7CiAgICAgdmly
dHVhbCB2b2lkIHNldEFjY2VsZXJhdGVkMmRDYW52YXNFbmFibGVkKGJvb2wpID0gMDsKICAgICB2
aXJ0dWFsIHZvaWQgc2V0QWNjZWxlcmF0ZWRBbmltYXRpb25FbmFibGVkKGJvb2wpID0gMDsKICAg
ICB2aXJ0dWFsIHZvaWQgc2V0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQoYm9vbCkgPSAw
OwpAQCAtMTE2LDYgKzExNyw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgc2V0R2VzdHVy
ZVRhcEhpZ2hsaWdodEVuYWJsZWQoYm9vbCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRIeXBl
cmxpbmtBdWRpdGluZ0VuYWJsZWQoYm9vbCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRJbWFn
ZXNFbmFibGVkKGJvb2wpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0SW5pdGlhbGl6ZUF0TWlu
aW11bVBhZ2VTY2FsZShib29sKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNldEludGVyYWN0aXZl
Rm9ybVZhbGlkYXRpb25FbmFibGVkKGJvb2wpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0SmF2
YUVuYWJsZWQoYm9vbCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRKYXZhU2NyaXB0Q2FuQWNj
ZXNzQ2xpcGJvYXJkKGJvb2wpID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p
dW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv
Q2hyb21lQ2xpZW50SW1wbC5jcHAKaW5kZXggOGNiNmM4YS4uMjRiMDYyMyAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKKysrIGIvU291
cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKQEAgLTY2Niw2ICs2
NjYsOCBAQCB2b2lkIENocm9tZUNsaWVudEltcGw6OmRpc3BhdGNoVmlld3BvcnRQcm9wZXJ0aWVz
RGlkQ2hhbmdlKGNvbnN0IFZpZXdwb3J0QXJndW1lbgogICAgICAgICBjb21wdXRlZC5tYXhpbXVt
U2NhbGUgPSBtYXgoY29tcHV0ZWQubWF4aW11bVNjYWxlLCBtX3dlYlZpZXctPm1heFBhZ2VTY2Fs
ZUZhY3Rvcik7CiAgICAgICAgIGNvbXB1dGVkLnVzZXJTY2FsYWJsZSA9IHRydWU7CiAgICAgfQor
ICAgIGlmIChhcmd1bWVudHMuem9vbSA9PSBWaWV3cG9ydEFyZ3VtZW50czo6VmFsdWVBdXRvICYm
ICFtX3dlYlZpZXctPnNldHRpbmdzSW1wbCgpLT5pbml0aWFsaXplQXRNaW5pbXVtUGFnZVNjYWxl
KCkpCisgICAgICAgIGNvbXB1dGVkLmluaXRpYWxTY2FsZSA9IDEuMGY7CiAgICAgaWYgKCFtX3dl
YlZpZXctPnNldHRpbmdzSW1wbCgpLT5hcHBseURldmljZVNjYWxlRmFjdG9ySW5Db21wb3NpdG9y
KCkpCiAgICAgICAgIGNvbXB1dGVkLmluaXRpYWxTY2FsZSAqPSBkZXZpY2VTY2FsZUZhY3RvcjsK
IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBs
LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5jcHAKaW5k
ZXggYzE5ZGFhYS4uMjY0Yzc1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z
cmMvV2ViU2V0dGluZ3NJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X
ZWJTZXR0aW5nc0ltcGwuY3BwCkBAIC01NCw2ICs1NCw3IEBAIFdlYlNldHRpbmdzSW1wbDo6V2Vi
U2V0dGluZ3NJbXBsKFNldHRpbmdzKiBzZXR0aW5ncykKICAgICAsIG1fcmVuZGVyVlN5bmNFbmFi
bGVkKHRydWUpCiAgICAgLCBtX3JlbmRlclZTeW5jTm90aWZpY2F0aW9uRW5hYmxlZChmYWxzZSkK
ICAgICAsIG1fdmlld3BvcnRFbmFibGVkKGZhbHNlKQorICAgICwgbV9pbml0aWFsaXplQXRNaW5p
bXVtUGFnZVNjYWxlKHRydWUpCiAgICAgLCBtX2dlc3R1cmVUYXBIaWdobGlnaHRFbmFibGVkKHRy
dWUpCiAgICAgLCBtX2F1dG9ab29tRm9jdXNlZE5vZGVUb0xlZ2libGVTY2FsZShmYWxzZSkKICAg
ICAsIG1fZGVmZXJyZWRJbWFnZURlY29kaW5nRW5hYmxlZChmYWxzZSkKQEAgLTIwNyw2ICsyMDgs
MTEgQEAgdm9pZCBXZWJTZXR0aW5nc0ltcGw6OnNldEltYWdlc0VuYWJsZWQoYm9vbCBlbmFibGVk
KQogICAgIG1fc2V0dGluZ3MtPnNldEltYWdlc0VuYWJsZWQoZW5hYmxlZCk7CiB9CiAKK3ZvaWQg
V2ViU2V0dGluZ3NJbXBsOjpzZXRJbml0aWFsaXplQXRNaW5pbXVtUGFnZVNjYWxlKGJvb2wgZW5h
YmxlZCkKK3sKKyAgICBtX2luaXRpYWxpemVBdE1pbmltdW1QYWdlU2NhbGUgPSBlbmFibGVkOwor
fQorCiB2b2lkIFdlYlNldHRpbmdzSW1wbDo6c2V0UGx1Z2luc0VuYWJsZWQoYm9vbCBlbmFibGVk
KQogewogICAgIG1fc2V0dGluZ3MtPnNldFBsdWdpbnNFbmFibGVkKGVuYWJsZWQpOwpkaWZmIC0t
Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmggYi9Tb3Vy
Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuaAppbmRleCBjNGQ3MjNhLi41
MjFiMGQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5n
c0ltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwu
aApAQCAtNDcsNiArNDcsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIGRldmljZVN1cHBv
cnRzVG91Y2goKTsKICAgICB2aXJ0dWFsIGJvb2wgc2Nyb2xsQW5pbWF0b3JFbmFibGVkKCkgY29u
c3Q7CiAgICAgdmlydHVhbCBib29sIHZpZXdwb3J0RW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1f
dmlld3BvcnRFbmFibGVkOyB9CisgICAgdmlydHVhbCBib29sIGluaXRpYWxpemVBdE1pbmltdW1Q
YWdlU2NhbGUoKSBjb25zdCB7IHJldHVybiBtX2luaXRpYWxpemVBdE1pbmltdW1QYWdlU2NhbGU7
IH0KICAgICB2aXJ0dWFsIHZvaWQgc2V0QWNjZWxlcmF0ZWQyZENhbnZhc0VuYWJsZWQoYm9vbCk7
CiAgICAgdmlydHVhbCB2b2lkIHNldEFjY2VsZXJhdGVkQW5pbWF0aW9uRW5hYmxlZChib29sKTsK
ICAgICB2aXJ0dWFsIHZvaWQgc2V0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQoYm9vbCk7
CkBAIC0xMDksNiArMTEwLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXRHZXN0dXJl
VGFwSGlnaGxpZ2h0RW5hYmxlZChib29sKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0SHlwZXJsaW5r
QXVkaXRpbmdFbmFibGVkKGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRJbWFnZXNFbmFibGVk
KGJvb2wpOworICAgIHZpcnR1YWwgdm9pZCBzZXRJbml0aWFsaXplQXRNaW5pbXVtUGFnZVNjYWxl
KGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRJbnRlcmFjdGl2ZUZvcm1WYWxpZGF0aW9uRW5h
YmxlZChib29sKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0SmF2YUVuYWJsZWQoYm9vbCk7CiAgICAg
dmlydHVhbCB2b2lkIHNldEphdmFTY3JpcHRDYW5BY2Nlc3NDbGlwYm9hcmQoYm9vbCk7CkBAIC0x
OTYsNiArMTk4LDcgQEAgcHJpdmF0ZToKICAgICBib29sIG1fcmVuZGVyVlN5bmNFbmFibGVkOwog
ICAgIGJvb2wgbV9yZW5kZXJWU3luY05vdGlmaWNhdGlvbkVuYWJsZWQ7CiAgICAgYm9vbCBtX3Zp
ZXdwb3J0RW5hYmxlZDsKKyAgICBib29sIG1faW5pdGlhbGl6ZUF0TWluaW11bVBhZ2VTY2FsZTsK
ICAgICBib29sIG1fZ2VzdHVyZVRhcEhpZ2hsaWdodEVuYWJsZWQ7CiAgICAgYm9vbCBtX2F1dG9a
b29tRm9jdXNlZE5vZGVUb0xlZ2libGVTY2FsZTsKICAgICBib29sIG1fZGVmZXJyZWRJbWFnZURl
Y29kaW5nRW5hYmxlZDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMv
V2ViRnJhbWVUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViRnJhbWVU
ZXN0LmNwcAppbmRleCAzYWQ1N2NjLi4zOGVkNDgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
L2Nocm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJv
bWl1bS90ZXN0cy9XZWJGcmFtZVRlc3QuY3BwCkBAIC0zNTIsNiArMzUyLDQ4IEBAIFRFU1RfRihX
ZWJGcmFtZVRlc3QsIEZpeGVkTGF5b3V0SW5pdGlhbGl6ZUF0TWluaW11bVBhZ2VTY2FsZSkKICAg
ICBFWFBFQ1RfRVEodXNlclBpbmNoUGFnZVNjYWxlRmFjdG9yLCBtX3dlYlZpZXctPnBhZ2VTY2Fs
ZUZhY3RvcigpKTsKIH0KIAorVEVTVF9GKFdlYkZyYW1lVGVzdCwgc2V0SW5pdGlhbGl6ZUF0TWlu
aW11bVBhZ2VTY2FsZVRvRmFsc2UpCit7CisgICAgcmVnaXN0ZXJNb2NrZWRIdHRwVVJMTG9hZCgi
dmlld3BvcnQtYXV0by1pbml0aWFsLXNjYWxlLmh0bWwiKTsKKworICAgIEZpeGVkTGF5b3V0VGVz
dFdlYlZpZXdDbGllbnQgY2xpZW50OworICAgIGNsaWVudC5tX3NjcmVlbkluZm8uZGV2aWNlU2Nh
bGVGYWN0b3IgPSAxOworICAgIGludCB2aWV3cG9ydFdpZHRoID0gNjQwOworICAgIGludCB2aWV3
cG9ydEhlaWdodCA9IDQ4MDsKKworICAgIG1fd2ViVmlldyA9IEZyYW1lVGVzdEhlbHBlcnM6OmNy
ZWF0ZVdlYlZpZXdBbmRMb2FkKG1fYmFzZVVSTCArICJ2aWV3cG9ydC1hdXRvLWluaXRpYWwtc2Nh
bGUuaHRtbCIsIHRydWUsIDAsICZjbGllbnQpOworICAgIG1fd2ViVmlldy0+c2V0dGluZ3MoKS0+
c2V0QXBwbHlEZXZpY2VTY2FsZUZhY3RvckluQ29tcG9zaXRvcih0cnVlKTsKKyAgICBtX3dlYlZp
ZXctPnNldHRpbmdzKCktPnNldEFwcGx5UGFnZVNjYWxlRmFjdG9ySW5Db21wb3NpdG9yKHRydWUp
OworICAgIG1fd2ViVmlldy0+ZW5hYmxlRml4ZWRMYXlvdXRNb2RlKHRydWUpOworICAgIG1fd2Vi
Vmlldy0+c2V0dGluZ3MoKS0+c2V0Vmlld3BvcnRFbmFibGVkKHRydWUpOworICAgIG1fd2ViVmll
dy0+c2V0dGluZ3MoKS0+c2V0SW5pdGlhbGl6ZUF0TWluaW11bVBhZ2VTY2FsZShmYWxzZSk7Cisg
ICAgbV93ZWJWaWV3LT5yZXNpemUoV2ViU2l6ZSh2aWV3cG9ydFdpZHRoLCB2aWV3cG9ydEhlaWdo
dCkpOworCisgICAgLy8gVGhlIHBhZ2UgbXVzdCBiZSBkaXNwbGF5ZWQgYXQgMTAwJSB6b29tLgor
ICAgIEVYUEVDVF9FUSgxLjBmLCBtX3dlYlZpZXctPnBhZ2VTY2FsZUZhY3RvcigpKTsKK30KKwor
VEVTVF9GKFdlYkZyYW1lVGVzdCwgUGFnZVZpZXdwb3J0SW5pdGlhbFNjYWxlT3ZlcnJpZGVzSW5p
dGlhbGl6ZUF0TWluaW11bVNjYWxlKQoreworICAgIHJlZ2lzdGVyTW9ja2VkSHR0cFVSTExvYWQo
InZpZXdwb3J0LTJ4LWluaXRpYWwtc2NhbGUuaHRtbCIpOworCisgICAgRml4ZWRMYXlvdXRUZXN0
V2ViVmlld0NsaWVudCBjbGllbnQ7CisgICAgY2xpZW50Lm1fc2NyZWVuSW5mby5kZXZpY2VTY2Fs
ZUZhY3RvciA9IDE7CisgICAgaW50IHZpZXdwb3J0V2lkdGggPSA2NDA7CisgICAgaW50IHZpZXdw
b3J0SGVpZ2h0ID0gNDgwOworCisgICAgbV93ZWJWaWV3ID0gRnJhbWVUZXN0SGVscGVyczo6Y3Jl
YXRlV2ViVmlld0FuZExvYWQobV9iYXNlVVJMICsgInZpZXdwb3J0LTJ4LWluaXRpYWwtc2NhbGUu
aHRtbCIsIHRydWUsIDAsICZjbGllbnQpOworICAgIG1fd2ViVmlldy0+c2V0dGluZ3MoKS0+c2V0
QXBwbHlEZXZpY2VTY2FsZUZhY3RvckluQ29tcG9zaXRvcih0cnVlKTsKKyAgICBtX3dlYlZpZXct
PnNldHRpbmdzKCktPnNldEFwcGx5UGFnZVNjYWxlRmFjdG9ySW5Db21wb3NpdG9yKHRydWUpOwor
ICAgIG1fd2ViVmlldy0+ZW5hYmxlRml4ZWRMYXlvdXRNb2RlKHRydWUpOworICAgIG1fd2ViVmll
dy0+c2V0dGluZ3MoKS0+c2V0Vmlld3BvcnRFbmFibGVkKHRydWUpOworICAgIG1fd2ViVmlldy0+
c2V0dGluZ3MoKS0+c2V0SW5pdGlhbGl6ZUF0TWluaW11bVBhZ2VTY2FsZShmYWxzZSk7CisgICAg
bV93ZWJWaWV3LT5yZXNpemUoV2ViU2l6ZSh2aWV3cG9ydFdpZHRoLCB2aWV3cG9ydEhlaWdodCkp
OworCisgICAgLy8gVGhlIHBhZ2UgbXVzdCBiZSBkaXNwbGF5ZWQgYXQgMjAwJSB6b29tLCBhcyBz
cGVjaWZpZWQgaW4gaXRzIHZpZXdwb3J0IG1ldGEgdGFnLgorICAgIEVYUEVDVF9FUSgyLjBmLCBt
X3dlYlZpZXctPnBhZ2VTY2FsZUZhY3RvcigpKTsKK30KKwogVEVTVF9GKFdlYkZyYW1lVGVzdCwg
U2NhbGVGYWN0b3JTaG91bGROb3RPc2NpbGxhdGUpCiB7CiAgICAgcmVnaXN0ZXJNb2NrZWRIdHRw
VVJMTG9hZCgic2NhbGVfb3NjaWxsYXRlLmh0bWwiKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL
aXQvY2hyb21pdW0vdGVzdHMvZGF0YS92aWV3cG9ydC0yeC1pbml0aWFsLXNjYWxlLmh0bWwgYi9T
b3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL2RhdGEvdmlld3BvcnQtMngtaW5pdGlhbC1zY2Fs
ZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjE2MTU5ZTAKLS0tIC9k
ZXYvbnVsbAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL2RhdGEvdmlld3BvcnQt
MngtaW5pdGlhbC1zY2FsZS5odG1sCkBAIC0wLDAgKzEsOCBAQAorPGh0bWw+CisgIDxoZWFkPgor
ICAgIDxtZXRhIG5hbWU9J3ZpZXdwb3J0JyBjb250ZW50PSd3aWR0aD0zMDAwLCBpbml0aWFsLXNj
YWxlPTInIC8+CisgIDwvaGVhZD4KKyAgPGJvZHk+CisgICAgQSBwYWdlIHdpdGggdGhlIHZpZXdw
b3J0IHNldCB0byAyeCBzY2FsZS4KKyAgPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9kYXRhL3ZpZXdwb3J0LWF1dG8taW5pdGlhbC1zY2Fs
ZS5odG1sIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9kYXRhL3ZpZXdwb3J0LWF1dG8t
aW5pdGlhbC1zY2FsZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjcw
MjBlNDkKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL2Rh
dGEvdmlld3BvcnQtYXV0by1pbml0aWFsLXNjYWxlLmh0bWwKQEAgLTAsMCArMSw4IEBACis8aHRt
bD4KKyAgPGhlYWQ+CisgICAgPG1ldGEgbmFtZT0ndmlld3BvcnQnIGNvbnRlbnQ9J3dpZHRoPTMw
MDAnIC8+CisgIDwvaGVhZD4KKyAgPGJvZHk+CisgICAgQSBwYWdlIHdpdGggYSB2aWV3cG9ydC4K
KyAgPC9ib2R5PgorPC9odG1sPgo=
</data>
<flag name="review"
          id="208044"
          type_id="1"
          status="+"
          setter="abarth"
    />
    <flag name="commit-queue"
          id="208045"
          type_id="3"
          status="-"
          setter="abarth"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>188331</attachid>
            <date>2013-02-14 05:51:14 -0800</date>
            <delta_ts>2013-02-14 05:51:14 -0800</delta_ts>
            <desc>Removed the getter from the public API</desc>
            <filename>wk-109584.patch</filename>
            <type>text/plain</type>
            <size>8721</size>
            <attacher name="Mikhail Naganov">mnaganov</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl
YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggZjczMjRmMS4uZDQ2ZDczYSAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j
aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMSBAQAorMjAxMy0wMi0xNCAgTWlraGFpbCBO
YWdhbm92ICA8bW5hZ2Fub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gQWRk
IGEgc2V0dGluZyB0byBjb250cm9sIHNjYWxpbmcgY29udGVudCB0byBmaXQgdmlld3BvcnQKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTU4NAorCisg
ICAgICAgIEFkZHMgYSBzZXR0aW5nIGNhbGxlZCAnaW5pdGlhbGl6ZUF0TWluaW11bVBhZ2VTY2Fs
ZScuIEJ5IGRlZmF1bHQsCisgICAgICAgIGl0IGlzIHNldCB0byAndHJ1ZScgd2hpY2ggY29ycmVz
cG9uZHMgdG8gQ2hyb21lIG9uIEFuZHJvaWQgYmVoYXZpb3ItLQorICAgICAgICBhZGp1c3QgdGhl
IHBhZ2Ugc2NhbGUgdG8gbWFrZSB0aGUgY29udGVudCBmaXQgaW50byB0aGUgdmlld3BvcnQKKyAg
ICAgICAgYnkgd2lkdGguIFdoZW4gc2V0IHRvIGZhbHNlLCB0aGUgc2V0dGluZyBpbnN0cnVjdHMg
Q2hyb21lQ2xpZW50SW1wbCB0bworICAgICAgICBzZXQgcGFnZSBzY2FsZSB0byAxLjAsIHVubGVz
cyB0aGUgc2NhbGUgdmFsdWUgaXMgc2V0IGJ5IHRoZSBwYWdlCisgICAgICAgIGluIHRoZSB2aWV3
cG9ydCBtZXRhLXRhZy4KKworICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgorCisgICAg
ICAgICogcHVibGljL1dlYlNldHRpbmdzLmg6CisgICAgICAgICogc3JjL0Nocm9tZUNsaWVudElt
cGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpDaHJvbWVDbGllbnRJbXBsOjpkaXNwYXRjaFZpZXdw
b3J0UHJvcGVydGllc0RpZENoYW5nZSk6CisgICAgICAgICogc3JjL1dlYlNldHRpbmdzSW1wbC5j
cHA6CisgICAgICAgIChXZWJLaXQ6OldlYlNldHRpbmdzSW1wbDo6V2ViU2V0dGluZ3NJbXBsKToK
KyAgICAgICAgKFdlYktpdDo6V2ViU2V0dGluZ3NJbXBsOjpzZXRJbml0aWFsaXplQXRNaW5pbXVt
UGFnZVNjYWxlKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgICogc3JjL1dlYlNldHRpbmdz
SW1wbC5oOgorICAgICAgICAoV2ViU2V0dGluZ3NJbXBsKToKKyAgICAgICAgKFdlYktpdDo6V2Vi
U2V0dGluZ3NJbXBsOjppbml0aWFsaXplQXRNaW5pbXVtUGFnZVNjYWxlKToKKyAgICAgICAgKiB0
ZXN0cy9XZWJGcmFtZVRlc3QuY3BwOgorICAgICAgICAqIHRlc3RzL2RhdGEvdmlld3BvcnQtMngt
aW5pdGlhbC1zY2FsZS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiB0ZXN0cy9kYXRhL3ZpZXdwb3J0
LWF1dG8taW5pdGlhbC1zY2FsZS5odG1sOiBBZGRlZC4KKwogMjAxMy0wMi0xNCAgU2hlcmlmZiBC
b3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg
cm9sbGluZyBvdXQgcjE0Mjg0MS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v
cHVibGljL1dlYlNldHRpbmdzLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJT
ZXR0aW5ncy5oCmluZGV4IGZlOTgzYmYuLmYxOTIwZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL
aXQvY2hyb21pdW0vcHVibGljL1dlYlNldHRpbmdzLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJv
bWl1bS9wdWJsaWMvV2ViU2V0dGluZ3MuaApAQCAtMTE2LDYgKzExNiw3IEBAIHB1YmxpYzoKICAg
ICB2aXJ0dWFsIHZvaWQgc2V0R2VzdHVyZVRhcEhpZ2hsaWdodEVuYWJsZWQoYm9vbCkgPSAwOwog
ICAgIHZpcnR1YWwgdm9pZCBzZXRIeXBlcmxpbmtBdWRpdGluZ0VuYWJsZWQoYm9vbCkgPSAwOwog
ICAgIHZpcnR1YWwgdm9pZCBzZXRJbWFnZXNFbmFibGVkKGJvb2wpID0gMDsKKyAgICB2aXJ0dWFs
IHZvaWQgc2V0SW5pdGlhbGl6ZUF0TWluaW11bVBhZ2VTY2FsZShib29sKSA9IDA7CiAgICAgdmly
dHVhbCB2b2lkIHNldEludGVyYWN0aXZlRm9ybVZhbGlkYXRpb25FbmFibGVkKGJvb2wpID0gMDsK
ICAgICB2aXJ0dWFsIHZvaWQgc2V0SmF2YUVuYWJsZWQoYm9vbCkgPSAwOwogICAgIHZpcnR1YWwg
dm9pZCBzZXRKYXZhU2NyaXB0Q2FuQWNjZXNzQ2xpcGJvYXJkKGJvb2wpID0gMDsKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwIGIvU291
cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKaW5kZXggOGNiNmM4
YS4uMjRiMDYyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21l
Q2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xp
ZW50SW1wbC5jcHAKQEAgLTY2Niw2ICs2NjYsOCBAQCB2b2lkIENocm9tZUNsaWVudEltcGw6OmRp
c3BhdGNoVmlld3BvcnRQcm9wZXJ0aWVzRGlkQ2hhbmdlKGNvbnN0IFZpZXdwb3J0QXJndW1lbgog
ICAgICAgICBjb21wdXRlZC5tYXhpbXVtU2NhbGUgPSBtYXgoY29tcHV0ZWQubWF4aW11bVNjYWxl
LCBtX3dlYlZpZXctPm1heFBhZ2VTY2FsZUZhY3Rvcik7CiAgICAgICAgIGNvbXB1dGVkLnVzZXJT
Y2FsYWJsZSA9IHRydWU7CiAgICAgfQorICAgIGlmIChhcmd1bWVudHMuem9vbSA9PSBWaWV3cG9y
dEFyZ3VtZW50czo6VmFsdWVBdXRvICYmICFtX3dlYlZpZXctPnNldHRpbmdzSW1wbCgpLT5pbml0
aWFsaXplQXRNaW5pbXVtUGFnZVNjYWxlKCkpCisgICAgICAgIGNvbXB1dGVkLmluaXRpYWxTY2Fs
ZSA9IDEuMGY7CiAgICAgaWYgKCFtX3dlYlZpZXctPnNldHRpbmdzSW1wbCgpLT5hcHBseURldmlj
ZVNjYWxlRmFjdG9ySW5Db21wb3NpdG9yKCkpCiAgICAgICAgIGNvbXB1dGVkLmluaXRpYWxTY2Fs
ZSAqPSBkZXZpY2VTY2FsZUZhY3RvcjsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv
bWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj
L1dlYlNldHRpbmdzSW1wbC5jcHAKaW5kZXggYzE5ZGFhYS4uMjY0Yzc1NiAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmNwcAorKysgYi9Tb3Vy
Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuY3BwCkBAIC01NCw2ICs1NCw3
IEBAIFdlYlNldHRpbmdzSW1wbDo6V2ViU2V0dGluZ3NJbXBsKFNldHRpbmdzKiBzZXR0aW5ncykK
ICAgICAsIG1fcmVuZGVyVlN5bmNFbmFibGVkKHRydWUpCiAgICAgLCBtX3JlbmRlclZTeW5jTm90
aWZpY2F0aW9uRW5hYmxlZChmYWxzZSkKICAgICAsIG1fdmlld3BvcnRFbmFibGVkKGZhbHNlKQor
ICAgICwgbV9pbml0aWFsaXplQXRNaW5pbXVtUGFnZVNjYWxlKHRydWUpCiAgICAgLCBtX2dlc3R1
cmVUYXBIaWdobGlnaHRFbmFibGVkKHRydWUpCiAgICAgLCBtX2F1dG9ab29tRm9jdXNlZE5vZGVU
b0xlZ2libGVTY2FsZShmYWxzZSkKICAgICAsIG1fZGVmZXJyZWRJbWFnZURlY29kaW5nRW5hYmxl
ZChmYWxzZSkKQEAgLTIwNyw2ICsyMDgsMTEgQEAgdm9pZCBXZWJTZXR0aW5nc0ltcGw6OnNldElt
YWdlc0VuYWJsZWQoYm9vbCBlbmFibGVkKQogICAgIG1fc2V0dGluZ3MtPnNldEltYWdlc0VuYWJs
ZWQoZW5hYmxlZCk7CiB9CiAKK3ZvaWQgV2ViU2V0dGluZ3NJbXBsOjpzZXRJbml0aWFsaXplQXRN
aW5pbXVtUGFnZVNjYWxlKGJvb2wgZW5hYmxlZCkKK3sKKyAgICBtX2luaXRpYWxpemVBdE1pbmlt
dW1QYWdlU2NhbGUgPSBlbmFibGVkOworfQorCiB2b2lkIFdlYlNldHRpbmdzSW1wbDo6c2V0UGx1
Z2luc0VuYWJsZWQoYm9vbCBlbmFibGVkKQogewogICAgIG1fc2V0dGluZ3MtPnNldFBsdWdpbnNF
bmFibGVkKGVuYWJsZWQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv
V2ViU2V0dGluZ3NJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5n
c0ltcGwuaAppbmRleCBjNGQ3MjNhLi43MmEzZTMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t
aXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuaApAQCAtMTA5LDYgKzEwOSw3IEBAIHB1YmxpYzoKICAg
ICB2aXJ0dWFsIHZvaWQgc2V0R2VzdHVyZVRhcEhpZ2hsaWdodEVuYWJsZWQoYm9vbCk7CiAgICAg
dmlydHVhbCB2b2lkIHNldEh5cGVybGlua0F1ZGl0aW5nRW5hYmxlZChib29sKTsKICAgICB2aXJ0
dWFsIHZvaWQgc2V0SW1hZ2VzRW5hYmxlZChib29sKTsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0SW5p
dGlhbGl6ZUF0TWluaW11bVBhZ2VTY2FsZShib29sKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0SW50
ZXJhY3RpdmVGb3JtVmFsaWRhdGlvbkVuYWJsZWQoYm9vbCk7CiAgICAgdmlydHVhbCB2b2lkIHNl
dEphdmFFbmFibGVkKGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRKYXZhU2NyaXB0Q2FuQWNj
ZXNzQ2xpcGJvYXJkKGJvb2wpOwpAQCAtMTc5LDYgKzE4MCw3IEBAIHB1YmxpYzoKICAgICBib29s
IHJlbmRlclZTeW5jTm90aWZpY2F0aW9uRW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1fcmVuZGVy
VlN5bmNOb3RpZmljYXRpb25FbmFibGVkOyB9CiAgICAgYm9vbCBhcHBseURldmljZVNjYWxlRmFj
dG9ySW5Db21wb3NpdG9yKCkgY29uc3Q7CiAgICAgYm9vbCBhcHBseVBhZ2VTY2FsZUZhY3Rvcklu
Q29tcG9zaXRvcigpIGNvbnN0OworICAgIGJvb2wgaW5pdGlhbGl6ZUF0TWluaW11bVBhZ2VTY2Fs
ZSgpIGNvbnN0IHsgcmV0dXJuIG1faW5pdGlhbGl6ZUF0TWluaW11bVBhZ2VTY2FsZTsgfQogICAg
IGJvb2wgYXV0b1pvb21Gb2N1c2VkTm9kZVRvTGVnaWJsZVNjYWxlKCkgY29uc3QgeyByZXR1cm4g
bV9hdXRvWm9vbUZvY3VzZWROb2RlVG9MZWdpYmxlU2NhbGU7IH0KICAgICBib29sIGdlc3R1cmVU
YXBIaWdobGlnaHRFbmFibGVkKCkgY29uc3QgeyByZXR1cm4gbV9nZXN0dXJlVGFwSGlnaGxpZ2h0
RW5hYmxlZDsgfQogICAgIGJvb2wgZG91YmxlVGFwVG9ab29tRW5hYmxlZCgpIGNvbnN0IHsgcmV0
dXJuIG1fZG91YmxlVGFwVG9ab29tRW5hYmxlZDsgfQpAQCAtMTk2LDYgKzE5OCw3IEBAIHByaXZh
dGU6CiAgICAgYm9vbCBtX3JlbmRlclZTeW5jRW5hYmxlZDsKICAgICBib29sIG1fcmVuZGVyVlN5
bmNOb3RpZmljYXRpb25FbmFibGVkOwogICAgIGJvb2wgbV92aWV3cG9ydEVuYWJsZWQ7CisgICAg
Ym9vbCBtX2luaXRpYWxpemVBdE1pbmltdW1QYWdlU2NhbGU7CiAgICAgYm9vbCBtX2dlc3R1cmVU
YXBIaWdobGlnaHRFbmFibGVkOwogICAgIGJvb2wgbV9hdXRvWm9vbUZvY3VzZWROb2RlVG9MZWdp
YmxlU2NhbGU7CiAgICAgYm9vbCBtX2RlZmVycmVkSW1hZ2VEZWNvZGluZ0VuYWJsZWQ7CmRpZmYg
LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAgYi9T
b3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAKaW5kZXggM2FkNTdj
Yy4uMzhlZDQ4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9XZWJG
cmFtZVRlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViRnJhbWVU
ZXN0LmNwcApAQCAtMzUyLDYgKzM1Miw0OCBAQCBURVNUX0YoV2ViRnJhbWVUZXN0LCBGaXhlZExh
eW91dEluaXRpYWxpemVBdE1pbmltdW1QYWdlU2NhbGUpCiAgICAgRVhQRUNUX0VRKHVzZXJQaW5j
aFBhZ2VTY2FsZUZhY3RvciwgbV93ZWJWaWV3LT5wYWdlU2NhbGVGYWN0b3IoKSk7CiB9CiAKK1RF
U1RfRihXZWJGcmFtZVRlc3QsIHNldEluaXRpYWxpemVBdE1pbmltdW1QYWdlU2NhbGVUb0ZhbHNl
KQoreworICAgIHJlZ2lzdGVyTW9ja2VkSHR0cFVSTExvYWQoInZpZXdwb3J0LWF1dG8taW5pdGlh
bC1zY2FsZS5odG1sIik7CisKKyAgICBGaXhlZExheW91dFRlc3RXZWJWaWV3Q2xpZW50IGNsaWVu
dDsKKyAgICBjbGllbnQubV9zY3JlZW5JbmZvLmRldmljZVNjYWxlRmFjdG9yID0gMTsKKyAgICBp
bnQgdmlld3BvcnRXaWR0aCA9IDY0MDsKKyAgICBpbnQgdmlld3BvcnRIZWlnaHQgPSA0ODA7CisK
KyAgICBtX3dlYlZpZXcgPSBGcmFtZVRlc3RIZWxwZXJzOjpjcmVhdGVXZWJWaWV3QW5kTG9hZCht
X2Jhc2VVUkwgKyAidmlld3BvcnQtYXV0by1pbml0aWFsLXNjYWxlLmh0bWwiLCB0cnVlLCAwLCAm
Y2xpZW50KTsKKyAgICBtX3dlYlZpZXctPnNldHRpbmdzKCktPnNldEFwcGx5RGV2aWNlU2NhbGVG
YWN0b3JJbkNvbXBvc2l0b3IodHJ1ZSk7CisgICAgbV93ZWJWaWV3LT5zZXR0aW5ncygpLT5zZXRB
cHBseVBhZ2VTY2FsZUZhY3RvckluQ29tcG9zaXRvcih0cnVlKTsKKyAgICBtX3dlYlZpZXctPmVu
YWJsZUZpeGVkTGF5b3V0TW9kZSh0cnVlKTsKKyAgICBtX3dlYlZpZXctPnNldHRpbmdzKCktPnNl
dFZpZXdwb3J0RW5hYmxlZCh0cnVlKTsKKyAgICBtX3dlYlZpZXctPnNldHRpbmdzKCktPnNldElu
aXRpYWxpemVBdE1pbmltdW1QYWdlU2NhbGUoZmFsc2UpOworICAgIG1fd2ViVmlldy0+cmVzaXpl
KFdlYlNpemUodmlld3BvcnRXaWR0aCwgdmlld3BvcnRIZWlnaHQpKTsKKworICAgIC8vIFRoZSBw
YWdlIG11c3QgYmUgZGlzcGxheWVkIGF0IDEwMCUgem9vbS4KKyAgICBFWFBFQ1RfRVEoMS4wZiwg
bV93ZWJWaWV3LT5wYWdlU2NhbGVGYWN0b3IoKSk7Cit9CisKK1RFU1RfRihXZWJGcmFtZVRlc3Qs
IFBhZ2VWaWV3cG9ydEluaXRpYWxTY2FsZU92ZXJyaWRlc0luaXRpYWxpemVBdE1pbmltdW1TY2Fs
ZSkKK3sKKyAgICByZWdpc3Rlck1vY2tlZEh0dHBVUkxMb2FkKCJ2aWV3cG9ydC0yeC1pbml0aWFs
LXNjYWxlLmh0bWwiKTsKKworICAgIEZpeGVkTGF5b3V0VGVzdFdlYlZpZXdDbGllbnQgY2xpZW50
OworICAgIGNsaWVudC5tX3NjcmVlbkluZm8uZGV2aWNlU2NhbGVGYWN0b3IgPSAxOworICAgIGlu
dCB2aWV3cG9ydFdpZHRoID0gNjQwOworICAgIGludCB2aWV3cG9ydEhlaWdodCA9IDQ4MDsKKwor
ICAgIG1fd2ViVmlldyA9IEZyYW1lVGVzdEhlbHBlcnM6OmNyZWF0ZVdlYlZpZXdBbmRMb2FkKG1f
YmFzZVVSTCArICJ2aWV3cG9ydC0yeC1pbml0aWFsLXNjYWxlLmh0bWwiLCB0cnVlLCAwLCAmY2xp
ZW50KTsKKyAgICBtX3dlYlZpZXctPnNldHRpbmdzKCktPnNldEFwcGx5RGV2aWNlU2NhbGVGYWN0
b3JJbkNvbXBvc2l0b3IodHJ1ZSk7CisgICAgbV93ZWJWaWV3LT5zZXR0aW5ncygpLT5zZXRBcHBs
eVBhZ2VTY2FsZUZhY3RvckluQ29tcG9zaXRvcih0cnVlKTsKKyAgICBtX3dlYlZpZXctPmVuYWJs
ZUZpeGVkTGF5b3V0TW9kZSh0cnVlKTsKKyAgICBtX3dlYlZpZXctPnNldHRpbmdzKCktPnNldFZp
ZXdwb3J0RW5hYmxlZCh0cnVlKTsKKyAgICBtX3dlYlZpZXctPnNldHRpbmdzKCktPnNldEluaXRp
YWxpemVBdE1pbmltdW1QYWdlU2NhbGUoZmFsc2UpOworICAgIG1fd2ViVmlldy0+cmVzaXplKFdl
YlNpemUodmlld3BvcnRXaWR0aCwgdmlld3BvcnRIZWlnaHQpKTsKKworICAgIC8vIFRoZSBwYWdl
IG11c3QgYmUgZGlzcGxheWVkIGF0IDIwMCUgem9vbSwgYXMgc3BlY2lmaWVkIGluIGl0cyB2aWV3
cG9ydCBtZXRhIHRhZy4KKyAgICBFWFBFQ1RfRVEoMi4wZiwgbV93ZWJWaWV3LT5wYWdlU2NhbGVG
YWN0b3IoKSk7Cit9CisKIFRFU1RfRihXZWJGcmFtZVRlc3QsIFNjYWxlRmFjdG9yU2hvdWxkTm90
T3NjaWxsYXRlKQogewogICAgIHJlZ2lzdGVyTW9ja2VkSHR0cFVSTExvYWQoInNjYWxlX29zY2ls
bGF0ZS5odG1sIik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL2Rh
dGEvdmlld3BvcnQtMngtaW5pdGlhbC1zY2FsZS5odG1sIGIvU291cmNlL1dlYktpdC9jaHJvbWl1
bS90ZXN0cy9kYXRhL3ZpZXdwb3J0LTJ4LWluaXRpYWwtc2NhbGUuaHRtbApuZXcgZmlsZSBtb2Rl
IDEwMDY0NAppbmRleCAwMDAwMDAwLi4xNjE1OWUwCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNl
L1dlYktpdC9jaHJvbWl1bS90ZXN0cy9kYXRhL3ZpZXdwb3J0LTJ4LWluaXRpYWwtc2NhbGUuaHRt
bApAQCAtMCwwICsxLDggQEAKKzxodG1sPgorICA8aGVhZD4KKyAgICA8bWV0YSBuYW1lPSd2aWV3
cG9ydCcgY29udGVudD0nd2lkdGg9MzAwMCwgaW5pdGlhbC1zY2FsZT0yJyAvPgorICA8L2hlYWQ+
CisgIDxib2R5PgorICAgIEEgcGFnZSB3aXRoIHRoZSB2aWV3cG9ydCBzZXQgdG8gMnggc2NhbGUu
CisgIDwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v
dGVzdHMvZGF0YS92aWV3cG9ydC1hdXRvLWluaXRpYWwtc2NhbGUuaHRtbCBiL1NvdXJjZS9XZWJL
aXQvY2hyb21pdW0vdGVzdHMvZGF0YS92aWV3cG9ydC1hdXRvLWluaXRpYWwtc2NhbGUuaHRtbApu
ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi43MDIwZTQ5Ci0tLSAvZGV2L251bGwK
KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9kYXRhL3ZpZXdwb3J0LWF1dG8taW5p
dGlhbC1zY2FsZS5odG1sCkBAIC0wLDAgKzEsOCBAQAorPGh0bWw+CisgIDxoZWFkPgorICAgIDxt
ZXRhIG5hbWU9J3ZpZXdwb3J0JyBjb250ZW50PSd3aWR0aD0zMDAwJyAvPgorICA8L2hlYWQ+Cisg
IDxib2R5PgorICAgIEEgcGFnZSB3aXRoIGEgdmlld3BvcnQuCisgIDwvYm9keT4KKzwvaHRtbD4K
</data>

          </attachment>
      

    </bug>

</bugzilla>