109526 2013-02-11 17:22:17 -0800 REGRESSION (r142520?): Space no longer scrolls the page 2013-02-11 17:37:26 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Regression P2 Normal --- 1 mrowe simon.fraser andersca cmarcelo jamesr simon.fraser thorton tonikitoo webkit.review.bot oldest_to_newest 830371 0 mrowe 2013-02-11 17:22:17 -0800 With TOT pressing the space key no longer seems to scroll the page. I narrowed it to the range r142514 - r142522. r142520 looks the most relevant. 830378 1 187734 simon.fraser 2013-02-11 17:28:14 -0800 Created attachment 187734 Patch 830388 2 simon.fraser 2013-02-11 17:37:26 -0800 http://trac.webkit.org/changeset/142561 187734 2013-02-11 17:28:14 -0800 2013-02-11 17:28:57 -0800 Patch bug-109526-20130211172445.patch text/plain 2106 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTY3MmU2OGQyNzc2YmI4 ZjgzNDc4ZjA2ZmQ0YjcyYmVlOGU0NzY4OC4uNDgwOGQzMmE0YTU2OTQxZmJhNWYxMjhiYTg2OTQ4 MGUwMjRiMWJkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEzLTAyLTExICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIFJFR1JFU1NJT04g KHIxNDI1MjA/KTogU3BhY2Ugbm8gbG9uZ2VyIHNjcm9sbHMgdGhlIHBhZ2UKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTUyNgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNjcm9sbGluZ1RyZWU6OnVwZGF0 ZVRyZWVGcm9tU3RhdGVOb2RlKCkgdXNlZCB0byBiYWlsIGVhcmx5IHdoZW4gaXQgaGFkCisgICAg ICAgIG5vIGNoaWxkcmVuIChubyBmaXhlZCBvciBzdGlja3kgZWxlbWVudHMpLCBidXQgdGhhdCBs ZWZ0IHVwZGF0ZUFmdGVyQ2hpbGRyZW4oKQorICAgICAgICB1bmNhbGxlZC4gRml4IGJ5IGFsd2F5 cyBjYWxsaW5nIHVwZGF0ZUFmdGVyQ2hpbGRyZW4oKSwgd2hpY2ggdXBkYXRlcyB0aGUgc2Nyb2xs CisgICAgICAgIHBvc2l0aW9uLgorCisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5n VHJlZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdUcmVlOjp1cGRhdGVUcmVlRnJv bVN0YXRlTm9kZSk6CisKKzIwMTMtMDItMTEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBh cHBsZS5jb20+CisKICAgICAgICAgUkVHUkVTU0lPTiAocjEzMzgwNyk6IFN0aWNreS1wb3NpdGlv biByZXZpZXcgYmFyIG9uIGJ1Z3ppbGxhIHJldmlldyBwYWdlIGlzIGp1bXB5CiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQyNzYKICAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzEyODI3MTg3PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9z Y3JvbGxpbmcvU2Nyb2xsaW5nVHJlZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGlu Zy9TY3JvbGxpbmdUcmVlLmNwcAppbmRleCAyMDYxOWRmYzdjZDExMzQwNjllMjkxNWYyNThlYzNm ODFkNTk0ZDc5Li5mNGM3NjkxNTE5MjUyNWVlMDUwOWM5NGMxNWUwMmYxMDgwOGQ0MWE2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVlLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVlLmNwcApAQCAt MTkzLDEzICsxOTMsMTEgQEAgdm9pZCBTY3JvbGxpbmdUcmVlOjp1cGRhdGVUcmVlRnJvbVN0YXRl Tm9kZShTY3JvbGxpbmdTdGF0ZU5vZGUqIHN0YXRlTm9kZSkKIAogICAgIC8vIE5vdyB1cGRhdGUg dGhlIGNoaWxkcmVuIGlmIHdlIGhhdmUgYW55LgogICAgIFZlY3RvcjxPd25QdHI8U2Nyb2xsaW5n U3RhdGVOb2RlPiA+KiBzdGF0ZU5vZGVDaGlsZHJlbiA9IHN0YXRlTm9kZS0+Y2hpbGRyZW4oKTsK LSAgICBpZiAoIXN0YXRlTm9kZUNoaWxkcmVuKQotICAgICAgICByZXR1cm47Ci0KLSAgICBzaXpl X3Qgc2l6ZSA9IHN0YXRlTm9kZUNoaWxkcmVuLT5zaXplKCk7Ci0gICAgZm9yIChzaXplX3QgaSA9 IDA7IGkgPCBzaXplOyArK2kpCi0gICAgICAgIHVwZGF0ZVRyZWVGcm9tU3RhdGVOb2RlKHN0YXRl Tm9kZUNoaWxkcmVuLT5hdChpKS5nZXQoKSk7Ci0gICAgCisgICAgaWYgKHN0YXRlTm9kZUNoaWxk cmVuKSB7CisgICAgICAgIHNpemVfdCBzaXplID0gc3RhdGVOb2RlQ2hpbGRyZW4tPnNpemUoKTsK KyAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBzaXplOyArK2kpCisgICAgICAgICAgICB1 cGRhdGVUcmVlRnJvbVN0YXRlTm9kZShzdGF0ZU5vZGVDaGlsZHJlbi0+YXQoaSkuZ2V0KCkpOwor ICAgIH0KICAgICBub2RlLT51cGRhdGVBZnRlckNoaWxkcmVuKHN0YXRlTm9kZSk7CiB9CiAK