109508 2013-02-11 15:59:13 -0800 WEBGL_compressed_texture_s3tc extension can be enabled even when not supported 2013-02-11 16:32:56 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr zmo bajones dino gman ojan.autocc webkit.review.bot zmo oldest_to_newest 830268 0 kbr 2013-02-11 15:59:13 -0800 It's been pointed out by Evan Parker from the MapsGL team that getExtension("WEBGL_compressed_texture_s3tc") is returning a non-null value even when the underlying hardware doesn't support the extension. A supports() check in getExtension is missing. 830298 1 187716 zmo 2013-02-11 16:28:13 -0800 Created attachment 187716 Patch 830302 2 187716 kbr 2013-02-11 16:31:24 -0800 Comment on attachment 187716 Patch Thanks for the quick fix. Looks good. Note for the record that this will eventually be covered by the WebGL conformance tests Gregg Tavares is in the process of importing. 830303 3 webkit.review.bot 2013-02-11 16:32:46 -0800 Attachment 187716 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp']" exit_code: 1 Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2409: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2410: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 830304 4 zmo 2013-02-11 16:32:56 -0800 Committed r142545: <http://trac.webkit.org/changeset/142545> 187716 2013-02-11 16:28:13 -0800 2013-02-11 16:31:24 -0800 Patch bug-109508-20130211162444.patch text/plain 1877 zmo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MjU0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAyLTExICBaaGVueWFv IE1vICA8em1vQGdvb2dsZS5jb20+CisKKyAgICAgICAgV0VCR0xfY29tcHJlc3NlZF90ZXh0dXJl X3MzdGMgZXh0ZW5zaW9uIGNhbiBiZSBlbmFibGVkIGV2ZW4gd2hlbiBub3Qgc3VwcG9ydGVkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk1MDgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvY2Fu dmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAg ICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dDo6Z2V0RXh0ZW5zaW9uKTogQ2hlY2sg d2hldGhlciB0aGUgZXh0ZW5zaW9uIHN1cHBvcnQgaXMgdGhlcmUgYmVmb3JlIHJldHVybmluZyB0 aGUgZXh0ZW5zaW9uIHBvaW50ZXIuCisKIDIwMTMtMDItMTEgIEVtaWwgQSBFa2x1bmQgIDxlYWVA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIENoYW5nZSBSZW5kZXJGcmFtZVNldDo6cGFpbnQgdG8g dXNlIG0tcm93cy9tX2NvbHMgZGlyZWN0bHkuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL2Nh bnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAJKHJldmlzaW9uIDE0MjUz OSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTI0MDUsOSArMjQwNSwxMCBAQCBXZWJHTEV4dGVuc2lvbiog V2ViR0xSZW5kZXJpbmdDb250ZXh0OjpnCiAgICAgICAgICAgICBtX3dlYmdsTG9zZUNvbnRleHQg PSBXZWJHTExvc2VDb250ZXh0OjpjcmVhdGUodGhpcyk7CiAgICAgICAgIHJldHVybiBtX3dlYmds TG9zZUNvbnRleHQuZ2V0KCk7CiAgICAgfQotICAgIGlmIChlcXVhbElnbm9yaW5nQ2FzZShuYW1l LCAiV0VCR0xfY29tcHJlc3NlZF90ZXh0dXJlX3MzdGMiKQotICAgICAgICAvLyBGSVhNRTogcmVt b3ZlIHRoaXMgYWZ0ZXIgYSBjZXJ0YWluIGdyYWNlIHBlcmlvZC4KLSAgICAgICAgfHwgZXF1YWxJ Z25vcmluZ0Nhc2UobmFtZSwgIldFQktJVF9XRUJHTF9jb21wcmVzc2VkX3RleHR1cmVfczN0YyIp KSB7CisgICAgaWYgKChlcXVhbElnbm9yaW5nQ2FzZShuYW1lLCAiV0VCR0xfY29tcHJlc3NlZF90 ZXh0dXJlX3MzdGMiKQorICAgICAgICAgLy8gRklYTUU6IHJlbW92ZSB0aGlzIGFmdGVyIGEgY2Vy dGFpbiBncmFjZSBwZXJpb2QuCisgICAgICAgICB8fCBlcXVhbElnbm9yaW5nQ2FzZShuYW1lLCAi V0VCS0lUX1dFQkdMX2NvbXByZXNzZWRfdGV4dHVyZV9zM3RjIikpCisgICAgICAgICYmIFdlYkdM Q29tcHJlc3NlZFRleHR1cmVTM1RDOjpzdXBwb3J0ZWQodGhpcykpIHsKICAgICAgICAgaWYgKCFt X3dlYmdsQ29tcHJlc3NlZFRleHR1cmVTM1RDKQogICAgICAgICAgICAgbV93ZWJnbENvbXByZXNz ZWRUZXh0dXJlUzNUQyA9IFdlYkdMQ29tcHJlc3NlZFRleHR1cmVTM1RDOjpjcmVhdGUodGhpcyk7 CiAgICAgICAgIHJldHVybiBtX3dlYmdsQ29tcHJlc3NlZFRleHR1cmVTM1RDLmdldCgpOwo=