109496 2013-02-11 14:53:35 -0800 PluginProcessConnectionManager should be a QueueClient 2013-02-12 09:49:23 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca jberlin thorton oldest_to_newest 830165 0 andersca 2013-02-11 14:53:35 -0800 PluginProcessConnectionManager should be a QueueClient 830167 1 187687 andersca 2013-02-11 14:54:24 -0800 Created attachment 187687 Patch 830168 2 187687 kling 2013-02-11 14:55:19 -0800 Comment on attachment 187687 Patch r=gooby 830279 3 andersca 2013-02-11 16:10:00 -0800 Committed r142540: <http://trac.webkit.org/changeset/142540> 830803 4 thorton 2013-02-12 05:17:50 -0800 Wut. This patch uses a function that as far as I can tell doesn't exist, broke all the builds, has been "build fix"'d multiple times, and ... the build is still broken? 830995 5 jberlin 2013-02-12 09:03:29 -0800 Build fix committed in http://trac.webkit.org/changeset/142632 831033 6 jberlin 2013-02-12 09:49:23 -0800 (In reply to comment #5) > Build fix committed in http://trac.webkit.org/changeset/142632 Note: the build fix was just to stub out the function. I am not sure that is the correct long term fix. 187687 2013-02-11 14:54:24 -0800 2013-02-11 14:55:18 -0800 Patch bug-109496-20130211145055.patch text/plain 6258 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmRhODUyYTY1YjJmZmU0 MjE4ZDM1M2M3MmEzYmJjNmM0ZDFmNzFlYS4uYjU3ZTc0Y2VmZGRmNzU3YzMzYzY3NGRjZGQzNGQ4 NDRkM2UyNmZjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEzLTAyLTExICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgUGx1Z2luUHJvY2Vz c0Nvbm5lY3Rpb25NYW5hZ2VyIHNob3VsZCBiZSBhIFF1ZXVlQ2xpZW50CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk0OTYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9Q bHVnaW5Qcm9jZXNzQ29ubmVjdGlvbk1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpQbHVn aW5Qcm9jZXNzQ29ubmVjdGlvbk1hbmFnZXI6OmRpZFJlY2VpdmVNZXNzYWdlT25Db25uZWN0aW9u V29ya1F1ZXVlKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblBy b2Nlc3NDb25uZWN0aW9uTWFuYWdlcjo6ZGlkQ2xvc2VPbkNvbm5lY3Rpb25Xb3JrUXVldWUpOgor ICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbk1hbmFn ZXIuaDoKKyAgICAgICAgKFBsdWdpblByb2Nlc3NDb25uZWN0aW9uTWFuYWdlcik6CisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vz czo6aW5pdGlhbGl6ZUNvbm5lY3Rpb24pOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUHJvY2Vz cy5oOgorICAgICAgICAoV2ViUHJvY2Vzcyk6CisKKzIwMTMtMDItMTEgIEFuZGVycyBDYXJsc3Nv biAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBNb3ZlIHRoZSBQbHVnaW5Qcm9jZXNz Q3Jhc2hlZCBtZXNzYWdlIHRvIFBsdWdpblByb2Nlc3NDb25uZWN0aW9uTWFuYWdlcgogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5NDkzCiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzQ29u bmVjdGlvbk1hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1Bs dWdpblByb2Nlc3NDb25uZWN0aW9uTWFuYWdlci5jcHAKaW5kZXggYjkwODgzMzVjM2JhMWQwNGFj NzZiZTYxOTE0YjdkYjY2NTM1ZTJhMi4uMDFmM2UwNmFmYzk2MmMyMTZhYjBjY2Q3ZWU5MGU0YmNk ZjZlYzJkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1Bs dWdpblByb2Nlc3NDb25uZWN0aW9uTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb2Nlc3NDb25uZWN0aW9uTWFuYWdlci5jcHAKQEAgLTMx LDYgKzMxLDcgQEAKICNpbmNsdWRlICJBcmd1bWVudERlY29kZXIuaCIKICNpbmNsdWRlICJBcmd1 bWVudEVuY29kZXIuaCIKICNpbmNsdWRlICJQbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbi5oIgorI2lu Y2x1ZGUgIlBsdWdpblByb2Nlc3NDb25uZWN0aW9uTWFuYWdlck1lc3NhZ2VzLmgiCiAjaW5jbHVk ZSAiV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmgiCiAjaW5jbHVkZSAiV2ViUHJvY2Vzcy5oIgogI2lu Y2x1ZGUgIldlYlByb2Nlc3NQcm94eU1lc3NhZ2VzLmgiCkBAIC0xMDEsNiArMTAyLDE4IEBAIHZv aWQgUGx1Z2luUHJvY2Vzc0Nvbm5lY3Rpb25NYW5hZ2VyOjpyZW1vdmVQbHVnaW5Qcm9jZXNzQ29u bmVjdGlvbihQbHVnaW5Qcm9jZXNzCiAgICAgbV9wbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbnMucmVt b3ZlKHZlY3RvckluZGV4KTsKIH0KIAordm9pZCBQbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbk1hbmFn ZXI6OmRpZFJlY2VpdmVNZXNzYWdlT25Db25uZWN0aW9uV29ya1F1ZXVlKENvcmVJUEM6OkNvbm5l Y3Rpb24qIGNvbm5lY3Rpb24sIE93blB0cjxDb3JlSVBDOjpNZXNzYWdlRGVjb2Rlcj4mIGRlY29k ZXIpCit7CisgICAgaWYgKGRlY29kZXItPm1lc3NhZ2VSZWNlaXZlck5hbWUoKSA9PSBNZXNzYWdl czo6UGx1Z2luUHJvY2Vzc0Nvbm5lY3Rpb25NYW5hZ2VyOjptZXNzYWdlUmVjZWl2ZXJOYW1lKCkp IHsKKyAgICAgICAgZGlkUmVjZWl2ZVBsdWdpblByb2Nlc3NDb25uZWN0aW9uTWFuYWdlck1lc3Nh Z2VPbkNvbm5lY3Rpb25Xb3JrUXVldWUoQ2hpbGRQcm9jZXNzOjpjb25uZWN0aW9uKCksIGRlY29k ZXIpOworICAgICAgICByZXR1cm47CisgICAgfQorfQorCit2b2lkIFBsdWdpblByb2Nlc3NDb25u ZWN0aW9uTWFuYWdlcjo6ZGlkQ2xvc2VPbkNvbm5lY3Rpb25Xb3JrUXVldWUoQ29yZUlQQzo6Q29u bmVjdGlvbiopCit7Cit9CisKIHZvaWQgUGx1Z2luUHJvY2Vzc0Nvbm5lY3Rpb25NYW5hZ2VyOjpw bHVnaW5Qcm9jZXNzQ3Jhc2hlZChDb3JlSVBDOjpDb25uZWN0aW9uKiwgY29uc3QgU3RyaW5nJiBw bHVnaW5QYXRoLCB1aW50MzJfdCBvcGFxdWVQbHVnaW5UeXBlKQogewogICAgIE11dGV4TG9ja2Vy IGxvY2tlcihtX3BhdGhzQW5kQ29ubmVjdGlvbnNNdXRleCk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJvY2Vzc0Nvbm5lY3Rpb25NYW5hZ2Vy LmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJvY2Vzc0Nvbm5l Y3Rpb25NYW5hZ2VyLmgKaW5kZXggZWQzZmRkY2E1OTYzZDU2NjExYmRjYTUxMTcwMDg2N2EzN2Q4 NGIwZS4uNzQ5ZWQ3MDI3ODYzZDE4MjQzZjY3MWMzYTA5ZDk5M2NlMmM3ZmZmZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb2Nlc3NDb25uZWN0 aW9uTWFuYWdlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVn aW5Qcm9jZXNzQ29ubmVjdGlvbk1hbmFnZXIuaApAQCAtNDYsNyArNDYsNyBAQCBuYW1lc3BhY2Ug V2ViS2l0IHsKIAogY2xhc3MgUGx1Z2luUHJvY2Vzc0Nvbm5lY3Rpb247CiAgICAgICAgIAotY2xh c3MgUGx1Z2luUHJvY2Vzc0Nvbm5lY3Rpb25NYW5hZ2VyIHsKK2NsYXNzIFBsdWdpblByb2Nlc3ND b25uZWN0aW9uTWFuYWdlciA6IHB1YmxpYyBDb3JlSVBDOjpDb25uZWN0aW9uOjpRdWV1ZUNsaWVu dCB7CiAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoUGx1Z2luUHJvY2Vzc0Nvbm5lY3Rpb25NYW5h Z2VyKTsKIHB1YmxpYzoKICAgICBQbHVnaW5Qcm9jZXNzQ29ubmVjdGlvbk1hbmFnZXIoKTsKQEAg LTU4LDYgKzU4LDEwIEBAIHB1YmxpYzoKICAgICB2b2lkIGRpZFJlY2VpdmVQbHVnaW5Qcm9jZXNz Q29ubmVjdGlvbk1hbmFnZXJNZXNzYWdlT25Db25uZWN0aW9uV29ya1F1ZXVlKENvcmVJUEM6OkNv bm5lY3Rpb24qLCBPd25QdHI8Q29yZUlQQzo6TWVzc2FnZURlY29kZXI+Jik7CiAKIHByaXZhdGU6 CisgICAgLy8gQ29yZUlQQzo6Q29ubmVjdGlvbjo6UXVldWVDbGllbnQKKyAgICB2aXJ0dWFsIHZv aWQgZGlkUmVjZWl2ZU1lc3NhZ2VPbkNvbm5lY3Rpb25Xb3JrUXVldWUoQ29yZUlQQzo6Q29ubmVj dGlvbiosIE93blB0cjxDb3JlSVBDOjpNZXNzYWdlRGVjb2Rlcj4mKSBPVkVSUklERTsKKyAgICB2 aXJ0dWFsIHZvaWQgZGlkQ2xvc2VPbkNvbm5lY3Rpb25Xb3JrUXVldWUoQ29yZUlQQzo6Q29ubmVj dGlvbiopIE9WRVJSSURFOworCiAgICAgLy8gQ2FsbGVkIG9uIHRoZSB3ZWIgcHJvY2VzcyBjb25u ZWN0aW9uIHdvcmsgcXVldWUuCiAgICAgdm9pZCBwbHVnaW5Qcm9jZXNzQ3Jhc2hlZChDb3JlSVBD OjpDb25uZWN0aW9uKiwgY29uc3QgU3RyaW5nJiBwbHVnaW5QYXRoLCB1aW50MzJfdCBvcGFxdWVQ bHVnaW5UeXBlKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ cm9jZXNzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAKaW5k ZXggMjZkZmNhNGJlYTBjNzI1MDliNjY1ZjY2NjVkMjYwYzE5NjliYjI0Yy4uODgxNzNmMDQyNDc1 MGQ0ZTA1YTg2OGViYjNiOWFjZmQyYWI1MDlkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlByb2Nlc3MuY3BwCkBAIC0zMCw3ICszMCw2IEBACiAjaW5jbHVkZSAiSW5qZWN0ZWRCdW5k bGUuaCIKICNpbmNsdWRlICJJbmplY3RlZEJ1bmRsZVVzZXJNZXNzYWdlQ29kZXJzLmgiCiAjaW5j bHVkZSAiTG9nZ2luZy5oIgotI2luY2x1ZGUgIlBsdWdpblByb2Nlc3NDb25uZWN0aW9uTWFuYWdl ck1lc3NhZ2VzLmgiCiAjaW5jbHVkZSAiU3RhdGlzdGljc0RhdGEuaCIKICNpbmNsdWRlICJXZWJB cHBsaWNhdGlvbkNhY2hlTWFuYWdlci5oIgogI2luY2x1ZGUgIldlYkNvbm5lY3Rpb25Ub1VJUHJv Y2Vzcy5oIgpAQCAtMjA3LDcgKzIwNiwxMCBAQCB2b2lkIFdlYlByb2Nlc3M6OmluaXRpYWxpemVD b25uZWN0aW9uKENvcmVJUEM6OkNvbm5lY3Rpb24qIGNvbm5lY3Rpb24pCiAKICAgICBjb25uZWN0 aW9uLT5zZXRTaG91bGRFeGl0T25TeW5jTWVzc2FnZVNlbmRGYWlsdXJlKHRydWUpOwogICAgIGNv bm5lY3Rpb24tPmFkZFF1ZXVlQ2xpZW50KCZtX2V2ZW50RGlzcGF0Y2hlcik7Ci0gICAgY29ubmVj dGlvbi0+YWRkUXVldWVDbGllbnQodGhpcyk7CisKKyNpZiBFTkFCTEUoUExVR0lOX1BST0NFU1Mp CisgICAgY29ubmVjdGlvbi0+YWRkUXVldWVDbGllbnQoJm1fcGx1Z2luUHJvY2Vzc0Nvbm5lY3Rp b25NYW5hZ2VyKTsKKyNlbmRpZgogCiAjaWYgVVNFKFNFQ1VSSVRZX0ZSQU1FV09SSykKICAgICBj b25uZWN0aW9uLT5hZGRRdWV1ZUNsaWVudCgmU2VjSXRlbVNoaW06OnNoYXJlZCgpKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5oIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmgKaW5kZXggOWE4ZDNjMzFlYjIwOTMxMDIwN2I4 ZDVhZmEyMTg1OGU1MWQxNWE2Mi4uMzQ5NmU1NDNjZGUwYWIzMzlkNmNkYmQxZjdhOGIwMzM2NjIy Yzk1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmgK KysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmgKQEAgLTkzLDcgKzkz LDcgQEAgY2xhc3MgTmV0d29ya1Byb2Nlc3NDb25uZWN0aW9uOwogY2xhc3MgV2ViUmVzb3VyY2VM b2FkU2NoZWR1bGVyOwogI2VuZGlmCiAKLWNsYXNzIFdlYlByb2Nlc3MgOiBwdWJsaWMgQ2hpbGRQ cm9jZXNzLCBwcml2YXRlIENvcmVJUEM6OkNvbm5lY3Rpb246OlF1ZXVlQ2xpZW50LCBwcml2YXRl IERvd25sb2FkTWFuYWdlcjo6Q2xpZW50IHsKK2NsYXNzIFdlYlByb2Nlc3MgOiBwdWJsaWMgQ2hp bGRQcm9jZXNzLCBwcml2YXRlIERvd25sb2FkTWFuYWdlcjo6Q2xpZW50IHsKIHB1YmxpYzoKICAg ICBzdGF0aWMgV2ViUHJvY2VzcyYgc2hhcmVkKCk7CiAKQEAgLTI2NCwxMCArMjY0LDYgQEAgcHJp dmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgZGlkQ2xvc2UoQ29yZUlQQzo6Q29ubmVjdGlvbiopOwog ICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlSW52YWxpZE1lc3NhZ2UoQ29yZUlQQzo6Q29ubmVj dGlvbiosIENvcmVJUEM6OlN0cmluZ1JlZmVyZW5jZSBtZXNzYWdlUmVjZWl2ZXJOYW1lLCBDb3Jl SVBDOjpTdHJpbmdSZWZlcmVuY2UgbWVzc2FnZU5hbWUpIE9WRVJSSURFOwogCi0gICAgLy8gQ29y ZUlQQzo6Q29ubmVjdGlvbjo6UXVldWVDbGllbnQKLSAgICB2aXJ0dWFsIHZvaWQgZGlkUmVjZWl2 ZU1lc3NhZ2VPbkNvbm5lY3Rpb25Xb3JrUXVldWUoQ29yZUlQQzo6Q29ubmVjdGlvbiosIE93blB0 cjxDb3JlSVBDOjpNZXNzYWdlRGVjb2Rlcj4mKSBPVkVSUklERTsKLSAgICB2aXJ0dWFsIHZvaWQg ZGlkQ2xvc2VPbkNvbm5lY3Rpb25Xb3JrUXVldWUoQ29yZUlQQzo6Q29ubmVjdGlvbiopIE9WRVJS SURFOwotCiAgICAgLy8gSW1wbGVtZW50ZWQgaW4gZ2VuZXJhdGVkIFdlYlByb2Nlc3NNZXNzYWdl UmVjZWl2ZXIuY3BwCiAgICAgdm9pZCBkaWRSZWNlaXZlV2ViUHJvY2Vzc01lc3NhZ2UoQ29yZUlQ Qzo6Q29ubmVjdGlvbiosIENvcmVJUEM6Ok1lc3NhZ2VEZWNvZGVyJik7CiAK