109475 2013-02-11 13:11:53 -0800 [GTK] Enable CSS image-set support in development builds 2013-02-12 07:53:40 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 109587 1 zan zan cdumez dbates mrobinson webkit.review.bot oldest_to_newest 830022 0 zan 2013-02-11 13:11:53 -0800 [GTK] Enable CSS image-set support in development builds 830030 1 187648 zan 2013-02-11 13:15:45 -0800 Created attachment 187648 Patch 830810 2 187648 zan 2013-02-12 05:27:26 -0800 Comment on attachment 187648 Patch Clearing flags on attachment: 187648 Committed r142606: <http://trac.webkit.org/changeset/142606> 830811 3 zan 2013-02-12 05:27:30 -0800 All reviewed patches have been landed. Closing bug. 830887 4 cdumez 2013-02-12 06:41:47 -0800 It seems this patch somehow disabled CSS_IMAGE_SET for EFL port? It brought a few failures on our bots: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r142607%20(9378)/results.html 830894 5 187648 cdumez 2013-02-12 06:43:28 -0800 Comment on attachment 187648 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187648&action=review > Tools/Scripts/webkitperl/FeatureList.pm:211 > + define => "ENABLE_CSS_IMAGE_SET", default => isGtk(), value => \$cssImageSetSupport }, So It seems we need a " || isEfl()" here? Some other ports probably have CSS_IMAGE_SET enabled as well (mac, chormium for e.g.). 830906 6 zan 2013-02-12 06:58:09 -0800 (In reply to comment #5) > (From update of attachment 187648 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=187648&action=review > > > Tools/Scripts/webkitperl/FeatureList.pm:211 > > + define => "ENABLE_CSS_IMAGE_SET", default => isGtk(), value => \$cssImageSetSupport }, > > So It seems we need a " || isEfl()" here? Some other ports probably have CSS_IMAGE_SET enabled as well (mac, chormium for e.g.). Did that in r142617. http://trac.webkit.org/changeset/142617 As for other ports, the Chromium port manages feature enabling in Source/WebKit/chromium/features.gypi independently from FeatureList.pm while the Mac port enables this feature by defining the macro in Platform.h, probably because it's also defined for the iOS platform. I'm not really comfortable changing that but it still seems to work (i.e. the feature is enabled at compile-time) despite the not enabling the feature in FeatureList.pm. 830908 7 cdumez 2013-02-12 06:59:07 -0800 (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 187648 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=187648&action=review > > > > > Tools/Scripts/webkitperl/FeatureList.pm:211 > > > + define => "ENABLE_CSS_IMAGE_SET", default => isGtk(), value => \$cssImageSetSupport }, > > > > So It seems we need a " || isEfl()" here? Some other ports probably have CSS_IMAGE_SET enabled as well (mac, chormium for e.g.). > > Did that in r142617. > http://trac.webkit.org/changeset/142617 > > As for other ports, the Chromium port manages feature enabling in Source/WebKit/chromium/features.gypi independently from FeatureList.pm while the Mac port enables this feature by defining the macro in Platform.h, probably because it's also defined for the iOS platform. I'm not really comfortable changing that but it still seems to work (i.e. the feature is enabled at compile-time) despite the not enabling the feature in FeatureList.pm. Sounds good to me. Thank you for the quick fix. 187648 2013-02-11 13:15:45 -0800 2013-02-12 06:43:28 -0800 Patch bug-109475-20130211221216.patch text/plain 6382 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNDk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDg5ZDQ5YzkzOGE2OTBk ZGQ4NmNhZGJkZmE1OTZmMGY3YjdkZmJmYS4uMTJlYTA4OWU1MjFjMDI2NWFjZTMxNjRmNzViZjk3 OTBkODNiNTU5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTExICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBFbmFibGUg Q1NTIGltYWdlLXNldCBzdXBwb3J0IGluIGRldmVsb3BtZW50IGJ1aWxkcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5NDc1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIC0gbWFqb3Jp dHkgb2YgdGhlIHJlbGF0ZWQgdGVzdHMgbm93IHBhc3Nlcy4KKworICAgICAgICAqIEdOVW1ha2Vm aWxlLmZlYXR1cmVzLmFtLmluOiBBZGQgdGhlIGZlYXR1cmUgZGVmaW5lIGZvciB0aGUgQ1NTIGlt YWdlLXNldCBmZWF0dXJlCisgICAgICAgIHdpdGggdGhlIGRlZmluZSB2YWx1ZSBkZWZhdWx0aW5n IHRvIDAuIFRoZSB2YWx1ZSBnZXRzIG92ZXJyaWRkZW4gd2l0aCAxIGluIGRldmVsb3BtZW50Cisg ICAgICAgIGJ1aWxkcywgbWVhbmluZyB0aGUgZmVhdHVyZSBpcyBlbmFibGVkIHVuZGVyIHRoYXQg Y29uZmlndXJhdGlvbi4KKwogMjAxMy0wMi0xMSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5v cmc+CiAKICAgICAgICAgTWFrZSBXZWJWVFRUb2tlbml6ZXIgc3RvcCBpbmhlcml0aW5nIGZyb20g TWFya3VwVG9rZW5pemVyQmFzZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvR05VbWFrZWZp bGUuZmVhdHVyZXMuYW0uaW4gYi9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5mZWF0dXJlcy5h bS5pbgppbmRleCA2ZDJkNTc3OTM1MDExOWU0NmRhNWM3YmZkZGJhNDZmYTA5MDJhMGU4Li5kMTcy MGJkNjQ5ZjM1MWIxY2UxYTk5YjQ2YzFiYzVlNzc3Y2I2MzA2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9HTlVtYWtlZmlsZS5mZWF0dXJlcy5hbS5pbgorKysgYi9Tb3VyY2UvV2ViQ29yZS9H TlVtYWtlZmlsZS5mZWF0dXJlcy5hbS5pbgpAQCAtMTUsNiArMTUsNyBAQCBmZWF0dXJlX2RlZmlu ZXNfZGVmYXVsdHMgKz0gXAogCUVOQUJMRV9DU1NfRklMVEVSUz0wIFwKIAlFTkFCTEVfQ1NTX0lN QUdFX09SSUVOVEFUSU9OPTAgXAogCUVOQUJMRV9DU1NfSU1BR0VfUkVTT0xVVElPTj0wIFwKKwlF TkFCTEVfQ1NTX0lNQUdFX1NFVD0wIFwKIAlFTkFCTEVfQ1NTX1JFR0lPTlM9MCBcCiAJRU5BQkxF X0NTU19TSEFERVJTPTAgXAogCUVOQUJMRV9DU1NfU1RJQ0tZX1BPU0lUSU9OPTAgXApkaWZmIC0t Z2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDIzNzMxNjg1MTZh OTgzYjU3NjQ4N2RhMzk3ZDA3ZWI4MGZhMDIzMGYuLjgxNTg5ZjAyYmUzZGRkMWIzY2RmYmQ1YjZk MDAyODNkNDg1NWZhMzQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMy0wMi0xMSAgWmFuIERvYmVyc2VrICA8emRv YmVyc2VrQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRW5hYmxlIENTUyBpbWFnZS1zZXQg c3VwcG9ydCBpbiBkZXZlbG9wbWVudCBidWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTQ3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBt OiBBZGQgdGhlIGNvbmZpZ3VyYXRpb24gb3B0aW9uIGZvciB0aGUgZmVhdHVyZS4KKyAgICAgICAg Tm90ZSB0aGF0IHRoZSBNYWMgcG9ydCBhbHNvIGVuYWJsZXMgdGhlIGZlYXR1cmUgYnV0IGRvZXMg c28gaW4gUGxhdGZvcm0uaCBhcyB0aGUgZmVhdHVyZQorICAgICAgICBpcyBhbHNvIGVuYWJsZWQg Zm9yIHRoZSBpT1MgcG9ydCB3aGljaCBjYW4ndCBhdCB0aGUgbW9tZW50IGJlIGRldGVjdGVkIHZp YSB3ZWJraXRwZXJsLgorCiAyMDEzLTAyLTExICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBs ZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gV2luZG93cyA3IERlYnVnIG1vZGUgYnVpbGQg Zml4LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBt IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtCmluZGV4IDU4MWJjMDdj ODdjYWU2ZmRkYmE1MTdlYzhlMjljMjVmYThmNTZmYTQuLjE1NDhiY2RmYzVmODI1ZTYxOGIzYWJm ZjViMzMzMGNjOGVmOWVhODYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9G ZWF0dXJlTGlzdC5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3Qu cG0KQEAgLTYwLDYgKzYwLDcgQEAgbXkgKAogICAgICRjc3NIaWVyYXJjaGllc1N1cHBvcnQsCiAg ICAgJGNzc0ltYWdlT3JpZW50YXRpb25TdXBwb3J0LAogICAgICRjc3NJbWFnZVJlc29sdXRpb25T dXBwb3J0LAorICAgICRjc3NJbWFnZVNldFN1cHBvcnQsCiAgICAgJGNzc1JlZ2lvbnNTdXBwb3J0 LAogICAgICRjc3NTaGFkZXJzU3VwcG9ydCwKICAgICAkY3NzU3RpY2t5UG9zaXRpb25TdXBwb3J0 LApAQCAtMjA2LDYgKzIwNyw5IEBAIG15IEBmZWF0dXJlcyA9ICgKICAgICB7IG9wdGlvbiA9PiAi Y3NzLWltYWdlLXJlc29sdXRpb24iLCBkZXNjID0+ICJUb2dnbGUgQ1NTIGltYWdlLXJlc29sdXRp b24gc3VwcG9ydCIsCiAgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9DU1NfSU1BR0VfUkVTT0xVVElP TiIsIGRlZmF1bHQgPT4gKGlzQmxhY2tCZXJyeSgpIHx8IGlzR3RrKCkpLCB2YWx1ZSA9PiBcJGNz c0ltYWdlUmVzb2x1dGlvblN1cHBvcnQgfSwKIAorICAgIHsgb3B0aW9uID0+ICJjc3MtaW1hZ2Ut c2V0IiwgZGVzYyA9PiAiVG9nZ2xlIENTUyBpbWFnZS1zZXQgc3VwcG9ydCIsCisgICAgICBkZWZp bmUgPT4gIkVOQUJMRV9DU1NfSU1BR0VfU0VUIiwgZGVmYXVsdCA9PiBpc0d0aygpLCB2YWx1ZSA9 PiBcJGNzc0ltYWdlU2V0U3VwcG9ydCB9LAorCiAgICAgeyBvcHRpb24gPT4gImNzcy1yZWdpb25z IiwgZGVzYyA9PiAiVG9nZ2xlIENTUyBSZWdpb25zIHN1cHBvcnQiLAogICAgICAgZGVmaW5lID0+ ICJFTkFCTEVfQ1NTX1JFR0lPTlMiLCBkZWZhdWx0ID0+IDEsIHZhbHVlID0+IFwkY3NzUmVnaW9u c1N1cHBvcnQgfSwKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGJhNjBmNjYyNGI1YmE1NTBiYzE5MWUzYzQ4YmIxNWM1NWVj MjUxNTEuLmJhMDNhMGIwNGFmMDVjY2I3OGMxYjZhMzBlM2RiMDlkN2JiMTUyOWUgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMy0wMi0xMSAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxp YS5jb20+CisKKyAgICAgICAgW0dUS10gRW5hYmxlIENTUyBpbWFnZS1zZXQgc3VwcG9ydCBpbiBk ZXZlbG9wbWVudCBidWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwOTQ3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6IFJlY2xhc3NpZnkgdHdv IGZhaWx1cmVzIHRoYXQgbm93IGZhaWwgZHVlIHRvCisgICAgICAgIGN1cnNvciBpbWFnZXMgbm90 IGxvYWRpbmcgd2hpbGUgdGhlIG90aGVyIGV4cGVjdGF0aW9ucyBhcmUgcmVtb3ZlZCBhcyB0aGUg dGVzdHMKKyAgICAgICAgbm93IHBhc3MuCisgICAgICAgICogcGxhdGZvcm0vZ3RrL2Zhc3QvY3Nz L2ltYWdlLXNldC12YWx1ZS1ub3QtcmVtb3ZlZC1jcmFzaC1leHBlY3RlZC50eHQ6IFJlbW92ZWQu IFRoZSBnZW5lcmljCisgICAgICAgIGV4cGVjdGF0aW9uIG5vdyBtYXRjaGVzIHRoZSB0ZXN0IG91 dHB1dC4KKwogMjAxMy0wMi0xMSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAg ICAgICAgIGRvY3VtZW50LndyaXRlIGR1cmluZyB3aW5kb3cub25sb2FkIGNhbiB0cmlnZ2VyIER1 bXBSZW5kZXJUcmVlIHRvIGR1bXAgdGhlIHJlbmRlciB0cmVlCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDgwMTE2NjYwYjk5NzU0MzJjM2VmOGRjY2I2MTEx Y2EwMTE1ZTk0NzYuLjM4Y2UzNmU2MzRlMTg5ZDVmNmM1NWI0NTFhNGE2OWQzMDhlMGM3MmEgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCisrKyBi L0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCkBAIC0zMTYsMTQgKzMx Niw2IEBAIHdlYmtpdC5vcmcvYi85OTAyNSBmYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9hbmNo b3ItZG93bmxvYWQtdW5zZXQuaHRtbCBbIFBhc3MKICMgQ1NTIEZpbHRlcnMgaXMgZGlzYWJsZWQK IHdlYmtpdC5vcmcvYi85OTAyNiBjc3MzL2ZpbHRlcnMgWyBTa2lwIF0KIAotIyBDU1MgaW1hZ2Ut c2V0IHN1cHBvcnQgbm90IHlldCBlbmFibGVkIChuZWVkcyBFTkFCTEVfQ1NTX0lNQUdFX1NFVCku Ci13ZWJraXQub3JnL2IvOTkwMjcgZmFzdC9jc3MvaW1hZ2Utc2V0LXBhcnNpbmcuaHRtbCBbIEZh aWx1cmUgXQotd2Via2l0Lm9yZy9iLzk5MDI3IGZhc3QvY3NzL2ltYWdlLXNldC1wYXJzaW5nLWlu dmFsaWQuaHRtbCBbIFBhc3MgXQotd2Via2l0Lm9yZy9iLzk5MDI3IGZhc3QvY3NzL2ltYWdlLXNl dC1zZXR0aW5nLmh0bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi85OTAyNyBmYXN0L2Nzcy9j dXJzb3ItcGFyc2luZy1pbWFnZS1zZXQuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzk5 MDI3IGZhc3QvZXZlbnRzL21vdXNlLWN1cnNvci1pbWFnZS1zZXQuaHRtbCBbIFRpbWVvdXQgXQot d2Via2l0Lm9yZy9iLzk5MDI3IGNzc29tL2Nzc3ZhbHVlLWNvbXBhcmlzb24uaHRtbCBbIEZhaWx1 cmUgXQotCiAjIEZvciBub3csIFdlYiBBdWRpbyBBUEkgaXMgZGlzYWJsZWQKIHdlYmtpdC5vcmcv Yi82NzE4NyB3ZWJhdWRpbyBbIFNraXAgXQogd2Via2l0Lm9yZy9iLzY3MTg3IHdlYmtpdC5vcmcv Yi8xMDIyNTggaW5zcGVjdG9yLXByb3RvY29sL25taS13ZWJhdWRpby5odG1sIFsgU2tpcCBdCkBA IC0xNDgyLDYgKzE0NzQsOSBAQCB3ZWJraXQub3JnL2IvMTA5MjI0IGZhc3QvZm9ybXMvbnVtYmVy L251bWJlci1sMTBuLWlucHV0Lmh0bWwgWyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzEwOTM1 MyBmYXN0L2ZsZXhib3gvbGluZS1jbGFtcC1saW5rLWFmdGVyLWVsbGlwc2lzLmh0bWwgWyBGYWls dXJlIF0KIAord2Via2l0Lm9yZy9iLzEwOTQ2OSBmYXN0L2Nzcy9jdXJzb3ItcGFyc2luZy1pbWFn ZS1zZXQuaHRtbCBbIEZhaWx1cmUgXQord2Via2l0Lm9yZy9iLzEwOTQ2OSBmYXN0L2V2ZW50cy9t b3VzZS1jdXJzb3ItaW1hZ2Utc2V0Lmh0bWwgWyBUaW1lb3V0IF0KKwogIy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8KICMgRW5kIG9mIFRlc3RzIGZhaWxpbmcKICMvLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsv ZmFzdC9jc3MvaW1hZ2Utc2V0LXZhbHVlLW5vdC1yZW1vdmVkLWNyYXNoLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9mYXN0L2Nzcy9pbWFnZS1zZXQtdmFsdWUtbm90LXJl bW92ZWQtY3Jhc2gtZXhwZWN0ZWQudHh0CmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCA0 YThiZjNjNDcwODhkNDcxMGQ5N2JkODA2NzZhMmQ0ODI3ODM2ODFiLi4wMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9m YXN0L2Nzcy9pbWFnZS1zZXQtdmFsdWUtbm90LXJlbW92ZWQtY3Jhc2gtZXhwZWN0ZWQudHh0Cisr KyAvZGV2L251bGwKQEAgLTEgKzAsMCBAQAotUEFTUy4gV2ViS2l0IGRpZCBub3QgY3Jhc2guCg==