109459 2013-02-11 10:08:27 -0800 [iOS] Upstream changes to Platform.h 2013-02-11 15:56:46 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer benjamin cmarcelo joepeck laszlo.gombos ojan.autocc sam webkit.review.bot oldest_to_newest 829827 0 ddkilzer 2013-02-11 10:08:27 -0800 Upstream iOS changes to Platform.h. 829837 1 187610 ddkilzer 2013-02-11 10:15:37 -0800 Created attachment 187610 Patch v1 829858 2 187610 laszlo.gombos 2013-02-11 10:33:57 -0800 Comment on attachment 187610 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=187610&action=review > Source/WTF/wtf/Platform.h:-621 > -#if PLATFORM(IOS_SIMULATOR) > - #define ENABLE_JIT 0 > - #define ENABLE_YARR_JIT 0 Is the intention to turn on JIT for the simulator as well ? If it is, the patch looks good to me. 829875 3 ddkilzer 2013-02-11 10:49:06 -0800 (In reply to comment #2) > (From update of attachment 187610 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=187610&action=review > > > Source/WTF/wtf/Platform.h:-621 > > -#if PLATFORM(IOS_SIMULATOR) > > - #define ENABLE_JIT 0 > > - #define ENABLE_YARR_JIT 0 > > Is the intention to turn on JIT for the simulator as well ? If it is, the patch looks good to me. Yes. 830035 4 187610 benjamin 2013-02-11 13:19:15 -0800 Comment on attachment 187610 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=187610&action=review > Source/WTF/wtf/Platform.h:624 > Remove the blank line. > Source/WTF/wtf/Platform.h:627 > +#define ENABLE_JIT 1 > +#define ENABLE_LLINT 1 > +#define ENABLE_YARR_JIT 1 Move those 3 ENABLE with the ones above? > Source/WTF/wtf/Platform.h:1131 > +#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 60000 || PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080 I'd just add parenthesis here for readability. 830238 5 ddkilzer 2013-02-11 15:38:37 -0800 (In reply to comment #4) > (From update of attachment 187610 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=187610&action=review > > > Source/WTF/wtf/Platform.h:624 > > > > Remove the blank line. Okay. > > Source/WTF/wtf/Platform.h:627 > > +#define ENABLE_JIT 1 > > +#define ENABLE_LLINT 1 > > +#define ENABLE_YARR_JIT 1 > > Move those 3 ENABLE with the ones above? Actually, all of these are defined below, so they should probably just be removed for "clarity". (I don't find the definitions below very easy to follow, but better to match other platforms.) > > Source/WTF/wtf/Platform.h:1131 > > +#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 60000 || PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080 > > I'd just add parenthesis here for readability. Will do. Thanks! 830264 6 ddkilzer 2013-02-11 15:56:46 -0800 Committed r142537: <http://trac.webkit.org/changeset/142537> 187610 2013-02-11 10:15:37 -0800 2013-02-11 13:19:14 -0800 Patch v1 bug-109459-20130211101208.patch text/plain 3335 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDdkNzU4Y2RmMGI2MWVhOGM4NTFkN2Ni OWRlYmUxODA4ZWYzZTU0YjkuLmNlMDA1OGIxNTkyMjdiOTFmOGIzZWY4ZDZjYzJkYzg5MDQyZGQy YWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTMtMDItMTEgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBVcHN0cmVhbSBjaGFuZ2VzIHRvIFBsYXRm b3JtLmgKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTA5NDU5PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6Cisg ICAgICAgIC0gQ2hhbmdlcyBmb3IgYXJtdjdzLgorICAgICAgICAtIEFkZCBFTkFCTEUoKSBkZWZp bml0aW9ucyBmb3IgREFTSEJPQVJEX1NVUFBPUlQgYW5kIFdFQkdMLgorICAgICAgICAtIFJlLXNv cnQgVVNFKCkgbWFjcm9zLgorICAgICAgICAtIFNpbXBsaWZ5IEVOQUJMRSgpIG1hY3JvcyBmb3Ig SklULCBMTElOVCBhbmQgWUFSUl9KSVQuCisgICAgICAgIC0gVHVybiBvZmYgSEFWRShIT1NURURf Q09SRV9BTklNQVRJT04pIGZvciBpT1MuCisgICAgICAgIC0gVHVybiBvbiBVU0UoQ09SRU1FRElB KSBmb3IgaU9TIDYuMCBhbmQgbGF0ZXIuCisKIDIwMTMtMDItMTEgIENocmlzdG9waGUgRHVtZXog IDxjaC5kdW1lekBzaXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIFN0b3AgdXNpbmcg c21hcnQgcG9pbnRlcnMgZm9yIEVjb3JlX1RpbWVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0 Zi9QbGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRleCA0NGYxZDAwNzEy ZmFhNjdjYzA1OGZlODYyZmY4YzhkYWIwZDkzOWZkLi5iYzhjODYwMDQ3OGIyZGQyMTgxYTU1ZmVl NGM0MzVmZTEwNzllNWEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisr KyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTIxNiw3ICsyMTYsOCBAQAogI2RlZmlu ZSBXVEZfQVJNX0FSQ0hfVkVSU0lPTiA2CiAKICNlbGlmIGRlZmluZWQoX19BUk1fQVJDSF83QV9f KSBcCi0gICAgfHwgZGVmaW5lZChfX0FSTV9BUkNIXzdSX18pCisgICAgfHwgZGVmaW5lZChfX0FS TV9BUkNIXzdSX18pIFwKKyAgICB8fCBkZWZpbmVkKF9fQVJNX0FSQ0hfN1NfXykKICNkZWZpbmUg V1RGX0FSTV9BUkNIX1ZFUlNJT04gNwogCiAvKiBSVkNUIHNldHMgX1RBUkdFVF9BUkNIX0FSTSAq LwpAQCAtMjU0LDggKzI1NSw5IEBACiAjZWxpZiBkZWZpbmVkKF9fQVJNX0FSQ0hfNlQyX18pIFwK ICAgICB8fCBkZWZpbmVkKF9fQVJNX0FSQ0hfN19fKSBcCiAgICAgfHwgZGVmaW5lZChfX0FSTV9B UkNIXzdBX18pIFwKKyAgICB8fCBkZWZpbmVkKF9fQVJNX0FSQ0hfN01fXykgXAogICAgIHx8IGRl ZmluZWQoX19BUk1fQVJDSF83Ul9fKSBcCi0gICAgfHwgZGVmaW5lZChfX0FSTV9BUkNIXzdNX18p CisgICAgfHwgZGVmaW5lZChfX0FSTV9BUkNIXzdTX18pCiAjZGVmaW5lIFdURl9USFVNQl9BUkNI X1ZFUlNJT04gNAogCiAvKiBSVkNUIHNldHMgX19UQVJHRVRfQVJDSF9USFVNQiAqLwpAQCAtNjAy LDYgKzYwNCw3IEBACiAKICNpZiBQTEFURk9STShJT1MpCiAjZGVmaW5lIEVOQUJMRV9DT05URVhU X01FTlVTIDAKKyNkZWZpbmUgRU5BQkxFX0RBU0hCT0FSRF9TVVBQT1JUIDAKICNkZWZpbmUgRU5B QkxFX0RSQUdfU1VQUE9SVCAwCiAjZGVmaW5lIEVOQUJMRV9HRU9MT0NBVElPTiAxCiAjZGVmaW5l IEVOQUJMRV9JQ09OREFUQUJBU0UgMApAQCAtNjEwLDI0ICs2MTMsMTkgQEAKICNkZWZpbmUgRU5B QkxFX09SSUVOVEFUSU9OX0VWRU5UUyAxCiAjZGVmaW5lIEVOQUJMRV9SRVBBSU5UX1RIUk9UVExJ TkcgMQogI2RlZmluZSBFTkFCTEVfV0VCX0FSQ0hJVkUgMQorI2RlZmluZSBFTkFCTEVfV0VCR0wg MQogI2RlZmluZSBIQVZFX1JFQURMSU5FIDEKKyNkZWZpbmUgV1RGX1VTRV9BUFBLSVQgMAogI2Rl ZmluZSBXVEZfVVNFX0NGIDEKICNkZWZpbmUgV1RGX1VTRV9DRk5FVFdPUksgMQogI2RlZmluZSBX VEZfVVNFX05FVFdPUktfQ0ZEQVRBX0FSUkFZX0NBTExCQUNLIDEKKyNkZWZpbmUgV1RGX1VTRV9T RUNVUklUWV9GUkFNRVdPUksgMAogI2RlZmluZSBXVEZfVVNFX1dFQl9USFJFQUQgMQogCi0jaWYg UExBVEZPUk0oSU9TX1NJTVVMQVRPUikKLSAgICAjZGVmaW5lIEVOQUJMRV9KSVQgMAotICAgICNk ZWZpbmUgRU5BQkxFX1lBUlJfSklUIDAKLSNlbHNlCi0gICAgI2RlZmluZSBFTkFCTEVfSklUIDEK LSAgICAjZGVmaW5lIEVOQUJMRV9MTElOVCAxCi0gICAgI2RlZmluZSBFTkFCTEVfWUFSUl9KSVQg MQotI2VuZGlmCi0KLSNkZWZpbmUgV1RGX1VTRV9BUFBLSVQgMAotI2RlZmluZSBXVEZfVVNFX1NF Q1VSSVRZX0ZSQU1FV09SSyAwCi0jZW5kaWYKKyNkZWZpbmUgRU5BQkxFX0pJVCAxCisjZGVmaW5l IEVOQUJMRV9MTElOVCAxCisjZGVmaW5lIEVOQUJMRV9ZQVJSX0pJVCAxCisjZW5kaWYgLyogUExB VEZPUk0oSU9TKSAqLwogCiAjaWYgUExBVEZPUk0oV0lOKSAmJiAhT1MoV0lOQ0UpCiAjZGVmaW5l IFdURl9VU0VfQ0YgMQpAQCAtNzE4LDExICs3MTYsMTEgQEAKICNpZiBQTEFURk9STShJT1MpIHx8 IF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTA2MAogCiAjZGVmaW5lIEhBVkVf RElTUEFUQ0hfSCAxCi0jZGVmaW5lIEhBVkVfSE9TVEVEX0NPUkVfQU5JTUFUSU9OIDEKICNkZWZp bmUgSEFWRV9NQURWX0ZSRUUgMQogI2RlZmluZSBIQVZFX1BUSFJFQURfU0VUTkFNRV9OUCAxCiAK ICNpZiAhUExBVEZPUk0oSU9TKQorI2RlZmluZSBIQVZFX0hPU1RFRF9DT1JFX0FOSU1BVElPTiAx CiAjZGVmaW5lIEhBVkVfTUFEVl9GUkVFX1JFVVNFIDEKICNlbmRpZiAvKiAhUExBVEZPUk0oSU9T KSAqLwogCkBAIC0xMTMwLDcgKzExMjgsNyBAQAogI2RlZmluZSBXVEZfVVNFX0FWRk9VTkRBVElP TiAxCiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKE1BQykgJiYgIVBMQVRGT1JNKElPUykgJiYgX19N QUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDgwCisjaWYgUExBVEZPUk0oSU9TKSAm JiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSA2MDAwMCB8fCBQTEFURk9STShN QUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTA4MAogI2RlZmluZSBX VEZfVVNFX0NPUkVNRURJQSAxCiAjZW5kaWYKIAo=