109456 2013-02-11 09:33:33 -0800 [WK2][EFL][WTR] Regression(r141836): WTR crashes on exit 2013-02-13 07:58:58 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov ap benjamin cdumez gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 829790 0 mikhail.pozdnyakov 2013-02-11 09:33:33 -0800 SSIA. #1 0x00007fffeff96d33 in WebKit::WebPageProxy::close (this=0x68e2a0) at /media/ssd/WebKit/Source/WebKit2/UIProcess/WebPageProxy.cpp:459 #2 0x00007ffff0160a36 in WebKit::WebView::~WebView (this=0xe96550, __in_chrg=<optimized out>) at /media/ssd/WebKit/Source/WebKit2/UIProcess/efl/WebView.cpp:54 #3 0x00007ffff0160a84 in WebKit::WebView::~WebView (this=0xe96550, __in_chrg=<optimized out>) at /media/ssd/WebKit/Source/WebKit2/UIProcess/efl/WebView.cpp:55 #4 0x00007fffefee5224 in WTF::ThreadSafeRefCounted<WebKit::APIObject>::deref (this=0xe96558) at /media/ssd/WebKit/Source/WTF/wtf/ThreadSafeRefCounted.h:137 #5 0x00007fffeff27a76 in WKRelease (typeRef=0xe96550) at /media/ssd/WebKit/Source/WebKit2/Shared/API/c/WKType.cpp:47 #6 0x0000000000435ea3 in WTR::PlatformWebView::~PlatformWebView (this=0x496d90, __in_chrg=<optimized out>) at /media/ssd/WebKit/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:80 #7 0x0000000000424c7f in WTF::deleteOwnedPtr<WTR::PlatformWebView> (ptr=0x496d90) at /media/ssd/WebKit/Source/WTF/wtf/OwnPtrCommon.h:63 #8 0x0000000000423adf in WTF::OwnPtr<WTR::PlatformWebView>::~OwnPtr (this=0x7fffffffdd48, __in_chrg=<optimized out>) at /media/ssd/WebKit/Source/WTF/wtf/OwnPtr.h:63 #9 0x000000000041d947 in WTR::TestController::~TestController (this=0x7fffffffdce0, __in_chrg=<optimized out>) at /media/ssd/WebKit/Tools/WebKitTestRunner/TestController.cpp:115 #10 0x0000000000436547 in main (argc=2, argv=0x7fffffffdef8) at /media/ssd/WebKit/Tools/WebKitTestRunner/efl/main.cpp:53 829849 1 mikhail.pozdnyakov 2013-02-11 10:28:42 -0800 Ahh.. several different problem lead to exact same crash..!! (at the same time ) 829887 2 187615 mikhail.pozdnyakov 2013-02-11 10:55:39 -0800 Created attachment 187615 patch Kill two crashes with one patch 830044 3 187615 benjamin 2013-02-11 13:27:04 -0800 Comment on attachment 187615 patch View in context: https://bugs.webkit.org/attachment.cgi?id=187615&action=review > Source/WebKit2/ChangeLog:8 > + WebView dtor now consideres the situation if its WebPageProxy dtor->destructor. consideres->considers > Source/WebKit2/UIProcess/efl/WebView.cpp:54 > + // Can be closed already from outside the class. This comments does not add enough information to be useful. You should either remove the comment, or full explain the events that leads to such situation. > Tools/WebKitTestRunner/efl/main.cpp:52 > + // Prefer the not installed web and plugin processes. What?? 830131 4 187615 mikhail.pozdnyakov 2013-02-11 14:26:57 -0800 Comment on attachment 187615 patch View in context: https://bugs.webkit.org/attachment.cgi?id=187615&action=review >> Source/WebKit2/UIProcess/efl/WebView.cpp:54 >> + // Can be closed already from outside the class. > > This comments does not add enough information to be useful. > You should either remove the comment, or full explain the events that leads to such situation. ok. >> Tools/WebKitTestRunner/efl/main.cpp:52 >> + // Prefer the not installed web and plugin processes. > > What?? that's not my comment, changing/removing it wasn't within scope of this patch :) Thanks for review! 830680 5 187804 mikhail.pozdnyakov 2013-02-12 01:10:47 -0800 Created attachment 187804 patch v2 Took comments from Benjamin into consideration. 830805 6 187804 kenneth 2013-02-12 05:24:24 -0800 Comment on attachment 187804 patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=187804&action=review > Tools/WebKitTestRunner/efl/main.cpp:49 > + // Test controller has own ptr containing WebView and Webview must be deleted Spelling Webview* -> WebView 831835 7 188062 mikhail.pozdnyakov 2013-02-13 05:34:02 -0800 Created attachment 188062 patch v3 Fixed misspelling in the comment. 831907 8 188062 webkit.review.bot 2013-02-13 07:58:53 -0800 Comment on attachment 188062 patch v3 Clearing flags on attachment: 188062 Committed r142748: <http://trac.webkit.org/changeset/142748> 831908 9 webkit.review.bot 2013-02-13 07:58:58 -0800 All reviewed patches have been landed. Closing bug. 187615 2013-02-11 10:55:39 -0800 2013-02-12 01:10:47 -0800 patch bug109456 text/plain 3304 mikhail.pozdnyakov Y29tbWl0IDhjNjE2ZDc4MmZkOWI2MjAzNzJjODBkZGZiMjU3MDUwYmFmNzNkYzYKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg TW9uIEZlYiAxMSAyMDo1MDoxMiAyMDEzICswMjAwCgogICAgYnVnMTA5NDU2CgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmlu ZGV4IGE3YWQxZDEuLjY5ZmM0MjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0w Mi0xMSAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4K KworICAgICAgICBbV0syXVtFRkxdW1dUUl0gUmVncmVzc2lvbihyMTQxODM2KTogV1RSIGNyYXNo ZXMgb24gZXhpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA5NDU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2ViVmlldyBkdG9yIG5vdyBjb25zaWRlcmVzIHRoZSBzaXR1YXRpb24gaWYgaXRzIFdlYlBh Z2VQcm94eQorICAgICAgICBpbnN0YW5jZSBoYWQgYmVlbiBjbG9zZWQgZnJvbSBvdXRzaWRlIHRo ZSBjbGFzcyAoZXhwbGljaXRseQorICAgICAgICBieSBjbGllbnQgY29kZSkuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvZWZsL1dlYlZpZXcuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3Ojp+ V2ViVmlldyk6CisKIDIwMTMtMDItMTAgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAog ICAgICAgICBNYWtlIHRoZSBQbHVnLWluIFhQQ1NlcnZpY2UgYnVpbGQgd29yayBldmVuIHdoZW4g YnVpbGRpbmcgaW4gWGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9l ZmwvV2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1dlYlZpZXcuY3Bw CmluZGV4IDY0OWYwZmIuLjIxYzNiNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9lZmwvV2ViVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9X ZWJWaWV3LmNwcApAQCAtNTEsNiArNTEsMTAgQEAgV2ViVmlldzo6V2ViVmlldyhXZWJDb250ZXh0 KiBjb250ZXh0LCBQYWdlQ2xpZW50KiBwYWdlQ2xpZW50LCBXZWJQYWdlR3JvdXAqIHBhZ2UKIAog V2ViVmlldzo6fldlYlZpZXcoKQogeworICAgIC8vIENhbiBiZSBjbG9zZWQgYWxyZWFkeSBmcm9t IG91dHNpZGUgdGhlIGNsYXNzLgorICAgIGlmIChtX3dlYlBhZ2VQcm94eS0+aXNDbG9zZWQoKSkK KyAgICAgICAgcmV0dXJuOworCiAgICAgbV93ZWJQYWdlUHJveHktPmNsb3NlKCk7CiB9CiAKZGlm ZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4ZWY5NTY3 Li45YzVhMDdlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTMtMDItMTEgIE1pa2hhaWwgUG96ZG55YWtvdiAgPG1p a2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CisKKyAgICAgICAgW1dLMl1bRUZMXVtXVFJdIFJl Z3Jlc3Npb24ocjE0MTgzNik6IFdUUiBjcmFzaGVzIG9uIGV4aXQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTQ1NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYlZpZXcgaW5zdGFuY2UgbXVzdCBub3Qg bGl2ZSBsb25nZXIgdGhhbiBFd2tWaWV3LCBhcyBFd2tWaWV3IG93bnMKKyAgICAgICAgb2JqZWN0 cyB0aGF0IHBhZ2UgcHJveHkgcmVmZXJzIHRvLCBkb2luZyBvdGhlcndpc2UgbGVhZHMgdG8gYSBj cmFzaC4KKworICAgICAgICBUZXN0IGNvbnRyb2xsZXIgaGFzIG93biBwdHIgY29udGFpbmluZyBX ZWJWaWV3LiBJbnZva2luZyBvZiBld2tfc2h1dGRvd24oKQorICAgICAgICBsZWFkcyB0byBldmFz IG9iamVjdHMgZGVsZXRpb24uIFNvLCB0aGUgcHJvYmxlbSB3YXMgdGhhdCB0ZXN0IGNvbnRyb2xs ZXIgd2FzCisgICAgICAgIGRlbGV0ZWQgYWZ0ZXIgZXdrX3NodXRkb3duKCkgaGFkIGJlZW4gY2Fs bGVkIGluIG1haW4oKSBmdW5jdGlvbiBjYXVzaW5nCisgICAgICAgIGNyYXNoZXMgb24gV1RSIGV4 aXQuCisKKyAgICAgICAgVGhlIHBhdGNoIGludHJvZHVjZXMgYSBzY29wZSBmb3IgdGVzdCBjb250 cm9sbGVyIHNvIHRoYXQgaXQgaXMgZGVsZXRlZCBmaXJzdC4KKworICAgICAgICAqIFdlYktpdFRl c3RSdW5uZXIvZWZsL21haW4uY3BwOgorICAgICAgICAobWFpbik6CisKIDIwMTMtMDItMTEgIEFu dG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGNo YW5nZSB0byBhZGQgbXlzZWxmIHRvIHRoZSBJbnNwZWN0b3IgSURMcyB3YXRjaGxpc3QuCmRpZmYg LS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2VmbC9tYWluLmNwcCBiL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvZWZsL21haW4uY3BwCmluZGV4IGIwMmZmMzUuLmFhNjYzZWYgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZWZsL21haW4uY3BwCisrKyBiL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvZWZsL21haW4uY3BwCkBAIC00NSw4ICs0NSwxMyBAQCBpbnQgbWFpbihpbnQg YXJnYywgY2hhcioqIGFyZ3YpCiAgICAgaWYgKCFld2tfaW5pdCgpKQogICAgICAgICByZXR1cm4g MTsKIAotICAgIC8vIFByZWZlciB0aGUgbm90IGluc3RhbGxlZCB3ZWIgYW5kIHBsdWdpbiBwcm9j ZXNzZXMuCi0gICAgV1RSOjpUZXN0Q29udHJvbGxlciBjb250cm9sbGVyKGFyZ2MsIGNvbnN0X2Nh c3Q8Y29uc3QgY2hhcioqPihhcmd2KSk7CisgICAgeworICAgICAgICAvLyBUZXN0IGNvbnRyb2xs ZXIgaGFzIG93biBwdHIgY29udGFpbmluZyBXZWJWaWV3IGFuZCBXZWJ2aWV3IG11c3QgYmUgZGVs ZXRlZAorICAgICAgICAvLyBiZWZvcmUgaXRzIGV2YXMgb2JqZWN0IGlzIGRlbGV0ZWQuIENhbGwg b2YgZXdrX3NodXRkb3duKCkgbGVhZHMgdG8gZXZhcyBvYmplY3RzIGRlbGV0aW9uLgorCisgICAg ICAgIC8vIFByZWZlciB0aGUgbm90IGluc3RhbGxlZCB3ZWIgYW5kIHBsdWdpbiBwcm9jZXNzZXMu CisgICAgICAgIFdUUjo6VGVzdENvbnRyb2xsZXIgY29udHJvbGxlcihhcmdjLCBjb25zdF9jYXN0 PGNvbnN0IGNoYXIqKj4oYXJndikpOworICAgIH0KIAogICAgIGV3a19zaHV0ZG93bigpOwogCg== 187804 2013-02-12 01:10:47 -0800 2013-02-13 05:34:02 -0800 patch v2 bug109456_v2 text/plain 3191 mikhail.pozdnyakov Y29tbWl0IGM1MDkwYWMyZjgxYWI3MTllYTIxNmI2MWY4MmJhNWYyY2RmYzE5YzAKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg TW9uIEZlYiAxMSAyMDo1MDoxMiAyMDEzICswMjAwCgogICAgYnVnMTA5NDU2CgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmlu ZGV4IGE3YWQxZDEuLmFiMTZmZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0w Mi0xMSAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4K KworICAgICAgICBbV0syXVtFRkxdW1dUUl0gUmVncmVzc2lvbihyMTQxODM2KTogV1RSIGNyYXNo ZXMgb24gZXhpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA5NDU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2ViVmlldyBkZXN0cnVjdG9yIG5vdyBjb25zaWRlcnMgdGhlIHNpdHVhdGlvbiBpZiBpdHMg V2ViUGFnZVByb3h5CisgICAgICAgIGluc3RhbmNlIGhhZCBiZWVuIGNsb3NlZCBmcm9tIG91dHNp ZGUgdGhlIGNsYXNzIChleHBsaWNpdGx5CisgICAgICAgIGJ5IGNsaWVudCBjb2RlKS4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9lZmwvV2ViVmlldy5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZp ZXc6On5XZWJWaWV3KToKKwogMjAxMy0wMi0xMCAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3Jn PgogCiAgICAgICAgIE1ha2UgdGhlIFBsdWctaW4gWFBDU2VydmljZSBidWlsZCB3b3JrIGV2ZW4g d2hlbiBidWlsZGluZyBpbiBYY29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL2VmbC9XZWJWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvV2ViVmll dy5jcHAKaW5kZXggNjQ5ZjBmYi4uNTBiNjdmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2VmbC9XZWJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv ZWZsL1dlYlZpZXcuY3BwCkBAIC01MSw2ICs1MSw5IEBAIFdlYlZpZXc6OldlYlZpZXcoV2ViQ29u dGV4dCogY29udGV4dCwgUGFnZUNsaWVudCogcGFnZUNsaWVudCwgV2ViUGFnZUdyb3VwKiBwYWdl CiAKIFdlYlZpZXc6On5XZWJWaWV3KCkKIHsKKyAgICBpZiAobV93ZWJQYWdlUHJveHktPmlzQ2xv c2VkKCkpCisgICAgICAgIHJldHVybjsKKwogICAgIG1fd2ViUGFnZVByb3h5LT5jbG9zZSgpOwog fQogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXgg OGVmOTU2Ny4uOWM1YTA3ZSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAyLTExICBNaWtoYWlsIFBvemRueWFr b3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtXSzJdW0VGTF1b V1RSXSBSZWdyZXNzaW9uKHIxNDE4MzYpOiBXVFIgY3Jhc2hlcyBvbiBleGl0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk0NTYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJWaWV3IGluc3RhbmNlIG11 c3Qgbm90IGxpdmUgbG9uZ2VyIHRoYW4gRXdrVmlldywgYXMgRXdrVmlldyBvd25zCisgICAgICAg IG9iamVjdHMgdGhhdCBwYWdlIHByb3h5IHJlZmVycyB0bywgZG9pbmcgb3RoZXJ3aXNlIGxlYWRz IHRvIGEgY3Jhc2guCisKKyAgICAgICAgVGVzdCBjb250cm9sbGVyIGhhcyBvd24gcHRyIGNvbnRh aW5pbmcgV2ViVmlldy4gSW52b2tpbmcgb2YgZXdrX3NodXRkb3duKCkKKyAgICAgICAgbGVhZHMg dG8gZXZhcyBvYmplY3RzIGRlbGV0aW9uLiBTbywgdGhlIHByb2JsZW0gd2FzIHRoYXQgdGVzdCBj b250cm9sbGVyIHdhcworICAgICAgICBkZWxldGVkIGFmdGVyIGV3a19zaHV0ZG93bigpIGhhZCBi ZWVuIGNhbGxlZCBpbiBtYWluKCkgZnVuY3Rpb24gY2F1c2luZworICAgICAgICBjcmFzaGVzIG9u IFdUUiBleGl0LgorCisgICAgICAgIFRoZSBwYXRjaCBpbnRyb2R1Y2VzIGEgc2NvcGUgZm9yIHRl c3QgY29udHJvbGxlciBzbyB0aGF0IGl0IGlzIGRlbGV0ZWQgZmlyc3QuCisKKyAgICAgICAgKiBX ZWJLaXRUZXN0UnVubmVyL2VmbC9tYWluLmNwcDoKKyAgICAgICAgKG1haW4pOgorCiAyMDEzLTAy LTExICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCBjaGFuZ2UgdG8gYWRkIG15c2VsZiB0byB0aGUgSW5zcGVjdG9yIElETHMgd2F0Y2hsaXN0 LgpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwvbWFpbi5jcHAgYi9Ub29s cy9XZWJLaXRUZXN0UnVubmVyL2VmbC9tYWluLmNwcAppbmRleCBiMDJmZjM1Li43ZTNhODg3IDEw MDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2VmbC9tYWluLmNwcAorKysgYi9Ub29s cy9XZWJLaXRUZXN0UnVubmVyL2VmbC9tYWluLmNwcApAQCAtNDUsOCArNDUsMTIgQEAgaW50IG1h aW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogICAgIGlmICghZXdrX2luaXQoKSkKICAgICAgICAg cmV0dXJuIDE7CiAKLSAgICAvLyBQcmVmZXIgdGhlIG5vdCBpbnN0YWxsZWQgd2ViIGFuZCBwbHVn aW4gcHJvY2Vzc2VzLgotICAgIFdUUjo6VGVzdENvbnRyb2xsZXIgY29udHJvbGxlcihhcmdjLCBj b25zdF9jYXN0PGNvbnN0IGNoYXIqKj4oYXJndikpOworICAgIHsKKyAgICAgICAgLy8gVGVzdCBj b250cm9sbGVyIGhhcyBvd24gcHRyIGNvbnRhaW5pbmcgV2ViVmlldyBhbmQgV2VidmlldyBtdXN0 IGJlIGRlbGV0ZWQKKyAgICAgICAgLy8gYmVmb3JlIGl0cyBldmFzIG9iamVjdCBpcyBkZWxldGVk LiBDYWxsIG9mIGV3a19zaHV0ZG93bigpIGxlYWRzIHRvIGV2YXMgb2JqZWN0cyBkZWxldGlvbi4K KworICAgICAgICBXVFI6OlRlc3RDb250cm9sbGVyIGNvbnRyb2xsZXIoYXJnYywgY29uc3RfY2Fz dDxjb25zdCBjaGFyKio+KGFyZ3YpKTsKKyAgICB9CiAKICAgICBld2tfc2h1dGRvd24oKTsKIAo= 188062 2013-02-13 05:34:02 -0800 2013-02-13 07:58:53 -0800 patch v3 bug109456_v3 text/plain 3191 mikhail.pozdnyakov Y29tbWl0IGM1MDkwYWMyZjgxYWI3MTllYTIxNmI2MWY4MmJhNWYyY2RmYzE5YzAKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg TW9uIEZlYiAxMSAyMDo1MDoxMiAyMDEzICswMjAwCgogICAgYnVnMTA5NDU2CgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmlu ZGV4IGE3YWQxZDEuLmFiMTZmZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0w Mi0xMSAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4K KworICAgICAgICBbV0syXVtFRkxdW1dUUl0gUmVncmVzc2lvbihyMTQxODM2KTogV1RSIGNyYXNo ZXMgb24gZXhpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA5NDU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2ViVmlldyBkZXN0cnVjdG9yIG5vdyBjb25zaWRlcnMgdGhlIHNpdHVhdGlvbiBpZiBpdHMg V2ViUGFnZVByb3h5CisgICAgICAgIGluc3RhbmNlIGhhZCBiZWVuIGNsb3NlZCBmcm9tIG91dHNp ZGUgdGhlIGNsYXNzIChleHBsaWNpdGx5CisgICAgICAgIGJ5IGNsaWVudCBjb2RlKS4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9lZmwvV2ViVmlldy5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZp ZXc6On5XZWJWaWV3KToKKwogMjAxMy0wMi0xMCAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3Jn PgogCiAgICAgICAgIE1ha2UgdGhlIFBsdWctaW4gWFBDU2VydmljZSBidWlsZCB3b3JrIGV2ZW4g d2hlbiBidWlsZGluZyBpbiBYY29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL2VmbC9XZWJWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvV2ViVmll dy5jcHAKaW5kZXggNjQ5ZjBmYi4uNTBiNjdmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2VmbC9XZWJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv ZWZsL1dlYlZpZXcuY3BwCkBAIC01MSw2ICs1MSw5IEBAIFdlYlZpZXc6OldlYlZpZXcoV2ViQ29u dGV4dCogY29udGV4dCwgUGFnZUNsaWVudCogcGFnZUNsaWVudCwgV2ViUGFnZUdyb3VwKiBwYWdl CiAKIFdlYlZpZXc6On5XZWJWaWV3KCkKIHsKKyAgICBpZiAobV93ZWJQYWdlUHJveHktPmlzQ2xv c2VkKCkpCisgICAgICAgIHJldHVybjsKKwogICAgIG1fd2ViUGFnZVByb3h5LT5jbG9zZSgpOwog fQogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXgg OGVmOTU2Ny4uOWM1YTA3ZSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAyLTExICBNaWtoYWlsIFBvemRueWFr b3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtXSzJdW0VGTF1b V1RSXSBSZWdyZXNzaW9uKHIxNDE4MzYpOiBXVFIgY3Jhc2hlcyBvbiBleGl0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk0NTYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJWaWV3IGluc3RhbmNlIG11 c3Qgbm90IGxpdmUgbG9uZ2VyIHRoYW4gRXdrVmlldywgYXMgRXdrVmlldyBvd25zCisgICAgICAg IG9iamVjdHMgdGhhdCBwYWdlIHByb3h5IHJlZmVycyB0bywgZG9pbmcgb3RoZXJ3aXNlIGxlYWRz IHRvIGEgY3Jhc2guCisKKyAgICAgICAgVGVzdCBjb250cm9sbGVyIGhhcyBvd24gcHRyIGNvbnRh aW5pbmcgV2ViVmlldy4gSW52b2tpbmcgb2YgZXdrX3NodXRkb3duKCkKKyAgICAgICAgbGVhZHMg dG8gZXZhcyBvYmplY3RzIGRlbGV0aW9uLiBTbywgdGhlIHByb2JsZW0gd2FzIHRoYXQgdGVzdCBj b250cm9sbGVyIHdhcworICAgICAgICBkZWxldGVkIGFmdGVyIGV3a19zaHV0ZG93bigpIGhhZCBi ZWVuIGNhbGxlZCBpbiBtYWluKCkgZnVuY3Rpb24gY2F1c2luZworICAgICAgICBjcmFzaGVzIG9u IFdUUiBleGl0LgorCisgICAgICAgIFRoZSBwYXRjaCBpbnRyb2R1Y2VzIGEgc2NvcGUgZm9yIHRl c3QgY29udHJvbGxlciBzbyB0aGF0IGl0IGlzIGRlbGV0ZWQgZmlyc3QuCisKKyAgICAgICAgKiBX ZWJLaXRUZXN0UnVubmVyL2VmbC9tYWluLmNwcDoKKyAgICAgICAgKG1haW4pOgorCiAyMDEzLTAy LTExICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCBjaGFuZ2UgdG8gYWRkIG15c2VsZiB0byB0aGUgSW5zcGVjdG9yIElETHMgd2F0Y2hsaXN0 LgpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwvbWFpbi5jcHAgYi9Ub29s cy9XZWJLaXRUZXN0UnVubmVyL2VmbC9tYWluLmNwcAppbmRleCBiMDJmZjM1Li43ZTNhODg3IDEw MDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2VmbC9tYWluLmNwcAorKysgYi9Ub29s cy9XZWJLaXRUZXN0UnVubmVyL2VmbC9tYWluLmNwcApAQCAtNDUsOCArNDUsMTIgQEAgaW50IG1h aW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogICAgIGlmICghZXdrX2luaXQoKSkKICAgICAgICAg cmV0dXJuIDE7CiAKLSAgICAvLyBQcmVmZXIgdGhlIG5vdCBpbnN0YWxsZWQgd2ViIGFuZCBwbHVn aW4gcHJvY2Vzc2VzLgotICAgIFdUUjo6VGVzdENvbnRyb2xsZXIgY29udHJvbGxlcihhcmdjLCBj b25zdF9jYXN0PGNvbnN0IGNoYXIqKj4oYXJndikpOworICAgIHsKKyAgICAgICAgLy8gVGVzdCBj b250cm9sbGVyIGhhcyBvd24gcHRyIGNvbnRhaW5pbmcgV2ViVmlldyBhbmQgV2ViVmlldyBtdXN0 IGJlIGRlbGV0ZWQKKyAgICAgICAgLy8gYmVmb3JlIGl0cyBldmFzIG9iamVjdCBpcyBkZWxldGVk LiBDYWxsIG9mIGV3a19zaHV0ZG93bigpIGxlYWRzIHRvIGV2YXMgb2JqZWN0cyBkZWxldGlvbi4K KworICAgICAgICBXVFI6OlRlc3RDb250cm9sbGVyIGNvbnRyb2xsZXIoYXJnYywgY29uc3RfY2Fz dDxjb25zdCBjaGFyKio+KGFyZ3YpKTsKKyAgICB9CiAKICAgICBld2tfc2h1dGRvd24oKTsKIAo=