109432 2013-02-11 07:15:24 -0800 Web Inspector: fix closure compiler warnings in the profiler code 2013-02-11 07:47:28 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 829658 0 yurys 2013-02-11 07:15:24 -0800 Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:500: WARNING - parameter graph does not appear in didReceiveMemorySnapshot's parameter list function didReceiveMemorySnapshot(error, memoryBlock) ^ Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:678: WARNING - parameter graph does not appear in didReceiveMemorySnapshot's parameter list function didReceiveMemorySnapshot(error, memoryBlock) ^ Source/WebCore/inspector/front-end/ProfilesPanel.js:1249: WARNING - mismatch of the addNativeSnapshotChunk property type and the type of the property it overrides from interface MemoryAgent.Dispatcher original: function (this:MemoryAgent.Dispatcher, (null|{baseToRealNodeId: (Array.<number>|null), edges: (Array.<number>|null), nodes: (Array.<number>|null), strings: (Array.<string>|null), ...})): undefined override: function (this:WebInspector.MemoryDispatcher, string): undefined addNativeSnapshotChunk: function(chunk) ^ Source/WebCore/inspector/front-end/ProfilesPanel.js:1249: WARNING - parameter uid does not appear in WebInspector.MemoryDispatcher.prototype.addNativeSnapshotChunk's parameter list addNativeSnapshotChunk: function(chunk) ^ 829660 1 187567 yurys 2013-02-11 07:16:41 -0800 Created attachment 187567 Patch 829683 2 187567 webkit.review.bot 2013-02-11 07:47:25 -0800 Comment on attachment 187567 Patch Clearing flags on attachment: 187567 Committed r142473: <http://trac.webkit.org/changeset/142473> 829684 3 webkit.review.bot 2013-02-11 07:47:28 -0800 All reviewed patches have been landed. Closing bug. 187567 2013-02-11 07:16:41 -0800 2013-02-11 07:47:25 -0800 Patch bug-109432-20130211191311.patch text/plain 2344 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjJjNjc0MWUxNTg5NmY5 NDAwMTJlYzVmMGNkMDNiNTIxY2MzMjlhYi4uNGMwMjI1ODM3MThmOGIxMWIyNTc0NjkzODUzMTdh ZGI1MjY1ZGI4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAyLTExICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGZpeCBjbG9zdXJlIGNvbXBpbGVyIHdhcm5pbmdzIGluIHRoZSBwcm9maWxlciBjb2RlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk0MzIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGVkIHR5 cGUgYW5ub3RhdGlvbnMgdG8gbWF0Y2ggdGhlIGNvZGUuCisKKyAgICAgICAgKiBpbnNwZWN0b3Iv ZnJvbnQtZW5kL05hdGl2ZU1lbW9yeVNuYXBzaG90Vmlldy5qczoKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL1Byb2ZpbGVzUGFuZWwuanM6CisKIDIwMTMtMDItMTEgIFphbiBEb2JlcnNl ayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW0NsYW5nXSBCdWlsZCBl cnJvcnMgaW4gTG9jYWxpemVkU3RyaW5nc0d0ay5jcHAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmF0aXZlTWVtb3J5U25hcHNob3RWaWV3LmpzIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OYXRpdmVNZW1vcnlTbmFwc2hvdFZpZXcu anMKaW5kZXggYzJkYmU0ZmRhMDVhNjk4NzI4ZWQ2YTg4M2EzMDczZDhkYjY0MzcxNS4uZWUwODk5 NWM1M2UyNTE5MzMzODYwYzVkMmE0YTVlMDc1OGNjOGZlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OYXRpdmVNZW1vcnlTbmFwc2hvdFZpZXcuanMKKysr IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OYXRpdmVNZW1vcnlTbmFwc2hv dFZpZXcuanMKQEAgLTQ5NSw3ICs0OTUsNiBAQCBXZWJJbnNwZWN0b3IuTmF0aXZlTWVtb3J5UHJv ZmlsZVR5cGUucHJvdG90eXBlID0gewogICAgICAgICAvKioKICAgICAgICAgICogQHBhcmFtIHs/ c3RyaW5nfSBlcnJvcgogICAgICAgICAgKiBAcGFyYW0gez9NZW1vcnlBZ2VudC5NZW1vcnlCbG9j a30gbWVtb3J5QmxvY2sKLSAgICAgICAgICogQHBhcmFtIHs/T2JqZWN0PX0gZ3JhcGgKICAgICAg ICAgICovCiAgICAgICAgIGZ1bmN0aW9uIGRpZFJlY2VpdmVNZW1vcnlTbmFwc2hvdChlcnJvciwg bWVtb3J5QmxvY2spCiAgICAgICAgIHsKQEAgLTY3Myw3ICs2NzIsNiBAQCBXZWJJbnNwZWN0b3Iu TmF0aXZlTWVtb3J5QmFyQ2hhcnQucHJvdG90eXBlID0gewogICAgICAgICAvKioKICAgICAgICAg ICogQHBhcmFtIHs/c3RyaW5nfSBlcnJvcgogICAgICAgICAgKiBAcGFyYW0gez9NZW1vcnlBZ2Vu dC5NZW1vcnlCbG9ja30gbWVtb3J5QmxvY2sKLSAgICAgICAgICogQHBhcmFtIHs/T2JqZWN0PX0g Z3JhcGgKICAgICAgICAgICovCiAgICAgICAgIGZ1bmN0aW9uIGRpZFJlY2VpdmVNZW1vcnlTbmFw c2hvdChlcnJvciwgbWVtb3J5QmxvY2spCiAgICAgICAgIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qcyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qcwppbmRleCBiOTE2YTZlMjk4 ODQ5NmY3ZTkxMzgzNDE2OWM0MzVhYzM2MjMyMTkyLi43M2NkN2NjZmFiMjYwOWMwYjkwYTBkM2Ux MTNhZWI4NWM0M2UwMTMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1Byb2ZpbGVzUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9Qcm9maWxlc1BhbmVsLmpzCkBAIC0xMjQzLDggKzEyNDMsNyBAQCBXZWJJbnNwZWN0 b3IuTWVtb3J5RGlzcGF0Y2hlci5wcm90b3R5cGUgPSB7CiAKICAgICAvKioKICAgICAgKiBAb3Zl cnJpZGUKLSAgICAgKiBAcGFyYW0ge251bWJlcn0gdWlkCi0gICAgICogQHBhcmFtIHtzdHJpbmd9 IGNodW5rCisgICAgICogQHBhcmFtIHtNZW1vcnlBZ2VudC5IZWFwU25hcHNob3RDaHVua30gY2h1 bmsKICAgICAgKi8KICAgICBhZGROYXRpdmVTbmFwc2hvdENodW5rOiBmdW5jdGlvbihjaHVuaykK ICAgICB7Cg==