109420 2013-02-11 05:35:03 -0800 [GTK] Don't generate documentation if building neither WebKit1 nor WebKit2 2013-02-11 07:07:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan dbates mrobinson pnormand webkit.review.bot oldest_to_newest 829597 0 zan 2013-02-11 05:35:03 -0800 [GTK] Don't generate documentation if building neither WebKit1 nor WebKit2 829599 1 187551 zan 2013-02-11 05:40:51 -0800 Created attachment 187551 Patch 829602 2 zan 2013-02-11 05:50:32 -0800 Admittedly there's not much use of building with both WebKit1 and WebKit2 disabled at the moment, but given that it's possible I'd say it makes sense to avoid document generation in case of this configuration. 829647 3 187551 zan 2013-02-11 07:06:58 -0800 Comment on attachment 187551 Patch Clearing flags on attachment: 187551 Committed r142467: <http://trac.webkit.org/changeset/142467> 829648 4 zan 2013-02-11 07:07:04 -0800 All reviewed patches have been landed. Closing bug. 187551 2013-02-11 05:40:51 -0800 2013-02-11 07:06:58 -0800 Patch bug-109420-20130211143722.patch text/plain 1386 zan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE0MjQ1OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDEzLTAyLTExICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXSBEb24ndCBnZW5lcmF0ZSBkb2N1bWVudGF0aW9uIGlmIGJ1aWxk aW5nIG5laXRoZXIgV2ViS2l0MSBub3IgV2ViS2l0MgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5NDIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3QgZ2VuZXJhdGUgdGhlIEdUSyBkb2N1bWVudGF0 aW9uIGlmIG5laXRoZXIgb2YgdGhlIFdlYktpdDEgYW5kIFdlYktpdDIKKyAgICAgICAgbGF5ZXJz IHdhcyBidWlsdC4gVGhpcyBqdXN0IHJlc3VsdHMgaW4gdW5uZWNlc3NhcnkgZXJyb3JzIGJlaW5n IHNwZXdlZCBvdXQKKyAgICAgICAgYnkgdGhlIGd0a2RvYyB1dGlsaXRpZXMuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChidWlsZEF1dG90b29sc1Byb2plY3Qp OgorCiAyMDEzLTAyLTExICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCBjaGFuZ2UgdG8gYWRkIG15c2VsZiB0byB0aGUgSW5zcGVjdG9yIElE THMgd2F0Y2hsaXN0LgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gMTQyNDU4KQorKysg VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpCkBAIC0yMTM5LDcgKzIx MzksNyBAQCBzdWIgYnVpbGRBdXRvdG9vbHNQcm9qZWN0KCRAKQogCiAgICAgY2hkaXIgIi4uIiBv ciBkaWU7CiAKLSAgICBpZiAoJHByb2plY3QgZXEgJ1dlYktpdCcgJiYgIWlzQ3Jvc3NDb21waWxh dGlvbigpKSB7CisgICAgaWYgKCRwcm9qZWN0IGVxICdXZWJLaXQnICYmICFpc0Nyb3NzQ29tcGls YXRpb24oKSAmJiAhKCRub1dlYktpdDEgJiYgJG5vV2ViS2l0MikpIHsKICAgICAgICAgbXkgQGRv Y0dlbmVyYXRpb25PcHRpb25zID0gKCIkc291cmNlRGlyL1Rvb2xzL2d0ay9nZW5lcmF0ZS1ndGtk b2MiLCAiLS1za2lwLWh0bWwiKTsKICAgICAgICAgcHVzaChAZG9jR2VuZXJhdGlvbk9wdGlvbnMs IHByb2R1Y3REaXIoKSk7CiAK