109414 2013-02-11 03:10:14 -0800 Web Inspector: Allow SplitView to keep the sidebar size as a fraction of the container size 2013-02-11 04:17:40 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kaznacheev kaznacheev apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 829544 0 kaznacheev 2013-02-11 03:10:14 -0800 Currently WebInspector.SplitView keeps the sidebar size with or height constant. For some applications it would be useful if the sidebar size was a fraction of the container size. 829546 1 187538 kaznacheev 2013-02-11 03:20:08 -0800 Created attachment 187538 Patch 829574 2 187538 webkit.review.bot 2013-02-11 04:17:36 -0800 Comment on attachment 187538 Patch Clearing flags on attachment: 187538 Committed r142452: <http://trac.webkit.org/changeset/142452> 829575 3 webkit.review.bot 2013-02-11 04:17:40 -0800 All reviewed patches have been landed. Closing bug. 187538 2013-02-11 03:20:08 -0800 2013-02-11 04:17:36 -0800 Patch bug-109414-20130211151639.patch text/plain 6418 kaznacheev U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzZkMDQ2ODkxMDY5Yzc0 NDYwMjQxMDRkNTUxMzM0MjkyMDU4NjEzMC4uOGU4M2I3MTVjNmY1MGIyNjk4ODA3NzZiZGYwY2Qw MTRhZTgxMjgyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTExICBWbGFk aXNsYXYgS2F6bmFjaGVldiAgPGthem5hY2hlZXZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdl YiBJbnNwZWN0b3I6IEFsbG93IFNwbGl0VmlldyB0byBrZWVwIHRoZSBzaWRlYmFyIHNpemUgYXMg YSBmcmFjdGlvbiBvZiB0aGUgY29udGFpbmVyIHNpemUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTQxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFNwbGl0VmlldyBub3cgaW50ZXJwcmV0cyBkZWZhdWx0 U2lkZWJhcldpZHRoIGFuZCBkZWZhdWx0U2lkZWJhckhlaWdodCB2YWx1ZXMgYmV0d2VlbiAwIGFu ZCAxIGFzCisgICAgICAgIGZyYWN0aW9ucyBvZiB0aGUgdG90YWwgY29udGFpbmVyIHNpemUuIFRo ZSBzaWRlYmFyIHRoZW4gd2lsbCBncm93IG9yIHNocmluayBhbG9uZyB3aXRoIHRoZSBjb250YWlu ZXIuCisgICAgICAgIFdoZW4gdGhlIHNpZGViYXIgaXMgcmVzaXplZCBtYW51YWxseSB0aGUgdXBk YXRlZCByYXRpbyBpcyBzdG9yZWQgaW4gdGhlIHNldHRpbmdzLgorCisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC9TcGxpdFZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3BsaXRW aWV3KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TcGxpdFZpZXcucHJvdG90eXBlLl9yZW1vdmVB bGxMYXlvdXRQcm9wZXJ0aWVzKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TcGxpdFZpZXcucHJv dG90eXBlLl91cGRhdGVUb3RhbFNpemUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNwbGl0Vmll dy5wcm90b3R5cGUuX2lubmVyU2V0U2lkZWJhclNpemUpOgorICAgICAgICAoV2ViSW5zcGVjdG9y LlNwbGl0Vmlldy5wcm90b3R5cGUuX3NhdmVTaWRlYmFyU2l6ZSk6CisKIDIwMTMtMDItMDggIENo YW5nU2VvayBPaCAgPHNoaXZhbWlkb3dAZ21haWwuY29tPgogCiAgICAgICAgIFtHVEtdW0FDXSBH cmFwaGljc0xheWVyQ2x1dHRlciBkb2Vzbid0IG5lZWQgdG8gcmVjYWxjdWxhdGUgaXRzIHBvc2l0 aW9uIGFmdGVyIGNoYW5naW5nIGFuY2hvciBwb3NpdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3BsaXRWaWV3LmpzIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9TcGxpdFZpZXcuanMKaW5kZXggMTc0M2JhZDkxNDExMzQ2NzZl NzJhOTQzYjczZmM0MjJhMDg3M2ZjYy4uMTY0ZDE3ZTE4MDc3OGI3ZTdjNWEwYzU2OGIyNzczZjdj NmMwMmRiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9T cGxpdFZpZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TcGxp dFZpZXcuanMKQEAgLTUyLDYgKzUyLDEwIEBAIFdlYkluc3BlY3Rvci5TcGxpdFZpZXcgPSBmdW5j dGlvbihpc1ZlcnRpY2FsLCBzaWRlYmFyU2l6ZVNldHRpbmdOYW1lLCBkZWZhdWx0U2lkCiAgICAg dGhpcy5fc2F2ZWRTaWRlYmFyV2lkdGggPSBkZWZhdWx0U2lkZWJhcldpZHRoIHx8IDIwMDsKICAg ICB0aGlzLl9zYXZlZFNpZGViYXJIZWlnaHQgPSBkZWZhdWx0U2lkZWJhckhlaWdodCB8fCB0aGlz Ll9zYXZlZFNpZGViYXJXaWR0aDsKIAorICAgIGlmICgwIDwgdGhpcy5fc2F2ZWRTaWRlYmFyV2lk dGggJiYgdGhpcy5fc2F2ZWRTaWRlYmFyV2lkdGggPCAxICYmCisgICAgICAgIDAgPCB0aGlzLl9z YXZlZFNpZGViYXJIZWlnaHQgJiYgdGhpcy5fc2F2ZWRTaWRlYmFySGVpZ2h0IDwgMSkKKyAgICAg ICAgdGhpcy5fdXNlRnJhY3Rpb24gPSB0cnVlOworICAgIAogICAgIHRoaXMuX3NpZGViYXJTaXpl U2V0dGluZ05hbWUgPSBzaWRlYmFyU2l6ZVNldHRpbmdOYW1lOwogCiAgICAgdGhpcy5fc2Vjb25k SXNTaWRlYmFyID0gdHJ1ZTsKQEAgLTIxNyw2ICsyMjEsMTEgQEAgV2ViSW5zcGVjdG9yLlNwbGl0 Vmlldy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX3Jlc2l6ZXJFbGVtZW50LnN0eWxlLnJl bW92ZVByb3BlcnR5KCJyaWdodCIpOwogICAgICAgICB0aGlzLl9yZXNpemVyRWxlbWVudC5zdHls ZS5yZW1vdmVQcm9wZXJ0eSgidG9wIik7CiAgICAgICAgIHRoaXMuX3Jlc2l6ZXJFbGVtZW50LnN0 eWxlLnJlbW92ZVByb3BlcnR5KCJib3R0b20iKTsKKworICAgICAgICB0aGlzLl9yZXNpemVyRWxl bWVudC5zdHlsZS5yZW1vdmVQcm9wZXJ0eSgibWFyZ2luLWxlZnQiKTsKKyAgICAgICAgdGhpcy5f cmVzaXplckVsZW1lbnQuc3R5bGUucmVtb3ZlUHJvcGVydHkoIm1hcmdpbi1yaWdodCIpOworICAg ICAgICB0aGlzLl9yZXNpemVyRWxlbWVudC5zdHlsZS5yZW1vdmVQcm9wZXJ0eSgibWFyZ2luLXRv cCIpOworICAgICAgICB0aGlzLl9yZXNpemVyRWxlbWVudC5zdHlsZS5yZW1vdmVQcm9wZXJ0eSgi bWFyZ2luLWJvdHRvbSIpOwogICAgIH0sCiAKICAgICBzaG93Qm90aDogZnVuY3Rpb24oKQpAQCAt Mjc5LDggKzI4OCwxMCBAQCBXZWJJbnNwZWN0b3IuU3BsaXRWaWV3LnByb3RvdHlwZSA9IHsKICAg ICBfdXBkYXRlVG90YWxTaXplOiBmdW5jdGlvbigpCiAgICAgewogICAgICAgICB0aGlzLl90b3Rh bFNpemUgPSB0aGlzLl9pc1ZlcnRpY2FsID8gdGhpcy5lbGVtZW50Lm9mZnNldFdpZHRoIDogdGhp cy5lbGVtZW50Lm9mZnNldEhlaWdodDsKKyAgICAgICAgaWYgKHRoaXMuX3VzZUZyYWN0aW9uKQor ICAgICAgICAgICAgdGhpcy5fc2lkZWJhclNpemUgPSB0aGlzLl9sYXN0U2lkZWJhclNpemUoKTsK ICAgICB9LAotICAKKwogICAgIC8qKgogICAgICAqIEBwYXJhbSB7bnVtYmVyfSBzaXplCiAgICAg ICovCkBAIC0yOTEsMjggKzMwMiwzOCBAQCBXZWJJbnNwZWN0b3IuU3BsaXRWaWV3LnByb3RvdHlw ZSA9IHsKIAogICAgICAgICB0aGlzLl9yZW1vdmVBbGxMYXlvdXRQcm9wZXJ0aWVzKCk7CiAKKyAg ICAgICAgdmFyIHNpemVWYWx1ZTsKKyAgICAgICAgaWYgKHRoaXMuX3VzZUZyYWN0aW9uKQorICAg ICAgICAgICAgc2l6ZVZhbHVlID0gKHNpemUgLyB0aGlzLl90b3RhbFNpemUpICogMTAwICsgIiUi OworICAgICAgICBlbHNlCisgICAgICAgICAgICBzaXplVmFsdWUgPSBzaXplICsgInB4IjsKKwog ICAgICAgICBpZiAodGhpcy5faXNWZXJ0aWNhbCkgewogICAgICAgICAgICAgdmFyIHJlc2l6ZXJX aWR0aCA9IHRoaXMuX3Jlc2l6ZXJFbGVtZW50Lm9mZnNldFdpZHRoOwogICAgICAgICAgICAgaWYg KHRoaXMuX3NlY29uZElzU2lkZWJhcikgewotICAgICAgICAgICAgICAgIHRoaXMuX2ZpcnN0RWxl bWVudC5zdHlsZS5yaWdodCA9IHNpemUgKyAicHgiOwotICAgICAgICAgICAgICAgIHRoaXMuX3Nl Y29uZEVsZW1lbnQuc3R5bGUud2lkdGggPSBzaXplICsgInB4IjsKLSAgICAgICAgICAgICAgICB0 aGlzLl9yZXNpemVyRWxlbWVudC5zdHlsZS5yaWdodCA9IHNpemUgLSByZXNpemVyV2lkdGggLyAy ICsgInB4IjsKKyAgICAgICAgICAgICAgICB0aGlzLl9maXJzdEVsZW1lbnQuc3R5bGUucmlnaHQg PSBzaXplVmFsdWU7CisgICAgICAgICAgICAgICAgdGhpcy5fc2Vjb25kRWxlbWVudC5zdHlsZS53 aWR0aCA9IHNpemVWYWx1ZTsKKyAgICAgICAgICAgICAgICB0aGlzLl9yZXNpemVyRWxlbWVudC5z dHlsZS5yaWdodCA9IHNpemVWYWx1ZTsKKyAgICAgICAgICAgICAgICB0aGlzLl9yZXNpemVyRWxl bWVudC5zdHlsZS5tYXJnaW5SaWdodCA9IC1yZXNpemVyV2lkdGggLyAyICsgInB4IjsKICAgICAg ICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAgICAgdGhpcy5fZmlyc3RFbGVtZW50LnN0eWxl LndpZHRoID0gc2l6ZSArICJweCI7Ci0gICAgICAgICAgICAgICAgdGhpcy5fc2Vjb25kRWxlbWVu dC5zdHlsZS5sZWZ0ID0gc2l6ZSArICJweCI7Ci0gICAgICAgICAgICAgICAgdGhpcy5fcmVzaXpl ckVsZW1lbnQuc3R5bGUubGVmdCA9IHNpemUgLSByZXNpemVyV2lkdGggLyAyICsgInB4IjsKKyAg ICAgICAgICAgICAgICB0aGlzLl9maXJzdEVsZW1lbnQuc3R5bGUud2lkdGggPSBzaXplVmFsdWU7 CisgICAgICAgICAgICAgICAgdGhpcy5fc2Vjb25kRWxlbWVudC5zdHlsZS5sZWZ0ID0gc2l6ZVZh bHVlOworICAgICAgICAgICAgICAgIHRoaXMuX3Jlc2l6ZXJFbGVtZW50LnN0eWxlLmxlZnQgPSBz aXplVmFsdWU7CisgICAgICAgICAgICAgICAgdGhpcy5fcmVzaXplckVsZW1lbnQuc3R5bGUubWFy Z2luTGVmdCA9IC1yZXNpemVyV2lkdGggLyAyICsgInB4IjsKICAgICAgICAgICAgIH0KICAgICAg ICAgfSBlbHNlIHsKICAgICAgICAgICAgIHZhciByZXNpemVySGVpZ2h0ID0gdGhpcy5fcmVzaXpl ckVsZW1lbnQub2Zmc2V0SGVpZ2h0OwotICAgICAgICAgICAKKwogICAgICAgICAgICAgaWYgKHRo aXMuX3NlY29uZElzU2lkZWJhcikgewotICAgICAgICAgICAgICAgIHRoaXMuX2ZpcnN0RWxlbWVu dC5zdHlsZS5ib3R0b20gPSBzaXplICsgInB4IjsKLSAgICAgICAgICAgICAgICB0aGlzLl9zZWNv bmRFbGVtZW50LnN0eWxlLmhlaWdodCA9IHNpemUgKyAicHgiOwotICAgICAgICAgICAgICAgIHRo aXMuX3Jlc2l6ZXJFbGVtZW50LnN0eWxlLmJvdHRvbSA9IHNpemUgLSByZXNpemVySGVpZ2h0IC8g MiArICJweCI7CisgICAgICAgICAgICAgICAgdGhpcy5fZmlyc3RFbGVtZW50LnN0eWxlLmJvdHRv bSA9IHNpemVWYWx1ZTsKKyAgICAgICAgICAgICAgICB0aGlzLl9zZWNvbmRFbGVtZW50LnN0eWxl LmhlaWdodCA9IHNpemVWYWx1ZTsKKyAgICAgICAgICAgICAgICB0aGlzLl9yZXNpemVyRWxlbWVu dC5zdHlsZS5ib3R0b20gPSBzaXplVmFsdWU7CisgICAgICAgICAgICAgICAgdGhpcy5fcmVzaXpl ckVsZW1lbnQuc3R5bGUubWFyZ2luQm90dG9tID0gLXJlc2l6ZXJIZWlnaHQgLyAyICsgInB4IjsK ICAgICAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAgICAgdGhpcy5fZmlyc3RFbGVtZW50 LnN0eWxlLmhlaWdodCA9IHNpemUgKyAicHgiOwotICAgICAgICAgICAgICAgIHRoaXMuX3NlY29u ZEVsZW1lbnQuc3R5bGUudG9wID0gc2l6ZSArICJweCI7Ci0gICAgICAgICAgICAgICAgdGhpcy5f cmVzaXplckVsZW1lbnQuc3R5bGUudG9wID0gc2l6ZSAtIHJlc2l6ZXJIZWlnaHQgLyAyICsgInB4 IjsKKyAgICAgICAgICAgICAgICB0aGlzLl9maXJzdEVsZW1lbnQuc3R5bGUuaGVpZ2h0ID0gc2l6 ZVZhbHVlOworICAgICAgICAgICAgICAgIHRoaXMuX3NlY29uZEVsZW1lbnQuc3R5bGUudG9wID0g c2l6ZVZhbHVlOworICAgICAgICAgICAgICAgIHRoaXMuX3Jlc2l6ZXJFbGVtZW50LnN0eWxlLnRv cCA9IHNpemVWYWx1ZTsKKyAgICAgICAgICAgICAgICB0aGlzLl9yZXNpemVyRWxlbWVudC5zdHls ZS5tYXJnaW5Ub3AgPSAtcmVzaXplckhlaWdodCAvIDIgKyAicHgiOwogICAgICAgICAgICAgfQog ICAgICAgICB9CiAKQEAgLTQxNCw3ICs0MzUsMTEgQEAgV2ViSW5zcGVjdG9yLlNwbGl0Vmlldy5w cm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICB2YXIgc2l6ZVNldHRpbmcgPSB0aGlzLl9zaXpl U2V0dGluZygpOwogICAgICAgICB2YXIgc2l6ZSA9IHNpemVTZXR0aW5nID8gc2l6ZVNldHRpbmcu Z2V0KCkgOiAwOwotICAgICAgICByZXR1cm4gc2l6ZSB8fCAodGhpcy5faXNWZXJ0aWNhbCA/IHRo aXMuX3NhdmVkU2lkZWJhcldpZHRoIDogdGhpcy5fc2F2ZWRTaWRlYmFySGVpZ2h0KTsKKyAgICAg ICAgaWYgKCFzaXplKQorICAgICAgICAgICAgIHNpemUgPSB0aGlzLl9pc1ZlcnRpY2FsID8gdGhp cy5fc2F2ZWRTaWRlYmFyV2lkdGggOiB0aGlzLl9zYXZlZFNpZGViYXJIZWlnaHQ7CisgICAgICAg IGlmICh0aGlzLl91c2VGcmFjdGlvbikKKyAgICAgICAgICAgIHNpemUgKj0gdGhpcy5fdG90YWxT aXplOworICAgICAgICByZXR1cm4gc2l6ZTsKICAgICB9LAogCiAgICAgLyoqCkBAIC00MjIsNiAr NDQ3LDkgQEAgV2ViSW5zcGVjdG9yLlNwbGl0Vmlldy5wcm90b3R5cGUgPSB7CiAgICAgICovCiAg ICAgX3NhdmVTaWRlYmFyU2l6ZTogZnVuY3Rpb24oc2l6ZSkKICAgICB7CisgICAgICAgIGlmICh0 aGlzLl91c2VGcmFjdGlvbikKKyAgICAgICAgICAgIHNpemUgLz0gdGhpcy5fdG90YWxTaXplOwor CiAgICAgICAgIGlmICh0aGlzLl9pc1ZlcnRpY2FsKQogICAgICAgICAgICAgdGhpcy5fc2F2ZWRT aWRlYmFyV2lkdGggPSBzaXplOwogICAgICAgICBlbHNlCg==