109408 2013-02-11 01:05:00 -0800 Remove AttributeBase now that NEW_XML is gone 2013-02-12 17:32:34 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107522 1 eric eric abarth ojan.autocc tonyg webkit.review.bot oldest_to_newest 829485 0 eric 2013-02-11 01:05:00 -0800 Remove AttributeBase now that NEW_XML is gone 829488 1 187523 eric 2013-02-11 01:07:36 -0800 Created attachment 187523 Patch 829750 2 187523 webkit.review.bot 2013-02-11 08:54:05 -0800 Comment on attachment 187523 Patch Clearing flags on attachment: 187523 Committed r142480: <http://trac.webkit.org/changeset/142480> 829751 3 webkit.review.bot 2013-02-11 08:54:08 -0800 All reviewed patches have been landed. Closing bug. 829756 4 187523 darin 2013-02-11 08:59:41 -0800 Comment on attachment 187523 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187523&action=review > Source/WebCore/xml/parser/MarkupTokenBase.h:67 > + class Attribute { > + public: > + class Range { > + public: > + int m_start; > + int m_end; > + }; > + > + Range m_nameRange; > + Range m_valueRange; > + WTF::Vector<UChar, 32> m_name; > + WTF::Vector<UChar, 32> m_value; > + }; The WTF:: prefixes here are not needed. Also, I notice a WebKit coding style anti-pattern here. In WebKit we use private data members, not public ones. When we want something with private data, we use struct, not class, and we name the data members without "m_" prefixes. So in WebKit coding style this would be: struct Attribute { struct Range { int start; int end; }; Range nameRange; Range valueRange; Vector<UChar, 32> name; Vector<UChar, 32> value; }; 829768 5 eric 2013-02-11 09:09:01 -0800 Agreed. Happy to fix the style in a follow-up patch. 829888 6 eric 2013-02-11 10:57:55 -0800 I looked at this this morning. gonna wait to fix this until we've killed MarkupTokenBase so that we can use String and AtomicString in this file. (which it currently seems to be avoiding). 831469 7 eric 2013-02-12 17:32:34 -0800 (In reply to comment #4) > (From update of attachment 187523 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=187523&action=review > The WTF:: prefixes here are not needed. > > Also, I notice a WebKit coding style anti-pattern here. In WebKit we use private data members, not public ones. When we want something with private data, we use struct, not class, and we name the data members without "m_" prefixes. So in WebKit coding style this would be: Fixed in bug 109638 187523 2013-02-11 01:07:36 -0800 2013-02-11 08:59:41 -0800 Patch bug-109408-20130211010424.patch text/plain 4161 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2U3NzcwZGQ2NTE0ZTY3 NzRhMDViOTUwZDQzZmE2NzE0ZGI3NzVmZS4uNTZiNDI3MGRjYjIzMDE1M2M5NmQxODVlMGJjNzhi MDQyN2RkM2RjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAyLTExICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBSZW1vdmUgQXR0cmlidXRlQmFz ZSBub3cgdGhhdCBORVdfWE1MIGlzIGdvbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwOTQwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEp1c3QgZGVsZXRpbmcgY29kZS4gIEhUTUxUb2tlbjo6QXR0cmli dXRlIGlzIG5vdyBqdXN0CisgICAgICAgIHRoZSByZWFsIGNsYXNzIGFuZCBub3QgYSB0eXBlZGVm LgorCisgICAgICAgICogaHRtbC9wYXJzZXIvQ29tcGFjdEhUTUxUb2tlbi5jcHA6CisgICAgICAg IChXZWJDb3JlOjpDb21wYWN0SFRNTFRva2VuOjpDb21wYWN0SFRNTFRva2VuKToKKyAgICAgICAg KiBodG1sL3BhcnNlci9IVE1MVG9rZW5pemVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF0b21p Y0hUTUxUb2tlbjo6bmFtZUZvckF0dHJpYnV0ZSk6CisgICAgICAgICogeG1sL3BhcnNlci9NYXJr dXBUb2tlbkJhc2UuaDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoTWFya3VwVG9rZW5C YXNlKToKKyAgICAgICAgKEF0dHJpYnV0ZSk6CisgICAgICAgIChSYW5nZSk6CisKIDIwMTMtMDIt MTAgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIE1ha2UgdGhlIGV4 aXN0aW5nIEhUTUxQcmVsb2FkU2Nhbm5lciB0aHJlYWRpbmctYXdhcmUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0NvbXBhY3RIVE1MVG9rZW4uY3BwIGIvU291cmNlL1dl YkNvcmUvaHRtbC9wYXJzZXIvQ29tcGFjdEhUTUxUb2tlbi5jcHAKaW5kZXggMWYxMjJmMDM3MDQ4 YTAyNDI2YWMyMzY4ODMxNzFkMzhiNTNjNjFiMC4uOTJlNjEzNDkzODUyYmE2OWU5YTJhM2MxY2Nk ZmIyNDliYmIxZmFlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvQ29t cGFjdEhUTUxUb2tlbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvQ29tcGFj dEhUTUxUb2tlbi5jcHAKQEAgLTY4LDcgKzY4LDcgQEAgQ29tcGFjdEhUTUxUb2tlbjo6Q29tcGFj dEhUTUxUb2tlbihjb25zdCBIVE1MVG9rZW4qIHRva2VuLCBjb25zdCBUZXh0UG9zaXRpb24mIHQK ICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBIVE1MVG9rZW5UeXBlczo6U3RhcnRUYWc6CiAgICAg ICAgIG1fYXR0cmlidXRlcy5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KHRva2VuLT5hdHRyaWJ1dGVz KCkuc2l6ZSgpKTsKLSAgICAgICAgZm9yIChWZWN0b3I8QXR0cmlidXRlQmFzZT46OmNvbnN0X2l0 ZXJhdG9yIGl0ID0gdG9rZW4tPmF0dHJpYnV0ZXMoKS5iZWdpbigpOyBpdCAhPSB0b2tlbi0+YXR0 cmlidXRlcygpLmVuZCgpOyArK2l0KQorICAgICAgICBmb3IgKFZlY3RvcjxIVE1MVG9rZW46OkF0 dHJpYnV0ZT46OmNvbnN0X2l0ZXJhdG9yIGl0ID0gdG9rZW4tPmF0dHJpYnV0ZXMoKS5iZWdpbigp OyBpdCAhPSB0b2tlbi0+YXR0cmlidXRlcygpLmVuZCgpOyArK2l0KQogICAgICAgICAgICAgbV9h dHRyaWJ1dGVzLmFwcGVuZChDb21wYWN0QXR0cmlidXRlKFN0cmluZyhpdC0+bV9uYW1lLmRhdGEo KSwgaXQtPm1fbmFtZS5zaXplKCkpLCBTdHJpbmcoaXQtPm1fdmFsdWUuZGF0YSgpLCBpdC0+bV92 YWx1ZS5zaXplKCkpKSk7CiAgICAgICAgIC8vIEZhbGwgdGhyb3VnaCEKICAgICBjYXNlIEhUTUxU b2tlblR5cGVzOjpFbmRUYWc6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNl ci9IVE1MVG9rZW5pemVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUb2tl bml6ZXIuY3BwCmluZGV4IDdkZTQyODg2ZmQyY2Q3MDk1ZTE3YmZiNDIzMmU5ZDZiMjVjNGZhNGYu LjM5YTQxNjNhN2UyMzRmOWU5ODE4MzliOWVkOGY0MzRhM2NlNTQxY2IgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUb2tlbml6ZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUb2tlbml6ZXIuY3BwCkBAIC00OSw3ICs0OSw3IEBAIHVz aW5nIG5hbWVzcGFjZSBIVE1MTmFtZXM7CiAKIC8vIFRoaXMgaGFzIHRvIGdvIGluIGEgLmNwcCBm aWxlLCBhcyB0aGUgbGlua2VyIGRvZXNuJ3QgbGlrZSBpdCBiZWluZyBpbmNsdWRlZCBtb3JlIHRo YW4gb25jZS4KIC8vIFdlIGRvbid0IGhhdmUgYW4gSFRNTFRva2VuLmNwcCB0aG91Z2gsIHNvIHRo aXMgaXMgdGhlIG5leHQgYmVzdCBwbGFjZS4KLVF1YWxpZmllZE5hbWUgQXRvbWljSFRNTFRva2Vu OjpuYW1lRm9yQXR0cmlidXRlKGNvbnN0IEF0dHJpYnV0ZUJhc2UmIGF0dHJpYnV0ZSkgY29uc3QK K1F1YWxpZmllZE5hbWUgQXRvbWljSFRNTFRva2VuOjpuYW1lRm9yQXR0cmlidXRlKGNvbnN0IEhU TUxUb2tlbjo6QXR0cmlidXRlJiBhdHRyaWJ1dGUpIGNvbnN0CiB7CiAgICAgcmV0dXJuIFF1YWxp ZmllZE5hbWUobnVsbEF0b20sIEF0b21pY1N0cmluZyhhdHRyaWJ1dGUubV9uYW1lLmRhdGEoKSwg YXR0cmlidXRlLm1fbmFtZS5zaXplKCkpLCBudWxsQXRvbSk7CiB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS94bWwvcGFyc2VyL01hcmt1cFRva2VuQmFzZS5oIGIvU291cmNlL1dlYkNvcmUv eG1sL3BhcnNlci9NYXJrdXBUb2tlbkJhc2UuaAppbmRleCA4ODdiMmFiYTgwMTBhOTNjZDg1NjIy NTMyYzlmYjk5MTAwMWJjOGUzLi44ZDczOTAwOTQzM2YyMjM0ZWE1N2E0ZDA1YjQ4NDA5ZTJlMTJh OGQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS94bWwvcGFyc2VyL01hcmt1cFRva2VuQmFz ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9wYXJzZXIvTWFya3VwVG9rZW5CYXNlLmgKQEAg LTQ1LDI3ICs0NSwyNiBAQCBzdGF0aWMgaW5saW5lIEF0dHJpYnV0ZSogZmluZEF0dHJpYnV0ZUlu VmVjdG9yKFZlY3RvcjxBdHRyaWJ1dGU+JiBhdHRyaWJ1dGVzLCBjbwogICAgIHJldHVybiAwOwog fQogCi1jbGFzcyBBdHRyaWJ1dGVCYXNlIHsKLXB1YmxpYzoKLSAgICBjbGFzcyBSYW5nZSB7Ci0g ICAgcHVibGljOgotICAgICAgICBpbnQgbV9zdGFydDsKLSAgICAgICAgaW50IG1fZW5kOwotICAg IH07Ci0KLSAgICBSYW5nZSBtX25hbWVSYW5nZTsKLSAgICBSYW5nZSBtX3ZhbHVlUmFuZ2U7Ci0g ICAgV1RGOjpWZWN0b3I8VUNoYXIsIDMyPiBtX25hbWU7Ci0gICAgV1RGOjpWZWN0b3I8VUNoYXIs IDMyPiBtX3ZhbHVlOwotfTsKLQotdGVtcGxhdGU8dHlwZW5hbWUgVHlwZVNldCwgdHlwZW5hbWUg QXR0cmlidXRlVHlwZSA9IEF0dHJpYnV0ZUJhc2U+Cit0ZW1wbGF0ZTx0eXBlbmFtZSBUeXBlU2V0 PgogY2xhc3MgTWFya3VwVG9rZW5CYXNlIHsKICAgICBXVEZfTUFLRV9OT05DT1BZQUJMRShNYXJr dXBUb2tlbkJhc2UpOwogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgogICAg IHR5cGVkZWYgVHlwZVNldCBUeXBlOwotICAgIHR5cGVkZWYgQXR0cmlidXRlVHlwZSBBdHRyaWJ1 dGU7CisKKyAgICBjbGFzcyBBdHRyaWJ1dGUgeworICAgIHB1YmxpYzoKKyAgICAgICAgY2xhc3Mg UmFuZ2UgeworICAgICAgICBwdWJsaWM6CisgICAgICAgICAgICBpbnQgbV9zdGFydDsKKyAgICAg ICAgICAgIGludCBtX2VuZDsKKyAgICAgICAgfTsKKworICAgICAgICBSYW5nZSBtX25hbWVSYW5n ZTsKKyAgICAgICAgUmFuZ2UgbV92YWx1ZVJhbmdlOworICAgICAgICBXVEY6OlZlY3RvcjxVQ2hh ciwgMzI+IG1fbmFtZTsKKyAgICAgICAgV1RGOjpWZWN0b3I8VUNoYXIsIDMyPiBtX3ZhbHVlOwor ICAgIH07CiAKICAgICB0eXBlZGVmIFdURjo6VmVjdG9yPEF0dHJpYnV0ZSwgMTA+IEF0dHJpYnV0 ZUxpc3Q7CiAgICAgdHlwZWRlZiBXVEY6OlZlY3RvcjxVQ2hhciwgMTAyND4gRGF0YVZlY3RvcjsK