109406 2013-02-11 00:42:51 -0800 Rename PreloadTask to StartTagScanner to match its purpose 2013-02-11 08:00:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric eric abarth ojan.autocc tonyg webkit.review.bot oldest_to_newest 829476 0 eric 2013-02-11 00:42:51 -0800 Rename PreloadTask to StarTagScanner to match its purpose 829477 1 187522 eric 2013-02-11 00:43:28 -0800 Created attachment 187522 Patch 829479 2 187522 eric 2013-02-11 00:44:34 -0800 Comment on attachment 187522 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187522&action=review > Source/WebCore/html/parser/HTMLPreloadScanner.cpp:72 > - && m_tagName != scriptTag > - && m_tagName != baseTag) > + && m_tagName != scriptTag) I also removed handling of baseTag in the earlier patch but failed to remove it from this if. 829697 3 187522 webkit.review.bot 2013-02-11 08:00:24 -0800 Comment on attachment 187522 Patch Clearing flags on attachment: 187522 Committed r142475: <http://trac.webkit.org/changeset/142475> 829698 4 webkit.review.bot 2013-02-11 08:00:28 -0800 All reviewed patches have been landed. Closing bug. 187522 2013-02-11 00:43:28 -0800 2013-02-11 08:00:24 -0800 Patch bug-109406-20130211004015.patch text/plain 2571 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2U3NzcwZGQ2NTE0ZTY3 NzRhMDViOTUwZDQzZmE2NzE0ZGI3NzVmZS4uMjY3NThjOTVmMzBlZDgxYjEwMmYwODA3YmFiMjgy MzdlOGZiY2EzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAyLTExICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBSZW5hbWUgUHJlbG9hZFRhc2sg dG8gU3RhcnRUYWdTY2FubmVyIHRvIG1hdGNoIGl0cyBwdXJwb3NlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk0MDYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcyBkaXNjdXNzZWQgaW4gYnVnIDEwNzgw Ny4KKworICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxQcmVsb2FkU2Nhbm5lci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTdGFydFRhZ1NjYW5uZXI6OlN0YXJ0VGFnU2Nhbm5lcik6CisgICAgICAg IChXZWJDb3JlOjpTdGFydFRhZ1NjYW5uZXI6OnByb2Nlc3NBdHRyaWJ1dGVzKToKKyAgICAgICAg KFdlYkNvcmU6OkhUTUxQcmVsb2FkU2Nhbm5lcjo6cHJvY2Vzc1Rva2VuKToKKwogMjAxMy0wMi0x MCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTWFrZSB0aGUgZXhp c3RpbmcgSFRNTFByZWxvYWRTY2FubmVyIHRocmVhZGluZy1hd2FyZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFByZWxvYWRTY2FubmVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxQcmVsb2FkU2Nhbm5lci5jcHAKaW5kZXggOWZkZDE0NTU3 MDRmZTQxYWQxOGY5MmUxNzRmODE2M2QzYzFhNzg5MS4uM2Q3ODg4OWJmMWY3OTc4NjY1MjQ4MTcy NTkwOTU4YWJmMGZmOWZjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIv SFRNTFByZWxvYWRTY2FubmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9I VE1MUHJlbG9hZFNjYW5uZXIuY3BwCkBAIC01Myw5ICs1Myw5IEBAIHN0YXRpYyBib29sIGlzU3Rh cnRPckVuZFRhZyhjb25zdCBIVE1MVG9rZW4mIHRva2VuKQogICAgIHJldHVybiB0b2tlbi50eXBl KCkgPT0gSFRNTFRva2VuVHlwZXM6OkVuZFRhZyB8fCBpc1N0YXJ0VGFnKHRva2VuKTsKIH0KIAot Y2xhc3MgUHJlbG9hZFRhc2sgeworY2xhc3MgU3RhcnRUYWdTY2FubmVyIHsKIHB1YmxpYzoKLSAg ICBleHBsaWNpdCBQcmVsb2FkVGFzayhjb25zdCBBdG9taWNTdHJpbmcmIHRhZ05hbWUsIGNvbnN0 IEhUTUxUb2tlbjo6QXR0cmlidXRlTGlzdCYgYXR0cmlidXRlcykKKyAgICBleHBsaWNpdCBTdGFy dFRhZ1NjYW5uZXIoY29uc3QgQXRvbWljU3RyaW5nJiB0YWdOYW1lLCBjb25zdCBIVE1MVG9rZW46 OkF0dHJpYnV0ZUxpc3QmIGF0dHJpYnV0ZXMpCiAgICAgICAgIDogbV90YWdOYW1lKHRhZ05hbWUp CiAgICAgICAgICwgbV9saW5rSXNTdHlsZVNoZWV0KGZhbHNlKQogICAgICAgICAsIG1fbGlua01l ZGlhQXR0cmlidXRlSXNTY3JlZW4odHJ1ZSkKQEAgLTY5LDggKzY5LDcgQEAgcHVibGljOgogICAg ICAgICBpZiAobV90YWdOYW1lICE9IGltZ1RhZwogICAgICAgICAgICAgJiYgbV90YWdOYW1lICE9 IGlucHV0VGFnCiAgICAgICAgICAgICAmJiBtX3RhZ05hbWUgIT0gbGlua1RhZwotICAgICAgICAg ICAgJiYgbV90YWdOYW1lICE9IHNjcmlwdFRhZwotICAgICAgICAgICAgJiYgbV90YWdOYW1lICE9 IGJhc2VUYWcpCisgICAgICAgICAgICAmJiBtX3RhZ05hbWUgIT0gc2NyaXB0VGFnKQogICAgICAg ICAgICAgcmV0dXJuOwogCiAgICAgICAgIGZvciAoSFRNTFRva2VuOjpBdHRyaWJ1dGVMaXN0Ojpj b25zdF9pdGVyYXRvciBpdGVyID0gYXR0cmlidXRlcy5iZWdpbigpOwpAQCAtMjk5LDggKzI5OCw4 IEBAIHZvaWQgSFRNTFByZWxvYWRTY2FubmVyOjpwcm9jZXNzVG9rZW4oY29uc3QgSFRNTFRva2Vu JiB0b2tlbiwgVmVjdG9yPE93blB0cjxQcmVsCiAgICAgaWYgKHByb2Nlc3NQb3NzaWJsZUJhc2VU YWcodGFnTmFtZSwgdG9rZW4pKQogICAgICAgICByZXR1cm47CiAKLSAgICBQcmVsb2FkVGFzayB0 YXNrKHRhZ05hbWUsIHRva2VuLmF0dHJpYnV0ZXMoKSk7Ci0gICAgT3duUHRyPFByZWxvYWRSZXF1 ZXN0PiByZXF1ZXN0ID0gIHRhc2suY3JlYXRlUHJlbG9hZFJlcXVlc3QobV9wcmVkaWN0ZWRCYXNl RWxlbWVudFVSTCk7CisgICAgU3RhcnRUYWdTY2FubmVyIHNjYW5uZXIodGFnTmFtZSwgdG9rZW4u YXR0cmlidXRlcygpKTsKKyAgICBPd25QdHI8UHJlbG9hZFJlcXVlc3Q+IHJlcXVlc3QgPSAgc2Nh bm5lci5jcmVhdGVQcmVsb2FkUmVxdWVzdChtX3ByZWRpY3RlZEJhc2VFbGVtZW50VVJMKTsKICAg ICBpZiAocmVxdWVzdCkKICAgICAgICAgcmVxdWVzdHMuYXBwZW5kKHJlcXVlc3QucmVsZWFzZSgp KTsKIH0K