109401 2013-02-10 22:55:34 -0800 [chromium] add a destructor to EventSender 2013-02-11 01:04:41 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen haraken webkit.review.bot oldest_to_newest 829442 0 jochen 2013-02-10 22:55:34 -0800 [chromium] add a destructor to EventSender 829443 1 187515 jochen 2013-02-10 22:57:25 -0800 Created attachment 187515 Patch 829463 2 187515 haraken 2013-02-11 00:09:18 -0800 Comment on attachment 187515 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187515&action=review > Tools/ChangeLog:7 > + Please describe the rationale for adding a destructor, as we discussed offline. 829467 3 187519 jochen 2013-02-11 00:13:12 -0800 Created attachment 187519 Patch for landing 829483 4 187519 webkit.review.bot 2013-02-11 01:04:37 -0800 Comment on attachment 187519 Patch for landing Clearing flags on attachment: 187519 Committed r142437: <http://trac.webkit.org/changeset/142437> 829484 5 webkit.review.bot 2013-02-11 01:04:41 -0800 All reviewed patches have been landed. Closing bug. 187515 2013-02-10 22:57:25 -0800 2013-02-11 00:13:09 -0800 Patch bug-109401-20130211075356.patch text/plain 2419 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNDMwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzcwZTI5ZmNhOTQzYTI5ZDA1Njg1YTRmNjZhN2YxMDgy ODRiMzJjMi4uMzljZWQ4OGM0MGRjMzM2MjI2NGQzMmQ0Nzg0Njg4MWNjYTA3NDZlNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTAyLTEwICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFtjaHJvbWl1bV0gYWRkIGEgZGVzdHJ1Y3RvciB0byBFdmVudFNlbmRlcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5NDAxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL3NyYy9FdmVudFNlbmRlci5jcHA6CisgICAgICAgIChX ZWJUZXN0UnVubmVyKToKKyAgICAgICAgKFdlYlRlc3RSdW5uZXI6OkV2ZW50U2VuZGVyOjp+RXZl bnRTZW5kZXIpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIv c3JjL0V2ZW50U2VuZGVyLmg6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAoRXZlbnRTZW5k ZXIpOgorCiAyMDEzLTAyLTEwICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQgYXR0ZW1wdGVkIGJ1aWxkIGZpeCBmb3IgR3RrIGFmdGVy IHIxNDI0MTIKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RS dW5uZXIvc3JjL0V2ZW50U2VuZGVyLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVt L1Rlc3RSdW5uZXIvc3JjL0V2ZW50U2VuZGVyLmNwcAppbmRleCBkZjYxYjMyNmM4MjhkZDgxYzk1 OTJjNGI5NWU0NGQxYWVlZTJkZWQ3Li4zODRlY2I5YTVhZjlkNjI0ZjFlNTFmMWUyNjNkNjYwYTIy NWQ1NmYzIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVu bmVyL3NyYy9FdmVudFNlbmRlci5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21p dW0vVGVzdFJ1bm5lci9zcmMvRXZlbnRTZW5kZXIuY3BwCkBAIC0zMTksNiArMzE5LDEwIEBAIEV2 ZW50U2VuZGVyOjpFdmVudFNlbmRlcigpCiAjZW5kaWYKIH0KIAorRXZlbnRTZW5kZXI6On5FdmVu dFNlbmRlcigpCit7Cit9CisKIHZvaWQgRXZlbnRTZW5kZXI6OnNldENvbnRleHRNZW51RGF0YShj b25zdCBXZWJDb250ZXh0TWVudURhdGEmIGNvbnRleHRNZW51RGF0YSkKIHsKICAgICBtX2xhc3RD b250ZXh0TWVudURhdGEgPSBhdXRvX3B0cjxXZWJDb250ZXh0TWVudURhdGE+KG5ldyBXZWJDb250 ZXh0TWVudURhdGEoY29udGV4dE1lbnVEYXRhKSk7CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVu ZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL3NyYy9FdmVudFNlbmRlci5oIGIvVG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9zcmMvRXZlbnRTZW5kZXIuaAppbmRleCA5 OTVkOTk3MWE1OTIyYmUyOTBhM2M2OWQ0MGVkZjg3MDVmYWIxYmMzLi45YjM2YjVmYzMxYWEzOWQ3 YmU3N2ZlYzc2NzBkOTIxMjQzZTkzZjM2IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9UZXN0UnVubmVyL3NyYy9FdmVudFNlbmRlci5oCisrKyBiL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvc3JjL0V2ZW50U2VuZGVyLmgKQEAgLTM4LDcg KzM4LDYgQEAKICNkZWZpbmUgRXZlbnRTZW5kZXJfaAogCiAjaW5jbHVkZSAiQ3BwQm91bmRDbGFz cy5oIgotI2luY2x1ZGUgIldlYkNvbnRleHRNZW51RGF0YS5oIgogI2luY2x1ZGUgIldlYkRyYWdP cGVyYXRpb24uaCIKICNpbmNsdWRlICJXZWJJbnB1dEV2ZW50LmgiCiAjaW5jbHVkZSAiV2ViVGFz ay5oIgpAQCAtNDgsNiArNDcsNyBAQAogbmFtZXNwYWNlIFdlYktpdCB7CiBjbGFzcyBXZWJEcmFn RGF0YTsKIGNsYXNzIFdlYlZpZXc7CitzdHJ1Y3QgV2ViQ29udGV4dE1lbnVEYXRhOwogfQogCiBu YW1lc3BhY2UgV2ViVGVzdFJ1bm5lciB7CkBAIC01Nyw2ICs1Nyw3IEBAIGNsYXNzIFdlYlRlc3RE ZWxlZ2F0ZTsKIGNsYXNzIEV2ZW50U2VuZGVyIDogcHVibGljIENwcEJvdW5kQ2xhc3MgewogcHVi bGljOgogICAgIEV2ZW50U2VuZGVyKCk7CisgICAgfkV2ZW50U2VuZGVyKCk7CiAKICAgICB2b2lk IHNldERlbGVnYXRlKFdlYlRlc3REZWxlZ2F0ZSogZGVsZWdhdGUpIHsgbV9kZWxlZ2F0ZSA9IGRl bGVnYXRlOyB9CiAgICAgdm9pZCBzZXRXZWJWaWV3KFdlYktpdDo6V2ViVmlldyogd2ViVmlldykg eyBtX3dlYlZpZXcgPSB3ZWJWaWV3OyB9Cg== 187519 2013-02-11 00:13:12 -0800 2013-02-11 01:04:37 -0800 Patch for landing bug-109401-20130211090943.patch text/plain 2591 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNDMwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzcwZTI5ZmNhOTQzYTI5ZDA1Njg1YTRmNjZhN2YxMDgy ODRiMzJjMi4uYWIxMTI4NDUyN2I5MzEzNTRhYWUxNDcxMmUyNjQ1Y2Q5MmVhNzE3YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEzLTAyLTEwICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFtjaHJvbWl1bV0gYWRkIGEgZGVzdHJ1Y3RvciB0byBFdmVudFNlbmRlcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5NDAxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgS2VudGFybyBIYXJhLgorCisgICAgICAgIE90aGVyd2lzZSwgdGhl IGNvbXBpbGVyIHdpbGwgYXV0b21hdGljYWxseSBnZW5lcmF0ZSBhIGRlc3RydWN0b3IsIGZvcgor ICAgICAgICB3aGljaCB3ZSBuZWVkIHRvIHVubmVjZXNzYXJpbHkgaW5jbHVkZSBXZWJDb250ZXh0 TWVudURhdGEuaCBpbiB0aGUKKyAgICAgICAgaGVhZGVyLgorCisgICAgICAgICogRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9zcmMvRXZlbnRTZW5kZXIuY3BwOgorICAgICAgICAo V2ViVGVzdFJ1bm5lcik6CisgICAgICAgIChXZWJUZXN0UnVubmVyOjpFdmVudFNlbmRlcjo6fkV2 ZW50U2VuZGVyKToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVy L3NyYy9FdmVudFNlbmRlci5oOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKEV2ZW50U2Vu ZGVyKToKKwogMjAxMy0wMi0xMCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkIGF0dGVtcHRlZCBidWlsZCBmaXggZm9yIEd0ayBhZnRl ciByMTQyNDEyCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0 UnVubmVyL3NyYy9FdmVudFNlbmRlci5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1 bS9UZXN0UnVubmVyL3NyYy9FdmVudFNlbmRlci5jcHAKaW5kZXggZGY2MWIzMjZjODI4ZGQ4MWM5 NTkyYzRiOTVlNDRkMWFlZWUyZGVkNy4uMzg0ZWNiOWE1YWY5ZDYyNGYxZTUxZjFlMjYzZDY2MGEy MjVkNTZmMyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFJ1 bm5lci9zcmMvRXZlbnRTZW5kZXIuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9t aXVtL1Rlc3RSdW5uZXIvc3JjL0V2ZW50U2VuZGVyLmNwcApAQCAtMzE5LDYgKzMxOSwxMCBAQCBF dmVudFNlbmRlcjo6RXZlbnRTZW5kZXIoKQogI2VuZGlmCiB9CiAKK0V2ZW50U2VuZGVyOjp+RXZl bnRTZW5kZXIoKQoreworfQorCiB2b2lkIEV2ZW50U2VuZGVyOjpzZXRDb250ZXh0TWVudURhdGEo Y29uc3QgV2ViQ29udGV4dE1lbnVEYXRhJiBjb250ZXh0TWVudURhdGEpCiB7CiAgICAgbV9sYXN0 Q29udGV4dE1lbnVEYXRhID0gYXV0b19wdHI8V2ViQ29udGV4dE1lbnVEYXRhPihuZXcgV2ViQ29u dGV4dE1lbnVEYXRhKGNvbnRleHRNZW51RGF0YSkpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9zcmMvRXZlbnRTZW5kZXIuaCBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvc3JjL0V2ZW50U2VuZGVyLmgKaW5kZXgg OTk1ZDk5NzFhNTkyMmJlMjkwYTNjNjlkNDBlZGY4NzA1ZmFiMWJjMy4uOWIzNmI1ZmMzMWFhMzlk N2JlNzdmZWM3NjcwZDkyMTI0M2U5M2YzNiAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRy ZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9zcmMvRXZlbnRTZW5kZXIuaAorKysgYi9Ub29scy9EdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL3NyYy9FdmVudFNlbmRlci5oCkBAIC0zOCw3 ICszOCw2IEBACiAjZGVmaW5lIEV2ZW50U2VuZGVyX2gKIAogI2luY2x1ZGUgIkNwcEJvdW5kQ2xh c3MuaCIKLSNpbmNsdWRlICJXZWJDb250ZXh0TWVudURhdGEuaCIKICNpbmNsdWRlICJXZWJEcmFn T3BlcmF0aW9uLmgiCiAjaW5jbHVkZSAiV2ViSW5wdXRFdmVudC5oIgogI2luY2x1ZGUgIldlYlRh c2suaCIKQEAgLTQ4LDYgKzQ3LDcgQEAKIG5hbWVzcGFjZSBXZWJLaXQgewogY2xhc3MgV2ViRHJh Z0RhdGE7CiBjbGFzcyBXZWJWaWV3Oworc3RydWN0IFdlYkNvbnRleHRNZW51RGF0YTsKIH0KIAog bmFtZXNwYWNlIFdlYlRlc3RSdW5uZXIgewpAQCAtNTcsNiArNTcsNyBAQCBjbGFzcyBXZWJUZXN0 RGVsZWdhdGU7CiBjbGFzcyBFdmVudFNlbmRlciA6IHB1YmxpYyBDcHBCb3VuZENsYXNzIHsKIHB1 YmxpYzoKICAgICBFdmVudFNlbmRlcigpOworICAgIH5FdmVudFNlbmRlcigpOwogCiAgICAgdm9p ZCBzZXREZWxlZ2F0ZShXZWJUZXN0RGVsZWdhdGUqIGRlbGVnYXRlKSB7IG1fZGVsZWdhdGUgPSBk ZWxlZ2F0ZTsgfQogICAgIHZvaWQgc2V0V2ViVmlldyhXZWJLaXQ6OldlYlZpZXcqIHdlYlZpZXcp IHsgbV93ZWJWaWV3ID0gd2ViVmlldzsgfQo=