10940 2006-09-19 17:14:36 -0700 REGRESSION: WebKit crashes when opening a PDF in a new window 2006-09-19 19:51:22 -0700 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 VERIFIED FIXED http://www.math.tamu.edu/~austin/wirmath151.html Regression P1 Normal --- 1 mrowe mrowe tyler oldest_to_newest 55963 0 mrowe 2006-09-19 17:14:36 -0700 Steps to reproduce: 1) Visit http://www.math.tamu.edu/~austin/wirmath151.html 2) Right click on 'Week 1 in Review' and select "Open Link in New Window" 3) *boom* Backtrace follows. Exception: EXC_BAD_ACCESS (0x0001) Codes: KERN_PROTECTION_FAILURE (0x0002) at 0x000006f4 Thread 0 Crashed: 0 com.apple.WebCore 0x0111095d WebCore::Document::iconURL() + 9 1 com.apple.WebCore 0x010f107b WebCore::Frame::iconURL() + 99 2 com.apple.WebCore 0x010f16a1 WebCore::Frame::endIfNotLoading() + 293 3 com.apple.WebKit 0x00379fe3 -[WebFrameLoader _finishedLoading] + 73 4 com.apple.WebKit 0x0037d281 -[WebMainResourceLoader didFinishLoading] + 55 5 com.apple.WebKit 0x0037c1f2 -[WebLoader connectionDidFinishLoading:] + 40 6 com.apple.Foundation 0x9278fa6c -[NSURLConnection(NSURLConnectionInternal) _sendDidFinishLoadingCallback] + 176 7 com.apple.Foundation 0x9278db15 -[NSURLConnection(NSURLConnectionInternal) _sendCallbacks] + 748 8 com.apple.Foundation 0x9278d7b3 _sendCallbacks + 201 9 com.apple.CoreFoundation 0x90823379 CFRunLoopRunSpecific + 1213 10 com.apple.CoreFoundation 0x90822eb5 CFRunLoopRunInMode + 61 11 com.apple.HIToolbox 0x92f02b90 RunCurrentEventLoopInMode + 285 12 com.apple.HIToolbox 0x92f02297 ReceiveNextEventCommon + 385 13 com.apple.HIToolbox 0x92f020ee BlockUntilNextEventMatchingListInMode + 81 14 com.apple.AppKit 0x933a3771 _DPSNextEvent + 576 15 com.apple.AppKit 0x933a335e -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 137 16 com.apple.Safari 0x00006f96 0x1000 + 24470 17 com.apple.AppKit 0x9339d0e3 -[NSApplication run] + 512 18 com.apple.AppKit 0x93391037 NSApplicationMain + 573 19 com.apple.Safari 0x0005f7de 0x1000 + 387038 20 com.apple.Safari 0x0005f6f9 0x1000 + 386809 55965 1 beidson 2006-09-19 17:18:26 -0700 When you open a PDF in a new frame, that frame doesn't have a Document, but we don't check for a NULL document() Patch is coming very shortly 55966 2 tyler 2006-09-19 17:19:49 -0700 (In reply to comment #0) > Steps to reproduce: > Thanks Mark, I'm not in a good mood today, exam tomorrow ;) 55969 3 10656 beidson 2006-09-19 17:37:37 -0700 Created attachment 10656 The Fix! After determining the root of the problem, thankfully t'was a one-liner fix 55970 4 10656 kmccullough 2006-09-19 17:45:14 -0700 Comment on attachment 10656 The Fix! looks sweet 55971 5 beidson 2006-09-19 17:46:59 -0700 Submitted in r16457, please verify 55990 6 mrowe 2006-09-19 19:51:22 -0700 Excellent! 10656 2006-09-19 17:37:37 -0700 2006-09-19 17:45:14 -0700 The Fix! patch.txt text/plain 1115 beidson SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDU2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDYtMDkt MTkgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2lu Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5NDAKKyAgICAgICAgT3BlbmluZyBhIFBERiBpbiBhIG5l dyB0YWIvd2luZG93IGNyZWF0ZXMgYSBkb2N1bWVudGxlc3MtZnJhbWUKKyAgICAgICAgYW5kIHdl IGRlcmVmIHRoZSBkb2N1bWVudCB3aXRob3V0IGNoZWNraW5nIGl0cyB2YWxpZGl0eQorCisgICAg ICAgICogcGFnZS9GcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZTo6aWNvblVSTCk6 CisKIDIwMDYtMDktMTkgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2FyY2lhQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBoYXJyaXNvbgpJbmRleDogcGFnZS9GcmFtZS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gcGFnZS9GcmFtZS5jcHAJKHJldmlzaW9uIDE2NDUzKQorKysgcGFnZS9GcmFt ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIzMSw3ICsyMzEsNyBAQAogICAgICAgICByZXR1cm4g IiI7CiAgICAgICAgIAogICAgIC8vIElmIHdlIGhhdmUgYW4gaWNvblVSTCBmcm9tIGEgTGluayBl bGVtZW50LCByZXR1cm4gdGhhdAotICAgIGlmICghZG9jdW1lbnQoKS0+aWNvblVSTCgpLmlzRW1w dHkoKSkKKyAgICBpZiAoZG9jdW1lbnQoKSAmJiAhZG9jdW1lbnQoKS0+aWNvblVSTCgpLmlzRW1w dHkoKSkKICAgICAgICAgcmV0dXJuIEtVUkwoZG9jdW1lbnQoKS0+aWNvblVSTCgpLmRlcHJlY2F0 ZWRTdHJpbmcoKSk7CiAgICAgICAgIAogICAgIC8vIERvbid0IHJldHVybiBhIGZhdmljb24gaWNv blVSTCB1bmxlc3Mgd2UncmUgaHR0cCBvciBodHRwcwo=