109381 2013-02-10 11:18:15 -0800 WKTR should propagate view creation options to opened windows 2013-02-12 19:37:25 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton simon.fraser oldest_to_newest 829319 0 thorton 2013-02-10 11:18:15 -0800 The options dictionary is dropped on the floor for window.open'd windows, but it would be nice if it weren't. 829320 1 187487 thorton 2013-02-10 11:21:45 -0800 Created attachment 187487 patch 829321 2 187487 simon.fraser 2013-02-10 11:24:28 -0800 Comment on attachment 187487 patch View in context: https://bugs.webkit.org/attachment.cgi?id=187487&action=review > Tools/ChangeLog:3 > + WKTR should propagate view creation options to subviews ''to subviews isn't quite accurate. "to opened windows"? 829322 3 thorton 2013-02-10 11:25:42 -0800 Yeah, it's a bit weird. I've been flopping between calling them subviews and subwindows :| It's really "to PlatformWebViews in subwindows". I'll go with "to opened windows". Thanks! 829323 4 thorton 2013-02-10 11:29:09 -0800 http://trac.webkit.org/changeset/142412 187487 2013-02-10 11:21:45 -0800 2013-02-10 11:24:28 -0800 patch wktr.diff text/plain 5463 thorton ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1Y2E5 MGJiLi5iMWU5MDIxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTMtMDItMTAgIFRpbSBIb3J0b24gIDx0aW1vdGh5 X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgV0tUUiBzaG91bGQgcHJvcGFnYXRlIHZpZXcg Y3JlYXRpb24gb3B0aW9ucyB0byBzdWJ2aWV3cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5MzgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1BsYXRmb3JtV2ViVmlldy5o OgorICAgICAgICAoV1RSOjpQbGF0Zm9ybVdlYlZpZXc6Om9wdGlvbnMpOgorICAgICAgICBBZGQg c3RvcmFnZSBhbmQgYSBnZXR0ZXIgZm9yIFBsYXRmb3JtV2ViVmlldydzIGNyZWF0aW9uIG9wdGlv bnMgZGljdGlvbmFyeS4KKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVy LmNwcDoKKyAgICAgICAgKFdUUjo6VGVzdENvbnRyb2xsZXI6OmNyZWF0ZU90aGVyUGFnZSk6Cisg ICAgICAgIFByb3BhZ2F0ZSBjcmVhdGlvbiBvcHRpb25zIGZyb20gcGFyZW50IHRvIGNoaWxkIFBs YXRmb3JtV2ViVmlldyB3aGVuIGNyZWF0aW5nIHN1YndpbmRvd3MuCisgICAgICAgICogV2ViS2l0 VGVzdFJ1bm5lci9lZmwvUGxhdGZvcm1XZWJWaWV3RWZsLmNwcDoKKyAgICAgICAgKFdUUjo6UGxh dGZvcm1XZWJWaWV3OjpQbGF0Zm9ybVdlYlZpZXcpOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5u ZXIvZ3RrL1BsYXRmb3JtV2ViVmlld0d0ay5jcHA6CisgICAgICAgIChXVFI6OlBsYXRmb3JtV2Vi Vmlldzo6UGxhdGZvcm1XZWJWaWV3KToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL21hYy9Q bGF0Zm9ybVdlYlZpZXdNYWMubW06CisgICAgICAgIChXVFI6OlBsYXRmb3JtV2ViVmlldzo6UGxh dGZvcm1XZWJWaWV3KToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL3F0L1BsYXRmb3JtV2Vi Vmlld1F0LmNwcDoKKyAgICAgICAgKFdUUjo6UGxhdGZvcm1XZWJWaWV3OjpQbGF0Zm9ybVdlYlZp ZXcpOgorICAgICAgICBTdG9yZSBjcmVhdGlvbiBvcHRpb25zIG9uIHRoZSBQbGF0Zm9ybVdlYlZp ZXcuCisKIDIwMTMtMDItMDkgIERhdmlkIEZhcmxlciAgPGRmYXJsZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIE1ha2UgVGVzdFdlYktpdEFQSSB3b3JrIGZvciBpT1MKZGlmZiAtLWdpdCBhL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1XZWJWaWV3LmggYi9Ub29scy9XZWJLaXRUZXN0UnVu bmVyL1BsYXRmb3JtV2ViVmlldy5oCmluZGV4IDUxYzRiY2MuLjM3Y2RmY2YgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1XZWJWaWV3LmgKKysrIGIvVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9QbGF0Zm9ybVdlYlZpZXcuaApAQCAtOTUsMTEgKzk1LDEzIEBAIHB1Ymxp YzoKICNlbmRpZgogCiAgICAgV0tSZXRhaW5QdHI8V0tJbWFnZVJlZj4gd2luZG93U25hcHNob3RJ bWFnZSgpOworICAgIFdLRGljdGlvbmFyeVJlZiBvcHRpb25zKCkgY29uc3QgeyByZXR1cm4gbV9v cHRpb25zLmdldCgpOyB9CiAKIHByaXZhdGU6CiAgICAgUGxhdGZvcm1XS1ZpZXcgbV92aWV3Owog ICAgIFBsYXRmb3JtV2luZG93IG1fd2luZG93OwogICAgIGJvb2wgbV93aW5kb3dJc0tleTsKKyAg ICBXS1JldGFpblB0cjxXS0RpY3Rpb25hcnlSZWY+IG1fb3B0aW9uczsKICNpZiBQTEFURk9STShF RkwpIHx8IFBMQVRGT1JNKFFUKQogICAgIGJvb2wgbV91c2luZ0ZpeGVkTGF5b3V0OwogI2VuZGlm CmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcCBi L1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCmluZGV4IGEzNzc5YWQu LjY5Y2Q5NWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xs ZXIuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCkBA IC0xODAsOSArMTgwLDExIEBAIGludCBUZXN0Q29udHJvbGxlcjo6Z2V0Q3VzdG9tVGltZW91dCgp CiAgICAgcmV0dXJuIG1fdGltZW91dDsKIH0KIAotV0tQYWdlUmVmIFRlc3RDb250cm9sbGVyOjpj cmVhdGVPdGhlclBhZ2UoV0tQYWdlUmVmIG9sZFBhZ2UsIFdLVVJMUmVxdWVzdFJlZiwgV0tEaWN0 aW9uYXJ5UmVmLCBXS0V2ZW50TW9kaWZpZXJzLCBXS0V2ZW50TW91c2VCdXR0b24sIGNvbnN0IHZv aWQqKQorV0tQYWdlUmVmIFRlc3RDb250cm9sbGVyOjpjcmVhdGVPdGhlclBhZ2UoV0tQYWdlUmVm IG9sZFBhZ2UsIFdLVVJMUmVxdWVzdFJlZiwgV0tEaWN0aW9uYXJ5UmVmLCBXS0V2ZW50TW9kaWZp ZXJzLCBXS0V2ZW50TW91c2VCdXR0b24sIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCiB7Ci0gICAg UGxhdGZvcm1XZWJWaWV3KiB2aWV3ID0gbmV3IFBsYXRmb3JtV2ViVmlldyhXS1BhZ2VHZXRDb250 ZXh0KG9sZFBhZ2UpLCBXS1BhZ2VHZXRQYWdlR3JvdXAob2xkUGFnZSkpOworICAgIFBsYXRmb3Jt V2ViVmlldyogcGFyZW50VmlldyA9IHN0YXRpY19jYXN0PFBsYXRmb3JtV2ViVmlldyo+KGNvbnN0 X2Nhc3Q8dm9pZCo+KGNsaWVudEluZm8pKTsKKworICAgIFBsYXRmb3JtV2ViVmlldyogdmlldyA9 IG5ldyBQbGF0Zm9ybVdlYlZpZXcoV0tQYWdlR2V0Q29udGV4dChvbGRQYWdlKSwgV0tQYWdlR2V0 UGFnZUdyb3VwKG9sZFBhZ2UpLCBwYXJlbnRWaWV3LT5vcHRpb25zKCkpOwogICAgIFdLUGFnZVJl ZiBuZXdQYWdlID0gdmlldy0+cGFnZSgpOwogCiAgICAgdmlldy0+cmVzaXplVG8oODAwLCA2MDAp OwpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwvUGxhdGZvcm1XZWJWaWV3 RWZsLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZWZsL1BsYXRmb3JtV2ViVmlld0VmbC5j cHAKaW5kZXggNjhiMjY5NS4uZWIxZjA0YiAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9lZmwvUGxhdGZvcm1XZWJWaWV3RWZsLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVu bmVyL2VmbC9QbGF0Zm9ybVdlYlZpZXdFZmwuY3BwCkBAIC01Myw2ICs1Myw3IEBAIHN0YXRpYyBF Y29yZV9FdmFzKiBpbml0RWNvcmVFdmFzKCkKIH0KIAogUGxhdGZvcm1XZWJWaWV3OjpQbGF0Zm9y bVdlYlZpZXcoV0tDb250ZXh0UmVmIGNvbnRleHQsIFdLUGFnZUdyb3VwUmVmIHBhZ2VHcm91cCwg V0tEaWN0aW9uYXJ5UmVmIG9wdGlvbnMpCisgICAgOiBtX29wdGlvbnMob3B0aW9ucykKIHsKICAg ICBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4gdXNlRml4ZWRMYXlvdXRLZXkoQWRvcHRXSywgV0tT dHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoIlVzZUZpeGVkTGF5b3V0IikpOwogICAgIG1fdXNp bmdGaXhlZExheW91dCA9IG9wdGlvbnMgPyBXS0Jvb2xlYW5HZXRWYWx1ZShzdGF0aWNfY2FzdDxX S0Jvb2xlYW5SZWY+KFdLRGljdGlvbmFyeUdldEl0ZW1Gb3JLZXkob3B0aW9ucywgdXNlRml4ZWRM YXlvdXRLZXkuZ2V0KCkpKSkgOiBmYWxzZTsKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvZ3RrL1BsYXRmb3JtV2ViVmlld0d0ay5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVy L2d0ay9QbGF0Zm9ybVdlYlZpZXdHdGsuY3BwCmluZGV4IGJiZWYwNGUuLjVkYjZmNTMgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL1BsYXRmb3JtV2ViVmlld0d0ay5jcHAK KysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9ndGsvUGxhdGZvcm1XZWJWaWV3R3RrLmNwcApA QCAtMzcsNiArMzcsNyBAQCBQbGF0Zm9ybVdlYlZpZXc6OlBsYXRmb3JtV2ViVmlldyhXS0NvbnRl eHRSZWYgY29udGV4dCwgV0tQYWdlR3JvdXBSZWYgcGFnZUdyb3VwLAogICAgIDogbV92aWV3KFdL Vmlld0NyZWF0ZShjb250ZXh0LCBwYWdlR3JvdXApKQogICAgICwgbV93aW5kb3coZ3RrX3dpbmRv d19uZXcoR1RLX1dJTkRPV19QT1BVUCkpCiAgICAgLCBtX3dpbmRvd0lzS2V5KHRydWUpCisgICAg LCBtX29wdGlvbnMob3B0aW9ucykKIHsKICAgICBndGtfY29udGFpbmVyX2FkZChHVEtfQ09OVEFJ TkVSKG1fd2luZG93KSwgR1RLX1dJREdFVChtX3ZpZXcpKTsKIApkaWZmIC0tZ2l0IGEvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9tYWMvUGxhdGZvcm1XZWJWaWV3TWFjLm1tIGIvVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9tYWMvUGxhdGZvcm1XZWJWaWV3TWFjLm1tCmluZGV4IDk4MTUwYjEuLjZmYWNk ZDQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1BsYXRmb3JtV2ViVmll d01hYy5tbQorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdN YWMubW0KQEAgLTEwNyw2ICsxMDcsNyBAQCBuYW1lc3BhY2UgV1RSIHsKIAogUGxhdGZvcm1XZWJW aWV3OjpQbGF0Zm9ybVdlYlZpZXcoV0tDb250ZXh0UmVmIGNvbnRleHRSZWYsIFdLUGFnZUdyb3Vw UmVmIHBhZ2VHcm91cFJlZiwgV0tEaWN0aW9uYXJ5UmVmIG9wdGlvbnMpCiAgICAgOiBtX3dpbmRv d0lzS2V5KHRydWUpCisgICAgLCBtX29wdGlvbnMob3B0aW9ucykKIHsKICAgICBXS1JldGFpblB0 cjxXS1N0cmluZ1JlZj4gdXNlVGlsZWREcmF3aW5nS2V5KEFkb3B0V0ssIFdLU3RyaW5nQ3JlYXRl V2l0aFVURjhDU3RyaW5nKCJUaWxlZERyYXdpbmciKSk7CiAgICAgV0tUeXBlUmVmIHVzZVRpbGVk RHJhd2luZ1ZhbHVlID0gb3B0aW9ucyA/IFdLRGljdGlvbmFyeUdldEl0ZW1Gb3JLZXkob3B0aW9u cywgdXNlVGlsZWREcmF3aW5nS2V5LmdldCgpKSA6IE5VTEw7CmRpZmYgLS1naXQgYS9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL3F0L1BsYXRmb3JtV2ViVmlld1F0LmNwcCBiL1Rvb2xzL1dlYktpdFRl c3RSdW5uZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQuY3BwCmluZGV4IDQ3ZDQwN2UuLjhmMzAyOTkg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQu Y3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQuY3Bw CkBAIC03OSw2ICs3OSw3IEBAIHByaXZhdGU6CiAKIFBsYXRmb3JtV2ViVmlldzo6UGxhdGZvcm1X ZWJWaWV3KFdLQ29udGV4dFJlZiBjb250ZXh0UmVmLCBXS1BhZ2VHcm91cFJlZiBwYWdlR3JvdXBS ZWYsIFdLRGljdGlvbmFyeVJlZiBvcHRpb25zKQogICAgIDogbV93aW5kb3dJc0tleSh0cnVlKQor ICAgICwgbV9vcHRpb25zKG9wdGlvbnMpCiAgICAgLCBtX21vZGFsRXZlbnRMb29wKDApCiB7CiAg ICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IHVzZUZpeGVkTGF5b3V0S2V5KEFkb3B0V0ssIFdL U3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJVc2VGaXhlZExheW91dCIpKTsK