109374 2013-02-10 01:04:47 -0800 [chromium] Fix Android scrollbar size 2013-02-10 18:55:55 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aelias aelias aelias dglazkov jamesr peter+ews trchen webkit.review.bot oldest_to_newest 829242 0 aelias 2013-02-10 01:04:47 -0800 [chromium] Fix Android scrollbar size 829244 1 187469 aelias 2013-02-10 01:09:46 -0800 Created attachment 187469 Patch 829246 2 187469 peter+ews 2013-02-10 01:21:47 -0800 Comment on attachment 187469 Patch Attachment 187469 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16468789 829348 3 187469 jamesr 2013-02-10 13:48:59 -0800 Comment on attachment 187469 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187469&action=review > Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp:114 > + context->fillRect(centerRect, Color(128, 128, 128, 128), ColorSpaceDeviceRGB); as EWS points out, this doesn't compile. What did you mean here instead of centerRect? thumbRect ? 829349 4 187469 jamesr 2013-02-10 13:50:35 -0800 Comment on attachment 187469 Patch Could you just extend the thumb rect out very slightly to get some edge AA? R=me if you make it compile 829387 5 187502 aelias 2013-02-10 17:58:07 -0800 Created attachment 187502 Patch Fix compile error (centerRect->thumbRect) 829390 6 187503 aelias 2013-02-10 18:00:24 -0800 Created attachment 187503 Patch for landing 829392 7 aelias 2013-02-10 18:12:08 -0800 Just saw your edge AA comment. Tien-Ren is reimplementing this to use SolidColorQuad (since scrollbar texture management is proving a pain) so let's revisit there. 829397 8 187503 webkit.review.bot 2013-02-10 18:55:52 -0800 Comment on attachment 187503 Patch for landing Clearing flags on attachment: 187503 Committed r142423: <http://trac.webkit.org/changeset/142423> 829398 9 webkit.review.bot 2013-02-10 18:55:55 -0800 All reviewed patches have been landed. Closing bug. 187469 2013-02-10 01:09:46 -0800 2013-02-10 17:58:06 -0800 Patch bug-109374-20130210010618.patch text/plain 3564 aelias U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTczZjljNjMxYmU1YTg3 NDFhNDBkOWMyZDVhYWNlYzA1M2NlODFjYS4uZTZlOTk4ZWI3MWY1NjIyMGZjMGU2Nzg3YjA1ZjRm MzM4YmU4MThlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAyLTEwICBBbGV4 YW5kcmUgRWxpYXMgIDxhZWxpYXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g Rml4IEFuZHJvaWQgc2Nyb2xsYmFyIHNpemUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwOTM3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoaXMgc2hyaW5rcyBzY3JvbGxiYXJzIHRvIDMgZGV2aWNlLWlu ZGVwZW5kZW50IHBpeGVscyAodXN1YWxseSA2CisgICAgICAgIHBoeXNpY2FsIHBpeGVscykgYW5k IGRlbGV0ZXMgdGhlIGVkZ2UgZmFkZS4gQWx0aG91Z2ggdGhlIEFuZHJvaWQKKyAgICAgICAgc3lz dGVtIHRoZW1lIGRvZXMgaGF2ZSBhbiBlZGdlIGZhZGUsIGl0J3MgYSBtdWNoIHNoYXJwZXIgY2xp ZmYKKyAgICAgICAgdGhhbiB3ZSBoYWQgKGFnYWluc3QgYmxhY2ssIHRoZSBjb2xvcnMgZ28gNjQg LT4gNjQgLT4gNTIgLT4gMjEgLT4gMCkKKyAgICAgICAgYW5kIEkgY2FuJ3QgcGVyY2VpdmUgYW55 IGRpZmZlcmVuY2UgY29tcGFyZWQgd2l0aCBubyBmYWRlIGF0IGFsbC4KKworICAgICAgICBObyBu ZXcgdGVzdHMgKGR1ZSBmb3IgcmV3cml0ZSBpbiBhIHdlZWsgYW55d2F5KS4KKworICAgICAgICAq IHBsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1BbmRyb2lkLmNwcDoKKyAg ICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVDaHJvbWl1 bUFuZHJvaWQ6OnBhaW50VGh1bWIpOgorCiAyMDEzLTAyLTA4ICBDaHJpcyBGbGVpemFjaCAgPGNm bGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmVmYWN0b3IgcGxhdGZvcm0tc3BlY2lmaWMg Y29kZSBpbiBTcGVlY2hTeW50aGVzaXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1BbmRyb2lkLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1BbmRyb2lkLmNw cAppbmRleCAyZTFmZWNjMWEzMjRiN2UxYjg3MDZmZjg1ZTA3NzA3MzYwZWRjMGQ4Li5mZDIxNzRm MzI1OTA1YWY2ZDVmYmJiNGQ5NWEwNjcxNTY0OTlkNWRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtQW5kcm9pZC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJv bWl1bUFuZHJvaWQuY3BwCkBAIC0zNyw4ICszNyw4IEBAIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CiAK IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotc3RhdGljIGNvbnN0IGludCBzY3JvbGxiYXJXaWR0aCA9 IDg7Ci1zdGF0aWMgY29uc3QgaW50IHNjcm9sbGJhck1hcmdpbiA9IDU7CitzdGF0aWMgY29uc3Qg aW50IHNjcm9sbGJhcldpZHRoID0gMzsKK3N0YXRpYyBjb25zdCBpbnQgc2Nyb2xsYmFyTWFyZ2lu ID0gNDsKIAogU2Nyb2xsYmFyVGhlbWUqIFNjcm9sbGJhclRoZW1lOjpuYXRpdmVUaGVtZSgpCiB7 CkBAIC0xMDQsMzcgKzEwNCw2IEBAIEludFJlY3QgU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bUFuZHJv aWQ6OnRyYWNrUmVjdChTY3JvbGxiYXJUaGVtZUNsaWVudCogc2Nyb2xsYmFyCiAgICAgcmV0dXJu IHJlY3Q7CiB9CiAKLXN0YXRpYyB2b2lkIGZpbGxTbW9vdGhFZGdlZFJlY3QoR3JhcGhpY3NDb250 ZXh0KiBjb250ZXh0LCBjb25zdCBJbnRSZWN0JiByZWN0LCBjb25zdCBDb2xvciYgY29sb3IpCi17 Ci0gICAgQ29sb3IgaGFsZkNvbG9yKGNvbG9yLnJlZCgpLCBjb2xvci5ncmVlbigpLCBjb2xvci5i bHVlKCksIGNvbG9yLmFscGhhKCkgLyAyKTsKLQotICAgIEludFJlY3QgdG9wUmVjdCA9IHJlY3Q7 Ci0gICAgdG9wUmVjdC5pbmZsYXRlWCgtMSk7Ci0gICAgdG9wUmVjdC5zZXRIZWlnaHQoMSk7Ci0g ICAgY29udGV4dC0+ZmlsbFJlY3QodG9wUmVjdCwgaGFsZkNvbG9yLCBDb2xvclNwYWNlRGV2aWNl UkdCKTsKLQotICAgIEludFJlY3QgbGVmdFJlY3QgPSByZWN0OwotICAgIGxlZnRSZWN0LmluZmxh dGVZKC0xKTsKLSAgICBsZWZ0UmVjdC5zZXRXaWR0aCgxKTsKLSAgICBjb250ZXh0LT5maWxsUmVj dChsZWZ0UmVjdCwgaGFsZkNvbG9yLCBDb2xvclNwYWNlRGV2aWNlUkdCKTsKLQotICAgIEludFJl Y3QgY2VudGVyUmVjdCA9IHJlY3Q7Ci0gICAgY2VudGVyUmVjdC5pbmZsYXRlKC0xKTsKLSAgICBj b250ZXh0LT5maWxsUmVjdChjZW50ZXJSZWN0LCBjb2xvciwgQ29sb3JTcGFjZURldmljZVJHQik7 Ci0KLSAgICBJbnRSZWN0IHJpZ2h0UmVjdCA9IHJlY3Q7Ci0gICAgcmlnaHRSZWN0LmluZmxhdGVZ KC0xKTsKLSAgICByaWdodFJlY3Quc2V0WChjZW50ZXJSZWN0Lm1heFgoKSk7Ci0gICAgcmlnaHRS ZWN0LnNldFdpZHRoKDEpOwotICAgIGNvbnRleHQtPmZpbGxSZWN0KHJpZ2h0UmVjdCwgaGFsZkNv bG9yLCBDb2xvclNwYWNlRGV2aWNlUkdCKTsKLQotICAgIEludFJlY3QgYm90dG9tUmVjdCA9IHJl Y3Q7Ci0gICAgYm90dG9tUmVjdC5pbmZsYXRlWCgtMSk7Ci0gICAgYm90dG9tUmVjdC5zZXRZKGNl bnRlclJlY3QubWF4WSgpKTsKLSAgICBib3R0b21SZWN0LnNldEhlaWdodCgxKTsKLSAgICBjb250 ZXh0LT5maWxsUmVjdChib3R0b21SZWN0LCBoYWxmQ29sb3IsIENvbG9yU3BhY2VEZXZpY2VSR0Ip OwotfQotCiB2b2lkIFNjcm9sbGJhclRoZW1lQ2hyb21pdW1BbmRyb2lkOjpwYWludFRodW1iKEdy YXBoaWNzQ29udGV4dCogY29udGV4dCwgU2Nyb2xsYmFyVGhlbWVDbGllbnQqIHNjcm9sbGJhciwg Y29uc3QgSW50UmVjdCYgcmVjdCkKIHsKICAgICBJbnRSZWN0IHRodW1iUmVjdCA9IHJlY3Q7CkBA IC0xNDIsNyArMTExLDcgQEAgdm9pZCBTY3JvbGxiYXJUaGVtZUNocm9taXVtQW5kcm9pZDo6cGFp bnRUaHVtYihHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIFNjcm9sbGIKICAgICAgICAgdGh1bWJS ZWN0LnNldEhlaWdodCh0aHVtYlJlY3QuaGVpZ2h0KCkgLSBzY3JvbGxiYXJNYXJnaW4pOwogICAg IGVsc2UKICAgICAgICAgdGh1bWJSZWN0LnNldFdpZHRoKHRodW1iUmVjdC53aWR0aCgpIC0gc2Ny b2xsYmFyTWFyZ2luKTsKLSAgICBmaWxsU21vb3RoRWRnZWRSZWN0KGNvbnRleHQsIHRodW1iUmVj dCwgQ29sb3IoMTI4LCAxMjgsIDEyOCwgMTI4KSk7CisgICAgY29udGV4dC0+ZmlsbFJlY3QoY2Vu dGVyUmVjdCwgQ29sb3IoMTI4LCAxMjgsIDEyOCwgMTI4KSwgQ29sb3JTcGFjZURldmljZVJHQik7 CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK 187502 2013-02-10 17:58:07 -0800 2013-02-10 18:00:21 -0800 Patch bug-109374-20130210175439.patch text/plain 3563 aelias U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTczZjljNjMxYmU1YTg3 NDFhNDBkOWMyZDVhYWNlYzA1M2NlODFjYS4uZTZlOTk4ZWI3MWY1NjIyMGZjMGU2Nzg3YjA1ZjRm MzM4YmU4MThlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAyLTEwICBBbGV4 YW5kcmUgRWxpYXMgIDxhZWxpYXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g Rml4IEFuZHJvaWQgc2Nyb2xsYmFyIHNpemUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwOTM3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoaXMgc2hyaW5rcyBzY3JvbGxiYXJzIHRvIDMgZGV2aWNlLWlu ZGVwZW5kZW50IHBpeGVscyAodXN1YWxseSA2CisgICAgICAgIHBoeXNpY2FsIHBpeGVscykgYW5k IGRlbGV0ZXMgdGhlIGVkZ2UgZmFkZS4gQWx0aG91Z2ggdGhlIEFuZHJvaWQKKyAgICAgICAgc3lz dGVtIHRoZW1lIGRvZXMgaGF2ZSBhbiBlZGdlIGZhZGUsIGl0J3MgYSBtdWNoIHNoYXJwZXIgY2xp ZmYKKyAgICAgICAgdGhhbiB3ZSBoYWQgKGFnYWluc3QgYmxhY2ssIHRoZSBjb2xvcnMgZ28gNjQg LT4gNjQgLT4gNTIgLT4gMjEgLT4gMCkKKyAgICAgICAgYW5kIEkgY2FuJ3QgcGVyY2VpdmUgYW55 IGRpZmZlcmVuY2UgY29tcGFyZWQgd2l0aCBubyBmYWRlIGF0IGFsbC4KKworICAgICAgICBObyBu ZXcgdGVzdHMgKGR1ZSBmb3IgcmV3cml0ZSBpbiBhIHdlZWsgYW55d2F5KS4KKworICAgICAgICAq IHBsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1BbmRyb2lkLmNwcDoKKyAg ICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVDaHJvbWl1 bUFuZHJvaWQ6OnBhaW50VGh1bWIpOgorCiAyMDEzLTAyLTA4ICBDaHJpcyBGbGVpemFjaCAgPGNm bGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmVmYWN0b3IgcGxhdGZvcm0tc3BlY2lmaWMg Y29kZSBpbiBTcGVlY2hTeW50aGVzaXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1BbmRyb2lkLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1BbmRyb2lkLmNw cAppbmRleCAyZTFmZWNjMWEzMjRiN2UxYjg3MDZmZjg1ZTA3NzA3MzYwZWRjMGQ4Li4wNjkxOTUx ZWY4MjdlZDI0ZWM2ZTUwNzJlZmY3NTdjZDFkOTliNmZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtQW5kcm9pZC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJv bWl1bUFuZHJvaWQuY3BwCkBAIC0zNyw4ICszNyw4IEBAIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CiAK IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotc3RhdGljIGNvbnN0IGludCBzY3JvbGxiYXJXaWR0aCA9 IDg7Ci1zdGF0aWMgY29uc3QgaW50IHNjcm9sbGJhck1hcmdpbiA9IDU7CitzdGF0aWMgY29uc3Qg aW50IHNjcm9sbGJhcldpZHRoID0gMzsKK3N0YXRpYyBjb25zdCBpbnQgc2Nyb2xsYmFyTWFyZ2lu ID0gNDsKIAogU2Nyb2xsYmFyVGhlbWUqIFNjcm9sbGJhclRoZW1lOjpuYXRpdmVUaGVtZSgpCiB7 CkBAIC0xMDQsMzcgKzEwNCw2IEBAIEludFJlY3QgU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bUFuZHJv aWQ6OnRyYWNrUmVjdChTY3JvbGxiYXJUaGVtZUNsaWVudCogc2Nyb2xsYmFyCiAgICAgcmV0dXJu IHJlY3Q7CiB9CiAKLXN0YXRpYyB2b2lkIGZpbGxTbW9vdGhFZGdlZFJlY3QoR3JhcGhpY3NDb250 ZXh0KiBjb250ZXh0LCBjb25zdCBJbnRSZWN0JiByZWN0LCBjb25zdCBDb2xvciYgY29sb3IpCi17 Ci0gICAgQ29sb3IgaGFsZkNvbG9yKGNvbG9yLnJlZCgpLCBjb2xvci5ncmVlbigpLCBjb2xvci5i bHVlKCksIGNvbG9yLmFscGhhKCkgLyAyKTsKLQotICAgIEludFJlY3QgdG9wUmVjdCA9IHJlY3Q7 Ci0gICAgdG9wUmVjdC5pbmZsYXRlWCgtMSk7Ci0gICAgdG9wUmVjdC5zZXRIZWlnaHQoMSk7Ci0g ICAgY29udGV4dC0+ZmlsbFJlY3QodG9wUmVjdCwgaGFsZkNvbG9yLCBDb2xvclNwYWNlRGV2aWNl UkdCKTsKLQotICAgIEludFJlY3QgbGVmdFJlY3QgPSByZWN0OwotICAgIGxlZnRSZWN0LmluZmxh dGVZKC0xKTsKLSAgICBsZWZ0UmVjdC5zZXRXaWR0aCgxKTsKLSAgICBjb250ZXh0LT5maWxsUmVj dChsZWZ0UmVjdCwgaGFsZkNvbG9yLCBDb2xvclNwYWNlRGV2aWNlUkdCKTsKLQotICAgIEludFJl Y3QgY2VudGVyUmVjdCA9IHJlY3Q7Ci0gICAgY2VudGVyUmVjdC5pbmZsYXRlKC0xKTsKLSAgICBj b250ZXh0LT5maWxsUmVjdChjZW50ZXJSZWN0LCBjb2xvciwgQ29sb3JTcGFjZURldmljZVJHQik7 Ci0KLSAgICBJbnRSZWN0IHJpZ2h0UmVjdCA9IHJlY3Q7Ci0gICAgcmlnaHRSZWN0LmluZmxhdGVZ KC0xKTsKLSAgICByaWdodFJlY3Quc2V0WChjZW50ZXJSZWN0Lm1heFgoKSk7Ci0gICAgcmlnaHRS ZWN0LnNldFdpZHRoKDEpOwotICAgIGNvbnRleHQtPmZpbGxSZWN0KHJpZ2h0UmVjdCwgaGFsZkNv bG9yLCBDb2xvclNwYWNlRGV2aWNlUkdCKTsKLQotICAgIEludFJlY3QgYm90dG9tUmVjdCA9IHJl Y3Q7Ci0gICAgYm90dG9tUmVjdC5pbmZsYXRlWCgtMSk7Ci0gICAgYm90dG9tUmVjdC5zZXRZKGNl bnRlclJlY3QubWF4WSgpKTsKLSAgICBib3R0b21SZWN0LnNldEhlaWdodCgxKTsKLSAgICBjb250 ZXh0LT5maWxsUmVjdChib3R0b21SZWN0LCBoYWxmQ29sb3IsIENvbG9yU3BhY2VEZXZpY2VSR0Ip OwotfQotCiB2b2lkIFNjcm9sbGJhclRoZW1lQ2hyb21pdW1BbmRyb2lkOjpwYWludFRodW1iKEdy YXBoaWNzQ29udGV4dCogY29udGV4dCwgU2Nyb2xsYmFyVGhlbWVDbGllbnQqIHNjcm9sbGJhciwg Y29uc3QgSW50UmVjdCYgcmVjdCkKIHsKICAgICBJbnRSZWN0IHRodW1iUmVjdCA9IHJlY3Q7CkBA IC0xNDIsNyArMTExLDcgQEAgdm9pZCBTY3JvbGxiYXJUaGVtZUNocm9taXVtQW5kcm9pZDo6cGFp bnRUaHVtYihHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIFNjcm9sbGIKICAgICAgICAgdGh1bWJS ZWN0LnNldEhlaWdodCh0aHVtYlJlY3QuaGVpZ2h0KCkgLSBzY3JvbGxiYXJNYXJnaW4pOwogICAg IGVsc2UKICAgICAgICAgdGh1bWJSZWN0LnNldFdpZHRoKHRodW1iUmVjdC53aWR0aCgpIC0gc2Ny b2xsYmFyTWFyZ2luKTsKLSAgICBmaWxsU21vb3RoRWRnZWRSZWN0KGNvbnRleHQsIHRodW1iUmVj dCwgQ29sb3IoMTI4LCAxMjgsIDEyOCwgMTI4KSk7CisgICAgY29udGV4dC0+ZmlsbFJlY3QodGh1 bWJSZWN0LCBDb2xvcigxMjgsIDEyOCwgMTI4LCAxMjgpLCBDb2xvclNwYWNlRGV2aWNlUkdCKTsK IH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 187503 2013-02-10 18:00:24 -0800 2013-02-10 18:55:52 -0800 Patch for landing bug-109374-20130210175656.patch text/plain 3563 aelias U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTczZjljNjMxYmU1YTg3 NDFhNDBkOWMyZDVhYWNlYzA1M2NlODFjYS4uYjIyZWZlYjAzZTJlMjZmYWZmNjY5MjAyZmM0YWY4 Mjg4ZmNhZjQxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAyLTEwICBBbGV4 YW5kcmUgRWxpYXMgIDxhZWxpYXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g Rml4IEFuZHJvaWQgc2Nyb2xsYmFyIHNpemUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwOTM3NAorCisgICAgICAgIFJldmlld2VkIGJ5IEphbWVzIFJv Ymluc29uLgorCisgICAgICAgIFRoaXMgc2hyaW5rcyBzY3JvbGxiYXJzIHRvIDMgZGV2aWNlLWlu ZGVwZW5kZW50IHBpeGVscyAodXN1YWxseSA2CisgICAgICAgIHBoeXNpY2FsIHBpeGVscykgYW5k IGRlbGV0ZXMgdGhlIGVkZ2UgZmFkZS4gQWx0aG91Z2ggdGhlIEFuZHJvaWQKKyAgICAgICAgc3lz dGVtIHRoZW1lIGRvZXMgaGF2ZSBhbiBlZGdlIGZhZGUsIGl0J3MgYSBtdWNoIHNoYXJwZXIgY2xp ZmYKKyAgICAgICAgdGhhbiB3ZSBoYWQgKGFnYWluc3QgYmxhY2ssIHRoZSBjb2xvcnMgZ28gNjQg LT4gNjQgLT4gNTIgLT4gMjEgLT4gMCkKKyAgICAgICAgYW5kIEkgY2FuJ3QgcGVyY2VpdmUgYW55 IGRpZmZlcmVuY2UgY29tcGFyZWQgd2l0aCBubyBmYWRlIGF0IGFsbC4KKworICAgICAgICBObyBu ZXcgdGVzdHMgKGR1ZSBmb3IgcmV3cml0ZSBpbiBhIHdlZWsgYW55d2F5KS4KKworICAgICAgICAq IHBsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1BbmRyb2lkLmNwcDoKKyAg ICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVDaHJvbWl1 bUFuZHJvaWQ6OnBhaW50VGh1bWIpOgorCiAyMDEzLTAyLTA4ICBDaHJpcyBGbGVpemFjaCAgPGNm bGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmVmYWN0b3IgcGxhdGZvcm0tc3BlY2lmaWMg Y29kZSBpbiBTcGVlY2hTeW50aGVzaXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1BbmRyb2lkLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1BbmRyb2lkLmNw cAppbmRleCAyZTFmZWNjMWEzMjRiN2UxYjg3MDZmZjg1ZTA3NzA3MzYwZWRjMGQ4Li4wNjkxOTUx ZWY4MjdlZDI0ZWM2ZTUwNzJlZmY3NTdjZDFkOTliNmZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtQW5kcm9pZC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJv bWl1bUFuZHJvaWQuY3BwCkBAIC0zNyw4ICszNyw4IEBAIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CiAK IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotc3RhdGljIGNvbnN0IGludCBzY3JvbGxiYXJXaWR0aCA9 IDg7Ci1zdGF0aWMgY29uc3QgaW50IHNjcm9sbGJhck1hcmdpbiA9IDU7CitzdGF0aWMgY29uc3Qg aW50IHNjcm9sbGJhcldpZHRoID0gMzsKK3N0YXRpYyBjb25zdCBpbnQgc2Nyb2xsYmFyTWFyZ2lu ID0gNDsKIAogU2Nyb2xsYmFyVGhlbWUqIFNjcm9sbGJhclRoZW1lOjpuYXRpdmVUaGVtZSgpCiB7 CkBAIC0xMDQsMzcgKzEwNCw2IEBAIEludFJlY3QgU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bUFuZHJv aWQ6OnRyYWNrUmVjdChTY3JvbGxiYXJUaGVtZUNsaWVudCogc2Nyb2xsYmFyCiAgICAgcmV0dXJu IHJlY3Q7CiB9CiAKLXN0YXRpYyB2b2lkIGZpbGxTbW9vdGhFZGdlZFJlY3QoR3JhcGhpY3NDb250 ZXh0KiBjb250ZXh0LCBjb25zdCBJbnRSZWN0JiByZWN0LCBjb25zdCBDb2xvciYgY29sb3IpCi17 Ci0gICAgQ29sb3IgaGFsZkNvbG9yKGNvbG9yLnJlZCgpLCBjb2xvci5ncmVlbigpLCBjb2xvci5i bHVlKCksIGNvbG9yLmFscGhhKCkgLyAyKTsKLQotICAgIEludFJlY3QgdG9wUmVjdCA9IHJlY3Q7 Ci0gICAgdG9wUmVjdC5pbmZsYXRlWCgtMSk7Ci0gICAgdG9wUmVjdC5zZXRIZWlnaHQoMSk7Ci0g ICAgY29udGV4dC0+ZmlsbFJlY3QodG9wUmVjdCwgaGFsZkNvbG9yLCBDb2xvclNwYWNlRGV2aWNl UkdCKTsKLQotICAgIEludFJlY3QgbGVmdFJlY3QgPSByZWN0OwotICAgIGxlZnRSZWN0LmluZmxh dGVZKC0xKTsKLSAgICBsZWZ0UmVjdC5zZXRXaWR0aCgxKTsKLSAgICBjb250ZXh0LT5maWxsUmVj dChsZWZ0UmVjdCwgaGFsZkNvbG9yLCBDb2xvclNwYWNlRGV2aWNlUkdCKTsKLQotICAgIEludFJl Y3QgY2VudGVyUmVjdCA9IHJlY3Q7Ci0gICAgY2VudGVyUmVjdC5pbmZsYXRlKC0xKTsKLSAgICBj b250ZXh0LT5maWxsUmVjdChjZW50ZXJSZWN0LCBjb2xvciwgQ29sb3JTcGFjZURldmljZVJHQik7 Ci0KLSAgICBJbnRSZWN0IHJpZ2h0UmVjdCA9IHJlY3Q7Ci0gICAgcmlnaHRSZWN0LmluZmxhdGVZ KC0xKTsKLSAgICByaWdodFJlY3Quc2V0WChjZW50ZXJSZWN0Lm1heFgoKSk7Ci0gICAgcmlnaHRS ZWN0LnNldFdpZHRoKDEpOwotICAgIGNvbnRleHQtPmZpbGxSZWN0KHJpZ2h0UmVjdCwgaGFsZkNv bG9yLCBDb2xvclNwYWNlRGV2aWNlUkdCKTsKLQotICAgIEludFJlY3QgYm90dG9tUmVjdCA9IHJl Y3Q7Ci0gICAgYm90dG9tUmVjdC5pbmZsYXRlWCgtMSk7Ci0gICAgYm90dG9tUmVjdC5zZXRZKGNl bnRlclJlY3QubWF4WSgpKTsKLSAgICBib3R0b21SZWN0LnNldEhlaWdodCgxKTsKLSAgICBjb250 ZXh0LT5maWxsUmVjdChib3R0b21SZWN0LCBoYWxmQ29sb3IsIENvbG9yU3BhY2VEZXZpY2VSR0Ip OwotfQotCiB2b2lkIFNjcm9sbGJhclRoZW1lQ2hyb21pdW1BbmRyb2lkOjpwYWludFRodW1iKEdy YXBoaWNzQ29udGV4dCogY29udGV4dCwgU2Nyb2xsYmFyVGhlbWVDbGllbnQqIHNjcm9sbGJhciwg Y29uc3QgSW50UmVjdCYgcmVjdCkKIHsKICAgICBJbnRSZWN0IHRodW1iUmVjdCA9IHJlY3Q7CkBA IC0xNDIsNyArMTExLDcgQEAgdm9pZCBTY3JvbGxiYXJUaGVtZUNocm9taXVtQW5kcm9pZDo6cGFp bnRUaHVtYihHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIFNjcm9sbGIKICAgICAgICAgdGh1bWJS ZWN0LnNldEhlaWdodCh0aHVtYlJlY3QuaGVpZ2h0KCkgLSBzY3JvbGxiYXJNYXJnaW4pOwogICAg IGVsc2UKICAgICAgICAgdGh1bWJSZWN0LnNldFdpZHRoKHRodW1iUmVjdC53aWR0aCgpIC0gc2Ny b2xsYmFyTWFyZ2luKTsKLSAgICBmaWxsU21vb3RoRWRnZWRSZWN0KGNvbnRleHQsIHRodW1iUmVj dCwgQ29sb3IoMTI4LCAxMjgsIDEyOCwgMTI4KSk7CisgICAgY29udGV4dC0+ZmlsbFJlY3QodGh1 bWJSZWN0LCBDb2xvcigxMjgsIDEyOCwgMTI4LCAxMjgpLCBDb2xvclNwYWNlRGV2aWNlUkdCKTsK IH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=