109372 2013-02-09 23:31:13 -0800 Use IGNORE_EXCEPTION for Editor::countMatchesForText's ignored exceptions. 2013-02-11 05:52:45 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mkwst mkwst buildbot dglazkov jochen mifenton peter+ews rego+ews rniwa webkit-ews webkit.review.bot xan.lopez oldest_to_newest 829220 0 mkwst 2013-02-09 23:31:13 -0800 Use IGNORE_EXCEPTION for Editor::countMatchesForText's ignored exceptions. 829221 1 187467 mkwst 2013-02-09 23:32:35 -0800 Created attachment 187467 Patch 829223 2 mkwst 2013-02-09 23:33:31 -0800 Hello Jochen! Here are moar trivial changes! 829224 3 187467 webkit.review.bot 2013-02-09 23:37:38 -0800 Comment on attachment 187467 Patch Attachment 187467 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16470666 829225 4 187467 webkit-ews 2013-02-09 23:37:51 -0800 Comment on attachment 187467 Patch Attachment 187467 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16471678 829227 5 187467 webkit-ews 2013-02-09 23:39:37 -0800 Comment on attachment 187467 Patch Attachment 187467 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16479607 829229 6 187467 webkit.review.bot 2013-02-09 23:41:01 -0800 Comment on attachment 187467 Patch Attachment 187467 did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16471679 829230 7 187467 eflews.bot 2013-02-09 23:41:16 -0800 Comment on attachment 187467 Patch Attachment 187467 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16467790 829231 8 187467 buildbot 2013-02-09 23:46:21 -0800 Comment on attachment 187467 Patch Attachment 187467 did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16470669 829232 9 mkwst 2013-02-10 00:01:18 -0800 *ahem* It's so trivial, it doesn't even compile. I'll fix that, shall I? 829234 10 187467 peter+ews 2013-02-10 00:19:17 -0800 Comment on attachment 187467 Patch Attachment 187467 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16468758 829235 11 187467 buildbot 2013-02-10 00:23:52 -0800 Comment on attachment 187467 Patch Attachment 187467 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16469716 829324 12 187488 mkwst 2013-02-10 11:30:11 -0800 Created attachment 187488 Second time's the charm. 829410 13 187488 buildbot 2013-02-10 20:01:47 -0800 Comment on attachment 187488 Second time's the charm. Attachment 187488 did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16479941 New failing tests: compositing/checkerboard.html accessibility/anchor-linked-anonymous-block-crash.html http/tests/cache/cancel-multiple-post-xhrs.html animations/3d/state-at-end-event-transform.html animations/animation-add-events-in-handler.html animations/3d/replace-filling-transform.html http/tests/cache/history-only-cached-subresource-loads.html compositing/bounds-in-flipped-writing-mode.html accessibility/accessibility-node-reparent.html animations/animation-border-overflow.html accessibility/accessibility-object-detached.html accessibility/anonymous-render-block-in-continuation-causes-crash.html animations/animation-controller-drt-api.html compositing/absolute-position-changed-with-composited-parent-layer.html compositing/absolute-position-changed-in-composited-layer.html http/tests/cache/iframe-304-crash.html animations/3d/transform-perspective.html http/tests/cache/cancel-during-failure-crash.html canvas/philip/tests/2d.clearRect.basic.html animations/3d/transform-origin-vs-functions.html animations/animation-css-rule-types.html canvas/philip/tests/2d.clearRect+fillRect.basic.html canvas/philip/tests/2d.clearRect+fillRect.alpha0.html 829593 14 187488 jochen 2013-02-11 05:14:55 -0800 Comment on attachment 187488 Second time's the charm. ok 829603 15 187488 webkit.review.bot 2013-02-11 05:52:41 -0800 Comment on attachment 187488 Second time's the charm. Clearing flags on attachment: 187488 Committed r142459: <http://trac.webkit.org/changeset/142459> 829604 16 webkit.review.bot 2013-02-11 05:52:45 -0800 All reviewed patches have been landed. Closing bug. 187467 2013-02-09 23:32:35 -0800 2013-02-10 11:30:04 -0800 Patch bug-109372-20130210082908.patch text/plain 3073 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjkxZThjM2IxNjFjZDEw NGVkZjFmNjA2MGUxZDkwOTc2YjA5ODA2Ny4uMWQ0YjliZWRmZGEwM2Y1MTllMmRhNzE1NzAzNGQ4 MjI4YzM5NzYyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTA5ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVXNlIElHTk9SRV9FWENFUFRJ T04gZm9yIEVkaXRvcjo6Y291bnRNYXRjaGVzRm9yVGV4dCdzIGlnbm9yZWQgZXhjZXB0aW9ucy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTM3Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJhdGhlciB0 aGFuIGltcGxpY2l0bHkgaWdub3JpbmcgZXhjZXB0aW9ucywgd2Ugc2hvdWxkIHVzZSB0aGUKKyAg ICAgICAgSUdOT1JFX0VYQ0VQVElPTiBtYWNybyBmb3IgY2xhcml0eS4KKworICAgICAgICAqIGVk aXRpbmcvRWRpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6Y291bnRNYXRjaGVz Rm9yVGV4dCk6CisKIDIwMTMtMDItMDkgIERvbWluaWMgTWF6em9uaSAgPGRtYXp6b25pQGdvb2ds ZS5jb20+CiAKICAgICAgICAgZmFzdC9lbmNvZGluZy9wYXJzZXItdGVzdHMtKi5odG1sIHRlc3Rz IHNvbWV0aW1lcyBjcmFzaApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0 b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCmluZGV4IDNiOWYzYTQw YzM4M2MyOWJjNjc4MzQzYzMzNjkxNGYwZDM5ZGI5NjAuLmJhZmU2ZDU1ODc4Njg4ZjJjOTA1Yjkz NWYwMGY3MzNjOWU4YWI2ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRp dG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKQEAgLTI4MTAs MTYgKzI4MTAsMTUgQEAgdW5zaWduZWQgRWRpdG9yOjpjb3VudE1hdGNoZXNGb3JUZXh0KGNvbnN0 IFN0cmluZyYgdGFyZ2V0LCBSYW5nZSogcmFuZ2UsIEZpbmRPcHQKICAgICBOb2RlKiBvcmlnaW5h bEVuZENvbnRhaW5lciA9IHNlYXJjaFJhbmdlLT5lbmRDb250YWluZXIoKTsKICAgICBpbnQgb3Jp Z2luYWxFbmRPZmZzZXQgPSBzZWFyY2hSYW5nZS0+ZW5kT2Zmc2V0KCk7CiAKLSAgICBFeGNlcHRp b25Db2RlIGV4Y2VwdGlvbiA9IDA7CiAgICAgdW5zaWduZWQgbWF0Y2hDb3VudCA9IDA7CiAgICAg ZG8gewogICAgICAgICBSZWZQdHI8UmFuZ2U+IHJlc3VsdFJhbmdlKGZpbmRQbGFpblRleHQoc2Vh cmNoUmFuZ2UuZ2V0KCksIHRhcmdldCwgb3B0aW9ucyAmIH5CYWNrd2FyZHMpKTsKLSAgICAgICAg aWYgKHJlc3VsdFJhbmdlLT5jb2xsYXBzZWQoZXhjZXB0aW9uKSkgeworICAgICAgICBpZiAocmVz dWx0UmFuZ2UtPmNvbGxhcHNlZChJR05PUkVfRVhDRVBUSU9OKSkgewogICAgICAgICAgICAgaWYg KCFyZXN1bHRSYW5nZS0+c3RhcnRDb250YWluZXIoKS0+aXNJblNoYWRvd1RyZWUoKSkKICAgICAg ICAgICAgICAgICBicmVhazsKIAotICAgICAgICAgICAgc2VhcmNoUmFuZ2UtPnNldFN0YXJ0QWZ0 ZXIocmVzdWx0UmFuZ2UtPnN0YXJ0Q29udGFpbmVyKCktPnNoYWRvd0hvc3QoKSwgZXhjZXB0aW9u KTsKLSAgICAgICAgICAgIHNlYXJjaFJhbmdlLT5zZXRFbmQob3JpZ2luYWxFbmRDb250YWluZXIs IG9yaWdpbmFsRW5kT2Zmc2V0LCBleGNlcHRpb24pOworICAgICAgICAgICAgc2VhcmNoUmFuZ2Ut PnNldFN0YXJ0QWZ0ZXIocmVzdWx0UmFuZ2UtPnN0YXJ0Q29udGFpbmVyKCktPnNoYWRvd0hvc3Qo KSwgSUdOT1JFX0VYQ0VQVElPTik7CisgICAgICAgICAgICBzZWFyY2hSYW5nZS0+c2V0RW5kKG9y aWdpbmFsRW5kQ29udGFpbmVyLCBvcmlnaW5hbEVuZE9mZnNldCwgSUdOT1JFX0VYQ0VQVElPTik7 CiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgfQogCkBAIC0yODM4LDExICsyODM3LDEx IEBAIHVuc2lnbmVkIEVkaXRvcjo6Y291bnRNYXRjaGVzRm9yVGV4dChjb25zdCBTdHJpbmcmIHRh cmdldCwgUmFuZ2UqIHJhbmdlLCBGaW5kT3B0CiAgICAgICAgIC8vIHJlc3VsdCByYW5nZS4gVGhl cmUgaXMgbm8gbmVlZCB0byB1c2UgYSBWaXNpYmxlUG9zaXRpb24gaGVyZSwKICAgICAgICAgLy8g c2luY2UgZmluZFBsYWluVGV4dCB3aWxsIHVzZSBhIFRleHRJdGVyYXRvciB0byBnbyBvdmVyIHRo ZSB2aXNpYmxlCiAgICAgICAgIC8vIHRleHQgbm9kZXMuIAotICAgICAgICBzZWFyY2hSYW5nZS0+ c2V0U3RhcnQocmVzdWx0UmFuZ2UtPmVuZENvbnRhaW5lcihleGNlcHRpb24pLCByZXN1bHRSYW5n ZS0+ZW5kT2Zmc2V0KGV4Y2VwdGlvbiksIGV4Y2VwdGlvbik7CisgICAgICAgIHNlYXJjaFJhbmdl LT5zZXRTdGFydChyZXN1bHRSYW5nZS0+ZW5kQ29udGFpbmVyKElHTk9SRV9FWENFUFRJT04pLCBy ZXN1bHRSYW5nZS0+ZW5kT2Zmc2V0KGV4Y2VwdGlvbiksIElHTk9SRV9FWENFUFRJT04pOwogCiAg ICAgICAgIE5vZGUqIHNoYWRvd1RyZWVSb290ID0gc2VhcmNoUmFuZ2UtPnNoYWRvd1Jvb3QoKTsK LSAgICAgICAgaWYgKHNlYXJjaFJhbmdlLT5jb2xsYXBzZWQoZXhjZXB0aW9uKSAmJiBzaGFkb3dU cmVlUm9vdCkKLSAgICAgICAgICAgIHNlYXJjaFJhbmdlLT5zZXRFbmQoc2hhZG93VHJlZVJvb3Qs IHNoYWRvd1RyZWVSb290LT5jaGlsZE5vZGVDb3VudCgpLCBleGNlcHRpb24pOworICAgICAgICBp ZiAoc2VhcmNoUmFuZ2UtPmNvbGxhcHNlZChJR05PUkVfRVhDRVBUSU9OKSAmJiBzaGFkb3dUcmVl Um9vdCkKKyAgICAgICAgICAgIHNlYXJjaFJhbmdlLT5zZXRFbmQoc2hhZG93VHJlZVJvb3QsIHNo YWRvd1RyZWVSb290LT5jaGlsZE5vZGVDb3VudCgpLCBJR05PUkVfRVhDRVBUSU9OKTsKICAgICB9 IHdoaWxlICh0cnVlKTsKIAogICAgIGlmIChtYXJrTWF0Y2hlcyB8fCBtYXRjaGVzKSB7Cg== 187488 2013-02-10 11:30:11 -0800 2013-02-11 05:52:41 -0800 Second time's the charm. bug-109372-20130210202641.patch text/plain 3080 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjkxZThjM2IxNjFjZDEw NGVkZjFmNjA2MGUxZDkwOTc2YjA5ODA2Ny4uM2MzODA3MWQyY2Q4ZjMwODFiOTBkZDBjMGU5N2U3 ZWIxZjQ3MDQzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTEwICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVXNlIElHTk9SRV9FWENFUFRJ T04gZm9yIEVkaXRvcjo6Y291bnRNYXRjaGVzRm9yVGV4dCdzIGlnbm9yZWQgZXhjZXB0aW9ucy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTM3Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJhdGhlciB0 aGFuIGltcGxpY2l0bHkgaWdub3JpbmcgZXhjZXB0aW9ucywgd2Ugc2hvdWxkIHVzZSB0aGUKKyAg ICAgICAgSUdOT1JFX0VYQ0VQVElPTiBtYWNybyBmb3IgY2xhcml0eS4KKworICAgICAgICAqIGVk aXRpbmcvRWRpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6Y291bnRNYXRjaGVz Rm9yVGV4dCk6CisKIDIwMTMtMDItMDkgIERvbWluaWMgTWF6em9uaSAgPGRtYXp6b25pQGdvb2ds ZS5jb20+CiAKICAgICAgICAgZmFzdC9lbmNvZGluZy9wYXJzZXItdGVzdHMtKi5odG1sIHRlc3Rz IHNvbWV0aW1lcyBjcmFzaApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0 b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCmluZGV4IDNiOWYzYTQw YzM4M2MyOWJjNjc4MzQzYzMzNjkxNGYwZDM5ZGI5NjAuLjIxOTIwOGFmYzFmYmRkOWQ3NTdkOGI0 ZDAzNjNhNzdiZTE2MmYwMmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRp dG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKQEAgLTI4MTAs MTYgKzI4MTAsMTUgQEAgdW5zaWduZWQgRWRpdG9yOjpjb3VudE1hdGNoZXNGb3JUZXh0KGNvbnN0 IFN0cmluZyYgdGFyZ2V0LCBSYW5nZSogcmFuZ2UsIEZpbmRPcHQKICAgICBOb2RlKiBvcmlnaW5h bEVuZENvbnRhaW5lciA9IHNlYXJjaFJhbmdlLT5lbmRDb250YWluZXIoKTsKICAgICBpbnQgb3Jp Z2luYWxFbmRPZmZzZXQgPSBzZWFyY2hSYW5nZS0+ZW5kT2Zmc2V0KCk7CiAKLSAgICBFeGNlcHRp b25Db2RlIGV4Y2VwdGlvbiA9IDA7CiAgICAgdW5zaWduZWQgbWF0Y2hDb3VudCA9IDA7CiAgICAg ZG8gewogICAgICAgICBSZWZQdHI8UmFuZ2U+IHJlc3VsdFJhbmdlKGZpbmRQbGFpblRleHQoc2Vh cmNoUmFuZ2UuZ2V0KCksIHRhcmdldCwgb3B0aW9ucyAmIH5CYWNrd2FyZHMpKTsKLSAgICAgICAg aWYgKHJlc3VsdFJhbmdlLT5jb2xsYXBzZWQoZXhjZXB0aW9uKSkgeworICAgICAgICBpZiAocmVz dWx0UmFuZ2UtPmNvbGxhcHNlZChJR05PUkVfRVhDRVBUSU9OKSkgewogICAgICAgICAgICAgaWYg KCFyZXN1bHRSYW5nZS0+c3RhcnRDb250YWluZXIoKS0+aXNJblNoYWRvd1RyZWUoKSkKICAgICAg ICAgICAgICAgICBicmVhazsKIAotICAgICAgICAgICAgc2VhcmNoUmFuZ2UtPnNldFN0YXJ0QWZ0 ZXIocmVzdWx0UmFuZ2UtPnN0YXJ0Q29udGFpbmVyKCktPnNoYWRvd0hvc3QoKSwgZXhjZXB0aW9u KTsKLSAgICAgICAgICAgIHNlYXJjaFJhbmdlLT5zZXRFbmQob3JpZ2luYWxFbmRDb250YWluZXIs IG9yaWdpbmFsRW5kT2Zmc2V0LCBleGNlcHRpb24pOworICAgICAgICAgICAgc2VhcmNoUmFuZ2Ut PnNldFN0YXJ0QWZ0ZXIocmVzdWx0UmFuZ2UtPnN0YXJ0Q29udGFpbmVyKCktPnNoYWRvd0hvc3Qo KSwgSUdOT1JFX0VYQ0VQVElPTik7CisgICAgICAgICAgICBzZWFyY2hSYW5nZS0+c2V0RW5kKG9y aWdpbmFsRW5kQ29udGFpbmVyLCBvcmlnaW5hbEVuZE9mZnNldCwgSUdOT1JFX0VYQ0VQVElPTik7 CiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgfQogCkBAIC0yODM4LDExICsyODM3LDEx IEBAIHVuc2lnbmVkIEVkaXRvcjo6Y291bnRNYXRjaGVzRm9yVGV4dChjb25zdCBTdHJpbmcmIHRh cmdldCwgUmFuZ2UqIHJhbmdlLCBGaW5kT3B0CiAgICAgICAgIC8vIHJlc3VsdCByYW5nZS4gVGhl cmUgaXMgbm8gbmVlZCB0byB1c2UgYSBWaXNpYmxlUG9zaXRpb24gaGVyZSwKICAgICAgICAgLy8g c2luY2UgZmluZFBsYWluVGV4dCB3aWxsIHVzZSBhIFRleHRJdGVyYXRvciB0byBnbyBvdmVyIHRo ZSB2aXNpYmxlCiAgICAgICAgIC8vIHRleHQgbm9kZXMuIAotICAgICAgICBzZWFyY2hSYW5nZS0+ c2V0U3RhcnQocmVzdWx0UmFuZ2UtPmVuZENvbnRhaW5lcihleGNlcHRpb24pLCByZXN1bHRSYW5n ZS0+ZW5kT2Zmc2V0KGV4Y2VwdGlvbiksIGV4Y2VwdGlvbik7CisgICAgICAgIHNlYXJjaFJhbmdl LT5zZXRTdGFydChyZXN1bHRSYW5nZS0+ZW5kQ29udGFpbmVyKElHTk9SRV9FWENFUFRJT04pLCBy ZXN1bHRSYW5nZS0+ZW5kT2Zmc2V0KElHTk9SRV9FWENFUFRJT04pLCBJR05PUkVfRVhDRVBUSU9O KTsKIAogICAgICAgICBOb2RlKiBzaGFkb3dUcmVlUm9vdCA9IHNlYXJjaFJhbmdlLT5zaGFkb3dS b290KCk7Ci0gICAgICAgIGlmIChzZWFyY2hSYW5nZS0+Y29sbGFwc2VkKGV4Y2VwdGlvbikgJiYg c2hhZG93VHJlZVJvb3QpCi0gICAgICAgICAgICBzZWFyY2hSYW5nZS0+c2V0RW5kKHNoYWRvd1Ry ZWVSb290LCBzaGFkb3dUcmVlUm9vdC0+Y2hpbGROb2RlQ291bnQoKSwgZXhjZXB0aW9uKTsKKyAg ICAgICAgaWYgKHNlYXJjaFJhbmdlLT5jb2xsYXBzZWQoSUdOT1JFX0VYQ0VQVElPTikgJiYgc2hh ZG93VHJlZVJvb3QpCisgICAgICAgICAgICBzZWFyY2hSYW5nZS0+c2V0RW5kKHNoYWRvd1RyZWVS b290LCBzaGFkb3dUcmVlUm9vdC0+Y2hpbGROb2RlQ291bnQoKSwgSUdOT1JFX0VYQ0VQVElPTik7 CiAgICAgfSB3aGlsZSAodHJ1ZSk7CiAKICAgICBpZiAobWFya01hdGNoZXMgfHwgbWF0Y2hlcykg ewo=