109364 2013-02-09 14:31:05 -0800 [WK2] Fix build on PLUGIN_ARCHITECTURE(UNSUPPORTED) after r142314 2013-02-12 10:24:03 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 zarvai webkit-unassigned andersca hausmann kadam ossy webkit.review.bot oldest_to_newest 829125 0 zarvai 2013-02-09 14:31:05 -0800 After r142314 QtWin build is broken. void NetscapePlugin::platformPreInitialize() is need to be added to WebKit2/WebProcess/Plugins/Netscape/NetscapePluginNone.cpp Patch is on the way. 829127 1 187446 zarvai 2013-02-09 14:35:12 -0800 Created attachment 187446 patch for landing 829239 2 187446 webkit.review.bot 2013-02-10 00:38:25 -0800 Comment on attachment 187446 patch for landing Clearing flags on attachment: 187446 Committed r142390: <http://trac.webkit.org/changeset/142390> 829240 3 webkit.review.bot 2013-02-10 00:38:28 -0800 All reviewed patches have been landed. Closing bug. 829880 4 andersca 2013-02-11 10:51:02 -0800 What is PLUGIN_ARCHITECTURE(UNSUPPORTED)? We already have an #ifdef for turning on/off plug-in support. 830702 5 zarvai 2013-02-12 01:42:55 -0800 Maybe plugin api is enabled for Qt but not supported on Windows? #if ENABLE(NETSCAPE_PLUGIN_API) && PLUGIN_ARCHITECTURE(UNSUPPORTED) This bug seems to be related: https://bugs.webkit.org/show_bug.cgi?id=86577 (In reply to comment #4) > What is PLUGIN_ARCHITECTURE(UNSUPPORTED)? We already have an #ifdef for turning on/off plug-in support. 831056 6 andersca 2013-02-12 10:24:03 -0800 (In reply to comment #5) > Maybe plugin api is enabled for Qt but not supported on Windows? > #if ENABLE(NETSCAPE_PLUGIN_API) && PLUGIN_ARCHITECTURE(UNSUPPORTED) > Why is it enabled on Windows then? 187446 2013-02-09 14:35:12 -0800 2013-02-10 00:38:24 -0800 patch for landing netscape-none.patch text/plain 1258 zarvai ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0MDE0NmZmLi4zZTE2NWVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDItMDkgIFpvbHRhbiBBcnZhaSAgPHphcnZhaUBpbmYudS1zemVnZWQuaHU+CisK KyAgICAgICAgW1dLMl0gRml4IGJ1aWxkIG9uIFBMVUdJTl9BUkNISVRFQ1RVUkUoVU5TVVBQT1JU RUQpIGFmdGVyIHIxNDIzMTQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwOTM2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIHZvaWQgTmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtUHJlSW5pdGlhbGl6ZSgpIGlz IG5lZWQgdG8gYmUgYWRkZWQgdG8gTmV0c2NhcGVQbHVnaW5Ob25lLmNwcC4KKworICAgICAgICAq IFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbk5vbmUuY3BwOgorICAg ICAgICAoV2ViS2l0OjpOZXRzY2FwZVBsdWdpbjo6cGxhdGZvcm1QcmVJbml0aWFsaXplKToKKyAg ICAgICAgKFdlYktpdCk6CisKIDIwMTMtMDItMDggIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9y Zz4KIAogICAgICAgICBGaXggQVNTRVJUIHdoZW4gdGhlIFdlYiBDb250ZW50IFByb2Nlc3MgY3Jh c2hlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNj YXBlL05ldHNjYXBlUGx1Z2luTm9uZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1Bs dWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW5Ob25lLmNwcAppbmRleCA4OGNjNGU3Li4wMmNk YTI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2Nh cGUvTmV0c2NhcGVQbHVnaW5Ob25lLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW5Ob25lLmNwcApAQCAtMzMsNiArMzMsMTAg QEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCit2b2lk IE5ldHNjYXBlUGx1Z2luOjpwbGF0Zm9ybVByZUluaXRpYWxpemUoKQoreworfQorCiBib29sIE5l dHNjYXBlUGx1Z2luOjpwbGF0Zm9ybVBvc3RJbml0aWFsaXplKCkKIHsKICAgICByZXR1cm4gZmFs c2U7Cg==