109355 2013-02-09 07:12:34 -0800 Web Inspector: highlight DOM nodes on hover while debugging 2013-02-11 03:51:25 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 829020 0 pfeldman 2013-02-09 07:12:34 -0800 Along with showing the popover, highlight the remote object as node. 829023 1 187431 pfeldman 2013-02-09 07:24:03 -0800 Created attachment 187431 Patch 829513 2 187431 vsevik 2013-02-11 02:08:24 -0800 Comment on attachment 187431 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187431&action=review > Source/WebCore/inspector/front-end/ObjectPopoverHelper.js:110 > + result.highlightAsDOMNode(); I think it is possible that some other UI component triggered another dom node highlighting before this call, e.g. when mouse cursor is moved to the console where an element is printed. 829514 3 vsevik 2013-02-11 02:09:00 -0800 Previous comment referred to the hide highlight method call, not the show highlight one. 829565 4 187431 webkit.review.bot 2013-02-11 03:51:21 -0800 Comment on attachment 187431 Patch Clearing flags on attachment: 187431 Committed r142450: <http://trac.webkit.org/changeset/142450> 829566 5 webkit.review.bot 2013-02-11 03:51:25 -0800 All reviewed patches have been landed. Closing bug. 187431 2013-02-09 07:24:03 -0800 2013-02-11 03:51:21 -0800 Patch bug-109355-20130209152037.patch text/plain 2250 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzc1ZjU4ZDNkNTAxM2Ey NGU3YTExYTBmY2I1OWY4OGMwZTQ5YjI3Yy4uMmUzMGQyNGQxZWM1NzI0MzBmNzIxNmNjZTgwYzQw YzYwOTFkMThmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAyLTA5ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGhpZ2hsaWdodCBET00gbm9kZXMgb24gaG92ZXIgd2hpbGUgZGVidWdnaW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDkzNTUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbG9uZyB3aXRoIHNob3dp bmcgdGhlIHBvcG92ZXIsIGhpZ2hsaWdodCB0aGUgcmVtb3RlIG9iamVjdCBhcyBub2RlLgorCisg ICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9PYmplY3RQb3BvdmVySGVscGVyLmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLk9iamVjdFBvcG92ZXJIZWxwZXIucHJvdG90eXBlLik6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuT2JqZWN0UG9wb3ZlckhlbHBlci5wcm90b3R5cGUuX3Nob3dPYmpl Y3RQb3BvdmVyKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5PYmplY3RQb3BvdmVySGVscGVyLnBy b3RvdHlwZS5fb25IaWRlT2JqZWN0UG9wb3Zlcik6CisKIDIwMTMtMDItMDcgIEd1c3Rhdm8gTm9y b25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBm aXguIGxpYldlYkNvcmUubGEgbmVlZHMgdG8gYmUgcmVsaW5rZWQgd2hlbgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9PYmplY3RQb3BvdmVySGVscGVyLmpz IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9PYmplY3RQb3BvdmVySGVscGVy LmpzCmluZGV4IGIwYmQ0MzFhNmFmZmQzMjgyMWMzM2NlNWJhMDg5OTIzMWJkNTQyYmMuLmM1NzQw OTFmZmY4OGI0NzU0MWEzMjA0NjFkOGVlNzI1OGE0OTU4ODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvT2JqZWN0UG9wb3ZlckhlbHBlci5qcworKysgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL09iamVjdFBvcG92ZXJIZWxwZXIuanMK QEAgLTEwNiw4ICsxMDYsOSBAQCBXZWJJbnNwZWN0b3IuT2JqZWN0UG9wb3ZlckhlbHBlci5wcm90 b3R5cGUgPSB7CiAgICAgICAgICAgICAgICAgICAgIHBvcG92ZXJDb250ZW50RWxlbWVudC50ZXh0 Q29udGVudCA9ICJcIiIgKyBwb3BvdmVyQ29udGVudEVsZW1lbnQudGV4dENvbnRlbnQgKyAiXCIi OwogICAgICAgICAgICAgICAgIHBvcG92ZXIuc2hvdyhwb3BvdmVyQ29udGVudEVsZW1lbnQsIGFu Y2hvckVsZW1lbnQpOwogICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICBpZiAo cmVzdWx0LnN1YnR5cGUgPT09ICJub2RlIikKKyAgICAgICAgICAgICAgICAgICAgcmVzdWx0Lmhp Z2hsaWdodEFzRE9NTm9kZSgpOwogICAgICAgICAgICAgICAgIHBvcG92ZXJDb250ZW50RWxlbWVu dCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwotCiAgICAgICAgICAgICAgICAgdGhp cy5fdGl0bGVFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CiAgICAgICAg ICAgICAgICAgdGhpcy5fdGl0bGVFbGVtZW50LmNsYXNzTmFtZSA9ICJzb3VyY2UtZnJhbWUtcG9w b3Zlci10aXRsZSBtb25vc3BhY2UiOwogICAgICAgICAgICAgICAgIHRoaXMuX3RpdGxlRWxlbWVu dC50ZXh0Q29udGVudCA9IHJlc3VsdC5kZXNjcmlwdGlvbjsKQEAgLTEzNCw2ICsxMzUsNyBAQCBX ZWJJbnNwZWN0b3IuT2JqZWN0UG9wb3ZlckhlbHBlci5wcm90b3R5cGUgPSB7CiAKICAgICBfb25I aWRlT2JqZWN0UG9wb3ZlcjogZnVuY3Rpb24oKQogICAgIHsKKyAgICAgICAgV2ViSW5zcGVjdG9y LmRvbUFnZW50LmhpZGVET01Ob2RlSGlnaGxpZ2h0KCk7CiAgICAgICAgIGlmICh0aGlzLl9saW5r aWZpZXIpIHsKICAgICAgICAgICAgIHRoaXMuX2xpbmtpZmllci5yZXNldCgpOwogICAgICAgICAg ICAgZGVsZXRlIHRoaXMuX2xpbmtpZmllcjsK