109348 2013-02-08 22:12:46 -0800 ScrollingTree node maps keep getting larger 2013-02-11 13:30:52 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser abarth andersca bdakin jamesr sam simon.fraser oldest_to_newest 828957 0 simon.fraser 2013-02-08 22:12:46 -0800 Both the ScrollingCoordinator's m_stateNodeMap and ScrollingTree's m_nodeMap get larger and larger as you navigate between pages. 829106 1 187441 simon.fraser 2013-02-09 13:01:22 -0800 Created attachment 187441 Patch 829107 2 simon.fraser 2013-02-09 13:02:04 -0800 This patch depends on the patch in bug 109361, so will probably fail EWS. 829108 3 simon.fraser 2013-02-09 13:03:28 -0800 The changelog should say that this isn't testable, because we only dump the state node tree (which is OK), not the hash map. The scrolling node tree does accumulate extra children, but we don't dump that. 830050 4 simon.fraser 2013-02-11 13:30:16 -0800 http://trac.webkit.org/changeset/142505 830053 5 simon.fraser 2013-02-11 13:30:52 -0800 *** Bug 108732 has been marked as a duplicate of this bug. *** 187441 2013-02-09 13:01:22 -0800 2013-02-10 21:01:39 -0800 Patch bug-109348-20130209125756.patch text/plain 6446 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmZmZjBmZDdhODY3Y2Q4 MzVkMDBhZTgxNWE1MjI1ZDkyZWQ3MTI5Yy4uNzUwN2M0ZDJmYjcwZmUwMTgzNmJjMDBlZjkzYjdj MjQ2MGNmMGM0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM5IEBACiAyMDEzLTAyLTA5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIFNjcm9sbGluZ1Ry ZWUgbm9kZSBtYXBzIGtlZXAgZ2V0dGluZyBsYXJnZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTM0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gbmF2aWdhdGluZyBiZXR3ZWVuIHBhZ2VzLCBu b2RlcyB3b3VsZCBnZXQgbGVmdCBpbiB0aGUgU2Nyb2xsaW5nVHJlZSdzCisgICAgICAgIG5vZGUg bWFwLCBhbmQgdGhlIFNjcm9sbGluZ1N0YXRlVHJlZSdzIG5vZGUgbWFwLCBzbyB0aGVzZSB3b3Vs ZCBnZXQgbGFyZ2VyCisgICAgICAgIGFuZCBsYXJnZXIgYXMgeW91IGJyb3dzZS4KKyAgICAgICAg CisgICAgICAgIFNpbXBsaWZ5IG1hcCBtYWludGVuYW5jZSBieSBjbGVhcmluZyB0aGUgbWFwIHdo ZW4gc2V0dGluZyBhIG5ldyByb290IG5vZGUKKyAgICAgICAgKHdoaWNoIGhhcHBlbnMgb24gdGhl IGZpcnN0IGNvbW1pdCBvZiBhIG5ldyBwYWdlKS4gQWxzbywgZG9uJ3Qga2VlcCByb290IG5vZGVz CisgICAgICAgIGFyb3VuZCwgYnV0IGNyZWF0ZSB0aGVtIGFmcmVzaCBmb3IgZWFjaCBwYWdlLCB3 aGljaCBzaW1wbGlmaWVzIHRoZWlyIElECisgICAgICAgIG1hbmFnZW1lbnQuCisgICAgICAgIAor ICAgICAgICBUaGlzIGlzIGNsb3NlciB0byB0aGUgb3JpZ2luYWwgYmVoYXZpb3I7IGtlZXBpbmcg dGhlIHJvb3Qgbm9kZXMgYXJvdW5kIHdhcworICAgICAgICBhIGZpeCBmb3IgYnVnIDk5NjY4LCBi dXQgd2UgYXZvaWQgcmVncmVzc2luZyB0aGF0IGZpeCBieSBiYWlsaW5nIGVhcmx5CisgICAgICAg IGZyb20gZnJhbWVWaWV3TGF5b3V0VXBkYXRlZCgpIGlmIHRoZXJlIGlzIG5vIHJvb3Qgc3RhdGUg bm9kZSAod2UnbGwgZ2V0CisgICAgICAgIGNhbGxlZCBhZ2FpbiBhbnl3YXkpLgorICAgICAgICAK KyAgICAgICAgVGhpcyBub3cgYWxsb3dzIHN0YXRlIG5vZGVJRHMgdG8gYmUgcHVyZWx5IHJlYWQt b25seS4KKworICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1N0YXRlTm9kZS5oOgor ICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1N0YXRlVHJlZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTY3JvbGxpbmdTdGF0ZVRyZWU6OlNjcm9sbGluZ1N0YXRlVHJlZSk6CisgICAg ICAgIChXZWJDb3JlOjpTY3JvbGxpbmdTdGF0ZVRyZWU6OmF0dGFjaE5vZGUpOgorICAgICAgICAo V2ViQ29yZTo6U2Nyb2xsaW5nU3RhdGVUcmVlOjpjbGVhcik6CisgICAgICAgIChXZWJDb3JlOjpT Y3JvbGxpbmdTdGF0ZVRyZWU6OnJlbW92ZU5vZGUpOgorICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5n L1Njcm9sbGluZ1RyZWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nVHJlZTo6dXBk YXRlVHJlZUZyb21TdGF0ZU5vZGUpOgorICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL21hYy9TY3Jv bGxpbmdDb29yZGluYXRvck1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ0Nvb3Jk aW5hdG9yTWFjOjpmcmFtZVZpZXdMYXlvdXRVcGRhdGVkKToKKworMjAxMy0wMi0wOSAgU2ltb24g RnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBNb3ZlIG1fc3RhdGVO b2RlTWFwIGZyb20gU2Nyb2xsaW5nQ29vcmRpbmF0b3JNYWMgdG8gU2Nyb2xsaW5nU3RhdGVUcmVl CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDkzNjEK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nU3Rh dGVOb2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZU5v ZGUuaAppbmRleCBjMDM3Y2JiM2Y2MjY4ZWZkZWEyNTM1MTVhYTBhMTNjMWM5Y2UyOTIxLi42Zjkz ZTRiMWRhMWI3Yjk2ZGE5NWE0NTJhZDBjNWNmNzlmYTM5NDRiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZU5vZGUuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZU5vZGUuaApAQCAtNzksNyArNzks NiBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRTY3JvbGxpbmdTdGF0ZVRyZWUoU2Nyb2xsaW5nU3Rh dGVUcmVlKiB0cmVlKSB7IG1fc2Nyb2xsaW5nU3RhdGVUcmVlID0gdHJlZTsgfQogCiAgICAgU2Ny b2xsaW5nTm9kZUlEIHNjcm9sbGluZ05vZGVJRCgpIGNvbnN0IHsgcmV0dXJuIG1fbm9kZUlEOyB9 Ci0gICAgdm9pZCBzZXRTY3JvbGxpbmdOb2RlSUQoU2Nyb2xsaW5nTm9kZUlEIG5vZGVJRCkgeyBt X25vZGVJRCA9IG5vZGVJRDsgfQogCiAgICAgU2Nyb2xsaW5nU3RhdGVOb2RlKiBwYXJlbnQoKSBj b25zdCB7IHJldHVybiBtX3BhcmVudDsgfQogICAgIHZvaWQgc2V0UGFyZW50KFNjcm9sbGluZ1N0 YXRlTm9kZSogcGFyZW50KSB7IG1fcGFyZW50ID0gcGFyZW50OyB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZVRyZWUuY3BwIGIvU291cmNl L1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nU3RhdGVUcmVlLmNwcAppbmRleCBiZDk3 NWMyMTg5ZWQwODNmZmRlYjIzYmIxMzJkNjM3MzllY2E5MTc1Li40MzM0MTVkMDMwY2QyZWI5NmIw ZmVkMmE3ZjVmZmQzMTMxMzkxNTBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Nj cm9sbGluZy9TY3JvbGxpbmdTdGF0ZVRyZWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv c2Nyb2xsaW5nL1Njcm9sbGluZ1N0YXRlVHJlZS5jcHAKQEAgLTQxLDggKzQxLDcgQEAgUGFzc093 blB0cjxTY3JvbGxpbmdTdGF0ZVRyZWU+IFNjcm9sbGluZ1N0YXRlVHJlZTo6Y3JlYXRlKCkKIH0K IAogU2Nyb2xsaW5nU3RhdGVUcmVlOjpTY3JvbGxpbmdTdGF0ZVRyZWUoKQotICAgIDogbV9yb290 U3RhdGVOb2RlKFNjcm9sbGluZ1N0YXRlU2Nyb2xsaW5nTm9kZTo6Y3JlYXRlKHRoaXMsIDApKQot ICAgICwgbV9oYXNDaGFuZ2VkUHJvcGVydGllcyhmYWxzZSkKKyAgICA6IG1faGFzQ2hhbmdlZFBy b3BlcnRpZXMoZmFsc2UpCiB7CiB9CiAKQEAgLTcwLDcgKzY5LDcgQEAgU2Nyb2xsaW5nTm9kZUlE IFNjcm9sbGluZ1N0YXRlVHJlZTo6YXR0YWNoTm9kZShTY3JvbGxpbmdOb2RlVHlwZSBub2RlVHlw ZSwgU2Nyb2wKICAgICAgICAgLy8gSWYgd2UncmUgcmVzZXR0aW5nIHRoZSByb290IG5vZGUsIHdl IHNob3VsZCBjbGVhciB0aGUgSGFzaE1hcCBhbmQgZGVzdHJveSB0aGUgY3VycmVudCBjaGlsZHJl bi4KICAgICAgICAgY2xlYXIoKTsKIAotICAgICAgICByb290U3RhdGVOb2RlKCktPnNldFNjcm9s bGluZ05vZGVJRChuZXdOb2RlSUQpOworICAgICAgICBzZXRSb290U3RhdGVOb2RlKFNjcm9sbGlu Z1N0YXRlU2Nyb2xsaW5nTm9kZTo6Y3JlYXRlKHRoaXMsIG5ld05vZGVJRCkpOwogICAgICAgICBu ZXdOb2RlID0gcm9vdFN0YXRlTm9kZSgpOwogICAgIH0gZWxzZSB7CiAgICAgICAgIFNjcm9sbGlu Z1N0YXRlTm9kZSogcGFyZW50ID0gc3RhdGVOb2RlRm9ySUQocGFyZW50SUQpOwpAQCAtMTIwLDYg KzExOSw3IEBAIHZvaWQgU2Nyb2xsaW5nU3RhdGVUcmVlOjpkZXRhY2hOb2RlKFNjcm9sbGluZ05v ZGVJRCBub2RlSUQpCiB2b2lkIFNjcm9sbGluZ1N0YXRlVHJlZTo6Y2xlYXIoKQogewogICAgIHJl bW92ZU5vZGUocm9vdFN0YXRlTm9kZSgpKTsKKyAgICBtX3N0YXRlTm9kZU1hcC5jbGVhcigpOwog fQogCiBQYXNzT3duUHRyPFNjcm9sbGluZ1N0YXRlVHJlZT4gU2Nyb2xsaW5nU3RhdGVUcmVlOjpj b21taXQoKQpAQCAtMTQwLDYgKzE0MCwxNSBAQCBQYXNzT3duUHRyPFNjcm9sbGluZ1N0YXRlVHJl ZT4gU2Nyb2xsaW5nU3RhdGVUcmVlOjpjb21taXQoKQogCiB2b2lkIFNjcm9sbGluZ1N0YXRlVHJl ZTo6cmVtb3ZlTm9kZShTY3JvbGxpbmdTdGF0ZU5vZGUqIG5vZGUpCiB7CisgICAgaWYgKCFub2Rl KQorICAgICAgICByZXR1cm47CisKKyAgICBpZiAobm9kZSA9PSBtX3Jvb3RTdGF0ZU5vZGUpIHsK KyAgICAgICAgZGlkUmVtb3ZlTm9kZShub2RlLT5zY3JvbGxpbmdOb2RlSUQoKSk7CisgICAgICAg IG1fcm9vdFN0YXRlTm9kZSA9IG51bGxwdHI7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAg ICBBU1NFUlQobV9yb290U3RhdGVOb2RlKTsKICAgICBtX3Jvb3RTdGF0ZU5vZGUtPnJlbW92ZUNo aWxkKG5vZGUpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9T Y3JvbGxpbmdUcmVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGlu Z1RyZWUuY3BwCmluZGV4IDcwZTY4OTkxYTQzMTFmYzY2MWRlYTRhYjRhMjA3ZDE1NmIzYzQ1ZjYu LjBkODAzZDRhNzg4ZmI0YzU3ZDM4N2UxNjkyYjg5YjQwMDU5M2IwYzggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWUuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWUuY3BwCkBAIC0xNTksMTAgKzE1 OSwxMCBAQCB2b2lkIFNjcm9sbGluZ1RyZWU6OnVwZGF0ZVRyZWVGcm9tU3RhdGVOb2RlKFNjcm9s bGluZ1N0YXRlTm9kZSogc3RhdGVOb2RlKQogICAgICAgICAvLyByb290IG5vZGUuCiAgICAgICAg IFNjcm9sbGluZ05vZGVJRCBub2RlSUQgPSBzdGF0ZU5vZGUtPnNjcm9sbGluZ05vZGVJRCgpOwog ICAgICAgICBpZiAoIXN0YXRlTm9kZS0+cGFyZW50KCkpIHsKLSAgICAgICAgICAgIC8vIFRoaXMg aXMgdGhlIHJvb3Qgbm9kZS4KLSAgICAgICAgICAgIGlmICghbV9yb290Tm9kZSkKLSAgICAgICAg ICAgICAgICBtX3Jvb3ROb2RlID0gU2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05vZGU6OmNyZWF0ZSh0 aGlzLCBub2RlSUQpOworICAgICAgICAgICAgLy8gVGhpcyBpcyB0aGUgcm9vdCBub2RlLiBOdWtl IHRoZSBub2RlIG1hcC4KKyAgICAgICAgICAgIG1fbm9kZU1hcC5jbGVhcigpOwogCisgICAgICAg ICAgICBtX3Jvb3ROb2RlID0gU2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05vZGU6OmNyZWF0ZSh0aGlz LCBub2RlSUQpOwogICAgICAgICAgICAgbV9ub2RlTWFwLnNldChub2RlSUQsIG1fcm9vdE5vZGUu Z2V0KCkpOwogICAgICAgICAgICAgbV9yb290Tm9kZS0+dXBkYXRlKHN0YXRlTm9kZSk7CiAgICAg ICAgIH0gZWxzZSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9t YWMvU2Nyb2xsaW5nQ29vcmRpbmF0b3JNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9s bGluZy9tYWMvU2Nyb2xsaW5nQ29vcmRpbmF0b3JNYWMubW0KaW5kZXggZjdlYTNlNzZlOWZhYzdh N2Q5MzA4ZjAyNTgyNzEzNWQ4MGUyNjI0NS4uOTIwMzgxMGYzZTRjZjRiZWE4NjdjNjgwMjQyMWI1 YmMyMTEyYjM1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbWFj L1Njcm9sbGluZ0Nvb3JkaW5hdG9yTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Ny b2xsaW5nL21hYy9TY3JvbGxpbmdDb29yZGluYXRvck1hYy5tbQpAQCAtMTA3LDYgKzEwNywxMCBA QCB2b2lkIFNjcm9sbGluZ0Nvb3JkaW5hdG9yTWFjOjpmcmFtZVZpZXdMYXlvdXRVcGRhdGVkKEZy YW1lVmlldyogZnJhbWVWaWV3KQogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CiAgICAgQVNT RVJUKG1fcGFnZSk7CiAKKyAgICAvLyBJZiB0aGVyZSBpc24ndCBhIHJvb3Qgbm9kZSB5ZXQsIGRv bid0IGRvIGFueXRoaW5nLiBXZSdsbCBiZSBjYWxsZWQgYWdhaW4gYWZ0ZXIgY3JlYXRpbmcgb25l LgorICAgIGlmICghbV9zY3JvbGxpbmdTdGF0ZVRyZWUtPnJvb3RTdGF0ZU5vZGUoKSkKKyAgICAg ICAgcmV0dXJuOworCiAgICAgLy8gQ29tcHV0ZSB0aGUgcmVnaW9uIG9mIHRoZSBwYWdlIHRoYXQg d2UgY2FuJ3QgZG8gZmFzdCBzY3JvbGxpbmcgZm9yLiBUaGlzIGN1cnJlbnRseSBpbmNsdWRlcwog ICAgIC8vIGFsbCBzY3JvbGxhYmxlIGFyZWFzLCBzdWNoIGFzIHN1YmZyYW1lcywgb3ZlcmZsb3cg ZGl2cyBhbmQgbGlzdCBib3hlcy4gV2UgbmVlZCB0byBkbyB0aGlzIGV2ZW4gaWYgdGhlCiAgICAg Ly8gZnJhbWUgdmlldyB3aG9zZSBsYXlvdXQgd2FzIHVwZGF0ZWQgaXMgbm90IHRoZSBtYWluIGZy YW1lLgo=