109324 2013-02-08 14:02:14 -0800 Make WebCore Derived Sources work with SDK identifiers too 2020-05-28 10:50:59 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=212436 P2 Normal --- 1 dfarler dfarler ddkilzer mrowe webkit.review.bot oldest_to_newest 828753 0 dfarler 2013-02-08 14:02:14 -0800 Source/WebCore/DerivedSources.make invokes CC with -isysroot $(SDKROOT), which won't work if you use an SDK identifier instead of an absolute path. Where necessary, we should use xcrun to find the absolute path to the SDK. This works for either: xcrun --sdk <SDK identifier> --show-sdk-path xcrun --sdk /Full/Path/To/The/SDK --show-sdkpath Both return /Full/Path/To/The/SDK. 828772 1 mrowe 2013-02-08 14:44:52 -0800 I'm a little bit surprised that Xcode isn't expanding SDKROOT out to the path to the SDK. 828778 2 ddkilzer 2013-02-08 14:51:51 -0800 (In reply to comment #1) > I'm a little bit surprised that Xcode isn't expanding SDKROOT out to the path to the SDK. Is it clang that doesn't know what to do with "-isysroot <SDK identifier>"? 828781 3 dfarler 2013-02-08 14:53:18 -0800 (In reply to comment #2) > (In reply to comment #1) > > I'm a little bit surprised that Xcode isn't expanding SDKROOT out to the path to the SDK. Actually, it turns out that it does expand it, but we have a derived sources shell script phase and it isn't passing SDKROOT=${SDKROOT} to the make invocation, so maybe adding that is all we need. > > Is it clang that doesn't know what to do with "-isysroot <SDK identifier>"? Yeah, it looks that it has to be an absolute path because it prepends it to other path options. 828786 4 187371 dfarler 2013-02-08 15:05:48 -0800 Created attachment 187371 Patch Yep, looks like we just need to pass SDKROOT to the make invocation for Derived Sources. Confirmed this on all platforms. 828788 5 187371 mrowe 2013-02-08 15:09:30 -0800 Comment on attachment 187371 Patch That's a little surprising. Where is make currently getting the value of SDKROOT from if not the environment? 828790 6 dfarler 2013-02-08 15:24:48 -0800 (In reply to comment #5) > (From update of attachment 187371 [details]) > That's a little surprising. Where is make currently getting the value of SDKROOT from if not the environment? I think it is getting it from the environment fine but when Xcode expands it it doesn't update the environment when calling out to shell scripts in build phases. That would seem to match the behavior I was seeing, where building with SDKROOT=my.sdk is passed through to the environment in `make -f DerivedSources.make`. 830306 7 187371 webkit.review.bot 2013-02-11 16:34:02 -0800 Comment on attachment 187371 Patch Clearing flags on attachment: 187371 Committed r142546: <http://trac.webkit.org/changeset/142546> 830307 8 webkit.review.bot 2013-02-11 16:34:05 -0800 All reviewed patches have been landed. Closing bug. 187371 2013-02-08 15:05:48 -0800 2013-02-11 16:34:02 -0800 Patch bug-109324-20130208150222.patch text/plain 2284 dfarler U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTczZjljNjMxYmU1YTg3 NDFhNDBkOWMyZDVhYWNlYzA1M2NlODFjYS4uY2IyMDFhMzVjOTMyM2E3ZmI1NTNhNGU4ZThkNWY3 ZjhkMWM0MjY1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAyLTA4ICBEYXZp ZCBGYXJsZXIgIDxkZmFybGVyQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIFdlYkNvcmUgRGVy aXZlZCBTb3VyY2VzIHdvcmsgd2l0aCBTREsgaWRlbnRpZmllcnMgdG9vCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDkzMjQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmUueGNvZGVwcm9qL3By b2plY3QucGJ4cHJvajogUGFzcyBTREtST09UIHRvIG1ha2UgZm9yIERlcml2ZWRTb3VyY2VzLm1h a2UKKwogMjAxMy0wMi0wOCAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgog CiAgICAgICAgIFJlZmFjdG9yIHBsYXRmb3JtLXNwZWNpZmljIGNvZGUgaW4gU3BlZWNoU3ludGhl c2lzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0 LnBieHByb2ogYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHBy b2oKaW5kZXggNDBmOTg2ZmZmZjc4OTAyNDI0M2ZiODZhY2ZjOWVjMDdjNzU3YjBmOS4uOTE5NjAy ZDAzZTkxMTFmYWNjYWEwNjZmNTU0MWQ3NmRmYzMzNWFiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCisrKyBiL1NvdXJjZS9XZWJD b3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagpAQCAtMjY3MTQsNyArMjY3MTQs NyBAQAogCQkJKTsKIAkJCXJ1bk9ubHlGb3JEZXBsb3ltZW50UG9zdHByb2Nlc3NpbmcgPSAwOwog CQkJc2hlbGxQYXRoID0gL2Jpbi9zaDsKLQkJCXNoZWxsU2NyaXB0ID0gIm1rZGlyIC1wIFwiJHtC VUlMVF9QUk9EVUNUU19ESVJ9L0Rlcml2ZWRTb3VyY2VzL1dlYkNvcmVcIlxuY2QgXCIke0JVSUxU X1BST0RVQ1RTX0RJUn0vRGVyaXZlZFNvdXJjZXMvV2ViQ29yZVwiXG5cbi9iaW4vbG4gLXNmaCBc IiR7U1JDUk9PVH1cIiBXZWJDb3JlXG5leHBvcnQgV2ViQ29yZT1cIldlYkNvcmVcIlxuXG5pZiBb ICEgJENDIF07IHRoZW5cbiAgICBleHBvcnQgQ0M9XCJgeGNydW4gLWZpbmQgY2xhbmdgXCJcbmZp XG5cbmlmIFsgISAkR1BFUkYgXTsgdGhlblxuICAgIGV4cG9ydCBHUEVSRj1cImB4Y3J1biAtZmlu ZCBncGVyZmBcIlxuZmlcblxuaWYgWyBcIiR7QUNUSU9OfVwiID0gXCJidWlsZFwiIC1vIFwiJHtB Q1RJT059XCIgPSBcImluc3RhbGxcIiAtbyBcIiR7QUNUSU9OfVwiID0gXCJpbnN0YWxsaGRyc1wi IF07IHRoZW5cbiAgICBtYWtlICAtLW5vLWJ1aWx0aW4tcnVsZXMgLWYgXCJXZWJDb3JlL0Rlcml2 ZWRTb3VyY2VzLm1ha2VcIiAtaiBgL3Vzci9zYmluL3N5c2N0bCAtbiBody5hdmFpbGNwdWBcbmZp XG4iOworCQkJc2hlbGxTY3JpcHQgPSAibWtkaXIgLXAgXCIke0JVSUxUX1BST0RVQ1RTX0RJUn0v RGVyaXZlZFNvdXJjZXMvV2ViQ29yZVwiXG5jZCBcIiR7QlVJTFRfUFJPRFVDVFNfRElSfS9EZXJp dmVkU291cmNlcy9XZWJDb3JlXCJcblxuL2Jpbi9sbiAtc2ZoIFwiJHtTUkNST09UfVwiIFdlYkNv cmVcbmV4cG9ydCBXZWJDb3JlPVwiV2ViQ29yZVwiXG5cbmlmIFsgISAkQ0MgXTsgdGhlblxuICAg IGV4cG9ydCBDQz1cImB4Y3J1biAtZmluZCBjbGFuZ2BcIlxuZmlcblxuaWYgWyAhICRHUEVSRiBd OyB0aGVuXG4gICAgZXhwb3J0IEdQRVJGPVwiYHhjcnVuIC1maW5kIGdwZXJmYFwiXG5maVxuXG5p ZiBbIFwiJHtBQ1RJT059XCIgPSBcImJ1aWxkXCIgLW8gXCIke0FDVElPTn1cIiA9IFwiaW5zdGFs bFwiIC1vIFwiJHtBQ1RJT059XCIgPSBcImluc3RhbGxoZHJzXCIgXTsgdGhlblxuICAgIG1ha2Ug IC0tbm8tYnVpbHRpbi1ydWxlcyAtZiBcIldlYkNvcmUvRGVyaXZlZFNvdXJjZXMubWFrZVwiIC1q IGAvdXNyL3NiaW4vc3lzY3RsIC1uIGh3LmF2YWlsY3B1YCBTREtST09UPVwiJHtTREtST09UfVwi XG5maVxuIjsKIAkJfTsKIC8qIEVuZCBQQlhTaGVsbFNjcmlwdEJ1aWxkUGhhc2Ugc2VjdGlvbiAq LwogCg==