109321 2013-02-08 13:20:54 -0800 [GTK] Build errors in TextureMapperShaderProgram.cpp when compiling with Clang 2013-02-10 02:42:18 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 109314 1 zan zan cmarcelo noam webkit.review.bot oldest_to_newest 828737 0 zan 2013-02-08 13:20:54 -0800 The build fails in TextureMapperShaderProgram.cpp when building with Clang at the following code: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp#L76 The errors being thrown out: ../../Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:81:9: error: non-constant-expression cannot be narrowed from type 'double' to 'GC3Dfloat' (aka 'float') in initializer list matrix.m11(), matrix.m12(), matrix.m13(), matrix.m14(), ^~~~~~~~~~~~ ../../Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:81:9: note: override this message by inserting an explicit cast matrix.m11(), matrix.m12(), matrix.m13(), matrix.m14(), ^~~~~~~~~~~~ static_cast<)C3Dfloat>( ../../Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:81:23: error: non-constant-expression cannot be narrowed from type 'double' to 'GC3Dfloat' (aka 'float') in initializer list matrix.m11(), matrix.m12(), matrix.m13(), matrix.m14(), ^~~~~~~~~~~~ ../../Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:81:23: note: override this message by inserting an explicit cast matrix.m11(), matrix.m12(), matrix.m13(), matrix.m14(), ^~~~~~~~~~~~ static_cast<)C3Dfloat>( (... and so on for the other 14 arguments as well). 828741 1 187358 zan 2013-02-08 13:37:29 -0800 Created attachment 187358 Patch 828994 2 noam 2013-02-09 03:04:07 -0800 implicit constructors would also work, without an additional "as" function: GC3Dfloat(double) 829243 3 zan 2013-02-10 01:07:06 -0800 (In reply to comment #2) > implicit constructors would also work, without an additional "as" function: > GC3Dfloat(double) I guess you meant explicit constructors. They work indeed, I'll upload a patch with those being used. 829245 4 187470 zan 2013-02-10 01:14:43 -0800 Created attachment 187470 Patch 829255 5 187470 zan 2013-02-10 02:42:08 -0800 Comment on attachment 187470 Patch Clearing flags on attachment: 187470 Committed r142392: <http://trac.webkit.org/changeset/142392> 829256 6 zan 2013-02-10 02:42:18 -0800 All reviewed patches have been landed. Closing bug. 187358 2013-02-08 13:37:29 -0800 2013-02-10 01:14:34 -0800 Patch bug-109321-20130208223405.patch text/plain 2633 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MjMxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAyLTA4ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBCdWlsZCBlcnJv cnMgaW4gVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0uY3BwIHdoZW4gY29tcGlsaW5nIHdpdGgg Q2xhbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw OTMyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENs YW5nIGlzIHJlcG9ydGluZyBlcnJvcnMgZHVlIHRvIG5vbi1jb25zdGFudCBleHByZXNzaW9ucyB0 aGF0IGNhbm5vdCBiZSBuYXJyb3dlZAorICAgICAgICBmcm9tIGRvdWJsZSB0byBmbG9hdCB0eXBl IGluIGluaXRpYWxpemVyIGxpc3Qgd2hlbiBjb25zdHJ1Y3RpbmcgYSBtYXRyaXggb2YgR0MzRGZs b2F0CisgICAgICAgIG51bWJlcnMuIFRvIGF2b2lkIHRoaXMgZXZlcnkgcGFyYW1ldGVyIGlzIHBh c3NlZCB0aHJvdWdoIGFuIGlubGluZSBmdW5jdGlvbiB0aGF0IGNhc3RzCisgICAgICAgIHRoZSB2 YWx1ZSBmcm9tIHRoZSBkb3VibGUgdHlwZSB0byB0aGUgR0MzRGZsb2F0IG9uZS4KKworICAgICAg ICBObyBuZXcgdGVzdHMgLSBubyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjphc0dDM0RmbG9hdCk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAg KFdlYkNvcmU6OlRleHR1cmVNYXBwZXJTaGFkZXJQcm9ncmFtOjpzZXRNYXRyaXgpOgorCiAyMDEz LTAyLTA4ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBQdXQgc25h cHNob3R0aW5nIGxhYmVsIHRleHQgaW50byBsb2NhbGl6YWJsZSBzdHJpbmdzCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlclNoYWRlclBy b2dyYW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3RleG1hcC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbS5jcHAJKHJldmlzaW9uIDE0MjMxOCkK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVy U2hhZGVyUHJvZ3JhbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcwLDEzICs3MCwxOCBAQCBUZXh0 dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbTo6VGV4dHVyZU1hcHBlCiAgICAgTE9HKENvbXBvc2l0aW5n LCAiUHJvZ3JhbSBsb2c6ICVzXG4iLCBsb2cudXRmOCgpLmRhdGEoKSk7CiB9CiAKK3N0YXRpYyBp bmxpbmUgR0MzRGZsb2F0IGFzR0MzRGZsb2F0KGRvdWJsZSB2YWx1ZSkKK3sKKyAgICByZXR1cm4g c3RhdGljX2Nhc3Q8R0MzRGZsb2F0Pih2YWx1ZSk7Cit9CisKIHZvaWQgVGV4dHVyZU1hcHBlclNo YWRlclByb2dyYW06OnNldE1hdHJpeChHQzNEdWludCBsb2NhdGlvbiwgY29uc3QgVHJhbnNmb3Jt YXRpb25NYXRyaXgmIG1hdHJpeCkKIHsKICAgICBHQzNEZmxvYXQgbWF0cml4QXNGbG9hdHNbXSA9 IHsKLSAgICAgICAgbWF0cml4Lm0xMSgpLCBtYXRyaXgubTEyKCksIG1hdHJpeC5tMTMoKSwgbWF0 cml4Lm0xNCgpLAotICAgICAgICBtYXRyaXgubTIxKCksIG1hdHJpeC5tMjIoKSwgbWF0cml4Lm0y MygpLCBtYXRyaXgubTI0KCksCi0gICAgICAgIG1hdHJpeC5tMzEoKSwgbWF0cml4Lm0zMigpLCBt YXRyaXgubTMzKCksIG1hdHJpeC5tMzQoKSwKLSAgICAgICAgbWF0cml4Lm00MSgpLCBtYXRyaXgu bTQyKCksIG1hdHJpeC5tNDMoKSwgbWF0cml4Lm00NCgpCisgICAgICAgIGFzR0MzRGZsb2F0KG1h dHJpeC5tMTEoKSksIGFzR0MzRGZsb2F0KG1hdHJpeC5tMTIoKSksIGFzR0MzRGZsb2F0KG1hdHJp eC5tMTMoKSksIGFzR0MzRGZsb2F0KG1hdHJpeC5tMTQoKSksCisgICAgICAgIGFzR0MzRGZsb2F0 KG1hdHJpeC5tMjEoKSksIGFzR0MzRGZsb2F0KG1hdHJpeC5tMjIoKSksIGFzR0MzRGZsb2F0KG1h dHJpeC5tMjMoKSksIGFzR0MzRGZsb2F0KG1hdHJpeC5tMjQoKSksCisgICAgICAgIGFzR0MzRGZs b2F0KG1hdHJpeC5tMzEoKSksIGFzR0MzRGZsb2F0KG1hdHJpeC5tMzIoKSksIGFzR0MzRGZsb2F0 KG1hdHJpeC5tMzMoKSksIGFzR0MzRGZsb2F0KG1hdHJpeC5tMzQoKSksCisgICAgICAgIGFzR0Mz RGZsb2F0KG1hdHJpeC5tNDEoKSksIGFzR0MzRGZsb2F0KG1hdHJpeC5tNDIoKSksIGFzR0MzRGZs b2F0KG1hdHJpeC5tNDMoKSksIGFzR0MzRGZsb2F0KG1hdHJpeC5tNDQoKSkKICAgICB9OwogCiAg ICAgbV9jb250ZXh0LT51bmlmb3JtTWF0cml4NGZ2KGxvY2F0aW9uLCAxLCBmYWxzZSwgbWF0cml4 QXNGbG9hdHMpOwo= 187470 2013-02-10 01:14:43 -0800 2013-02-10 02:42:08 -0800 Patch bug-109321-20130210101112.patch text/plain 2332 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MjM5MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTEwICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBCdWlsZCBlcnJv cnMgaW4gVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0uY3BwIHdoZW4gY29tcGlsaW5nIHdpdGgg Q2xhbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw OTMyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENs YW5nIGlzIHJlcG9ydGluZyBlcnJvcnMgZHVlIHRvIG5vbi1jb25zdGFudCBleHByZXNzaW9ucyB0 aGF0IGNhbm5vdCBiZSBuYXJyb3dlZAorICAgICAgICBmcm9tIGRvdWJsZSB0byBmbG9hdCB0eXBl IGluIGluaXRpYWxpemVyIGxpc3Qgd2hlbiBjb25zdHJ1Y3RpbmcgYSBtYXRyaXggb2YgR0MzRGZs b2F0CisgICAgICAgIG51bWJlcnMuIFRvIGF2b2lkIHRoaXMgZXZlcnkgcGFyYW1ldGVyIGlzIHBh c3NlZCB0aHJvdWdoIGFuIGV4cGxpY2l0IEdDM0RmbG9hdCBjb25zdHJ1Y3Rvci4KKworICAgICAg ICBObyBuZXcgdGVzdHMgLSBubyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpUZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbTo6c2V0TWF0cml4KToKKwog MjAxMy0wMi0wOSAgRG9taW5pYyBNYXp6b25pICA8ZG1henpvbmlAZ29vZ2xlLmNvbT4KIAogICAg ICAgICBmYXN0L2VuY29kaW5nL3BhcnNlci10ZXN0cy0qLmh0bWwgdGVzdHMgc29tZXRpbWVzIGNy YXNoCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVy ZU1hcHBlclNoYWRlclByb2dyYW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbS5jcHAJKHJl dmlzaW9uIDE0MjM5MCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1h cC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTczLDEw ICs3MywxMCBAQCBUZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbTo6VGV4dHVyZU1hcHBlCiB2b2lk IFRleHR1cmVNYXBwZXJTaGFkZXJQcm9ncmFtOjpzZXRNYXRyaXgoR0MzRHVpbnQgbG9jYXRpb24s IGNvbnN0IFRyYW5zZm9ybWF0aW9uTWF0cml4JiBtYXRyaXgpCiB7CiAgICAgR0MzRGZsb2F0IG1h dHJpeEFzRmxvYXRzW10gPSB7Ci0gICAgICAgIG1hdHJpeC5tMTEoKSwgbWF0cml4Lm0xMigpLCBt YXRyaXgubTEzKCksIG1hdHJpeC5tMTQoKSwKLSAgICAgICAgbWF0cml4Lm0yMSgpLCBtYXRyaXgu bTIyKCksIG1hdHJpeC5tMjMoKSwgbWF0cml4Lm0yNCgpLAotICAgICAgICBtYXRyaXgubTMxKCks IG1hdHJpeC5tMzIoKSwgbWF0cml4Lm0zMygpLCBtYXRyaXgubTM0KCksCi0gICAgICAgIG1hdHJp eC5tNDEoKSwgbWF0cml4Lm00MigpLCBtYXRyaXgubTQzKCksIG1hdHJpeC5tNDQoKQorICAgICAg ICBHQzNEZmxvYXQobWF0cml4Lm0xMSgpKSwgR0MzRGZsb2F0KG1hdHJpeC5tMTIoKSksIEdDM0Rm bG9hdChtYXRyaXgubTEzKCkpLCBHQzNEZmxvYXQobWF0cml4Lm0xNCgpKSwKKyAgICAgICAgR0Mz RGZsb2F0KG1hdHJpeC5tMjEoKSksIEdDM0RmbG9hdChtYXRyaXgubTIyKCkpLCBHQzNEZmxvYXQo bWF0cml4Lm0yMygpKSwgR0MzRGZsb2F0KG1hdHJpeC5tMjQoKSksCisgICAgICAgIEdDM0RmbG9h dChtYXRyaXgubTMxKCkpLCBHQzNEZmxvYXQobWF0cml4Lm0zMigpKSwgR0MzRGZsb2F0KG1hdHJp eC5tMzMoKSksIEdDM0RmbG9hdChtYXRyaXgubTM0KCkpLAorICAgICAgICBHQzNEZmxvYXQobWF0 cml4Lm00MSgpKSwgR0MzRGZsb2F0KG1hdHJpeC5tNDIoKSksIEdDM0RmbG9hdChtYXRyaXgubTQz KCkpLCBHQzNEZmxvYXQobWF0cml4Lm00NCgpKQogICAgIH07CiAKICAgICBtX2NvbnRleHQtPnVu aWZvcm1NYXRyaXg0ZnYobG9jYXRpb24sIDEsIGZhbHNlLCBtYXRyaXhBc0Zsb2F0cyk7Cg==