109292 2013-02-08 05:51:28 -0800 RTCPeerConnection.getStats() fails when remote stats are instantiated. 2013-02-08 09:07:07 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hta hta eric.carlson feature-media-reviews tommyw webkit.review.bot oldest_to_newest 828490 0 hta 2013-02-08 05:51:28 -0800 Assert failure observed. Stack trace: webkit!WebCore::RTCStatsReport::addElement+0xe4 webkit!WebCore::RTCStatsResponse::addElement+0x6b webkit!WebKit::WebRTCStatsResponse::addElement+0x44 content!content::LocalRTCStatsResponse::addElement+0x2f content!content::StatsResponse::AddElement+0x72 content!content::StatsResponse::OnComplete+0x149 content!webrtc::PeerConnection::OnMessage+0x21c content!jingle_glue::JingleThreadWrapper::RunTask+0x283 Code: void RTCStatsReport::addElement(bool isLocal, double timestamp) { if (isLocal) { ASSERT(!m_local); m_local = RTCStatsElement::create(timestamp); } ASSERT(!m_remote); <<============================================ m_remote = RTCStatsElement::create(timestamp); } Missing RETURN inside if block. 828527 1 187308 hta 2013-02-08 06:36:32 -0800 Created attachment 187308 Patch 828620 2 187308 webkit.review.bot 2013-02-08 09:07:04 -0800 Comment on attachment 187308 Patch Clearing flags on attachment: 187308 Committed r142289: <http://trac.webkit.org/changeset/142289> 828621 3 webkit.review.bot 2013-02-08 09:07:07 -0800 All reviewed patches have been landed. Closing bug. 187308 2013-02-08 06:36:32 -0800 2013-02-08 09:07:04 -0800 Patch bug-109292-20130208153306.patch text/plain 3039 hta U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTc5ZmE3ZWFiMDBiZjNj YmVmMjViYTU0Yzg1Y2RiYjA5OGE2N2M3Yy4uODNjMDI2NjI2M2ZlYmRhNjNmN2JiM2RhMjUyMzZl MmY0ZDA0YzNiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAyLTA4ICBIYXJh bGQgQWx2ZXN0cmFuZCAgPGh0YUBnb29nbGUuY29tPgorCisgICAgICAgIEZpeCBhbmQgdGVzdCBm b3IgbWlzc2luZyByZXR1cm4gc3RhdGVtZW50CisKKyAgICAgICAgUlRDUGVlckNvbm5lY3Rpb24u Z2V0U3RhdHMoKSBmYWlsZWQgd2hlbiByZW1vdGUgc3RhdHMgd2VyZSBpbnN0YW50aWF0ZWQuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDkyOTIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0ZWQgYnkg ZXh0ZW5kaW5nIHRoZSBleGlzdGluZyBtb2NrJ3MgYmVoYXZpb3VyLgorCisgICAgICAgICogTW9k dWxlcy9tZWRpYXN0cmVhbS9SVENTdGF0c1JlcG9ydC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS VENTdGF0c1JlcG9ydDo6YWRkRWxlbWVudCk6CisKIDIwMTMtMDItMDMgIE1pa2UgV2VzdCAgPG1r d3N0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBDbGVhbnVwOiAnRXhjZXB0aW9uQ29kZSYgZWMn LCBub3QgJ0V4Y2VwdGlvbkNvZGUgJmVjJy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFzdHJlYW0vUlRDU3RhdHNSZXBvcnQuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tZWRpYXN0cmVhbS9SVENTdGF0c1JlcG9ydC5jcHAKaW5kZXggNGNlOTJmZjJhNDJhYTE4 NjhiM2ZhZmJjMGI5MGQwZmFjNzc0YzNkNS4uYTU2MTZkNTllOWZhMDJjOGMyM2U5OGJkOGY1NTY4 ZTUzYWFhNDRjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVh bS9SVENTdGF0c1JlcG9ydC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0 cmVhbS9SVENTdGF0c1JlcG9ydC5jcHAKQEAgLTQ0LDYgKzQ0LDcgQEAgdm9pZCBSVENTdGF0c1Jl cG9ydDo6YWRkRWxlbWVudChib29sIGlzTG9jYWwsIGRvdWJsZSB0aW1lc3RhbXApCiAgICAgaWYg KGlzTG9jYWwpIHsKICAgICAgICAgQVNTRVJUKCFtX2xvY2FsKTsKICAgICAgICAgbV9sb2NhbCA9 IFJUQ1N0YXRzRWxlbWVudDo6Y3JlYXRlKHRpbWVzdGFtcCk7CisgICAgICAgIHJldHVybjsKICAg ICB9CiAgICAgQVNTRVJUKCFtX3JlbW90ZSk7CiAgICAgbV9yZW1vdGUgPSBSVENTdGF0c0VsZW1l bnQ6OmNyZWF0ZSh0aW1lc3RhbXApOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9v bHMvQ2hhbmdlTG9nCmluZGV4IDFlZTU4YjkxYzQ5YTdmYWNhZTQwNmVlYThkNGZjZjRiYjBmZjFi MDEuLmJlNDk0MWVjOTAxNWZmYjg4NGE5Y2ZlZDBmMzkyYjEwNWE5OTA2YWMgMTAwNjQ0Ci0tLSBh L1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxMy0wMi0wOCAgSGFyYWxkIEFsdmVzdHJhbmQgIDxodGFAZ29vZ2xlLmNvbT4KKworICAgICAg ICBGaXggYW5kIHRlc3QgZm9yIG1pc3NpbmcgcmV0dXJuCisKKyAgICAgICAgUlRDUGVlckNvbm5l Y3Rpb24uZ2V0U3RhdHMoKSBmYWlscyB3aGVuIHJlbW90ZSBzdGF0cyBhcmUgaW5zdGFudGlhdGVk LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5Mjky CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9Nb2NrV2ViUlRDUGVlckNvbm5lY3Rpb25IYW5kbGVyLmNwcDoK KyAgICAgICAgKE1vY2tXZWJSVENQZWVyQ29ubmVjdGlvbkhhbmRsZXI6OmdldFN0YXRzKToKKwog MjAxMy0wMi0wMiAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgQWRk IEFudG9pbmUgUXVpbnQgdG8gdGhlIGxpc3Qgb2YgY29tbWl0dGVycwpkaWZmIC0tZ2l0IGEvVG9v bHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTW9ja1dlYlJUQ1BlZXJDb25uZWN0aW9uSGFuZGxl ci5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9Nb2NrV2ViUlRDUGVlckNvbm5l Y3Rpb25IYW5kbGVyLmNwcAppbmRleCAxZmMwYzc5YzdkNzExNDQ1OWRkYmY2NmNmYjM0MTVhZWRm NDM5NjUwLi40Njk1YTJkZjZmODk5YjViM2ZmM2U1YjdjZGNiNWNhNDE0YTg4ZGZkIDEwMDY0NAot LS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9Nb2NrV2ViUlRDUGVlckNvbm5lY3Rp b25IYW5kbGVyLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9Nb2NrV2Vi UlRDUGVlckNvbm5lY3Rpb25IYW5kbGVyLmNwcApAQCAtMjgxLDYgKzI4MSw4IEBAIHZvaWQgTW9j a1dlYlJUQ1BlZXJDb25uZWN0aW9uSGFuZGxlcjo6Z2V0U3RhdHMoY29uc3QgV2ViUlRDU3RhdHNS ZXF1ZXN0JiByZXF1ZXN0CiAgICAgICAgICAgICByZXBvcnRJbmRleCA9IHJlc3BvbnNlLmFkZFJl cG9ydCgpOwogICAgICAgICAgICAgcmVzcG9uc2UuYWRkRWxlbWVudChyZXBvcnRJbmRleCwgdHJ1 ZSwgY3VycmVudERhdGUpOwogICAgICAgICAgICAgcmVzcG9uc2UuYWRkU3RhdGlzdGljKHJlcG9y dEluZGV4LCB0cnVlLCAidHlwZSIsICJ2aWRlbyIpOworICAgICAgICAgICAgLy8gV2UgYWRkIGFu IGVtcHR5IHJlbW90ZSByZXBvcnQgZWxlbWVudC4KKyAgICAgICAgICAgIHJlc3BvbnNlLmFkZEVs ZW1lbnQocmVwb3J0SW5kZXgsIGZhbHNlLCBjdXJyZW50RGF0ZSk7CiAgICAgICAgIH0KICAgICB9 CiAgICAgcG9zdFRhc2sobmV3IFJUQ1N0YXRzUmVxdWVzdFN1Y2NlZWRlZFRhc2sodGhpcywgcmVx dWVzdCwgcmVzcG9uc2UpKTsK