109253 2013-02-07 21:19:31 -0800 [BlackBerry] webpage needs null check in BackingStore::setCurrentBackingStoreOwner 2013-02-08 04:16:21 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 charles.wei charles.wei jpetsovits staikos webkit.review.bot oldest_to_newest 828165 0 charles.wei 2013-02-07 21:19:31 -0800 In void BackingStorePrivate::setCurrentBackingStoreOwner(WebPage* webPage) { // Let the previously active backingstore release its tile buffers so // the new one (e.g. another tab) can use the buffers to render contents. if (BackingStorePrivate::s_currentBackingStoreOwner && BackingStorePrivate::s_currentBackingStoreOwner != webPage) BackingStorePrivate::s_currentBackingStoreOwner->d->m_backingStore->d->resetTiles(); BackingStorePrivate::s_currentBackingStoreOwner = webPage; webPage->backingStore()->d->updateSuspendScreenUpdateState(); // depends on isActive() } webPage could be null when a tab is been deleted, so we need to check for null before using webPage. 828173 1 187232 charles.wei 2013-02-07 21:24:37 -0800 Created attachment 187232 Patch 828174 2 187232 charles.wei 2013-02-07 21:28:10 -0800 Comment on attachment 187232 Patch Already reviewed and approved by George. Commit it. 828186 3 187232 webkit.review.bot 2013-02-07 21:49:23 -0800 Comment on attachment 187232 Patch Clearing flags on attachment: 187232 Committed r142227: <http://trac.webkit.org/changeset/142227> 828187 4 webkit.review.bot 2013-02-07 21:49:26 -0800 All reviewed patches have been landed. Closing bug. 187232 2013-02-07 21:24:37 -0800 2013-02-07 21:49:23 -0800 Patch bug-109253-20130208132111.patch text/plain 1600 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBhMjM3NTMxNTZjNTkxZWYxMjhiYjU5M2Q0NzJhMDlkOGY1OGU4ZGU3Li5hMWM0NTY4MTk1 NTRmY2YwNTU0YWE1MTAxMGYzOWFjMDQzNzhmMWU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wMi0wNyAgQ2hhcmxlcyBXZWkgIDxjaGFybGVz LndlaUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgd2VicGFnZSBuZWVkcyBudWxsIGNo ZWNrIGluIEJhY2tpbmdTdG9yZTo6c2V0Q3VycmVudEJhY2tpbmdTdG9yZU93bmVyCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDkyNTMKKworICAgICAg ICBSZXZpZXdlZCBieSBHZW9yZ2UgU3RhaWtvcy4KKworICAgICAgICAqIEFwaS9CYWNraW5nU3Rv cmUuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpCYWNraW5nU3RvcmVQcml2YXRl OjpzZXRDdXJyZW50QmFja2luZ1N0b3JlT3duZXIpOgorCiAyMDEzLTAyLTA3ICBNYXJ5IFd1ICA8 bWFyeS53dUB0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEVuYWJs ZSBub24tdmlkZW8gZWxlbWVudCBlbnRlci9leGl0IGZ1bGxzY3JlZW4uCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAKaW5kZXggMWZiMTFmZjEzODk2Yzdl NmM2NTYxZjQ5NDkwNWRlOGIyNGIwOGI0Mi4uMzJjYTExZGM3Yjc2MzVjNDdjNjhmZWFhYmM0MTYw M2YyNjhmNzc3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNr aW5nU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0 b3JlLmNwcApAQCAtMjM0OCw3ICsyMzQ4LDggQEAgdm9pZCBCYWNraW5nU3RvcmVQcml2YXRlOjpz ZXRDdXJyZW50QmFja2luZ1N0b3JlT3duZXIoV2ViUGFnZSogd2ViUGFnZSkKICAgICAgICAgQmFj a2luZ1N0b3JlUHJpdmF0ZTo6c19jdXJyZW50QmFja2luZ1N0b3JlT3duZXItPmQtPm1fYmFja2lu Z1N0b3JlLT5kLT5yZXNldFRpbGVzKCk7CiAKICAgICBCYWNraW5nU3RvcmVQcml2YXRlOjpzX2N1 cnJlbnRCYWNraW5nU3RvcmVPd25lciA9IHdlYlBhZ2U7Ci0gICAgd2ViUGFnZS0+YmFja2luZ1N0 b3JlKCktPmQtPnVwZGF0ZVN1c3BlbmRTY3JlZW5VcGRhdGVTdGF0ZSgpOyAvLyBkZXBlbmRzIG9u IGlzQWN0aXZlKCkKKyAgICBpZiAod2ViUGFnZSkKKyAgICAgICAgd2ViUGFnZS0+YmFja2luZ1N0 b3JlKCktPmQtPnVwZGF0ZVN1c3BlbmRTY3JlZW5VcGRhdGVTdGF0ZSgpOyAvLyBkZXBlbmRzIG9u IGlzQWN0aXZlKCkKIH0KIAogYm9vbCBCYWNraW5nU3RvcmVQcml2YXRlOjppc0FjdGl2ZSgpIGNv bnN0Cg==