109248 2013-02-07 19:20:38 -0800 [Mac] Experimental gyp-based build system 2013-04-05 01:07:20 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 mrowe webkit-unassigned aestes aroben cbiesinger dino dpranke eric.carlson eric laszlo.gombos mark mjs shezbaig.wk thakis oldest_to_newest 828107 0 mrowe 2013-02-07 19:20:38 -0800 As discussed on webkit-dev, we should attempt to bring up a gyp-based build system for the Mac. This will help us determine if there are any limitations in gyp that need to be addressed. 828110 1 mrowe 2013-02-07 19:29:07 -0800 I started experimenting with this today by setting up gyp to generate an Xcode project for WTF that matches the structure and configuration of the current Xcode project. This should help minimize any changes in build behavior. I believe I've got things set up in such a way that they work for engineering builds ("xcodebuild -configuration Debug" or "xcodebuild -configuration Release"). I'm struggling to get a project that works for our production builds though, unless I move the .gyp file to the top level of the WTF directory. 828117 2 dpranke 2013-02-07 19:51:57 -0800 what setting in xcode controls where the project directory is set? Put differently, what setting in the generated wtf.xcodeproj is wrong, and what is the corresponding setting in the checked-in wtf.xcodeproj? 828126 3 mrowe 2013-02-07 20:12:18 -0800 projectDirPath on the project object gets set to the path containing the .gyp file: projectDirPath = WTF.gyp/mac; This causes SRCROOT to get set to Source/WTF/WTF.gyp/mac, which is bogus. SRCROOT is supposed to point to the top level directory containing the source (Source/WTF). 828132 4 mrowe 2013-02-07 20:16:15 -0800 Maybe I'm invoking gyp wrong? In order to get it to spit the Xcode project out at the right location I'm doing: cd WTF.gyp/mac && gyp --generator-output=../.. -f xcode --depth=. WTF.gyp If I run gyp from the top level directory and specify "." as the output directory then I don't get the bogus projectDirPath value, but the Xcode project ends up in a subdirectory rather than where I wanted it. 828139 5 dpranke 2013-02-07 20:32:16 -0800 it's a bit hard to say what's wrong. Can you post the WT.gyp you're using? 828140 6 dpranke 2013-02-07 20:32:28 -0800 (WTF.gyp, rather). 828143 7 187227 mrowe 2013-02-07 20:34:51 -0800 Created attachment 187227 WTF.gyp for Mac I've attached a patch that shows the gyp file I'm experimenting with for WTF in case anyone wants to take a look. I've tweaked the "Copy WTF Headers" script phase to dump out the value of SRCROOT and gyp's project_dir. This shows that no matter where I generate the .xcodeproj to, gyp tweaks the projects projectDirPath such that SRCROOT is always incorrect. 828207 8 dpranke 2013-02-07 22:42:36 -0800 Okay, I have reproduced this. I think what's going on is that GYP uses the location of the .gyp file as the current working directory for any relative paths, and in order for that to translate most easily into the xcodeproject, we set the projectDirPath to match the directory containing the gyp file. As you say, it does look like projectDirPath/SRCROOT is supposed to be the directory containing the .xcodeproj. When that is not the same as the directory containing the .gyp file, you're gonna have problems. At this point, I can't say why gyp does this, and we'd probably need to check w/ Mark Mentovai (or maybe Nico), since my knowledge of both xcode and the gyp xcode generator is pretty weak. Perhaps the thing to do is to adjust the xcode gyp generator to make sure the relative paths are based on the directory containing the .xcodeproj, not the directory containing the .gyp . Or, maybe there's a reason it needs to be this way, dunno. Generally speaking, we always put the .xcodeproj's next to the .gyp files. So, for you to get something to work, you could probably work around this by moving your WTF.gyp from Source/WTF/WTF.gyp/mac/WTF.gyp to just Source/WTF . If we do eventually go down the "everyone uses gyp" route, that seems like the better thing to do anyway. Hope this helps and I haven't written anything wrong here, but if I have hopefully Mark Mentovai or Nico will correct me. 828347 9 mrowe 2013-02-08 02:03:48 -0800 (In reply to comment #8) > Generally speaking, we always put the .xcodeproj's next to the .gyp files. So, for you to get something to work, you could probably work around this by moving your WTF.gyp from Source/WTF/WTF.gyp/mac/WTF.gyp to just Source/WTF . If we do eventually go down the "everyone uses gyp" route, that seems like the better thing to do anyway. This seems like a reasonable workaround while I'm experimenting with this. 832346 10 187227 thakis 2013-02-13 14:26:08 -0800 Comment on attachment 187227 WTF.gyp for Mac View in context: https://bugs.webkit.org/attachment.cgi?id=187227&action=review > Source/WTF/WTF.gyp/mac/WTF.gyp:7 > + 'xcode_config_file': '<(project_dir)/Configurations/Base.xcconfig', Just FYI: xcode_config_file works for the xcode backend of gyp, but there's no support for it in the make and ninja generators. There's http://crbug.com/90043 open for adding support, but we ended up not needing it for chromium, so we didn't implement that. Just copying the contents of the xcconfig into an xcode_settings block doesn't quite work either, because the conditional syntax used in your xcconfig files isn't emulated either: http://crbug.com/122592 We ended up using gyp conditionals instead, so we didn't end up implementing this either. If you only care about producing xcode files , this is a non-issue for you. 832349 11 mrowe 2013-02-13 14:33:51 -0800 (In reply to comment #10) > (From update of attachment 187227 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=187227&action=review > > > Source/WTF/WTF.gyp/mac/WTF.gyp:7 > > + 'xcode_config_file': '<(project_dir)/Configurations/Base.xcconfig', > > Just FYI: xcode_config_file works for the xcode backend of gyp, but there's no support for it in the make and ninja generators. There's http://crbug.com/90043 open for adding support, but we ended up not needing it for chromium, so we didn't implement that. > > Just copying the contents of the xcconfig into an xcode_settings block doesn't quite work either, because the conditional syntax used in your xcconfig files isn't emulated either: http://crbug.com/122592 We ended up using gyp conditionals instead, so we didn't end up implementing this either. > > If you only care about producing xcode files , this is a non-issue for you. Understood. I'm initially trying to match the structure of our existing Xcode projects. Once we get that working, we can evolve towards a less Xcode-specific gyp file. 187227 2013-02-07 20:34:51 -0800 2013-02-13 14:26:08 -0800 WTF.gyp for Mac WTF-gyp.patch text/plain 2938 mrowe ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvV1RGLmd5cC9tYWMvV1RGLmd5cCBiL1NvdXJjZS9XVEYv V1RGLmd5cC9tYWMvV1RGLmd5cApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi42 ZjM2MmUxCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dURi9XVEYuZ3lwL21hYy9XVEYuZ3lw CkBAIC0wLDAgKzEsNjcgQEAKK3sKKyAgJ2luY2x1ZGVzJzogWworICAgICcuLi8uLi9XVEYuZ3lw aScsCisgIF0sCisgICdjb25maWd1cmF0aW9ucyc6IHsKKyAgICAnUHJvZHVjdGlvbic6IHsKKyAg ICAgICd4Y29kZV9jb25maWdfZmlsZSc6ICc8KHByb2plY3RfZGlyKS9Db25maWd1cmF0aW9ucy9C YXNlLnhjY29uZmlnJywKKyAgICB9LAorICAgICdSZWxlYXNlJzogeworICAgICAgJ3hjb2RlX2Nv bmZpZ19maWxlJzogJzwocHJvamVjdF9kaXIpL0NvbmZpZ3VyYXRpb25zL0RlYnVnUmVsZWFzZS54 Y2NvbmZpZycsCisgICAgfSwKKyAgICAnRGVidWcnOiB7CisgICAgICAneGNvZGVfY29uZmlnX2Zp bGUnOiAnPChwcm9qZWN0X2RpcikvQ29uZmlndXJhdGlvbnMvRGVidWdSZWxlYXNlLnhjY29uZmln JywKKyAgICAgICd4Y29kZV9zZXR0aW5ncyc6IHsKKyAgICAgICAgJ1NUUklQX0lOU1RBTExFRF9Q Uk9EVUNUJzogJyQoU1RSSVBfSU5TVEFMTEVEX1BST0RVQ1RfZGVidWcpJywKKyAgICAgICAgJ0RF QURfQ09ERV9TVFJJUFBJTkcnOiAnJChERUFEX0NPREVfU1RSSVBQSU5HX2RlYnVnKScsCisgICAg ICAgICdHQ0NfT1BUSU1JWkFUSU9OX0xFVkVMJzogJyQoR0NDX09QVElNSVpBVElPTl9MRVZFTF9k ZWJ1ZyknLAorICAgICAgICAnREVCVUdfREVGSU5FUyc6ICckKERFQlVHX0RFRklORVNfZGVidWcp JywKKyAgICAgIH0sCisgICAgfSwKKyAgfSwKKyAgJ3RhcmdldF9kZWZhdWx0cyc6IHsKKyAgICAn Y29uZmlndXJhdGlvbnMnOiB7CisgICAgICAnUHJvZHVjdGlvbic6IHt9LAorICAgICAgJ0RlYnVn Jzoge30sCisgICAgICAnUmVsZWFzZSc6IHt9CisgICAgfQorICB9LAorICAndGFyZ2V0cyc6IFsK KyAgICB7CisgICAgICAndGFyZ2V0X25hbWUnOiAnV1RGJywKKyAgICAgICd0eXBlJzogJ3N0YXRp Y19saWJyYXJ5JywKKyAgICAgICd4Y29kZV9jb25maWdfZmlsZSc6ICc8KHByb2plY3RfZGlyKS9D b25maWd1cmF0aW9ucy9XVEYueGNjb25maWcnLAorICAgICAgJ2RlcGVuZGVuY2llcyc6IFsnQ29w eSBXVEYgSGVhZGVycyddLAorICAgICAgJ3NvdXJjZXMnOiBbCisgICAgICAgICcuLi8uLi9jb25m aWcuaCcsCisgICAgICAgICc8QCh3dGZfcHJpdmF0ZWhlYWRlcl9maWxlcyknLAorICAgICAgICAn PEAod3RmX2ZpbGVzKScsCisgICAgICBdLAorICAgICAgJ3NvdXJjZXMvJzogWworICAgICAgICBb J2V4Y2x1ZGUnLCAnd3RmL2Nocm9taXVtJ10sCisgICAgICAgIFsnZXhjbHVkZScsICd3dGYvZWZs J10sCisgICAgICAgIFsnZXhjbHVkZScsICd3dGYvZ3RrJ10sCisgICAgICAgIFsnZXhjbHVkZScs ICd3dGYvcXQnXSwKKyAgICAgICAgWydleGNsdWRlJywgJ3d0Zi91bmljb2RlL3F0NCddLAorICAg ICAgICBbJ2V4Y2x1ZGUnLCAnd3RmL3VuaWNvZGUvd2NoYXInXSwKKyAgICAgICAgWydleGNsdWRl JywgJ3d0Zi91cmwnXSwKKyAgICAgICAgWydleGNsdWRlJywgJ3d0Zi93aW5jZSddLAorICAgICAg ICBbJ2V4Y2x1ZGUnLCAnd3RmL3d4J10sCisgICAgICAgIFsnZXhjbHVkZScsICcoRGVmYXVsdHxX Y2hhcnxHdGt8Tm9uZXxRdHxXaW58V3h8RWZsKVxcLihjcHB8bW0pJCddLAorICAgICAgXSwKKyAg ICB9LAorICAgIHsKKyAgICAgICd0YXJnZXRfbmFtZSc6ICdDb3B5IFdURiBIZWFkZXJzJywKKyAg ICAgICd0eXBlJzogJ25vbmUnLAorICAgICAgJ3hjb2RlX2NvbmZpZ19maWxlJzogJzwocHJvamVj dF9kaXIpL0NvbmZpZ3VyYXRpb25zL0NvcHlXVEZIZWFkZXJzLnhjY29uZmlnJywKKyAgICAgICdh Y3Rpb25zJzogWworICAgICAgICB7CisgICAgICAgICAgJ2FjdGlvbl9uYW1lJzogJ0NvcHkgV1RG IEhlYWRlcnMnLAorICAgICAgICAgICdpbnB1dHMnOiBbXSwKKyAgICAgICAgICAnb3V0cHV0cyc6 IFtdLAorICAgICAgICAgICdhY3Rpb24nOiBbJ3NoJywgJ2NvcHktd3RmLWhlYWRlcnMuc2gnLCAn PEAocHJvamVjdF9kaXIpJ10sCisgICAgICAgIH0KKyAgICAgIF0KKyAgICB9CisgIF0KK30KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvV1RGLmd5cC9tYWMvY29weS13dGYtaGVhZGVycy5zaCBiL1Nv dXJjZS9XVEYvV1RGLmd5cC9tYWMvY29weS13dGYtaGVhZGVycy5zaApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwLi43NTIxODQwCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dU Ri9XVEYuZ3lwL21hYy9jb3B5LXd0Zi1oZWFkZXJzLnNoCkBAIC0wLDAgKzEsMTMgQEAKK2lmIFtb ICIke0RFUExPWU1FTlRfTE9DQVRJT059IiA9PSAiTk8iIF1dOyB0aGVuCisgICAgUFJJVkFURV9I RUFERVJTX1BBVEg9IiR7VEFSR0VUX0JVSUxEX0RJUiUlL30ke1BSSVZBVEVfSEVBREVSU19GT0xE RVJfUEFUSH0iCitlbHNlCisgICAgUFJJVkFURV9IRUFERVJTX1BBVEg9IiR7RFNUUk9PVCUlL30k e1BSSVZBVEVfSEVBREVSU19GT0xERVJfUEFUSH0iCitmaTsKKworUFJPSkVDVF9ESVI9JDEKKwor ZWNobyAiZ3lwJ3MgcHJvamVjdF9kaXIgaXMgJHtQUk9KRUNUX0RJUn0iCitlY2hvICJTUkNST09U IGlzICR7U1JDUk9PVH0iCisKK21rZGlyIC1wICIke1BSSVZBVEVfSEVBREVSU19QQVRIfSIKK3Jz eW5jIC1hdiAtLW5vLW93bmVyIC0tbm8tZ3JvdXAgLS1wcnVuZS1lbXB0eS1kaXJzIC0tZXhjbHVk ZSAiLnN2biIgLS1leGNsdWRlICJ1c3IiIC0tZXhjbHVkZSAiRGVyaXZlZFNvdXJjZXMiIC0taW5j bHVkZSAiKi8iIC0taW5jbHVkZSAiKi5oIiAtLWV4Y2x1ZGUgIioiICIke1BST0pFQ1RfRElSfS93 dGYvIiAiJHtQUklWQVRFX0hFQURFUlNfUEFUSH0iCg==