109243 2013-02-07 17:14:59 -0800 Add a comment about how the SQLTransaction state machine works 2013-02-07 19:09:58 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104750 1 mark.lam mark.lam andersca michaeln oldest_to_newest 828037 0 mark.lam 2013-02-07 17:14:59 -0800 Just adding a big comment. No code change. 828041 1 187204 mark.lam 2013-02-07 17:20:05 -0800 Created attachment 187204 the patch. 828042 2 mark.lam 2013-02-07 17:20:29 -0800 Please review. Thanks. 828046 3 mark.lam 2013-02-07 17:25:56 -0800 Thanks for the review. Landed in r142213: <http://trac.webkit.org/changeset/142213>. 187204 2013-02-07 17:20:05 -0800 2013-02-07 17:21:01 -0800 the patch. bug-109243.patch text/plain 7292 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MjIxMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAyLTA3ICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYSBjb21tZW50IGFib3V0IGhv dyB0aGUgU1FMVHJhbnNhY3Rpb24gc3RhdGUgbWFjaGluZSB3b3Jrcy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTI0My4KKworICAgICAgICBSZXZp ZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAg ICAgICogTW9kdWxlcy93ZWJkYXRhYmFzZS9TUUxUcmFuc2FjdGlvbkJhY2tlbmQuY3BwOgorCiAy MDEzLTAyLTA3ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBbVjhdICNpZm5kZWYgTkRFQlVHIGlzIHJlZHVuZGFudCBmb3IgYXNzZXJ0Q29udGV4dEhhc0Nv cnJlY3RQcm90b3R5cGUoKQpJbmRleDogU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFz ZS9TUUxUcmFuc2FjdGlvbkJhY2tlbmQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L01vZHVsZXMvd2ViZGF0YWJhc2UvU1FMVHJhbnNhY3Rpb25CYWNrZW5kLmNwcAkocmV2aXNpb24g MTQyMjExKQorKysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFzZS9TUUxUcmFuc2Fj dGlvbkJhY2tlbmQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NSw2ICs1NSwxMjEgQEAKICNpbmNs dWRlIDx3dGYvUmVmUHRyLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKKwor Ly8gSG93IGRvZXMgYSBTUUxUcmFuc2FjdGlvbiB3b3JrPworLy8gPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09CisvLyBUaGUgU1FMVHJhbnNhY3Rpb24gaXMgYSBzdGF0ZSBtYWNoaW5lIHRo YXQgZXhlY3V0ZXMgYSBzZXJpZXMgb2Ygc3RhdGVzIC8gc3RlcHMuCisvLworLy8gdGhzIFN0YXRl IFRyYW5zaXRpb24gR3JhcGggYXQgYSBnbGFuY2U6CisvLyA9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQorLy8KKy8vICAgIEJhY2tlbmQgKHdvcmtzIHdpdGggU1FMaXRlRGF0 YWJhc2UpICAgICAgICAgIC4gICBGcm9udGVuZCAod29ya3Mgd2l0aCBTY3JpcHQpCisvLyAgICA9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PSAgICAgICAgICAuICAgPT09PT09PT09 PT09PT09PT09PT09PT09PT09PQorLy8gICAsLS0+IFN0YXRlIDA6IFtpbml0aWFsIHN0YXRlXSAg ICAgICAgICAgICAgICAgLgorLy8gICB8IF4gICAgIHYgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgLgorLy8gICB8IHwgIFN0YXRlIDE6IFthY3F1aXJlTG9ja10gICAgICAgICAg ICAgICAgICAgLgorLy8gICB8IHwgICAgIHYgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgLgorLy8gICB8IHwgIFN0YXRlIDI6IFtvcGVuVHJhbnNhY3Rpb25BbmRQcmVmbGlnaHRd IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0uCisv LyAgIHwgfCAgICAgfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAuICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKKy8vICAgfCB8ICAg ICBgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tPiBTdGF0ZSAzOiBbZGVs aXZlclRyYW5zYWN0aW9uQ2FsbGJhY2tdIC0tLS0tLiAgfAorLy8gICB8IHwgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLiAgICAgIHwgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB2ICB2CisvLyAgIHwgfCAgICAgLC0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tJyAgICAgU3RhdGUgMTA6IFtkZWxpdmVyVHJhbnNh Y3Rpb25FcnJvckNhbGxiYWNrXSArCisvLyAgIHwgfCAgICAgfCAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAuICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIF4gIF4gIF4gICB8CisvLyAgIHwgfCAgICAgdiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAuICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgIHwgIHwgICB8CisvLyAgIHwgfCAgU3RhdGUgNDogW3J1blN0YXRlbWVudHNdIC0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LScgIHwgIHwgICB8CisvLyAgIHwgfCAgICAgfCAgICAgICAgXiAgXiB8ICBeIHwgICAgICAgICAg ICAgICAgICAuICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHwgIHwgICB8CisvLyAgIHwgfCAgICAgfC0tLS0tLS0tJyAgfCB8ICB8IGAtLS0tLS0tLS0tLS0t LS0tLS0tLT4gU3RhdGUgODogW2RlbGl2ZXJTdGF0ZW1lbnRDYWxsYmFja10gKy0tLS0tLS0tLScg IHwgICB8CisvLyAgIHwgfCAgICAgfCAgICAgICAgICAgfCB8ICBgLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tJyAgICAgICAgICAgIHwg ICB8CisvLyAgIHwgfCAgICAgfCAgICAgICAgICAgfCBgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LT4gU3RhdGUgOTogW2RlbGl2ZXJRdW90YUluY3JlYXNlQ2FsbGJhY2tdICsgICAgICAgIHwgICB8 CisvLyAgIHwgfCAgICAgfCAgICAgICAgICAgIGAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLScgICAgICAgIHwgICB8Cisv LyAgIHwgfCAgICAgdiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAuICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICB8CisvLyAg IHwgfCAgU3RhdGUgNTogW3Bvc3RmbGlnaHRBbmRDb21taXRdIC0tKy0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLScgICB8CisvLyAgIHwg fCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfC0tLS0tLS0tLT4gU3RhdGUgNjog W2RlbGl2ZXJTdWNjZXNzQ2FsbGJhY2tdICsgICAgICAgICAgICAgICAgICB8CisvLyAgIHwgfCAg ICAgLC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tJyAgICAgICAuICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAgICAgICAgICAgICAgICB8CisvLyAgIHwgfCAgICAg diAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAuICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAgICAgICAgICAgICAgICB8CisvLyAgIHwgfCAgU3RhdGUg NzogW2NsZWFudXBBZnRlclN1Y2Nlc3NDYWxsYmFja10gPC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLScgICAgICAgICAgICAgICAgICB8CisvLyAgIHwgYC0tLS0tJyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAuICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8CisvLyAgIGAtLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0nCisvLyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAuCisvLworLy8gdGhlIFN0YXRlcyBhbmQgU3RhdGUg VHJhbnNpdGlvbnM6CisvLyA9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQorLy8gRXhl Y3V0ZWQgaW4gdGhlIGJhY2stZW5kOgorLy8gICAgIFN0YXRlIDA6IFtpbml0aWFsIHN0YXRlXQor Ly8gICAgIC0gT24gc2NoZWR1bGVkIHRyYW5zYWN0aW9uLCBnb3RvIFthY3F1aXJlTG9ja10uCisv LworLy8gICAgIFN0YXRlIDE6IFthY3F1aXJlTG9ja10KKy8vICAgICAtIGFjcXVpcmUgbG9jay4K Ky8vICAgICAtIG9uICJsb2NrIiBhY3F1aXNpdGlvbiwgZ290byBbb3BlblRyYW5zYWN0aW9uQW5k UHJlZmxpZ2h0XS4KKy8vCisvLyAgICAgU3RhdGUgMjogW29wZW5UcmFuc2FjdGlvbkFuZFByZWZs aWdodF0KKy8vICAgICAtIFNldHMgdXAgYW4gU1FMaXRlVHJhbnNhY3Rpb24uCisvLyAgICAgLSBi ZWdpbiB0aGUgU1FMaXRlVHJhbnNhY3Rpb24uCisvLyAgICAgLSBjYWxsIHRoZSBTUUxUcmFuc2Fj dGlvbldyYXBwZXIgcHJlZmxpZ2h0IGlmIGF2YWlsYWJsZS4KKy8vICAgICAtIHNjaGVkdWxlIHNj cmlwdCBjYWxsYmFjay4KKy8vICAgICAtIG9uIGVycm9yIChzZWUgaGFuZGxlVHJhbnNhY3Rpb25F cnJvciksIGdvdG8gW2RlbGl2ZXJUcmFuc2FjdGlvbkVycm9yQ2FsbGJhY2tdLgorLy8gICAgIC0g Z290byBbZGVsaXZlclRyYW5zYWN0aW9uQ2FsbGJhY2tdLgorLy8KKy8vIEV4ZWN1dGVkIGluIHRo ZSBmcm9udC1lbmQ6CisvLyAgICAgU3RhdGUgMzogW2RlbGl2ZXJUcmFuc2FjdGlvbkNhbGxiYWNr XQorLy8gICAgIC0gaW52b2tlIHRoZSBzY3JpcHQgZnVuY3Rpb24gY2FsbGJhY2soKSBpZiBhdmFp bGFibGUuCisvLyAgICAgLSBvbiBlcnJvciwgZ290byBbZGVsaXZlclRyYW5zYWN0aW9uRXJyb3JD YWxsYmFja10uCisvLyAgICAgLSBnb3RvIFtydW5TdGF0ZW1lbnRzXS4KKy8vCisvLyBFeGVjdXRl ZCBpbiB0aGUgYmFjay1lbmQ6CisvLyAgICAgU3RhdGUgNDogW3J1blN0YXRlbWVudHNdCisvLyAg ICAgLSB3aGlsZSB0aGVyZSBhcmUgc3RhdGVtZW50cyB7CisvLyAgICAgICAgIC0gcnVuIGEgc3Rh dGVtZW50LgorLy8gICAgICAgICAtIGlmIHN0YXRlbWVudENhbGxiYWNrIGlzIGF2YWlsYWJsZSwg Z290byBbZGVsaXZlclN0YXRlbWVudENhbGxiYWNrXS4KKy8vICAgICAgICAgLSBvbiBlcnJvciwK Ky8vICAgICAgICAgICBnb3RvIFtkZWxpdmVyUXVvdGFJbmNyZWFzZUNhbGxiYWNrXSwgb3IKKy8v ICAgICAgICAgICBnb3RvIFtkZWxpdmVyU3RhdGVtZW50Q2FsbGJhY2tdIChzZWUgaGFuZGxlQ3Vy cmVudFN0YXRlbWVudEVycm9yKSwgb3IKKy8vICAgICAgICAgICBnb3RvIFtkZWxpdmVyVHJhbnNh Y3Rpb25FcnJvckNhbGxiYWNrXS4KKy8vICAgICAgIH0KKy8vICAgICAtIGdvdG8gW3Bvc3RmbGln aHRBbmRDb21taXRdLgorLy8KKy8vICAgICBTdGF0ZSA1OiBbcG9zdGZsaWdodEFuZENvbW1pdF0K Ky8vICAgICAtIGNhbGwgdGhlIFNRTFRyYW5zYWN0aW9uV3JhcHBlciBwb3N0ZmxpZ2h0IGlmIGF2 YWlsYWJsZS4KKy8vICAgICAtIGNvbW1pdCB0aGUgU1FMaXRlVGFuc2FjdGlvbi4KKy8vICAgICAt IG9uIGVycm9yLCBnb3RvIFtkZWxpdmVyVHJhbnNhY3Rpb25FcnJvckNhbGxiYWNrXSAoc2VlIGhh bmRsZVRyYW5zYWN0aW9uRXJyb3IpLgorLy8gICAgIC0gaWYgc3VjY2Vzc0NhbGxiYWNrIGlzIGF2 YWlsYWJsZSwgZ290byBbZGVsaXZlclN1Y2Nlc3NDYWxsYmFja10uCisvLyAgICAgICBlbHNlIGdv dG8gW2NsZWFudXBBZnRlclN1Y2Nlc3NDYWxsYmFja10uCisvLworLy8gRXhlY3V0ZWQgaW4gdGhl IGZyb250LWVuZDoKKy8vICAgICBTdGF0ZSA2OiBbZGVsaXZlclN1Y2Nlc3NDYWxsYmFja10KKy8v ICAgICAtIGludm9rZSB0aGUgc2NyaXB0IGZ1bmN0aW9uIHN1Y2Nlc3NDYWxsYmFjaygpIGlmIGF2 YWlsYWJsZS4KKy8vICAgICAtIGdvdG8gW2NsZWFudXBBZnRlclN1Y2Nlc3NDYWxsYmFja10uCisv LworLy8gRXhlY3V0ZWQgaW4gdGhlIGJhY2stZW5kOgorLy8gICAgIFN0YXRlIDc6IFtjbGVhbnVw QWZ0ZXJTdWNjZXNzQ2FsbGJhY2tdCisvLyAgICAgLSBjbGVhbiB0aGUgU1FMaXRlVHJhbnNhY3Rp b24uCisvLyAgICAgLSByZWxlYXNlIGxvY2suCisvLyAgICAgLSBnb3RvIFtpbml0aWFsIHN0YXRl XS4KKy8vCisvLyBPdGhlciBzdGF0ZXM6CisvLyBFeGVjdXRlZCBpbiB0aGUgZnJvbnQtZW5kOgor Ly8gICAgIFN0YXRlIDg6IFtkZWxpdmVyU3RhdGVtZW50Q2FsbGJhY2tdCisvLyAgICAgLSBpbnZv a2Ugc2NyaXB0IHN0YXRlbWVudCBjYWxsYmFjayAoYXNzdW1lIGF2YWlsYWJsZSkuCisvLyAgICAg LSBvbiBlcnJvciAoc2VlIGhhbmRsZVRyYW5zYWN0aW9uRXJyb3IpLAorLy8gICAgICAgZ290byBb ZGVsaXZlclRyYW5zYWN0aW9uRXJyb3JDYWxsYmFja10uCisvLyAgICAgLSBnb3RvIFtydW5TdGF0 ZW1lbnRzXS4KKy8vCisvLyAgICAgU3RhdGUgOTogW2RlbGl2ZXJRdW90YUluY3JlYXNlQ2FsbGJh Y2tdCisvLyAgICAgLSBnaXZlIGNsaWVudCBhIGNoYW5jZSB0byBpbmNyZWFzZSB0aGUgcXVvdGEu CisvLyAgICAgLSBnb3RvIFtydW5TdGF0ZW1lbnRzXS4KKy8vCisvLyAgICAgU3RhdGUgMTA6IFtk ZWxpdmVyVHJhbnNhY3Rpb25FcnJvckNhbGxiYWNrXQorLy8gICAgIC0gaW52b2tlIHRoZSBzY3Jp cHQgZnVuY3Rpb24gZXJyb3JDYWxsYmFjayBpZiBhdmFpbGFibGUuCisvLyAgICAgLSBnb3RvIFtj bGVhbnVwQWZ0ZXJUcmFuc2FjdGlvbkVycm9yQ2FsbGJhY2tdLgorLy8KKy8vIEV4ZWN1dGVkIGlu IHRoZSBiYWNrLWVuZDoKKy8vICAgICBTdGF0ZSAxMTogW2NsZWFudXBBZnRlclRyYW5zYWN0aW9u RXJyb3JDYWxsYmFja10KKy8vICAgICAtIHJvbGxiYWNrIGFuZCBjbGVhciBTUUxpdGVUcmFuc2Fj dGlvbi4KKy8vICAgICAtIGNsZWFyIHN0YXRlbWVudHMuCisvLyAgICAgLSByZWxlYXNlIGxvY2su CisvLyAgICAgLSBnb3RvIFtpbml0aWFsIHN0YXRlXS4KKworCiAvLyBUaGVyZSdzIG5vIHdheSBv ZiBrbm93aW5nIGV4YWN0bHkgaG93IG11Y2ggbW9yZSBzcGFjZSB3aWxsIGJlIHJlcXVpcmVkIHdo ZW4gYSBzdGF0ZW1lbnQgaGl0cyB0aGUgcXVvdGEgbGltaXQuCiAvLyBGb3Igbm93LCB3ZSdsbCBh cmJpdHJhcmlseSBjaG9vc2UgY3VycmVudFF1b3RhICsgMW1iLgogLy8gSW4gdGhlIGZ1dHVyZSB3 ZSBkZWNpZGUgdG8gdHJhY2sgaWYgYSBzaXplIGluY3JlYXNlIHdhc24ndCBlbm91Z2gsIGFuZCBh c2sgZm9yIGxhcmdlci1hbmQtbGFyZ2VyIGluY3JlYXNlcyB1bnRpbCBpdHMgZW5vdWdoLgo=