109223 2013-02-07 13:17:19 -0800 Improve logging of MediaPlayerPrivateAVFoundation Notifications. 2013-02-07 15:20:48 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble eric.carlson feature-media-reviews webkit.review.bot oldest_to_newest 827839 0 jer.noble 2013-02-07 13:17:19 -0800 Improve logging of MediaPlayerPrivateAVFoundation Notifications. 827850 1 187163 jer.noble 2013-02-07 13:24:12 -0800 Created attachment 187163 Patch 827856 2 187163 eric.carlson 2013-02-07 13:28:42 -0800 Comment on attachment 187163 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187163&action=review > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:699 > +static const char* stringifyNotificationType(MediaPlayerPrivateAVFoundation::Notification::Type type) Nit: this name is odd, maybe just notificationName? 827923 3 jer.noble 2013-02-07 15:20:48 -0800 Committed r142186: <http://trac.webkit.org/changeset/142186> 187163 2013-02-07 13:24:12 -0800 2013-02-07 13:28:42 -0800 Patch bug-109223-20130207132047.patch text/plain 5307 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzhjYzBlYzM0MjlmOGI4 NTdkYzQwMWIxNmE0NmNlNGJhOTVlYTRhZi4uMzI2YmEwYzg0OTgzYjNiMWEyYzdmZmFlYTEyYjAz NGNmOTE2ZjNhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTA3ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIEltcHJvdmUgbG9nZ2luZyBv ZiBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24gTm90aWZpY2F0aW9ucy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTIyMworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbnZlcnQgdGhlIGV4aXN0 aW5nIE5vdGlmaWNhdGlvbiBlbnVtIHRvIGFuIGV4cGFuZGFibGUgbWFjcm8uIFRoZW4gYWRkIGEK KyAgICAgICAgTG9nZ2luZy1vbmx5IGZ1bmN0aW9uIHdoaWNoIHN0cmluZ2lmaWVzIHRoZSBlbnVt cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXll clByaXZhdGVBVkZvdW5kYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6c3RyaW5naWZ5Tm90 aWZpY2F0aW9uVHlwZSk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVBVkZv dW5kYXRpb246OnNjaGVkdWxlTWFpblRocmVhZE5vdGlmaWNhdGlvbik6CisgICAgICAgIChXZWJD b3JlOjpNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb246OmRpc3BhdGNoTm90aWZpY2F0aW9u KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQ cml2YXRlQVZGb3VuZGF0aW9uLmg6CisKIDIwMTMtMDItMDYgIERpbWEgR29yYmlrICA8ZGdvcmJp a0BhcHBsZS5jb20+CiAKICAgICAgICAgU3RvcmUgdGhlIGxhbmd1YWdlIGludGVybmFsbHkgaW5z dGVhZCBvZiB1c2luZyBsYW5nIGF0dHJpYnV0ZSBmb3IgV2ViVlRUIG5vZGVzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5 ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24uY3BwCmluZGV4 IDRkNjRiYTFmOGUxYTExMDAzYWE2YTliZmNmODM3MjUzYzc4ZWQyYjcuLmUzNDljYzhiMWUxNjZi ZjBhYjI5YmNiNzU2NWY5ZDc2MmE4NzNhNGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRp b24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlv bi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24uY3BwCkBAIC02OTUsOSArNjk1LDIxIEBA IHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uOjpzY2hlZHVsZU1haW5UaHJlYWRO b3RpZmljYXRpb24oTm90aWZpY2F0aW9uCiAgICAgc2NoZWR1bGVNYWluVGhyZWFkTm90aWZpY2F0 aW9uKE5vdGlmaWNhdGlvbih0eXBlLCBmaW5pc2hlZCkpOwogfQogCisjaWYgIUxPR19ESVNBQkxF RAorc3RhdGljIGNvbnN0IGNoYXIqIHN0cmluZ2lmeU5vdGlmaWNhdGlvblR5cGUoTWVkaWFQbGF5 ZXJQcml2YXRlQVZGb3VuZGF0aW9uOjpOb3RpZmljYXRpb246OlR5cGUgdHlwZSkKK3sKKyNkZWZp bmUgREVGSU5FX1RZUEVfU1RSSU5HX0NBU0UodHlwZSkgY2FzZSBNZWRpYVBsYXllclByaXZhdGVB VkZvdW5kYXRpb246Ok5vdGlmaWNhdGlvbjo6dHlwZTogcmV0dXJuICN0eXBlOworICAgIHN3aXRj aCAodHlwZSkgeworICAgICAgICBGT1JfRUFDSF9NRURJQVBMQVlFUlBSSVZBVEVBVkZPVU5EQVRJ T05fTk9USUZJQ0FUSU9OX1RZUEUoREVGSU5FX1RZUEVfU1RSSU5HX0NBU0UpCisgICAgfQorI3Vu ZGVmIERFRklORV9UWVBFX1NUUklOR19DQVNFCit9CisjZW5kaWYgLy8gIUxPR19ESVNBQkxFRAor ICAgIAorCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6c2NoZWR1bGVNYWlu VGhyZWFkTm90aWZpY2F0aW9uKE5vdGlmaWNhdGlvbiBub3RpZmljYXRpb24pCiB7Ci0gICAgTE9H KE1lZGlhLCAiTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uOjpzY2hlZHVsZU1haW5UaHJl YWROb3RpZmljYXRpb24oJXApIC0gbm90aWZpY2F0aW9uICVkIiwgdGhpcywgc3RhdGljX2Nhc3Q8 aW50Pihub3RpZmljYXRpb24udHlwZSgpKSk7CisgICAgTE9HKE1lZGlhLCAiTWVkaWFQbGF5ZXJQ cml2YXRlQVZGb3VuZGF0aW9uOjpzY2hlZHVsZU1haW5UaHJlYWROb3RpZmljYXRpb24oJXApIC0g bm90aWZpY2F0aW9uICVzIiwgdGhpcywgc3RyaW5naWZ5Tm90aWZpY2F0aW9uVHlwZShub3RpZmlj YXRpb24udHlwZSgpKSk7CiAgICAgbV9xdWV1ZU11dGV4LmxvY2soKTsKIAogICAgIC8vIEl0IGlz IGltcG9ydGFudCB0byBhbHdheXMgcHJvY2VzcyB0aGUgcHJvcGVydGllcyBpbiB0aGUgb3JkZXIg dGhhdCB3ZSBhcmUgbm90aWZpZWQsIApAQCAtNzQ0LDcgKzc1Niw3IEBAIHZvaWQgTWVkaWFQbGF5 ZXJQcml2YXRlQVZGb3VuZGF0aW9uOjpkaXNwYXRjaE5vdGlmaWNhdGlvbigpCiAgICAgICAgICAg ICByZXR1cm47CiAgICAgfQogCi0gICAgTE9HKE1lZGlhLCAiTWVkaWFQbGF5ZXJQcml2YXRlQVZG b3VuZGF0aW9uOjpkaXNwYXRjaE5vdGlmaWNhdGlvbiglcCkgLSBkaXNwYXRjaGluZyAlZCIsIHRo aXMsIHN0YXRpY19jYXN0PGludD4obm90aWZpY2F0aW9uLnR5cGUoKSkpOworICAgIExPRyhNZWRp YSwgIk1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6ZGlzcGF0Y2hOb3RpZmljYXRpb24o JXApIC0gZGlzcGF0Y2hpbmcgJXMiLCB0aGlzLCBzdHJpbmdpZnlOb3RpZmljYXRpb25UeXBlKG5v dGlmaWNhdGlvbi50eXBlKCkpKTsKIAogICAgIHN3aXRjaCAobm90aWZpY2F0aW9uLnR5cGUoKSkg ewogICAgIGNhc2UgTm90aWZpY2F0aW9uOjpJdGVtRGlkUGxheVRvRW5kVGltZToKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBs YXllclByaXZhdGVBVkZvdW5kYXRpb24uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24uaAppbmRleCA5 ODdiN2Q1ODI4NmVkMTM0YWM5NmExYWNmM2RmNjgxMzI3NDA2Mzk2Li5hNmE5Y2ZkMzE0MTc4NjIy NDYxMGViMWU2YTM5OTkyYzE5ZmJkNzkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9u LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL01l ZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbi5oCkBAIC01OSwyNSArNTksMzAgQEAgcHVibGlj OgogCiAgICAgY2xhc3MgTm90aWZpY2F0aW9uIHsKICAgICBwdWJsaWM6CisjZGVmaW5lIEZPUl9F QUNIX01FRElBUExBWUVSUFJJVkFURUFWRk9VTkRBVElPTl9OT1RJRklDQVRJT05fVFlQRShtYWNy bykgXAorICAgIG1hY3JvKE5vbmUpIFwKKyAgICBtYWNybyhJdGVtRGlkUGxheVRvRW5kVGltZSkg XAorICAgIG1hY3JvKEl0ZW1UcmFja3NDaGFuZ2VkKSBcCisgICAgbWFjcm8oSXRlbVN0YXR1c0No YW5nZWQpIFwKKyAgICBtYWNybyhJdGVtU2Vla2FibGVUaW1lUmFuZ2VzQ2hhbmdlZCkgXAorICAg IG1hY3JvKEl0ZW1Mb2FkZWRUaW1lUmFuZ2VzQ2hhbmdlZCkgXAorICAgIG1hY3JvKEl0ZW1QcmVz ZW50YXRpb25TaXplQ2hhbmdlZCkgXAorICAgIG1hY3JvKEl0ZW1Jc1BsYXliYWNrTGlrZWx5VG9L ZWVwVXBDaGFuZ2VkKSBcCisgICAgbWFjcm8oSXRlbUlzUGxheWJhY2tCdWZmZXJFbXB0eUNoYW5n ZWQpIFwKKyAgICBtYWNybyhJdGVtSXNQbGF5YmFja0J1ZmZlckZ1bGxDaGFuZ2VkKSBcCisgICAg bWFjcm8oQXNzZXRNZXRhZGF0YUxvYWRlZCkgXAorICAgIG1hY3JvKEFzc2V0UGxheWFiaWxpdHlL bm93bikgXAorICAgIG1hY3JvKFBsYXllclJhdGVDaGFuZ2VkKSBcCisgICAgbWFjcm8oUGxheWVy VGltZUNoYW5nZWQpIFwKKyAgICBtYWNybyhTZWVrQ29tcGxldGVkKSBcCisgICAgbWFjcm8oRHVy YXRpb25DaGFuZ2VkKSBcCisgICAgbWFjcm8oQ29udGVudHNOZWVkc0Rpc3BsYXkpIFwKKyAgICBt YWNybyhJbmJhbmRUcmFja3NOZWVkQ29uZmlndXJhdGlvbikgXAorCiAgICAgICAgIGVudW0gVHlw ZSB7Ci0gICAgICAgICAgICBOb25lLAotICAgICAgICAgICAgSXRlbURpZFBsYXlUb0VuZFRpbWUs Ci0gICAgICAgICAgICBJdGVtVHJhY2tzQ2hhbmdlZCwKLSAgICAgICAgICAgIEl0ZW1TdGF0dXND aGFuZ2VkLAotICAgICAgICAgICAgSXRlbVNlZWthYmxlVGltZVJhbmdlc0NoYW5nZWQsCi0gICAg ICAgICAgICBJdGVtTG9hZGVkVGltZVJhbmdlc0NoYW5nZWQsCi0gICAgICAgICAgICBJdGVtUHJl c2VudGF0aW9uU2l6ZUNoYW5nZWQsCi0gICAgICAgICAgICBJdGVtSXNQbGF5YmFja0xpa2VseVRv S2VlcFVwQ2hhbmdlZCwKLSAgICAgICAgICAgIEl0ZW1Jc1BsYXliYWNrQnVmZmVyRW1wdHlDaGFu Z2VkLAotICAgICAgICAgICAgSXRlbUlzUGxheWJhY2tCdWZmZXJGdWxsQ2hhbmdlZCwKLSAgICAg ICAgICAgIEFzc2V0TWV0YWRhdGFMb2FkZWQsCi0gICAgICAgICAgICBBc3NldFBsYXlhYmlsaXR5 S25vd24sCi0gICAgICAgICAgICBQbGF5ZXJSYXRlQ2hhbmdlZCwKLSAgICAgICAgICAgIFBsYXll clRpbWVDaGFuZ2VkLAotICAgICAgICAgICAgU2Vla0NvbXBsZXRlZCwKLSAgICAgICAgICAgIER1 cmF0aW9uQ2hhbmdlZCwKLSAgICAgICAgICAgIENvbnRlbnRzTmVlZHNEaXNwbGF5LAotICAgICAg ICAgICAgSW5iYW5kVHJhY2tzTmVlZENvbmZpZ3VyYXRpb24KKyNkZWZpbmUgREVGSU5FX1RZUEVf RU5VTSh0eXBlKSB0eXBlLAorICAgICAgICAgICAgRk9SX0VBQ0hfTUVESUFQTEFZRVJQUklWQVRF QVZGT1VOREFUSU9OX05PVElGSUNBVElPTl9UWVBFKERFRklORV9UWVBFX0VOVU0pCisjdW5kZWYg REVGSU5FX1RZUEVfRU5VTQogICAgICAgICB9OwogICAgICAgICAKICAgICAgICAgTm90aWZpY2F0 aW9uKCkK