109221 2013-02-07 13:07:34 -0800 build-webkit: document sdk, debug, release, device, and simulator options 2013-02-09 11:10:44 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac All RESOLVED FIXED P3 Minor --- 1 dfarler dfarler dbates ddkilzer webkit.review.bot oldest_to_newest 827827 0 dfarler 2013-02-07 13:07:34 -0800 Add comments in build-webkit usage for the following command line switches: —sdk=<sdk> —debug —release —device —simulator We should remove switches for —devel and —deploy when determining the Xcode configuration while we are at it. 827832 1 187159 dfarler 2013-02-07 13:12:39 -0800 Created attachment 187159 Patch 828122 2 187159 ddkilzer 2013-02-07 20:05:05 -0800 Comment on attachment 187159 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187159&action=review r=me with those changes. > Tools/Scripts/build-webkit:112 > - --debug Compile in debug mode > + --debug Compile with Debug Xcode configuration > + --release Compile with Release Xcode configuration The --debug (and --release) switches are used by more than just platforms that build with Xcode. I would suggest removing "Xcode" from the help text here. > Tools/Scripts/build-webkit:113 > + --sdk=<sdk> Use a specific Xcode SDK I would add "(iOS and Mac only)" to the end of the description here. > Tools/Scripts/build-webkit:115 > + --device Use the iphoneos.internal SDK > + --simulator Use the iphonesimulator SDK Similarly, add "(iOS only)" here. Maybe: Use the current <sdkname> SDK (iOS only) 828802 3 187377 dfarler 2013-02-08 15:52:33 -0800 Created attachment 187377 Patch Patch updated with the above suggestions. 828911 4 187377 ddkilzer 2013-02-08 21:06:51 -0800 Comment on attachment 187377 Patch r=me 829087 5 187377 webkit.review.bot 2013-02-09 11:10:40 -0800 Comment on attachment 187377 Patch Clearing flags on attachment: 187377 Committed r142373: <http://trac.webkit.org/changeset/142373> 829088 6 webkit.review.bot 2013-02-09 11:10:44 -0800 All reviewed patches have been landed. Closing bug. 187159 2013-02-07 13:12:39 -0800 2013-02-08 15:52:33 -0800 Patch bug-109221-20130207130914.patch text/plain 2627 dfarler U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMTYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTM3YzU5ODgzNDJlZDEzMDAzZjgyNjRhM2VhYjJhZmIx N2Y2ODRlMC4uYmM4MDdhMDhiZjc1ZDY5MmIwMjlmMGQyMDNkYjI0MTViMmIxNDg5MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEzLTAyLTA3ICBEYXZpZCBGYXJsZXIgIDxkZmFybGVyQGFwcGxlLmNvbT4KKworICAg ICAgICBidWlsZC13ZWJraXQ6IGRvY3VtZW50IHNkaywgZGVidWcsIHJlbGVhc2UsIGRldmljZSwg YW5kIHNpbXVsYXRvciBvcHRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDkyMjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvYnVpbGQtd2Via2l0OiBBZGQgb3B0aW9ucyB0byB1c2Fn ZQorICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbTogUmVtb3ZlIC0tZGVwbG95IGFuZCAt LWRldmVsIGNoZWNrcworCiAyMDEzLTAyLTA3ICBFdW5taSBMZWUgIDxldW5taTE1LmxlZUBzYW1z dW5nLmNvbT4KIAogICAgICAgICBEbyBub3QgY2hlY2sgZW51bSdzIGNhc2luZyBmb3IgV2ViS2l0 MiBDIEFQSS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0IGIvVG9vbHMv U2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggYzBiZDgyZmU2MGFhMTdlNTkyN2Y2ZGE4ZWM0NWQ3 NzI5NTczMDlhMy4uZTNlNmMzYzg2YzQyMjcwNDc4NTQ0YWY5ZGQ1NjE1MzU4ODBjZmM0MCAxMDA3 NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKKysrIGIvVG9vbHMvU2NyaXB0cy9i dWlsZC13ZWJraXQKQEAgLTEwOCw3ICsxMDgsMTEgQEAgbXkgJHVzYWdlID0gPDxFT0Y7CiBVc2Fn ZTogJHByb2dyYW1OYW1lIFtvcHRpb25zXSBbb3B0aW9ucyB0byBwYXNzIHRvIGJ1aWxkIHN5c3Rl bV0KICAgLS1oZWxwICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNob3cgdGhpcyBoZWxwIG1l c3NhZ2UKICAgLS1jbGVhbiAgICAgICAgICAgICAgICAgICAgICAgICAgIENsZWFudXAgdGhlIGJ1 aWxkIGRpcmVjdG9yeQotICAtLWRlYnVnICAgICAgICAgICAgICAgICAgICAgICAgICAgQ29tcGls ZSBpbiBkZWJ1ZyBtb2RlCisgIC0tZGVidWcgICAgICAgICAgICAgICAgICAgICAgICAgICBDb21w aWxlIHdpdGggRGVidWcgWGNvZGUgY29uZmlndXJhdGlvbgorICAtLXJlbGVhc2UgICAgICAgICAg ICAgICAgICAgICAgICAgQ29tcGlsZSB3aXRoIFJlbGVhc2UgWGNvZGUgY29uZmlndXJhdGlvbgor ICAtLXNkaz08c2RrPiAgICAgICAgICAgICAgICAgICAgICAgVXNlIGEgc3BlY2lmaWMgWGNvZGUg U0RLCisgIC0tZGV2aWNlICAgICAgICAgICAgICAgICAgICAgICAgICBVc2UgdGhlIGlwaG9uZW9z LmludGVybmFsIFNESworICAtLXNpbXVsYXRvciAgICAgICAgICAgICAgICAgICAgICAgVXNlIHRo ZSBpcGhvbmVzaW11bGF0b3IgU0RLCiAgIC0tZ3lwICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBVc2UgR1lQLWdlbmVyYXRlZCBwcm9qZWN0IGZpbGVzCiAgIC0tY292ZXJhZ2UgICAgICAgICAg ICAgICAgICAgICAgICBFbmFibGUgQ29kZSBDb3ZlcmFnZSBzdXBwb3J0IChNYWMgb25seSkKIApk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRkaXJzLnBtCmluZGV4IDZmM2IwYzdmYWRlY2YyYzJhYjJhN2VlYWI2MzA2ODI3NTBkYjJj N2EuLmY5MTIwY2RlMzYxNGQzYTQzNTAxMDczOWNhZjc0NDY4ZTAyYTA3YmEgMTAwNzU1Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRp cnMucG0KQEAgLTU5MCwxMyArNTkwLDEzIEBAIHN1YiBkZXRlcm1pbmVQYXNzZWRDb25maWd1cmF0 aW9uCiAKICAgICBmb3IgbXkgJGkgKDAgLi4gJCNBUkdWKSB7CiAgICAgICAgIG15ICRvcHQgPSAk QVJHVlskaV07Ci0gICAgICAgIGlmICgkb3B0ID1+IC9eLS1kZWJ1ZyQvaSB8fCAkb3B0ID1+IC9e LS1kZXZlbC9pKSB7CisgICAgICAgIGlmICgkb3B0ID1+IC9eLS1kZWJ1ZyQvaSkgewogICAgICAg ICAgICAgc3BsaWNlKEBBUkdWLCAkaSwgMSk7CiAgICAgICAgICAgICAkcGFzc2VkQ29uZmlndXJh dGlvbiA9ICJEZWJ1ZyI7CiAgICAgICAgICAgICAkcGFzc2VkQ29uZmlndXJhdGlvbiAuPSAiX0Nh aXJvX0NGTGl0ZSIgaWYgKGlzV2luQ2Fpcm8oKSAmJiBpc0N5Z3dpbigpKTsKICAgICAgICAgICAg IHJldHVybjsKICAgICAgICAgfQotICAgICAgICBpZiAoJG9wdCA9fiAvXi0tcmVsZWFzZSQvaSB8 fCAkb3B0ID1+IC9eLS1kZXBsb3kvaSkgeworICAgICAgICBpZiAoJG9wdCA9fiAvXi0tcmVsZWFz ZSQvaSkgewogICAgICAgICAgICAgc3BsaWNlKEBBUkdWLCAkaSwgMSk7CiAgICAgICAgICAgICAk cGFzc2VkQ29uZmlndXJhdGlvbiA9ICJSZWxlYXNlIjsKICAgICAgICAgICAgICRwYXNzZWRDb25m aWd1cmF0aW9uIC49ICJfQ2Fpcm9fQ0ZMaXRlIiBpZiAoaXNXaW5DYWlybygpICYmIGlzQ3lnd2lu KCkpOwo= 187377 2013-02-08 15:52:33 -0800 2013-02-09 11:10:40 -0800 Patch 0001-build-webkit-document-sdk-debug-release-device-and-s copy.patch text/plain 3138 dfarler RnJvbSA3YTdlMGNjZTViMGVkNTkzMmIyMmNiMjE2MWQwNmUzNGYxZWJjMThhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBGYXJsZXIgPGRmYXJsZXJAYXBwbGUuY29tPgpEYXRl OiBUaHUsIDcgRmViIDIwMTMgMTY6MTQ6MDAgLTA4MDAKU3ViamVjdDogW1BBVENIXSBidWlsZC13 ZWJraXQ6IGRvY3VtZW50IHNkaywgZGVidWcsIHJlbGVhc2UsIGRldmljZSwgYW5kCiBzaW11bGF0 b3Igb3B0aW9ucyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5MjIx CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogU2NyaXB0cy9idWlsZC13ZWJraXQ6IEFk ZCBvcHRpb25zIHRvIHVzYWdlCiogU2NyaXB0cy93ZWJraXRkaXJzLnBtOiBSZW1vdmUgLS1kZXBs b3kgYW5kIC0tZGV2ZWwgY2hlY2tzCi0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgIHwg MTAgKysrKysrKysrKwogVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQgIHwgIDYgKysrKystCiBU b29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gfCAgNCArKy0tCiAzIGZpbGVzIGNoYW5nZWQsIDE3 IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdl TG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGUyMThmMmIuLjE4MWMwOGYgMTAwNjQ0Ci0tLSBh L1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxMy0wMi0wNyAgRGF2aWQgRmFybGVyICA8ZGZhcmxlckBhcHBsZS5jb20+CisKKyAgICAgICAg YnVpbGQtd2Via2l0OiBkb2N1bWVudCBzZGssIGRlYnVnLCByZWxlYXNlLCBkZXZpY2UsIGFuZCBz aW11bGF0b3Igb3B0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA5MjIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDogQWRkIG9wdGlvbnMgdG8gdXNhZ2UKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06IFJlbW92ZSAtLWRlcGxveSBhbmQgLS1kZXZl bCBjaGVja3MKKwogMjAxMy0wMi0wOCAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUuY29t PgogCiAgICAgICAgIER1bXBSZW5kZXJUcmVlLCBJbWFnZURpZmYgYW5kIFRlc3ROZXRzY2FwZVBs dWdpbiBwcm9qZWN0cywgcHJvcGVydHkgc2hlZXRzIGFuZCByZXNvdXJjZXMgZm9yIFZTMjAxMCBz b2x1dGlvbi4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0IGIvVG9vbHMv U2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggYzBiZDgyZi4uODg5NDhhNiAxMDA3NTUKLS0tIGEv VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKKysrIGIvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJr aXQKQEAgLTEwOCw3ICsxMDgsMTEgQEAgbXkgJHVzYWdlID0gPDxFT0Y7CiBVc2FnZTogJHByb2dy YW1OYW1lIFtvcHRpb25zXSBbb3B0aW9ucyB0byBwYXNzIHRvIGJ1aWxkIHN5c3RlbV0KICAgLS1o ZWxwICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNob3cgdGhpcyBoZWxwIG1lc3NhZ2UKICAg LS1jbGVhbiAgICAgICAgICAgICAgICAgICAgICAgICAgIENsZWFudXAgdGhlIGJ1aWxkIGRpcmVj dG9yeQotICAtLWRlYnVnICAgICAgICAgICAgICAgICAgICAgICAgICAgQ29tcGlsZSBpbiBkZWJ1 ZyBtb2RlCisgIC0tZGVidWcgICAgICAgICAgICAgICAgICAgICAgICAgICBDb21waWxlIHdpdGgg RGVidWcgY29uZmlndXJhdGlvbgorICAtLXJlbGVhc2UgICAgICAgICAgICAgICAgICAgICAgICAg Q29tcGlsZSB3aXRoIFJlbGVhc2UgY29uZmlndXJhdGlvbgorICAtLXNkaz08c2RrPiAgICAgICAg ICAgICAgICAgICAgICAgVXNlIGEgc3BlY2lmaWMgWGNvZGUgU0RLIChpT1MgYW5kIE1hYyBvbmx5 KQorICAtLWRldmljZSAgICAgICAgICAgICAgICAgICAgICAgICAgVXNlIHRoZSBjdXJyZW50IGlw aG9uZW9zLmludGVybmFsIFNESyAoaU9TIG9ubHkpCisgIC0tc2ltdWxhdG9yICAgICAgICAgICAg ICAgICAgICAgICBVc2UgdGhlIGN1cnJlbnQgaXBob25lc2ltdWxhdG9yIFNESyAoaU9TIG9ubHkp CiAgIC0tZ3lwICAgICAgICAgICAgICAgICAgICAgICAgICAgICBVc2UgR1lQLWdlbmVyYXRlZCBw cm9qZWN0IGZpbGVzCiAgIC0tY292ZXJhZ2UgICAgICAgICAgICAgICAgICAgICAgICBFbmFibGUg Q29kZSBDb3ZlcmFnZSBzdXBwb3J0IChNYWMgb25seSkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDZm M2IwYzcuLmY5MTIwY2QgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTU5MCwxMyArNTkwLDEzIEBAIHN1 YiBkZXRlcm1pbmVQYXNzZWRDb25maWd1cmF0aW9uCiAKICAgICBmb3IgbXkgJGkgKDAgLi4gJCNB UkdWKSB7CiAgICAgICAgIG15ICRvcHQgPSAkQVJHVlskaV07Ci0gICAgICAgIGlmICgkb3B0ID1+ IC9eLS1kZWJ1ZyQvaSB8fCAkb3B0ID1+IC9eLS1kZXZlbC9pKSB7CisgICAgICAgIGlmICgkb3B0 ID1+IC9eLS1kZWJ1ZyQvaSkgewogICAgICAgICAgICAgc3BsaWNlKEBBUkdWLCAkaSwgMSk7CiAg ICAgICAgICAgICAkcGFzc2VkQ29uZmlndXJhdGlvbiA9ICJEZWJ1ZyI7CiAgICAgICAgICAgICAk cGFzc2VkQ29uZmlndXJhdGlvbiAuPSAiX0NhaXJvX0NGTGl0ZSIgaWYgKGlzV2luQ2Fpcm8oKSAm JiBpc0N5Z3dpbigpKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQotICAgICAgICBp ZiAoJG9wdCA9fiAvXi0tcmVsZWFzZSQvaSB8fCAkb3B0ID1+IC9eLS1kZXBsb3kvaSkgeworICAg ICAgICBpZiAoJG9wdCA9fiAvXi0tcmVsZWFzZSQvaSkgewogICAgICAgICAgICAgc3BsaWNlKEBB UkdWLCAkaSwgMSk7CiAgICAgICAgICAgICAkcGFzc2VkQ29uZmlndXJhdGlvbiA9ICJSZWxlYXNl IjsKICAgICAgICAgICAgICRwYXNzZWRDb25maWd1cmF0aW9uIC49ICJfQ2Fpcm9fQ0ZMaXRlIiBp ZiAoaXNXaW5DYWlybygpICYmIGlzQ3lnd2luKCkpOwotLSAKMS44LjAuMiAoQXBwbGUgR2l0LTQx KQoK