109217 2013-02-07 12:36:39 -0800 WebKit does not build when compiling with css3-text and css3-conditional-rules feature flags enabled. 2013-02-07 16:19:53 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Major --- 0 lamarque webkit-unassigned cmarcelo macpherson menard ojan.autocc webkit.review.bot oldest_to_newest 827799 0 187148 lamarque 2013-02-07 12:36:39 -0800 Created attachment 187148 Fix build with css3-text and css3-conditiona-rules Because of some changes in commits 78f751a31aa2a23acb4dfc03768821934accff7e and 686b13346a97e637edc3ec071ea7ce1a607649c7 WebKit does not build with css3-text and css3-conditional-rules anymore. The attached patch fixes the problems I have found. 827811 1 187151 lamarque 2013-02-07 12:47:34 -0800 Created attachment 187151 Patch Proposed patch 827919 2 187185 lamarque 2013-02-07 15:14:28 -0800 Created attachment 187185 Patch Proposed patch 827975 3 187185 webkit.review.bot 2013-02-07 16:19:50 -0800 Comment on attachment 187185 Patch Clearing flags on attachment: 187185 Committed r142199: <http://trac.webkit.org/changeset/142199> 827976 4 webkit.review.bot 2013-02-07 16:19:53 -0800 All reviewed patches have been landed. Closing bug. 187148 2013-02-07 12:36:39 -0800 2013-02-07 12:47:30 -0800 Fix build with css3-text and css3-conditiona-rules 0001-Fix-build-with-css3-text-and-css3-conditional-rules-.patch text/plain 1264 lamarque RnJvbSA5MTQwM2IyYzAwMTRlODY1YzdhMWVkYTBiMTY0N2FjZjliZjhiNWVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiTGFtYXJxdWUgVi4gU291emEiIDxMYW1hcnF1ZS5Tb3V6YUBi YXN5c2tvbS5jb20+CkRhdGU6IFRodSwgNyBGZWIgMjAxMyAxODoyMjoxNyAtMDIwMApTdWJqZWN0 OiBbUEFUQ0hdIEZpeCBidWlsZCB3aXRoIGNzczMtdGV4dCBhbmQgY3NzMy1jb25kaXRpb25hbC1y dWxlcyBlbmFibGVkLgoKClNpZ25lZC1vZmYtYnk6IExhbWFycXVlIFYuIFNvdXphIDxMYW1hcnF1 ZS5Tb3V6YUBiYXN5c2tvbS5jb20+Ci0tLQogU291cmNlL1dlYkNvcmUvY3NzL0luc3BlY3RvckNT U09NV3JhcHBlcnMuY3BwIHwgMyArKy0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyks IDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvSW5zcGVjdG9y Q1NTT01XcmFwcGVycy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvSW5zcGVjdG9yQ1NTT01XcmFw cGVycy5jcHAKaW5kZXggYTM1Yzk1My4uMjZkMWZlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvY3NzL0luc3BlY3RvckNTU09NV3JhcHBlcnMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9JbnNwZWN0b3JDU1NPTVdyYXBwZXJzLmNwcApAQCAtMzYsNiArMzYsNyBAQAogI2luY2x1ZGUg IkNTU1J1bGUuaCIKICNpbmNsdWRlICJDU1NTdHlsZVJ1bGUuaCIKICNpbmNsdWRlICJDU1NTdHls ZVNoZWV0LmgiCisjaW5jbHVkZSAiQ1NTU3VwcG9ydHNSdWxlLmgiCiAjaW5jbHVkZSAiRG9jdW1l bnRTdHlsZVNoZWV0Q29sbGVjdGlvbi5oIgogI2luY2x1ZGUgIlN0eWxlU2hlZXRDb250ZW50cy5o IgogI2luY2x1ZGUgIldlYktpdENTU1JlZ2lvblJ1bGUuaCIKQEAgLTY4LDcgKzY5LDcgQEAgdm9p ZCBJbnNwZWN0b3JDU1NPTVdyYXBwZXJzOjpjb2xsZWN0KExpc3RUeXBlKiBsaXN0VHlwZSkKICAg ICAgICAgICAgIGJyZWFrOwogI2lmIEVOQUJMRShDU1MzX0NPTkRJVElPTkFMX1JVTEVTKQogICAg ICAgICBjYXNlIENTU1J1bGU6OlNVUFBPUlRTX1JVTEU6Ci0gICAgICAgICAgICBjb2xsZWN0Q1NT T01XcmFwcGVycyhzdGF0aWNfY2FzdDxDU1NTdXBwb3J0c1J1bGUqPihjc3NSdWxlKSk7CisgICAg ICAgICAgICBjb2xsZWN0KHN0YXRpY19jYXN0PENTU1N1cHBvcnRzUnVsZSo+KGNzc1J1bGUpKTsK ICAgICAgICAgICAgIGJyZWFrOwogI2VuZGlmCiAjaWYgRU5BQkxFKENTU19SRUdJT05TKQotLSAK MS43LjEyLjQKCg== 187151 2013-02-07 12:47:34 -0800 2013-02-07 15:14:23 -0800 Patch bug-109217-20130207184408.patch text/plain 1692 lamarque U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzhhNjMyOGZiNmYyYTYy NTI2ZjA1MTNjNjY5Y2VkMjE0ODYxN2JiNy4uMzc1OTIzZjcxMmE0MzNkYWNjNTc1YmU3M2Q5MDRh OTlmMjQzMGVhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAyLTA3ICBMYW1h cnF1ZSBWLiBTb3V6YSAgPExhbWFycXVlLlNvdXphQGJhc3lza29tLmNvbT4KKworICAgICAgICBG aXggYnVpbGQgd2hlbiBjb21waWxpbmcgd2l0aCBjc3MzLXRleHQgYW5kIGNzczMtY29uZGl0aW9u YWwtcnVsZXMgZmVhdHVyZSBmbGFncyBlbmFibGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5MjE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAg KiBjc3MvSW5zcGVjdG9yQ1NTT01XcmFwcGVycy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNw ZWN0b3JDU1NPTVdyYXBwZXJzOjpjb2xsZWN0KToKKwogMjAxMy0wMi0wNyAgRWJlcmhhcmQgR3Jh ZXRoZXIgIDxlZ3JhZXRoZXJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBB ZGQgc2V0dGluZ3MgY2hlY2tib3ggZm9yIGNvbXBvc2l0ZWQgbGF5ZXIgYm9yZGVycwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0luc3BlY3RvckNTU09NV3JhcHBlcnMuY3BwIGIvU291 cmNlL1dlYkNvcmUvY3NzL0luc3BlY3RvckNTU09NV3JhcHBlcnMuY3BwCmluZGV4IGEzNWM5NTM0 YWY0Nzk3ZjFmN2Y0MjIyOWYzYTc4YTM4ZmY3MmNiOTYuLjI2ZDFmZWYyYzBlZTY2Mjk1NzlmNjRm MDliYTEwYzNiOWIyYmUzZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9JbnNwZWN0 b3JDU1NPTVdyYXBwZXJzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvSW5zcGVjdG9yQ1NT T01XcmFwcGVycy5jcHAKQEAgLTM2LDYgKzM2LDcgQEAKICNpbmNsdWRlICJDU1NSdWxlLmgiCiAj aW5jbHVkZSAiQ1NTU3R5bGVSdWxlLmgiCiAjaW5jbHVkZSAiQ1NTU3R5bGVTaGVldC5oIgorI2lu Y2x1ZGUgIkNTU1N1cHBvcnRzUnVsZS5oIgogI2luY2x1ZGUgIkRvY3VtZW50U3R5bGVTaGVldENv bGxlY3Rpb24uaCIKICNpbmNsdWRlICJTdHlsZVNoZWV0Q29udGVudHMuaCIKICNpbmNsdWRlICJX ZWJLaXRDU1NSZWdpb25SdWxlLmgiCkBAIC02OCw3ICs2OSw3IEBAIHZvaWQgSW5zcGVjdG9yQ1NT T01XcmFwcGVyczo6Y29sbGVjdChMaXN0VHlwZSogbGlzdFR5cGUpCiAgICAgICAgICAgICBicmVh azsKICNpZiBFTkFCTEUoQ1NTM19DT05ESVRJT05BTF9SVUxFUykKICAgICAgICAgY2FzZSBDU1NS dWxlOjpTVVBQT1JUU19SVUxFOgotICAgICAgICAgICAgY29sbGVjdENTU09NV3JhcHBlcnMoc3Rh dGljX2Nhc3Q8Q1NTU3VwcG9ydHNSdWxlKj4oY3NzUnVsZSkpOworICAgICAgICAgICAgY29sbGVj dChzdGF0aWNfY2FzdDxDU1NTdXBwb3J0c1J1bGUqPihjc3NSdWxlKSk7CiAgICAgICAgICAgICBi cmVhazsKICNlbmRpZgogI2lmIEVOQUJMRShDU1NfUkVHSU9OUykK 187185 2013-02-07 15:14:28 -0800 2013-02-07 16:19:50 -0800 Patch bug-109217-20130207211103.patch text/plain 1643 lamarque U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2UzZTY5MzVmOWUxY2Fl YzY5OWIyMWU3NzNjOWUxNTQwOTBmZjM4YS4uZjI4YjQwMjdjZGU5NzM1NjhmNmU0ODAxOTkxMzQ3 ZTI4N2U2MTA1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAyLTA3ICBMYW1h cnF1ZSBWLiBTb3V6YSAgPExhbWFycXVlLlNvdXphQGJhc3lza29tLmNvbT4KKworICAgICAgICBG aXggYnVpbGQgd2hlbiBjb21waWxpbmcgd2l0aCBjc3MzLXRleHQgYW5kIGNzczMtY29uZGl0aW9u YWwtcnVsZXMgZmVhdHVyZSBmbGFncyBlbmFibGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5MjE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjc3MvSW5zcGVjdG9yQ1NTT01XcmFwcGVycy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDU1NPTVdyYXBwZXJzOjpjb2xsZWN0KToKKwog MjAxMy0wMi0wNyAgUmlrIENhYmFuaWVyICA8Y2FiYW5pZXJAYWRvYmUuY29tPgogCiAgICAgICAg IEFkZCBzdXBwb3J0IGZvciBwYXJzaW5nIG9mIC13ZWJraXQtYmFja2dyb3VuZC1ibGVuZC1tb2Rl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvSW5zcGVjdG9yQ1NTT01XcmFwcGVycy5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvSW5zcGVjdG9yQ1NTT01XcmFwcGVycy5jcHAKaW5kZXgg YTM1Yzk1MzRhZjQ3OTdmMWY3ZjQyMjI5ZjNhNzhhMzhmZjcyY2I5Ni4uMjZkMWZlZjJjMGVlNjYy OTU3OWY2NGYwOWJhMTBjM2I5YjJiZTNkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3Nz L0luc3BlY3RvckNTU09NV3JhcHBlcnMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9JbnNw ZWN0b3JDU1NPTVdyYXBwZXJzLmNwcApAQCAtMzYsNiArMzYsNyBAQAogI2luY2x1ZGUgIkNTU1J1 bGUuaCIKICNpbmNsdWRlICJDU1NTdHlsZVJ1bGUuaCIKICNpbmNsdWRlICJDU1NTdHlsZVNoZWV0 LmgiCisjaW5jbHVkZSAiQ1NTU3VwcG9ydHNSdWxlLmgiCiAjaW5jbHVkZSAiRG9jdW1lbnRTdHls ZVNoZWV0Q29sbGVjdGlvbi5oIgogI2luY2x1ZGUgIlN0eWxlU2hlZXRDb250ZW50cy5oIgogI2lu Y2x1ZGUgIldlYktpdENTU1JlZ2lvblJ1bGUuaCIKQEAgLTY4LDcgKzY5LDcgQEAgdm9pZCBJbnNw ZWN0b3JDU1NPTVdyYXBwZXJzOjpjb2xsZWN0KExpc3RUeXBlKiBsaXN0VHlwZSkKICAgICAgICAg ICAgIGJyZWFrOwogI2lmIEVOQUJMRShDU1MzX0NPTkRJVElPTkFMX1JVTEVTKQogICAgICAgICBj YXNlIENTU1J1bGU6OlNVUFBPUlRTX1JVTEU6Ci0gICAgICAgICAgICBjb2xsZWN0Q1NTT01XcmFw cGVycyhzdGF0aWNfY2FzdDxDU1NTdXBwb3J0c1J1bGUqPihjc3NSdWxlKSk7CisgICAgICAgICAg ICBjb2xsZWN0KHN0YXRpY19jYXN0PENTU1N1cHBvcnRzUnVsZSo+KGNzc1J1bGUpKTsKICAgICAg ICAgICAgIGJyZWFrOwogI2VuZGlmCiAjaWYgRU5BQkxFKENTU19SRUdJT05TKQo=