109139 2013-02-06 23:41:48 -0800 Remove DOMWindow::parseModalDialogFeatures() 2013-02-07 00:40:59 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth tkent oldest_to_newest 827082 0 haraken 2013-02-06 23:41:48 -0800 No one uses the method. FIXME is saying: // FIXME: We can remove this function once V8 showModalDialog is changed to use DOMWindow. Given that V8's showModalDialog is now using DOMWindow, we can remove it. 827084 1 186999 haraken 2013-02-06 23:42:54 -0800 Created attachment 186999 Patch 827088 2 186999 tkent 2013-02-06 23:46:58 -0800 Comment on attachment 186999 Patch ok 827120 3 haraken 2013-02-07 00:40:33 -0800 Committed r142075: <http://trac.webkit.org/changeset/142075> 186999 2013-02-06 23:42:54 -0800 2013-02-07 00:40:59 -0800 Patch bug-109139-20130207163930.patch text/plain 2451 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWRjNWVlZGU0ODE0NzM4 NzIyMzM5MDliZjNkODRkOTQ4NzE3ZWVjMC4uMzUwYTBmOWM5ZDM3MjM0MDk1NjdlMzc3NjJiNzE2 ZGZjODQ2ODY4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAyLTA2ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgRE9NV2lu ZG93OjpwYXJzZU1vZGFsRGlhbG9nRmVhdHVyZXMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5MTM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gb25lIHVzZXMgdGhlIG1ldGhvZC4gRklYTUUgaXMg c2F5aW5nOgorCisgICAgICAgICAgLy8gRklYTUU6IFdlIGNhbiByZW1vdmUgdGhpcyBmdW5jdGlv biBvbmNlIFY4IHNob3dNb2RhbERpYWxvZyBpcyBjaGFuZ2VkIHRvIHVzZSBET01XaW5kb3cuCisK KyAgICAgICAgR2l2ZW4gdGhhdCBWOCdzIHNob3dNb2RhbERpYWxvZygpIGlzIG5vdyB1c2luZyBE T01XaW5kb3csIHdlIGNhbiByZW1vdmUgaXQuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5n ZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIHBhZ2UvRE9NV2luZG93LmNwcDoKKyAgICAgICAg KiBwYWdlL0RPTVdpbmRvdy5oOgorICAgICAgICAoRE9NV2luZG93KToKKwogMjAxMy0wMi0wNiAg VGVycnkgQW5kZXJzb24gIDx0ZGFuZGVyc29uQGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQg c3VwcG9ydCBmb3IgZ2VzdHVyZSBzY3JvbGwgZXZlbnRzIHRoYXQgZG8gbm90IHByb3BhZ2F0ZSB0 byBlbmNsb3Npbmcgc2Nyb2xsYWJsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RE9NV2luZG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAppbmRleCAx Y2NiZjNjMDRkZTg0OGY3NmJiMTE5ODQyZmYyNGYzNWNmM2JiMGI0Li40MjU4NmYyNjQ2MTI2NzNl MTM1ZWVkNzNkMDU0NTc1YzA0NDM5OTVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L0RPTVdpbmRvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCkBA IC0zNDksMTIgKzM0OSw2IEBAIEZsb2F0UmVjdCBET01XaW5kb3c6OmFkanVzdFdpbmRvd1JlY3Qo UGFnZSogcGFnZSwgY29uc3QgRmxvYXRSZWN0JiBwZW5kaW5nQ2hhbmdlCiAgICAgcmV0dXJuIHdp bmRvdzsKIH0KIAotLy8gRklYTUU6IFdlIGNhbiByZW1vdmUgdGhpcyBmdW5jdGlvbiBvbmNlIFY4 IHNob3dNb2RhbERpYWxvZyBpcyBjaGFuZ2VkIHRvIHVzZSBET01XaW5kb3cuCi12b2lkIERPTVdp bmRvdzo6cGFyc2VNb2RhbERpYWxvZ0ZlYXR1cmVzKGNvbnN0IFN0cmluZyYgc3RyaW5nLCBIYXNo TWFwPFN0cmluZywgU3RyaW5nPiYgbWFwKQotewotICAgIFdpbmRvd0ZlYXR1cmVzOjpwYXJzZURp YWxvZ0ZlYXR1cmVzKHN0cmluZywgbWFwKTsKLX0KLQogYm9vbCBET01XaW5kb3c6OmFsbG93UG9w VXAoRnJhbWUqIGZpcnN0RnJhbWUpCiB7CiAgICAgQVNTRVJUKGZpcnN0RnJhbWUpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaCBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRE9NV2luZG93LmgKaW5kZXggNDc5Nzc0ZjU3Y2NhOGQ1MGQwYzdlYzc5MTZlYzI3OGE2YzJk M2JmMi4uYmNmY2I0ZTRiMTIyODE2ZWNhNjgxZmZkZmQ5ZGU4MDQzM2Q4Y2Y0MiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL0RPTVdpbmRvdy5oCkBAIC0xMjIsOSArMTIyLDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog CiAgICAgICAgIHN0YXRpYyBGbG9hdFJlY3QgYWRqdXN0V2luZG93UmVjdChQYWdlKiwgY29uc3Qg RmxvYXRSZWN0JiBwZW5kaW5nQ2hhbmdlcyk7CiAKLSAgICAgICAgLy8gRklYTUU6IFdlIGNhbiBy ZW1vdmUgdGhpcyBmdW5jdGlvbiBvbmNlIFY4IHNob3dNb2RhbERpYWxvZyBpcyBjaGFuZ2VkIHRv IHVzZSBET01XaW5kb3cuCi0gICAgICAgIHN0YXRpYyB2b2lkIHBhcnNlTW9kYWxEaWFsb2dGZWF0 dXJlcyhjb25zdCBTdHJpbmcmLCBIYXNoTWFwPFN0cmluZywgU3RyaW5nPiYpOwotCiAgICAgICAg IGJvb2wgYWxsb3dQb3BVcCgpOyAvLyBDYWxsIG9uIGZpcnN0IHdpbmRvdywgbm90IHRhcmdldCB3 aW5kb3cuCiAgICAgICAgIHN0YXRpYyBib29sIGFsbG93UG9wVXAoRnJhbWUqIGZpcnN0RnJhbWUp OwogICAgICAgICBzdGF0aWMgYm9vbCBjYW5TaG93TW9kYWxEaWFsb2coY29uc3QgRnJhbWUqKTsK