109130 2013-02-06 20:38:56 -0800 Upstream iOS isWebThread() and isUIThread() 2013-02-07 12:36:39 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin abarth ddkilzer ojan.autocc psolanki webkit.review.bot oldest_to_newest 827032 0 benjamin 2013-02-06 20:38:56 -0800 Upstream iOS isWebThread() and isUIThread() 827036 1 186986 benjamin 2013-02-06 20:43:05 -0800 Created attachment 186986 Patch 827045 2 186986 abarth 2013-02-06 21:26:57 -0800 Comment on attachment 186986 Patch LGTM, but I don't understand in enough detail to officially review. 827074 3 benjamin 2013-02-06 23:21:00 -0800 > (From update of attachment 186986 [details]) > LGTM, but I don't understand in enough detail to officially review. Thanks for checking the patch. I'll ask Dave for a review. 827185 4 186986 buildbot 2013-02-07 01:43:35 -0800 Comment on attachment 186986 Patch Attachment 186986 did not pass win-ews (win): Output: http://queues.webkit.org/results/16443020 827737 5 186986 ddkilzer 2013-02-07 11:13:03 -0800 Comment on attachment 186986 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186986&action=review > Source/WTF/wtf/mac/MainThreadMac.mm:148 > +#if USE(WEB_THREAD) > +bool isUIThread() > +{ > + return pthread_main_np(); > +} > + > +bool isWebThread() > +{ > + return pthread_equal(pthread_self(), mainThreadPthread); > +} > +#endif // USE(WEB_THREAD) I would have suggested putting these methods in an MainThreadIOS.cpp source file instead of MainThreadMac.mm. They can be moved later if anyone else (besides me) has a strong feeling about it. 827797 6 186986 benjamin 2013-02-07 12:36:36 -0800 Comment on attachment 186986 Patch Clearing flags on attachment: 186986 Committed r142163: <http://trac.webkit.org/changeset/142163> 827798 7 benjamin 2013-02-07 12:36:39 -0800 All reviewed patches have been landed. Closing bug. 186986 2013-02-06 20:43:05 -0800 2013-02-07 12:36:36 -0800 Patch bug-109130-20130206203942.patch text/plain 7093 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMDMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDBjZGY4ZjE1YjdjNmEyNTUyNmRkNzZk ZGM0NmQwOGQ5MGQ2OTgyNjguLjhjYTg4MjYyNjBmNDBhNjRkNjEyNWU5MDAxZTc5NzZjMDEyYmU3 ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMTMtMDItMDYgIEJlbmphbWluIFBvdWxhaW4gIDxi cG91bGFpbkBhcHBsZS5jb20+CisKKyAgICAgICAgVXBzdHJlYW0gaU9TIGlzV2ViVGhyZWFkKCkg YW5kIGlzVUlUaHJlYWQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA5MTMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgT24gaU9TLCBpdCBpcyBzb21ldGltZXMgbmVjZXNzYXJ5IHRvIGRpZmZlcmVuY2lh dGUgdGhlIHRocmVhZCBydW5uaW5nIFdlYkNvcmUsCisgICAgICAgIGFuZCB0aGUgdGhyZWFkIHJ1 bm5pbmcgdGhlIFVJLiBUaGlzIHBhdGNoIHVwc3RyZWFtIHRob3NlIGZ1bmN0aW9ucy4KKworICAg ICAgICAqIHd0Zi9NYWluVGhyZWFkLmNwcDoKKyAgICAgICAgKiB3dGYvTWFpblRocmVhZC5oOgor ICAgICAgICBEaXNhYmxlIHRoZSBsZWdhY3kgaW5pdGlhbGl6ZXIgYXMgaXQgaXMgaW5jb3JyZWN0 IHdoZW4gdXNpbmcgdGhlIFdlYlRocmVhZCB0byBydW4gV2ViQ29yZS4KKyAgICAgICAgKFdURjo6 aXNXZWJUaHJlYWQpOgorICAgICAgICAoV1RGOjppc1VJVGhyZWFkKToKKyAgICAgICAgUmV0dXJu IHRydWUgd2hlbiB0aGUgY3VycmVudCB0aHJlYWQgaXMgdGhlIFdlYi9VSSB0aHJlYWQuCisKKyAg ICAgICAgKiB3dGYvbWFjL01haW5UaHJlYWRNYWMubW06CisgICAgICAgIChXVEY6OmlzVUlUaHJl YWQpOgorICAgICAgICAoV1RGOjppc1dlYlRocmVhZCk6CisKKyAgICAgICAgKiB3dGYvdGV4dC9B dG9taWNTdHJpbmcuY3BwOgorICAgICAgICAoV1RGOjpBdG9taWNTdHJpbmdUYWJsZTo6Y3JlYXRl KToKKyAgICAgICAgVXNlIHRoZSBuZXdseSBhZGRlZCBtZXRob2RzLgorCiAyMDEzLTAyLTA2ICBa YW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1RGVVJMXSBG aXggZXJyb25lb3VzIGhlYWRlciBpbmNsdXNpb25zIGluIFdURlVSTCBjb2RlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggYWM4ZjE0MmUwOTNkMTBhNGVhNzM0YzljYTlmMTczNzQwZDgxZGMyMS4uYTc0Y2NmNTRiOGVk Y2Y2OGIxOGZlYjY1NzJhNTA3YWY0YTFiY2Q5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBA CiAyMDEzLTAyLTA2ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCisg ICAgICAgIFVwc3RyZWFtIGlPUyBpc1dlYlRocmVhZCgpIGFuZCBpc1VJVGhyZWFkKCkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTEzMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYmluZGluZ3Mvb2Jq Yy9XZWJTY3JpcHRPYmplY3QubW06CisgICAgICAgICgrW1dlYlNjcmlwdE9iamVjdCBpbml0aWFs aXplXSk6CisgICAgICAgICogcGxhdGZvcm0vbWFjL1NoYXJlZEJ1ZmZlck1hYy5tbToKKyAgICAg ICAgKCtbV2ViQ29yZVNoYXJlZEJ1ZmZlckRhdGEgaW5pdGlhbGl6ZV0pOgorICAgICAgICAjaWZk ZWYgb3V0IHRoZSBsZWdhY3kgaW5pdGlhbGl6YXRpb24gYXMgaXQgaXMgbm90IGNvcnJlY3Qgd2hl bgorICAgICAgICB1c2luZyBhIFdlYlRocmVhZC4KKworMjAxMy0wMi0wNiAgQmVuamFtaW4gUG91 bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KKwogICAgICAgICBNb3ZlIHBhdXNlQW5pbWF0aW9u L3BhdXNlVHJhbnNpdGlvbiBmcm9tIFRlc3RSdW5uZXIgdG8gSW50ZXJuYWxzCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDkxMDcKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi93dGYvTWFpblRocmVhZC5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9NYWluVGhy ZWFkLmNwcAppbmRleCBmODY4NmFhMzE2YzhlNGFhZTBmMTNmNzQ0MWY3NGNiMWQzN2Q2ODBiLi43 MDhjZGJiYWQ3Yzg3MjYwMjg4MTcyMmE4ZTBkNzQ4OGI4N2E3Y2ZjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV1RGL3d0Zi9NYWluVGhyZWFkLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9NYWluVGhyZWFk LmNwcApAQCAtMTIwLDYgKzEyMCw3IEBAIHZvaWQgaW5pdGlhbGl6ZU1haW5UaHJlYWQoKQogICAg IHB0aHJlYWRfb25jZSgmaW5pdGlhbGl6ZU1haW5UaHJlYWRLZXlPbmNlLCBpbml0aWFsaXplTWFp blRocmVhZE9uY2UpOwogfQogCisjaWYgIVVTRShXRUJfVEhSRUFEKQogc3RhdGljIHZvaWQgaW5p dGlhbGl6ZU1haW5UaHJlYWRUb1Byb2Nlc3NNYWluVGhyZWFkT25jZSgpCiB7CiAgICAgbWFpblRo cmVhZEZ1bmN0aW9uUXVldWVNdXRleCgpOwpAQCAtMTMwLDYgKzEzMSw4IEBAIHZvaWQgaW5pdGlh bGl6ZU1haW5UaHJlYWRUb1Byb2Nlc3NNYWluVGhyZWFkKCkKIHsKICAgICBwdGhyZWFkX29uY2Uo JmluaXRpYWxpemVNYWluVGhyZWFkS2V5T25jZSwgaW5pdGlhbGl6ZU1haW5UaHJlYWRUb1Byb2Nl c3NNYWluVGhyZWFkT25jZSk7CiB9CisjZW5kaWYgLy8gIVVTRShXRUJfVEhSRUFEKQorCiAjZW5k aWYKIAogLy8gMC4xIHNlYyBkZWxheXMgaW4gVUkgaXMgYXBwcm94aW1hdGUgdGhyZXNob2xkIHdo ZW4gdGhleSBiZWNvbWUgbm90aWNlYWJsZS4gSGF2ZSBhIGxpbWl0IHRoYXQncyBoYWxmIG9mIHRo YXQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9NYWluVGhyZWFkLmggYi9Tb3VyY2UvV1RG L3d0Zi9NYWluVGhyZWFkLmgKaW5kZXggOWE0MGFkNGYwMGRjYWE2N2JkZmNlNmE3MmFlMjFjN2Fh ZTc3NGRmNC4uZTU3N2ZkMWM3MjZkMWRhOTE5OTJmYzUxOTZiZDIzYWE4MDY3MDA1YiAxMDA2NDQK LS0tIGEvU291cmNlL1dURi93dGYvTWFpblRocmVhZC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL01h aW5UaHJlYWQuaApAQCAtNTEsNiArNTEsMTUgQEAgV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgc2V0 TWFpblRocmVhZENhbGxiYWNrc1BhdXNlZChib29sIHBhdXNlZCk7CiAKIFdURl9FWFBPUlRfUFJJ VkFURSBib29sIGlzTWFpblRocmVhZCgpOwogCisjaWYgVVNFKFdFQl9USFJFQUQpCitXVEZfRVhQ T1JUX1BSSVZBVEUgYm9vbCBpc1dlYlRocmVhZCgpOworV1RGX0VYUE9SVF9QUklWQVRFIGJvb2wg aXNVSVRocmVhZCgpOworI2Vsc2UKK2lubGluZSBib29sIGlzV2ViVGhyZWFkKCkgeyByZXR1cm4g aXNNYWluVGhyZWFkKCk7IH0KK2lubGluZSBib29sIGlzVUlUaHJlYWQoKSB7IHJldHVybiBpc01h aW5UaHJlYWQoKTsgfQorI2VuZGlmIC8vIFBMQVRGT1JNKElPUykKKworCiB2b2lkIGluaXRpYWxp emVHQ1RocmVhZHMoKTsKIAogI2lmIEVOQUJMRShQQVJBTExFTF9HQykKQEAgLTY4LDEwICs3Nywx MiBAQCB2b2lkIHNjaGVkdWxlRGlzcGF0Y2hGdW5jdGlvbnNPbk1haW5UaHJlYWQoKTsKIHZvaWQg ZGlzcGF0Y2hGdW5jdGlvbnNGcm9tTWFpblRocmVhZCgpOwogCiAjaWYgUExBVEZPUk0oTUFDKQor I2lmICFVU0UoV0VCX1RIUkVBRCkKIC8vIFRoaXMgdmVyc2lvbiBvZiBpbml0aWFsaXplTWFpblRo cmVhZCBzZXRzIHVwIHRoZSBtYWluIHRocmVhZCBhcyBjb3JyZXNwb25kaW5nCiAvLyB0byB0aGUg cHJvY2VzcydzIG1haW4gdGhyZWFkLCBhbmQgbm90IG5lY2Vzc2FyaWx5IHRoZSB0aHJlYWQgdGhh dCBjYWxscyB0aGlzCiAvLyBmdW5jdGlvbi4gSXQgc2hvdWxkIG9ubHkgYmUgdXNlZCBhcyBhIGxl Z2FjeSBhaWQgZm9yIE1hYyBXZWJLaXQuCiBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBpbml0aWFs aXplTWFpblRocmVhZFRvUHJvY2Vzc01haW5UaHJlYWQoKTsKKyNlbmRpZiAvLyAhVVNFKFdFQl9U SFJFQUQpCiB2b2lkIGluaXRpYWxpemVNYWluVGhyZWFkVG9Qcm9jZXNzTWFpblRocmVhZFBsYXRm b3JtKCk7CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvbWFjL01haW5UaHJl YWRNYWMubW0gYi9Tb3VyY2UvV1RGL3d0Zi9tYWMvTWFpblRocmVhZE1hYy5tbQppbmRleCA1YTgy ZjQwYTZmYzAxNDcyNjBhYjg3ZWM5MzZjMmZkYjlkMmMxNjllLi5lZmY5NjkxOTJiM2NjZmZlMjUx ZTM0YjQyNjRlY2VhNzcyMDQ1MDlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9tYWMvTWFp blRocmVhZE1hYy5tbQorKysgYi9Tb3VyY2UvV1RGL3d0Zi9tYWMvTWFpblRocmVhZE1hYy5tbQpA QCAtNzAsNiArNzAsNyBAQCB2b2lkIGluaXRpYWxpemVNYWluVGhyZWFkUGxhdGZvcm0oKQogICAg IGluaXRpYWxpemVHQ1RocmVhZHMoKTsKIH0KIAorI2lmICFVU0UoV0VCX1RIUkVBRCkKIHZvaWQg aW5pdGlhbGl6ZU1haW5UaHJlYWRUb1Byb2Nlc3NNYWluVGhyZWFkUGxhdGZvcm0oKQogewogICAg IGlmICghcHRocmVhZF9tYWluX25wKCkpCkBAIC04NCw2ICs4NSw3IEBAIHZvaWQgaW5pdGlhbGl6 ZU1haW5UaHJlYWRUb1Byb2Nlc3NNYWluVGhyZWFkUGxhdGZvcm0oKQogICAgIAogICAgIGluaXRp YWxpemVHQ1RocmVhZHMoKTsKIH0KKyNlbmRpZiAvLyAhVVNFKFdFQl9USFJFQUQpCiAKIHN0YXRp YyB2b2lkIHRpbWVyRmlyZWQoQ0ZSdW5Mb29wVGltZXJSZWYgdGltZXIsIHZvaWQqKQogewpAQCAt MTMzLDQgKzEzNSwxNiBAQCBib29sIGlzTWFpblRocmVhZCgpCiAgICAgcmV0dXJuIHB0aHJlYWRf ZXF1YWwocHRocmVhZF9zZWxmKCksIG1haW5UaHJlYWRQdGhyZWFkKTsKIH0KIAorI2lmIFVTRShX RUJfVEhSRUFEKQorYm9vbCBpc1VJVGhyZWFkKCkKK3sKKyAgICByZXR1cm4gcHRocmVhZF9tYWlu X25wKCk7Cit9CisKK2Jvb2wgaXNXZWJUaHJlYWQoKQoreworICAgIHJldHVybiBwdGhyZWFkX2Vx dWFsKHB0aHJlYWRfc2VsZigpLCBtYWluVGhyZWFkUHRocmVhZCk7Cit9CisjZW5kaWYgLy8gVVNF KFdFQl9USFJFQUQpCisKIH0gLy8gbmFtZXNwYWNlIFdURgpkaWZmIC0tZ2l0IGEvU291cmNlL1dU Ri93dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwIGIvU291cmNlL1dURi93dGYvdGV4dC9BdG9taWNT dHJpbmcuY3BwCmluZGV4IDlhMDYxNDhhMjg3Y2Q3MGZhMzcxZDI0YTYxZTU2ZmE3ZWNjZTkyZDcu LmMzN2VhZjBjNTdiOGY4ZTIyOTQ2YTk3ZjA3M2M5MzFjZTg4MTdhM2UgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90 ZXh0L0F0b21pY1N0cmluZy5jcHAKQEAgLTc0LDcgKzc0LDcgQEAgcHVibGljOgogICAgICAgICBz dGF0aWMgQXRvbWljU3RyaW5nVGFibGUqIHNoYXJlZFN0cmluZ1RhYmxlID0gbmV3IEF0b21pY1N0 cmluZ1RhYmxlOwogCiAgICAgICAgIGJvb2wgY3VycmVudFRocmVhZElzV2ViVGhyZWFkID0gaXNX ZWJUaHJlYWQoKTsKLSAgICAgICAgaWYgKGN1cnJlbnRUaHJlYWRJc1dlYlRocmVhZCB8fCBwdGhy ZWFkX21haW5fbnAoKSkKKyAgICAgICAgaWYgKGN1cnJlbnRUaHJlYWRJc1dlYlRocmVhZCB8fCBp c1VJVGhyZWFkKCkpCiAgICAgICAgICAgICBkYXRhLm1fYXRvbWljU3RyaW5nVGFibGUgPSBzaGFy ZWRTdHJpbmdUYWJsZTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgZGF0YS5tX2F0b21pY1N0 cmluZ1RhYmxlID0gbmV3IEF0b21pY1N0cmluZ1RhYmxlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvb2JqYy9XZWJTY3JpcHRPYmplY3QubW0gYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9vYmpjL1dlYlNjcmlwdE9iamVjdC5tbQppbmRleCAzMjU5ODRlNDM1OTA1YWRkN2Mx MGZiYmMwM2I3ZmM3NmEzMGE2ZmQ2Li5hODllYjk2MDY3NzJhMWNkMDgzZTE0NWVmMmQzMWE3NDMw MWNlYTk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9vYmpjL1dlYlNjcmlw dE9iamVjdC5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9vYmpjL1dlYlNjcmlwdE9i amVjdC5tbQpAQCAtMTI3LDggKzEyNywxMCBAQCBzdGF0aWMgdm9pZCBhZGRFeGNlcHRpb25Ub0Nv bnNvbGUoRXhlY1N0YXRlKiBleGVjKQogCiArICh2b2lkKWluaXRpYWxpemUKIHsKKyNpZiAhVVNF KFdFQl9USFJFQUQpCiAgICAgSlNDOjppbml0aWFsaXplVGhyZWFkaW5nKCk7CiAgICAgV1RGOjpp bml0aWFsaXplTWFpblRocmVhZFRvUHJvY2Vzc01haW5UaHJlYWQoKTsKKyNlbmRpZiAvLyAhVVNF KFdFQl9USFJFQUQpCiAgICAgV2ViQ29yZU9iakNGaW5hbGl6ZU9uTWFpblRocmVhZChzZWxmKTsK IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1NoYXJlZEJ1ZmZl ck1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TaGFyZWRCdWZmZXJNYWMubW0K aW5kZXggZTcwMDY1YTAwYzg5YjgzZmIwZTYyYTEzODRhY2Q5ZDMzZGViYjFhNy4uMjI4ZDY5MTU1 ZTA0MGViNDA0MWRkZDlhNmUyMDgzZjdjNmY3ZTNhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL1NoYXJlZEJ1ZmZlck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tYWMvU2hhcmVkQnVmZmVyTWFjLm1tCkBAIC00NywxMiArNDcsMTQgQEAgdXNpbmcg bmFtZXNwYWNlIFdlYkNvcmU7CiAKICsgKHZvaWQpaW5pdGlhbGl6ZQogeworI2lmICFVU0UoV0VC X1RIUkVBRCkKICAgICBKU0M6OmluaXRpYWxpemVUaHJlYWRpbmcoKTsKICNpZiBQTEFURk9STShR VCkgJiYgVVNFKFFUS0lUKQogICAgIFdURjo6aW5pdGlhbGl6ZU1haW5UaHJlYWQoKTsKICNlbHNl CiAgICAgV1RGOjppbml0aWFsaXplTWFpblRocmVhZFRvUHJvY2Vzc01haW5UaHJlYWQoKTsKICNl bmRpZgorI2VuZGlmIC8vICFVU0UoV0VCX1RIUkVBRCkKICAgICBXZWJDb3JlT2JqQ0ZpbmFsaXpl T25NYWluVGhyZWFkKHNlbGYpOwogfQogCg==