109123 2013-02-06 18:15:05 -0800 [V8] StringCache::m_stringCache should be HashMap<StringImpl*, Persistent<String>> 2013-02-07 10:58:49 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet jsbell webkit.review.bot oldest_to_newest 826958 0 haraken 2013-02-06 18:15:05 -0800 Currently StringCache::m_stringCache is implemented as HashMap<StringImpl*, v8::String*>. Given that v8::String* can change when a GC is triggered, this is dangerous. We should use HashMap<StringImpl*, v8::Persistent<v8::String>> instead. 826961 1 186971 haraken 2013-02-06 18:20:28 -0800 Created attachment 186971 Patch 827702 2 186971 webkit.review.bot 2013-02-07 10:58:46 -0800 Comment on attachment 186971 Patch Clearing flags on attachment: 186971 Committed r142154: <http://trac.webkit.org/changeset/142154> 827703 3 webkit.review.bot 2013-02-07 10:58:49 -0800 All reviewed patches have been landed. Closing bug. 186971 2013-02-06 18:20:28 -0800 2013-02-07 10:58:46 -0800 Patch bug-109123-20130207111705.patch text/plain 3901 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWRjNWVlZGU0ODE0NzM4 NzIyMzM5MDliZjNkODRkOTQ4NzE3ZWVjMC4uMTljNWM4NDU2NWNkOTk3YzhiZmZkMjU4Mjk2YjIw NzY2MmQ2YTg1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTAyLTA2ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFN0cmluZ0Nh Y2hlOjptX3N0cmluZ0NhY2hlIHNob3VsZCBiZSBIYXNoTWFwPFN0cmluZ0ltcGwqLCBQZXJzaXN0 ZW50PFN0cmluZz4+CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDkxMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDdXJyZW50bHkgU3RyaW5nQ2FjaGU6Om1fc3RyaW5nQ2FjaGUgaXMgaW1wbGVtZW50ZWQg YXMKKyAgICAgICAgSGFzaE1hcDxTdHJpbmdJbXBsKiwgdjg6OlN0cmluZyo+LiBHaXZlbiB0aGF0 IHY4OjpTdHJpbmcqCisgICAgICAgIGNhbiBjaGFuZ2Ugd2hlbiBhIEdDIGlzIHRyaWdnZXJlZCwg aXQgaXMgZGFuZ2Vyb3VzIHRvIHN0b3JlIGEgcmF3IHBvaW50ZXIuCisgICAgICAgIFdlIHNob3Vs ZCB1c2UgSGFzaE1hcDxTdHJpbmdJbXBsKiwgdjg6OlBlcnNpc3RlbnQ8djg6OlN0cmluZz4+IGlu c3RlYWQuCisKKyAgICAgICAgVGhpcyBpcyBhIHBvc3NpYmxlIGZpeCBmb3IgYW4gSW5kZXhlZERC IGNyYXNoIChodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MzYzKSwK KyAgICAgICAgYWx0aG91Z2ggSSdtIG5vdCBzdXJlIGlmIHRoaXMgcGF0Y2ggZml4ZXMgdGhlIGNy YXNoLiAoSSBjb3VsZG4ndCByZXByb2R1Y2UgdGhlIGNyYXNoLikKKworICAgICAgICBObyB0ZXN0 cy4gVGhpcyBjaGFuZ2UgaGlnaGx5IGRlcGVuZHMgb24gR0MgYmVoYXZpb3IgYW5kIHRodXMgaXQg aXMKKyAgICAgICAgZGlmZmljdWx0IHRvIG1ha2UgYSByZWxpYWJsZSB0ZXN0IGNhc2UuCisKKyAg ICAgICAgKiBiaW5kaW5ncy92OC9WOFZhbHVlQ2FjaGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 bWFrZUV4dGVybmFsU3RyaW5nKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFZhbHVlQ2FjaGUu aDoKKyAgICAgICAgKFN0cmluZ0NhY2hlKToKKwogMjAxMy0wMi0wNiAgVGVycnkgQW5kZXJzb24g IDx0ZGFuZGVyc29uQGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgZ2Vz dHVyZSBzY3JvbGwgZXZlbnRzIHRoYXQgZG8gbm90IHByb3BhZ2F0ZSB0byBlbmNsb3Npbmcgc2Ny b2xsYWJsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VmFsdWVD YWNoZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFZhbHVlQ2FjaGUuY3BwCmlu ZGV4IDdjNGVlM2I0NzY5MTk1NTU2MmVmNWMyYjhmZDJhOWUwZGZkYjQxNjQuLmFkOTY2ZmFhM2Nk N2RhN2FmNzdhNTNiYWZjMjVlY2E0MDZiMDVkZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4VmFsdWVDYWNoZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhWYWx1ZUNhY2hlLmNwcApAQCAtODUsMTYgKzg1LDEzIEBAIHY4OjpIYW5kbGU8djg6 OlN0cmluZz4gU3RyaW5nQ2FjaGU6OnY4RXh0ZXJuYWxTdHJpbmdTbG93KFN0cmluZ0ltcGwqIHN0 cmluZ0ltcGwsCiAgICAgaWYgKCFzdHJpbmdJbXBsLT5sZW5ndGgoKSkKICAgICAgICAgcmV0dXJu IHY4OjpTdHJpbmc6OkVtcHR5KGlzb2xhdGUpOwogCi0gICAgdjg6OlN0cmluZyogY2FjaGVkVjhT dHJpbmcgPSBtX3N0cmluZ0NhY2hlLmdldChzdHJpbmdJbXBsKTsKLSAgICBpZiAoY2FjaGVkVjhT dHJpbmcpIHsKLSAgICAgICAgdjg6OlBlcnNpc3RlbnQ8djg6OlN0cmluZz4gaGFuZGxlKGNhY2hl ZFY4U3RyaW5nKTsKLSAgICAgICAgaWYgKGhhbmRsZS5Jc1dlYWsoKSkgewotICAgICAgICAgICAg bV9sYXN0U3RyaW5nSW1wbCA9IHN0cmluZ0ltcGw7Ci0gICAgICAgICAgICBtX2xhc3RWOFN0cmlu ZyA9IGhhbmRsZTsKLSAgICAgICAgICAgIGlmIChoYW5kbGVUeXBlID09IFJldHVyblVuc2FmZUhh bmRsZSkKLSAgICAgICAgICAgICAgICByZXR1cm4gaGFuZGxlOwotICAgICAgICAgICAgcmV0dXJu IHY4OjpMb2NhbDx2ODo6U3RyaW5nPjo6TmV3KGhhbmRsZSk7Ci0gICAgICAgIH0KKyAgICB2ODo6 UGVyc2lzdGVudDx2ODo6U3RyaW5nPiBjYWNoZWRWOFN0cmluZyA9IG1fc3RyaW5nQ2FjaGUuZ2V0 KHN0cmluZ0ltcGwpOworICAgIGlmIChjYWNoZWRWOFN0cmluZy5Jc1dlYWsoKSkgeworICAgICAg ICBtX2xhc3RTdHJpbmdJbXBsID0gc3RyaW5nSW1wbDsKKyAgICAgICAgbV9sYXN0VjhTdHJpbmcg PSBjYWNoZWRWOFN0cmluZzsKKyAgICAgICAgaWYgKGhhbmRsZVR5cGUgPT0gUmV0dXJuVW5zYWZl SGFuZGxlKQorICAgICAgICAgICAgcmV0dXJuIGNhY2hlZFY4U3RyaW5nOworICAgICAgICByZXR1 cm4gdjg6OkxvY2FsPHY4OjpTdHJpbmc+OjpOZXcoY2FjaGVkVjhTdHJpbmcpOwogICAgIH0KIAog ICAgIHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuZXdTdHJpbmcgPSBtYWtlRXh0ZXJuYWxTdHJpbmco U3RyaW5nKHN0cmluZ0ltcGwpKTsKQEAgLTEwOCw3ICsxMDUsNyBAQCB2ODo6SGFuZGxlPHY4OjpT dHJpbmc+IFN0cmluZ0NhY2hlOjp2OEV4dGVybmFsU3RyaW5nU2xvdyhTdHJpbmdJbXBsKiBzdHJp bmdJbXBsLAogICAgIHN0cmluZ0ltcGwtPnJlZigpOwogICAgIHdyYXBwZXIuTWFya0luZGVwZW5k ZW50KCk7CiAgICAgd3JhcHBlci5NYWtlV2Vhayhpc29sYXRlLCBzdHJpbmdJbXBsLCBjYWNoZWRT dHJpbmdDYWxsYmFjayk7Ci0gICAgbV9zdHJpbmdDYWNoZS5zZXQoc3RyaW5nSW1wbCwgKndyYXBw ZXIpOworICAgIG1fc3RyaW5nQ2FjaGUuc2V0KHN0cmluZ0ltcGwsIHdyYXBwZXIpOwogCiAgICAg bV9sYXN0U3RyaW5nSW1wbCA9IHN0cmluZ0ltcGw7CiAgICAgbV9sYXN0VjhTdHJpbmcgPSB3cmFw cGVyOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhWYWx1ZUNhY2hl LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFZhbHVlQ2FjaGUuaAppbmRleCA3YTUy YWNkOWVkZjM4MTA3ZDM4ZTY3OGEzZTNjYzMyYTg5YmQ5OWI1Li43NTZhMjM5YTExMjdiZTU5MTc0 ZWRjZjliOTIwOTFlNmFlZTFmM2Q1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9WOFZhbHVlQ2FjaGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFZh bHVlQ2FjaGUuaApAQCAtNzEsNyArNzEsNyBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIHY4OjpI YW5kbGU8djg6OlN0cmluZz4gdjhFeHRlcm5hbFN0cmluZ1Nsb3coU3RyaW5nSW1wbCosIFJldHVy bkhhbmRsZVR5cGUsIHY4OjpJc29sYXRlKik7CiAKLSAgICBIYXNoTWFwPFN0cmluZ0ltcGwqLCB2 ODo6U3RyaW5nKj4gbV9zdHJpbmdDYWNoZTsKKyAgICBIYXNoTWFwPFN0cmluZ0ltcGwqLCB2ODo6 UGVyc2lzdGVudDx2ODo6U3RyaW5nPiA+IG1fc3RyaW5nQ2FjaGU7CiAgICAgdjg6OlBlcnNpc3Rl bnQ8djg6OlN0cmluZz4gbV9sYXN0VjhTdHJpbmc7CiAgICAgLy8gTm90ZTogUmVmUHRyIGlzIGEg bXVzdCBhcyB3ZSBjYWNoZSBieSBTdHJpbmdJbXBsKiBlcXVhbGl0eSwgbm90IGlkZW50aXR5CiAg ICAgLy8gaGVuY2UgbGFzdFN0cmluZ0ltcGwgbWlnaHQgYmUgbm90IGEga2V5IG9mIHRoZSBjYWNo ZSAoaW4gc2Vuc2Ugb2YgaWRlbnRpdHkpCg==