109102 2013-02-06 16:10:52 -0800 display:none file upload button crashes 2013-02-07 10:25:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan eric hyatt leviw mifenton ojan.autocc tkent tony webkit.review.bot oldest_to_newest 826838 0 ojan 2013-02-06 16:10:52 -0800 display:none file upload button crashes 826844 1 186939 ojan 2013-02-06 16:13:11 -0800 Created attachment 186939 Patch 826852 2 186939 leviw 2013-02-06 16:18:29 -0800 Comment on attachment 186939 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186939&action=review > LayoutTests/fast/forms/file/display-none-upload-button.html:15 > +// FIXME: The text inside the file input should give the input a contentHeight > +// even when there's no upload button. File a bug and link? 826877 3 ojan 2013-02-06 16:42:41 -0800 Committed r142054: <http://trac.webkit.org/changeset/142054> 186939 2013-02-06 16:13:11 -0800 2013-02-07 10:25:36 -0800 Patch bug-109102-20130207000948.patch text/plain 4956 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMDA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDYyM2QxOWNiYjE3MThk MDc1MDY0ZGY5N2IzOGE3ZTY5ZmI0ZWVlZC4uYTUxYmRiMmUxOGExMDg3M2VjZmEyMmZhMDVkMGZl OTVhM2IyZGYyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAyLTA2ICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgZGlzcGxheTpub25lIGZpbGUg dXBsb2FkIGJ1dHRvbiBjcmFzaGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDkxMDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUZXN0OiBmYXN0L2Zvcm1zL2ZpbGUvZGlzcGxheS1ub25lLXVwbG9hZC1i dXR0b24uaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckZpbGVVcGxvYWRDb250cm9s LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om5vZGVXaWR0aCk6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJGaWxlVXBsb2FkQ29udHJvbDo6cGFpbnRPYmplY3QpOgorICAgICAgICBIYXZpbmcgYW4g dXBsb2FkIGJ1dHRvbiBkb2Vzbid0IG1lYW4gd2UgaGF2ZSBhIHJlbmRlcmVkIHVwbG9hZCBidXR0 b24uCisgICAgICAgIE51bGwgY2hlY2sgdGhlIHJlbmRlcmVyIGJlZm9yZSB0cnlpbmcgdG8gYWNj ZXNzIGl0LgorCiAyMDEzLTAyLTA2ICBUb255IEdlbnRpbGNvcmUgIDx0b255Z0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgQ2FsbCBYU1NBdWRpdG9yJ3MgZGlkQmxvY2tTY3JpcHQoKSBmb3IgdGhl IHRocmVhZGVkIEhUTUwgcGFyc2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckZpbGVVcGxvYWRDb250cm9sLmNwcAppbmRleCAwOTg0NDJmOGUwMjNiNmYzYjlkMjJl OTQzYTdlNzZjYzBhMzQzYjIwLi5lYjQ1NDJmNGRkMTM4NzFhMjU0MjU0N2E0YWIyZWE4Njk2YTY2 MzE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9h ZENvbnRyb2wuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGaWxlVXBs b2FkQ29udHJvbC5jcHAKQEAgLTg5LDcgKzg5LDcgQEAgdm9pZCBSZW5kZXJGaWxlVXBsb2FkQ29u dHJvbDo6dXBkYXRlRnJvbUVsZW1lbnQoKQogCiBzdGF0aWMgaW50IG5vZGVXaWR0aChOb2RlKiBu b2RlKQogewotICAgIHJldHVybiBub2RlID8gbm9kZS0+cmVuZGVyQm94KCktPnBpeGVsU25hcHBl ZFdpZHRoKCkgOiAwOworICAgIHJldHVybiAobm9kZSAmJiBub2RlLT5yZW5kZXJCb3goKSkgPyBu b2RlLT5yZW5kZXJCb3goKS0+cGl4ZWxTbmFwcGVkV2lkdGgoKSA6IDA7CiB9CiAKIGludCBSZW5k ZXJGaWxlVXBsb2FkQ29udHJvbDo6bWF4RmlsZW5hbWVXaWR0aCgpIGNvbnN0CkBAIC0xMzYsMTAg KzEzNiwxNCBAQCB2b2lkIFJlbmRlckZpbGVVcGxvYWRDb250cm9sOjpwYWludE9iamVjdChQYWlu dEluZm8mIHBhaW50SW5mbywgY29uc3QgTGF5b3V0UG9pbgogICAgICAgICAgICAgdGV4dFggPSBj b250ZW50TGVmdCArIGJ1dHRvbkFuZEljb25XaWR0aDsKICAgICAgICAgZWxzZQogICAgICAgICAg ICAgdGV4dFggPSBjb250ZW50TGVmdCArIGNvbnRlbnRXaWR0aCgpIC0gYnV0dG9uQW5kSWNvbldp ZHRoIC0gZm9udC53aWR0aCh0ZXh0UnVuKTsKKworICAgICAgICBMYXlvdXRVbml0IHRleHRZID0g MDsKICAgICAgICAgLy8gV2Ugd2FudCB0byBtYXRjaCB0aGUgYnV0dG9uJ3MgYmFzZWxpbmUKLSAg ICAgICAgUmVuZGVyQnV0dG9uKiBidXR0b25SZW5kZXJlciA9IHRvUmVuZGVyQnV0dG9uKGJ1dHRv bi0+cmVuZGVyZXIoKSk7CiAgICAgICAgIC8vIEZJWE1FOiBNYWtlIHRoaXMgd29yayB3aXRoIHRy YW5zZm9ybXMuCi0gICAgICAgIExheW91dFVuaXQgdGV4dFkgPSBwYWludE9mZnNldC55KCkgKyBi dXR0b25SZW5kZXJlci0+YmFzZWxpbmVQb3NpdGlvbihBbHBoYWJldGljQmFzZWxpbmUsIHRydWUs IEhvcml6b250YWxMaW5lLCBQb3NpdGlvbk9uQ29udGFpbmluZ0xpbmUpOworICAgICAgICBpZiAo UmVuZGVyQnV0dG9uKiBidXR0b25SZW5kZXJlciA9IHRvUmVuZGVyQnV0dG9uKGJ1dHRvbi0+cmVu ZGVyZXIoKSkpCisgICAgICAgICAgICB0ZXh0WSA9IHBhaW50T2Zmc2V0LnkoKSArIGJ1dHRvblJl bmRlcmVyLT5iYXNlbGluZVBvc2l0aW9uKEFscGhhYmV0aWNCYXNlbGluZSwgdHJ1ZSwgSG9yaXpv bnRhbExpbmUsIFBvc2l0aW9uT25Db250YWluaW5nTGluZSk7CisgICAgICAgIGVsc2UKKyAgICAg ICAgICAgIHRleHRZID0gYmFzZWxpbmVQb3NpdGlvbihBbHBoYWJldGljQmFzZWxpbmUsIHRydWUs IEhvcml6b250YWxMaW5lLCBQb3NpdGlvbk9uQ29udGFpbmluZ0xpbmUpOwogCiAgICAgICAgIHBh aW50SW5mby5jb250ZXh0LT5zZXRGaWxsQ29sb3Ioc3R5bGUoKS0+dmlzaXRlZERlcGVuZGVudENv bG9yKENTU1Byb3BlcnR5Q29sb3IpLCBzdHlsZSgpLT5jb2xvclNwYWNlKCkpOwogICAgICAgICAK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1OTcwN2U3Y2QzOGM1ZDg4ZGFkYjVhMjc1NmY1ODJhNDJkODBjYWYyLi44ZDE2Mzkx NzMwMTkyYTljZTkyNTBkNTQ5MTgyODFiOTRkMjMzNzE1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTMtMDItMDYgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBk aXNwbGF5Om5vbmUgZmlsZSB1cGxvYWQgYnV0dG9uIGNyYXNoZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTEwMgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9mb3Jtcy9maWxlL2Rpc3BsYXkt bm9uZS11cGxvYWQtYnV0dG9uLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9m b3Jtcy9maWxlL2Rpc3BsYXktbm9uZS11cGxvYWQtYnV0dG9uLmh0bWw6IEFkZGVkLgorICAgICAg ICBUZXN0cyB0aGF0IHdlIGRvbid0IGNyYXNoLiBBbHNvIGV4cG9zZXMgYSBidWcgdGhhdCB0aGUg YmFzZWxpbmUgYW5kIGhlaWdodCBvZgorICAgICAgICB0aGUgaW5wdXQgZG9uJ3QgaW5jbHVkZSB0 aGUgaGVpZ2h0IG9mIHRoZSBmaWxlbmFtZSB0ZXh0LgorCiAyMDEzLTAyLTA2ICBEZWFuIEphY2tz b24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBNaW5vciB1cGRhdGVzIHRvIGNhcHRpb25z IG1lbnUgVUkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvZmlsZS9kaXNwbGF5 LW5vbmUtdXBsb2FkLWJ1dHRvbi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1z L2ZpbGUvZGlzcGxheS1ub25lLXVwbG9hZC1idXR0b24tZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LmNlMjczYWE1N2MwMTNlNTM3Y2VhNmVkOTdhM2NjZjMyODhiNTg5NmQKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2ZpbGUvZGlzcGxheS1ub25lLXVwbG9hZC1idXR0 b24tZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNSBAQAorRkFJTCBkb2N1bWVudC5xdWVyeVNlbGVj dG9yKCdpbnB1dCcpLm9mZnNldEhlaWdodCA+IDEwIHNob3VsZCBiZSB0cnVlLiBXYXMgZmFsc2Uu CitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKK1Rlc3Rz IHRoYXQgYSBkaXNwbGF5Om5vbmUgdXBsb2FkIGJ1dHRvbiB3b3Jrcy4gCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2ZpbGUvZGlzcGxheS1ub25lLXVwbG9hZC1idXR0b24uaHRt bCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvZmlsZS9kaXNwbGF5LW5vbmUtdXBsb2FkLWJ1dHRv bi5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjk2MDgxNGUzNjE4Yzg0ZTE4NDVlZjczMzY0YTdhZjU0Y2Y0MjM3 ZDIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2ZpbGUvZGlzcGxh eS1ub25lLXVwbG9hZC1idXR0b24uaHRtbApAQCAtMCwwICsxLDE4IEBACis8IURPQ1RZUEUgSFRN TD4NCis8c3R5bGU+DQoraW5wdXQgew0KKyAgICBib3JkZXI6IDVweCBzb2xpZCBzYWxtb247DQor fQ0KK2lucHV0Ojotd2Via2l0LWZpbGUtdXBsb2FkLWJ1dHRvbiB7DQorICAgIGRpc3BsYXk6IG5v bmU7DQorfQ0KKzwvc3R5bGU+DQorVGVzdHMgdGhhdCBhIGRpc3BsYXk6bm9uZSB1cGxvYWQgYnV0 dG9uIHdvcmtzLg0KKzxpbnB1dCB0eXBlPSJmaWxlIj4NCis8c2NyaXB0IHNyYz0iLi4vLi4vanMv cmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4NCis8c2NyaXB0Pg0KKy8vIEZJWE1F OiBUaGUgdGV4dCBpbnNpZGUgdGhlIGZpbGUgaW5wdXQgc2hvdWxkIGdpdmUgdGhlIGlucHV0IGEg Y29udGVudEhlaWdodA0KKy8vIGV2ZW4gd2hlbiB0aGVyZSdzIG5vIHVwbG9hZCBidXR0b24uDQor c2hvdWxkQmVUcnVlKCJkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCdpbnB1dCcpLm9mZnNldEhlaWdo dCA+IDEwIik7DQorPC9zY3JpcHQ+DQorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9q cy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK