109101 2013-02-06 15:29:34 -0800 Reset the border property for -webkit-slider-thumb in unknown-pseudo-element-matching test 2013-02-06 16:32:56 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dgorbik dgorbik ddkilzer joepeck webkit-bug-importer webkit.review.bot oldest_to_newest 826800 0 dgorbik 2013-02-06 15:29:34 -0800 We check that the style matches a pseudo element by setting its height to 1px. But if there was a border property set in default styles the minimum height will be 2px, so the test will fail. We need to reset this property. 826801 1 webkit-bug-importer 2013-02-06 15:29:45 -0800 <rdar://problem/13166872> 826808 2 186935 dgorbik 2013-02-06 15:36:19 -0800 Created attachment 186935 Proposed fix 0.1 826812 3 186935 joepeck 2013-02-06 15:38:40 -0800 Comment on attachment 186935 Proposed fix 0.1 View in context: https://bugs.webkit.org/attachment.cgi?id=186935&action=review r=me > LayoutTests/ChangeLog:8 > + We need to reset this property. You could call out a sample user agent "Some user agents, like iOS, have default border styles that affect the minimum height". 826815 4 186937 dgorbik 2013-02-06 15:42:12 -0800 Created attachment 186937 Proposed fix 0.2 826816 5 186937 joepeck 2013-02-06 15:43:27 -0800 Comment on attachment 186937 Proposed fix 0.2 r=me 826868 6 186937 webkit.review.bot 2013-02-06 16:32:52 -0800 Comment on attachment 186937 Proposed fix 0.2 Clearing flags on attachment: 186937 Committed r142052: <http://trac.webkit.org/changeset/142052> 826869 7 webkit.review.bot 2013-02-06 16:32:56 -0800 All reviewed patches have been landed. Closing bug. 186935 2013-02-06 15:36:19 -0800 2013-02-06 15:42:12 -0800 Proposed fix 0.1 patch text/plain 1525 dgorbik ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0ODI4MmVkLi4yMzFjNzU5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDIt MDYgIERpbWEgR29yYmlrICA8ZGdvcmJpa0BhcHBsZS5jb20+CisKKyAgICAgICAgUmVzZXQgdGhl IGJvcmRlciBwcm9wZXJ0eSBmb3IgLXdlYmtpdC1zbGlkZXItdGh1bWIgaW4gdW5rbm93bi1wc2V1 ZG8tZWxlbWVudC1tYXRjaGluZyB0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDkxMDEKKworICAgICAgICBXZSBjaGVjayB0aGF0IHRoZSBzdHls ZSBtYXRjaGVzIGEgcHNldWRvIGVsZW1lbnQgYnkgc2V0dGluZyBpdHMgaGVpZ2h0IHRvIDFweC4g QnV0IGlmIHRoZXJlIHdhcworICAgICAgICBhIGJvcmRlciBwcm9wZXJ0eSBzZXQgaW4gZGVmYXVs dCBzdHlsZXMgdGhlIG1pbmltdW0gaGVpZ2h0IHdpbGwgYmUgMnB4LCBzbyB0aGUgdGVzdCB3aWxs IGZhaWwuIAorICAgICAgICBXZSBuZWVkIHRvIHJlc2V0IHRoaXMgcHJvcGVydHkuCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2Nzcy91bmtu b3duLXBzZXVkby1lbGVtZW50LW1hdGNoaW5nLmh0bWw6CisKIDIwMTMtMDItMDYgIFphbiBEb2Jl cnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgR1RLIGdh cmRlbmluZy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3Vua25vd24tcHNldWRv LWVsZW1lbnQtbWF0Y2hpbmcuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3Vua25vd24tcHNl dWRvLWVsZW1lbnQtbWF0Y2hpbmcuaHRtbAppbmRleCA3OTBhMWM3Li5lNTY3NWYwIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy91bmtub3duLXBzZXVkby1lbGVtZW50LW1hdGNoaW5n Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvdW5rbm93bi1wc2V1ZG8tZWxlbWVudC1t YXRjaGluZy5odG1sCkBAIC0xNSw3ICsxNSw3IEBAIHZhciBoZWFkOwogdmFyIGlucHV0OwogdmFy IGxvZ0RpdjsKIHZhciBOQU1FU1BBQ0VfREVDTEFSQVRJT04gPSAnQG5hbWVzcGFjZSAiaHR0cDov L2V4YW1wbGUuY29tL2Zvby9uYW1lc3BhY2UiO1xuQG5hbWVzcGFjZSBodG1sICJodHRwOi8vd3d3 LnczLm9yZy8xOTk5L3hodG1sIjtcbic7Ci12YXIgU0VMRUNUT1JfVEVTVF9QUk9QRVJUSUVTID0g JyB7IGhlaWdodDogMXB4OyAtd2Via2l0LWFwcGVhcmFuY2U6IG5vbmU7IH0nOwordmFyIFNFTEVD VE9SX1RFU1RfUFJPUEVSVElFUyA9ICcgeyBoZWlnaHQ6IDFweDsgLXdlYmtpdC1hcHBlYXJhbmNl OiBub25lOyBib3JkZXI6IG5vbmU7IH0nOwogdmFyIFNFTEVDVE9SUyA9IFsKICc6Oi13ZWJraXQt c2xpZGVyLXRodW1iJywKICcqOjotd2Via2l0LXNsaWRlci10aHVtYicsCg== 186937 2013-02-06 15:42:12 -0800 2013-02-06 16:32:51 -0800 Proposed fix 0.2 patch text/plain 1494 dgorbik ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0ODI4MmVkLi5iNTEwNTM1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDIt MDYgIERpbWEgR29yYmlrICA8ZGdvcmJpa0BhcHBsZS5jb20+CisKKyAgICAgICAgUmVzZXQgdGhl IGJvcmRlciBwcm9wZXJ0eSBmb3IgLXdlYmtpdC1zbGlkZXItdGh1bWIgaW4gdW5rbm93bi1wc2V1 ZG8tZWxlbWVudC1tYXRjaGluZyB0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDkxMDEKKworICAgICAgICBXZSBjaGVjayB0aGF0IHRoZSBzdHls ZSBtYXRjaGVzIGEgcHNldWRvIGVsZW1lbnQgYnkgc2V0dGluZyBpdHMgaGVpZ2h0IHRvIDFweC4K KyAgICAgICAgU29tZSB1c2VyIGFnZW50cywgbGlrZSBpT1MsIGhhdmUgZGVmYXVsdCBib3JkZXIg c3R5bGVzIHRoYXQgYWZmZWN0IHRoZSBtaW5pbXVtIGhlaWdodCwKKyAgICAgICAgc28gd2UgbmVl ZCB0byByZXNldCB0aG9zZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGZhc3QvY3NzL3Vua25vd24tcHNldWRvLWVsZW1lbnQtbWF0Y2hpbmcuaHRt bDoKKwogMjAxMy0wMi0wNiAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZCBHVEsgZ2FyZGVuaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9jc3MvdW5rbm93bi1wc2V1ZG8tZWxlbWVudC1tYXRjaGluZy5odG1sIGIvTGF5b3V0 VGVzdHMvZmFzdC9jc3MvdW5rbm93bi1wc2V1ZG8tZWxlbWVudC1tYXRjaGluZy5odG1sCmluZGV4 IDc5MGExYzcuLmU1Njc1ZjAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3Vua25v d24tcHNldWRvLWVsZW1lbnQtbWF0Y2hpbmcuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nz cy91bmtub3duLXBzZXVkby1lbGVtZW50LW1hdGNoaW5nLmh0bWwKQEAgLTE1LDcgKzE1LDcgQEAg dmFyIGhlYWQ7CiB2YXIgaW5wdXQ7CiB2YXIgbG9nRGl2OwogdmFyIE5BTUVTUEFDRV9ERUNMQVJB VElPTiA9ICdAbmFtZXNwYWNlICJodHRwOi8vZXhhbXBsZS5jb20vZm9vL25hbWVzcGFjZSI7XG5A bmFtZXNwYWNlIGh0bWwgImh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiO1xuJzsKLXZhciBT RUxFQ1RPUl9URVNUX1BST1BFUlRJRVMgPSAnIHsgaGVpZ2h0OiAxcHg7IC13ZWJraXQtYXBwZWFy YW5jZTogbm9uZTsgfSc7Cit2YXIgU0VMRUNUT1JfVEVTVF9QUk9QRVJUSUVTID0gJyB7IGhlaWdo dDogMXB4OyAtd2Via2l0LWFwcGVhcmFuY2U6IG5vbmU7IGJvcmRlcjogbm9uZTsgfSc7CiB2YXIg U0VMRUNUT1JTID0gWwogJzo6LXdlYmtpdC1zbGlkZXItdGh1bWInLAogJyo6Oi13ZWJraXQtc2xp ZGVyLXRodW1iJywK