109099 2013-02-06 15:03:25 -0800 Dispatch storage manager messages to the storage work queue 2013-02-06 15:46:13 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 826790 0 andersca 2013-02-06 15:03:25 -0800 Dispatch storage manager messages to the storage work queue 826791 1 186930 andersca 2013-02-06 15:03:49 -0800 Created attachment 186930 Patch 826814 2 186930 kling 2013-02-06 15:41:11 -0800 Comment on attachment 186930 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186930&action=review > Source/WebKit2/UIProcess/Storage/StorageManager.cpp:87 > + didReceiveStorageManagerMessageOnConnectionWorkQueue(connection, decoderPtr); This function name is no longer accurate as it won't be called on the connection work queue. 826818 3 186930 kling 2013-02-06 15:44:53 -0800 Comment on attachment 186930 Patch r=me, since you aim to clean this up. 826819 4 andersca 2013-02-06 15:46:13 -0800 Committed r142044: <http://trac.webkit.org/changeset/142044> 186930 2013-02-06 15:03:49 -0800 2013-02-06 15:44:53 -0800 Patch bug-109099-20130206150018.patch text/plain 3265 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMDI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODFkNDI1YTMzYmJmOTYx N2M2MjFhMjEwZGJhODA3MGVmYWRjYTdjNi4uZmQzOWUzYWExYWUyMzRjM2IyN2E3ZDI2ZWU2Nzg2 ZGI0NzJiY2IxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEzLTAyLTA2ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgRGlzcGF0Y2ggc3Rv cmFnZSBtYW5hZ2VyIG1lc3NhZ2VzIHRvIHRoZSBzdG9yYWdlIHdvcmsgcXVldWUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTA5OQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1N0b3Jh Z2UvU3RvcmFnZU1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpTdG9yYWdlTWFuYWdlcjo6 ZGlkUmVjZWl2ZU1lc3NhZ2VPbkNvbm5lY3Rpb25Xb3JrUXVldWUpOgorICAgICAgICAoV2ViS2l0 OjpTdG9yYWdlTWFuYWdlcjo6ZGlzcGF0Y2hNZXNzYWdlT25TdG9yYWdlTWFuYWdlclF1ZXVlKToK KyAgICAgICAgKFdlYktpdCk6CisgICAgICAgICogVUlQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU1h bmFnZXIuaDoKKyAgICAgICAgKFN0b3JhZ2VNYW5hZ2VyKToKKworMjAxMy0wMi0wNiAgQW5kZXJz IENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIFBhc3MgdGhlIGRvY3Vt ZW50IHNvdXJjZSBVUkwgdG8gdGhlIHBsdWdpbkxvYWRQb2xpY3kgY2FsbGJhY2sKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTA4NAogICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMTMxNTQ1MTY+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvU3RvcmFnZS9TdG9yYWdlTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvU3RvcmFnZS9TdG9yYWdlTWFuYWdlci5jcHAKaW5kZXggYzJiNDdjYTIwNDQyZTg1N2Q2NzYy ZjFjZjg4NjNmZDE1ODdjYzNkOS4uYzcwZDJjODdhOGE4NDA3NjVkMDVmM2UzMWYyY2MyMzJiYTBk MmM2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvU3RvcmFn ZU1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9TdG9yYWdlL1N0b3Jh Z2VNYW5hZ2VyLmNwcApAQCAtNTksNyArNTksOCBAQCB2b2lkIFN0b3JhZ2VNYW5hZ2VyOjpwcm9j ZXNzV2lsbENsb3NlQ29ubmVjdGlvbihXZWJQcm9jZXNzUHJveHkqIHdlYlByb2Nlc3NQcm94eQog dm9pZCBTdG9yYWdlTWFuYWdlcjo6ZGlkUmVjZWl2ZU1lc3NhZ2VPbkNvbm5lY3Rpb25Xb3JrUXVl dWUoQ29yZUlQQzo6Q29ubmVjdGlvbiogY29ubmVjdGlvbiwgT3duUHRyPENvcmVJUEM6Ok1lc3Nh Z2VEZWNvZGVyPiYgZGVjb2RlcikKIHsKICAgICBpZiAoZGVjb2Rlci0+bWVzc2FnZVJlY2VpdmVy TmFtZSgpID09IE1lc3NhZ2VzOjpTdG9yYWdlTWFuYWdlcjo6bWVzc2FnZVJlY2VpdmVyTmFtZSgp KSB7Ci0gICAgICAgIGRpZFJlY2VpdmVTdG9yYWdlTWFuYWdlck1lc3NhZ2VPbkNvbm5lY3Rpb25X b3JrUXVldWUoY29ubmVjdGlvbiwgZGVjb2Rlcik7CisgICAgICAgIC8vIEZJWE1FOiBXZSBzaG91 bGQgY29tZSB1cCB3aXRoIGEgYmV0dGVyIHdheSB0byBhdXRvbWF0aWNhbGx5IGRpc3BhdGNoIG1l c3NhZ2VzIG9uIGEgZ2l2ZW4gd29yayBxdWV1ZS4KKyAgICAgICAgbV9xdWV1ZS0+ZGlzcGF0Y2go YmluZCgmU3RvcmFnZU1hbmFnZXI6OmRpc3BhdGNoTWVzc2FnZU9uU3RvcmFnZU1hbmFnZXJRdWV1 ZSwgdGhpcywgUmVmUHRyPENvcmVJUEM6OkNvbm5lY3Rpb24+KGNvbm5lY3Rpb24pLCBkZWNvZGVy LmxlYWtQdHIoKSkpOwogICAgICAgICByZXR1cm47CiAgICAgfQogfQpAQCAtNzgsNCArNzksMTQg QEAgdm9pZCBTdG9yYWdlTWFuYWdlcjo6ZGVzdHJveVN0b3JhZ2VBcmVhKENvcmVJUEM6OkNvbm5l Y3Rpb24qLCB1aW50NjRfdCkKIHsKIH0KIAordm9pZCBTdG9yYWdlTWFuYWdlcjo6ZGlzcGF0Y2hN ZXNzYWdlT25TdG9yYWdlTWFuYWdlclF1ZXVlKENvcmVJUEM6OkNvbm5lY3Rpb24qIGNvbm5lY3Rp b24sIENvcmVJUEM6Ok1lc3NhZ2VEZWNvZGVyKiBkZWNvZGVyKQoreworICAgIEFTU0VSVChkZWNv ZGVyLT5tZXNzYWdlUmVjZWl2ZXJOYW1lKCkgPT0gTWVzc2FnZXM6OlN0b3JhZ2VNYW5hZ2VyOjpt ZXNzYWdlUmVjZWl2ZXJOYW1lKCkpOworCisgICAgT3duUHRyPENvcmVJUEM6Ok1lc3NhZ2VEZWNv ZGVyPiBkZWNvZGVyUHRyID0gYWRvcHRQdHIoZGVjb2Rlcik7CisgICAgZGlkUmVjZWl2ZVN0b3Jh Z2VNYW5hZ2VyTWVzc2FnZU9uQ29ubmVjdGlvbldvcmtRdWV1ZShjb25uZWN0aW9uLCBkZWNvZGVy UHRyKTsKKworICAgIEFTU0VSVCghZGVjb2RlclB0cik7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdl YktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvU3RvcmFn ZU1hbmFnZXIuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VNYW5h Z2VyLmgKaW5kZXggODVlMDYyMGQ0MmJlZTcxZTViNjM3ZmJjM2ZmMzdlMzEzOTk5M2RiMy4uNTVh OWU4MTk1YzE5ZDZiODEzZGNmZmQzYzMzZTg2M2E0N2I5ZjU3OCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU1hbmFnZXIuaAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFnZS9TdG9yYWdlTWFuYWdlci5oCkBAIC01OCw2ICs1OCw4 IEBAIHByaXZhdGU6CiAgICAgdm9pZCBjcmVhdGVTdG9yYWdlQXJlYShDb3JlSVBDOjpDb25uZWN0 aW9uKiwgdWludDY0X3Qgc3RvcmFnZUFyZWFJRCwgdWludDY0X3Qgc3RvcmFnZU5hbWVzcGFjZUlE LCBjb25zdCBTZWN1cml0eU9yaWdpbkRhdGEmKTsKICAgICB2b2lkIGRlc3Ryb3lTdG9yYWdlQXJl YShDb3JlSVBDOjpDb25uZWN0aW9uKiwgdWludDY0X3Qgc3RvcmFnZUFyZWFJRCk7CiAKKyAgICB2 b2lkIGRpc3BhdGNoTWVzc2FnZU9uU3RvcmFnZU1hbmFnZXJRdWV1ZShDb3JlSVBDOjpDb25uZWN0 aW9uKiwgQ29yZUlQQzo6TWVzc2FnZURlY29kZXIqKTsKKwogICAgIFJlZlB0cjxXb3JrUXVldWU+ IG1fcXVldWU7CiB9OwogCg==