109072 2013-02-06 11:05:48 -0800 IndexedDB: De-flake open-during-transaction layout test 2013-02-08 14:50:26 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jsbell jsbell alecflett dgrogan tony webkit.review.bot oldest_to_newest 826568 0 jsbell 2013-02-06 11:05:48 -0800 IndexedDB: De-flake open-during-transaction layout test 826575 1 186879 jsbell 2013-02-06 11:10:17 -0800 Created attachment 186879 Patch 826580 2 jsbell 2013-02-06 11:18:37 -0800 dgrogan@, alecflett@ - can you take a look? I saw this flake when doing repeated runs of the storage/indexeddb tests. I was actually surprised to see this flake under DRT (single-process) as opposed to content_shell (multi-process), but I believe it's due to the timing of the open() calls occurring in event callbacks vs. the transaction timer. (I also moved my /tmp dir to a ramdisk so the opens() take less wall-clock time on my machine.) I don't know if it's worth digging in further. The test was first added in wkrev.com/98749 to act as a canary for crashes around with metadata snapshotting. Since then that whole mechanism has changed and there are dedicated tests and setVersion() has been removed. So I think the remaining purpose of this test is merely "make sure open()-with-no-version isn't blocked on a running transaction". This seems trivial but weird, so feedback appreciated. 826756 3 alecflett 2013-02-06 14:22:53 -0800 lgtm 826920 4 dgrogan 2013-02-06 17:39:56 -0800 lgtm2 828771 5 jsbell 2013-02-08 14:39:18 -0800 tony@ - when convenient, r? cq? 828775 6 186879 webkit.review.bot 2013-02-08 14:50:23 -0800 Comment on attachment 186879 Patch Clearing flags on attachment: 186879 Committed r142324: <http://trac.webkit.org/changeset/142324> 828776 7 webkit.review.bot 2013-02-08 14:50:26 -0800 All reviewed patches have been landed. Closing bug. 186879 2013-02-06 11:10:17 -0800 2013-02-08 14:50:22 -0800 Patch bug-109072-20130206110653.patch text/plain 4151 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxOTYzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMGE0YTI3NDc2YWI2NWEwMzhmMzkx YjQ3MDBkNGM5ZTdkOTQzMjE1My4uOTk3ZTJiNGU3MzE3NTMyNDE2ZTQ1OWVhMDM4OTEyNzhiYWEw MTI5OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAyLTA2ICBKb3NodWEgQmVsbCAgPGpz YmVsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5kZXhlZERCOiBEZS1mbGFrZSBvcGVuLWR1 cmluZy10cmFuc2FjdGlvbiBsYXlvdXQgdGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5MDcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhpcyB0ZXN0IHdhcyBvYnNlcnZlZCB0byBiZSBmbGFreSBp biBsb2NhbCBydW5zOyBzb21ldGltZXMgdGhlIHRyYW5zYWN0aW9uCisgICAgICAgIHdvdWxkIHRl cm1pbmF0ZSBhZnRlciB0aGUgdGhpcmQgb3BlbigpIGNhbGwgcmF0aGVyIHRoYW4gdGhlIHNlY29u ZCwgcmVzdWx0aW5nCisgICAgICAgIGluIGEgVEVYVCBkaWZmZXJlbmNlLiBBZGRlZCBjb2RlIHRv IGtlZXAgdGhlIHRyYW5zYWN0aW9uIGFsaXZlIHVudGlsIGFsbCBvZgorICAgICAgICB0aGUgb3Bl bigpIGNhbGxzIGFyZSBjb21wbGV0ZSwgYW5kIGNoYW5nZWQgZXhwZWN0YXRpb25zIHRvIG1hdGNo LgorCisgICAgICAgICogc3RvcmFnZS9pbmRleGVkZGIvb3Blbi1kdXJpbmctdHJhbnNhY3Rpb24t ZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9vcGVu LWR1cmluZy10cmFuc2FjdGlvbi5qczoKKwogMjAxMy0wMi0wNSAgSnVsaWVuIENoYWZmcmFpeCAg PGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KIAogICAgICAgICBbQ1NTIEdyaWQgTGF5b3V0XSBHcmlk IGl0ZW0ncyBsb2dpY2FsIGhlaWdodCBpcyBub3QgcHJvcGVybHkgcmVjb21wdXRlZCBhZnRlciAt d2Via2l0LWdyaWQtY29sdW1uIC8gLXdlYmtpdC1ncmlkLXJvdyBjaGFuZ2VzCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9vcGVuLWR1cmluZy10cmFuc2FjdGlvbi1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9vcGVuLWR1cmluZy10 cmFuc2FjdGlvbi1leHBlY3RlZC50eHQKaW5kZXggMDc2YWJhOWVmY2ZlMzEwZTQ0YjEwZmYwNzUw ZmNhYzM5ZTQwOWJmNi4uZmM1ZTQwY2RlMzIxNGNkMGI1NzI5YzNjMzgzMmNlY2IyNTJjNjA4NiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvb3Blbi1kdXJpbmctdHJh bnNhY3Rpb24tZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRi L29wZW4tZHVyaW5nLXRyYW5zYWN0aW9uLWV4cGVjdGVkLnR4dApAQCAtMTQsNyArMTQsNyBAQCBk YXRhYmFzZSBwcmVwYXJhdGlvbiBjb21wbGV0ZQogc3RhcnRpbmcgdHJhbnNhY3Rpb24KIHN0YXRl ID0gJ3N0YXJ0aW5nJwogdHJhbnMgPSBkYmMxLnRyYW5zYWN0aW9uKCdzdG9yZU5hbWUnLCAncmVh ZHdyaXRlJykKLXRyYW5zLm9iamVjdFN0b3JlKCdzdG9yZU5hbWUnKS5wdXQoJ3ZhbHVlJywgJ2tl eScpCit0aGUgdHJhbnNhY3Rpb24gaXMga2VwdCBhbGl2ZSB3aXRoIGEgc2VyaWVzIG9mIHB1dHMg dW50aWwgb3BlbnMgYXJlIGNvbXBsZXRlCiAKIHRyeWluZyB0byBvcGVuIHRoZSBzYW1lIGRhdGFi YXNlCiBvcGVucmVxMiA9IGluZGV4ZWREQi5vcGVuKGRibmFtZSkKQEAgLTI2LDEyICsyNiwxMyBA QCBvcGVucmVxMi5vbnN1Y2Nlc3MKIFBBU1Mgc3RhdGUgaXMgInN0YXJ0aW5nIgogc3RhdGUgPSAn b3BlbjJjb21wbGV0ZScKIAotdHJhbnNhY3Rpb24gY29tcGxldGUKLVBBU1Mgc3RhdGUgaXMgIm9w ZW4yY29tcGxldGUiCi0KIG9wZW5yZXEzLm9uc3VjY2VzcwogUEFTUyBzdGF0ZSBpcyAib3BlbjJj b21wbGV0ZSIKIHN0YXRlID0gJ29wZW4zY29tcGxldGUnCisKK3RyYW5zYWN0aW9uIGNvbXBsZXRl CitQQVNTIHN0YXRlIGlzICJvcGVuM2NvbXBsZXRlIgorCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNl ZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3Jh Z2UvaW5kZXhlZGRiL3Jlc291cmNlcy9vcGVuLWR1cmluZy10cmFuc2FjdGlvbi5qcyBiL0xheW91 dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9vcGVuLWR1cmluZy10cmFuc2FjdGlv bi5qcwppbmRleCA4MDk2NGNjZmM3NThmYWU5YmU2YzdjY2M1ZGRmODRlMmFiZTE1YzI0Li40MDI1 ZjExYjNmMzk0NWUzYTI0YjQzODIxNWM0NjM0ZGM5MTMyZTcyIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvb3Blbi1kdXJpbmctdHJhbnNhY3Rpb24u anMKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3VyY2VzL29wZW4tZHVy aW5nLXRyYW5zYWN0aW9uLmpzCkBAIC0yMSwxMyArMjEsMjQgQEAgZnVuY3Rpb24gc3RhcnRUcmFu c2FjdGlvbigpCiAgICAgZGVidWcoInN0YXJ0aW5nIHRyYW5zYWN0aW9uIik7CiAgICAgZXZhbEFu ZExvZygic3RhdGUgPSAnc3RhcnRpbmcnIik7CiAgICAgZXZhbEFuZExvZygidHJhbnMgPSBkYmMx LnRyYW5zYWN0aW9uKCdzdG9yZU5hbWUnLCAncmVhZHdyaXRlJykiKTsKLSAgICBldmFsQW5kTG9n KCJ0cmFucy5vYmplY3RTdG9yZSgnc3RvcmVOYW1lJykucHV0KCd2YWx1ZScsICdrZXknKSIpOwor CisgICAgZGVidWcoInRoZSB0cmFuc2FjdGlvbiBpcyBrZXB0IGFsaXZlIHdpdGggYSBzZXJpZXMg b2YgcHV0cyB1bnRpbCBvcGVucyBhcmUgY29tcGxldGUiKTsKKyAgICAoZnVuY3Rpb24ga2VlcEFs aXZlKCkgeworICAgICAgICAvLyBEb24ndCBsb2csIHNpbmNlIHRoaXMgbWF5IHJ1biBhbiBhcmJp dHJhcnkgbnVtYmVyIG9mIHRpbWVzLgorICAgICAgICBpZiAoc3RhdGUgIT09ICdvcGVuM2NvbXBs ZXRlJykgeworICAgICAgICAgICAgdmFyIHJlcXVlc3QgPSB0cmFucy5vYmplY3RTdG9yZSgnc3Rv cmVOYW1lJykucHV0KCd2YWx1ZScsICdrZXknKTsKKyAgICAgICAgICAgIHJlcXVlc3Qub25lcnJv ciA9IHVuZXhwZWN0ZWRFcnJvckNhbGxiYWNrOworICAgICAgICAgICAgcmVxdWVzdC5vbnN1Y2Nl c3MgPSBrZWVwQWxpdmU7CisgICAgICAgIH0KKyAgICB9KCkpOworCiAgICAgdHJhbnMub25hYm9y dCA9IHVuZXhwZWN0ZWRBYm9ydENhbGxiYWNrOwogICAgIHRyYW5zLm9uZXJyb3IgPSB1bmV4cGVj dGVkRXJyb3JDYWxsYmFjazsKICAgICB0cmFucy5vbmNvbXBsZXRlID0gZnVuY3Rpb24gKGUpIHsK ICAgICAgICAgZGVidWcoInRyYW5zYWN0aW9uIGNvbXBsZXRlIik7Ci0gICAgICAgIHNob3VsZEJl RXF1YWxUb1N0cmluZygic3RhdGUiLCAib3BlbjJjb21wbGV0ZSIpOworICAgICAgICBzaG91bGRC ZUVxdWFsVG9TdHJpbmcoInN0YXRlIiwgIm9wZW4zY29tcGxldGUiKTsKICAgICAgICAgZGVidWco IiIpOworICAgICAgICBmaW5pc2hKU1Rlc3QoKTsKICAgICB9OwogCiAgICAgZGVidWcoIiIpOwpA QCAtNDQsNyArNTUsNyBAQCBmdW5jdGlvbiB0cnlPcGVucygpCiAgICAgICAgIHNob3VsZEJlRXF1 YWxUb1N0cmluZygic3RhdGUiLCAic3RhcnRpbmciKTsKICAgICAgICAgZXZhbEFuZExvZygic3Rh dGUgPSAnb3BlbjJjb21wbGV0ZSciKTsKICAgICAgICAgZGVidWcoIiIpOwotICAgIH0KKyAgICB9 OwogICAgIGRlYnVnKCIiKTsKIAogICAgIGRlYnVnKCJ0cnlpbmcgdG8gb3BlbiBhIGRpZmZlcmVu dCBkYXRhYmFzZSIpOwpAQCAtNTQsNyArNjUsNyBAQCBmdW5jdGlvbiB0cnlPcGVucygpCiAgICAg ICAgIGRlYnVnKCJvcGVucmVxMy5vbnN1Y2Nlc3MiKTsKICAgICAgICAgc2hvdWxkQmVFcXVhbFRv U3RyaW5nKCJzdGF0ZSIsICJvcGVuMmNvbXBsZXRlIik7CiAgICAgICAgIGV2YWxBbmRMb2coInN0 YXRlID0gJ29wZW4zY29tcGxldGUnIik7Ci0gICAgICAgIGZpbmlzaEpTVGVzdCgpOwotICAgIH0K KyAgICAgICAgZGVidWcoIiIpOworICAgIH07CiAgICAgZGVidWcoIiIpOwogfQo=