109042 2013-02-06 05:21:54 -0800 Web Inspector: Native Memory Instrumentation: provide name property for DOM Element and Attribute nodes. 2013-04-08 12:27:16 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 107254 1 loislo loislo apavlov cmarcelo keishi loislo ojan.autocc pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 826362 0 loislo 2013-02-06 05:21:54 -0800 EOM 826364 1 186836 loislo 2013-02-06 05:28:54 -0800 Created attachment 186836 Patch 828270 2 186836 yurys 2013-02-08 00:22:47 -0800 Comment on attachment 186836 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186836&action=review > Source/WebCore/dom/Element.cpp:2827 > + memoryObjectInfo->setName(buildElementSelectorString(this).utf8().data()); This may have a noticeable performance impact which should be avoided in the cases when we don't collect heap graph. 858376 3 186836 pfeldman 2013-03-19 09:53:39 -0700 Comment on attachment 186836 Patch Clearing r? - it has been there for ages, probably obsolete. 186836 2013-02-06 05:28:54 -0800 2013-03-19 09:53:39 -0700 Patch bug-109042-20130206172531.patch text/plain 4740 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxOTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmQ4NGI0NTZkYzk4NTNm OWY4MTc1MzVmODg5ZTJiMTVjMDExOTVjZS4uNTc4NDljNDY1MmQ2ZDczZWRiODFlOTYzNmE4NDMy YmVjNjkwN2YxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAyLTA2ICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBOYXRpdmUgTWVtb3J5IEluc3RydW1lbnRhdGlvbjogcHJvdmlkZSBuYW1lIHByb3BlcnR5 IGZvciBET00gRWxlbWVudCBhbmQgQXR0cmlidXRlIG5vZGVzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5MDQyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHNuYXBzaG90IGhhcyBtYW55IERPTSBp dGVtcyBhbmQgd2UgbmVlZCB0byBnaXZlIHRoZSBkZXZlbG9wZXJzIGEgY2x1ZSB3aG8gaXMgd2hv IGluIHRoaXMgbGlzdCBvZiB0aGUgZWxlbWVudHMuCisgICAgICAgIFRoZSBvbmx5IHJlY29nbml6 YWJsZSBuYW1lIHdoaWNoIHdlIGNvdWxkIHByb3ZpZGUgaXMgdGhlIGVsZW1lbnQgc2VsZWN0b3Ig d2hpY2ggaGFzIHR5cGUgbmFtZSwgaWQgYW5kIGNsYXNzIGxpc3QuCisKKyAgICAgICAgKiBkb20v QXR0cmlidXRlLmg6CisgICAgICAgIChXZWJDb3JlOjpBdHRyaWJ1dGU6OnJlcG9ydE1lbW9yeVVz YWdlKToKKyAgICAgICAgKiBkb20vRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpidWls ZEVsZW1lbnRTZWxlY3RvclN0cmluZyk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdl YkNvcmU6OkVsZW1lbnQ6OnJlcG9ydE1lbW9yeVVzYWdlKToKKyAgICAgICAgKiBkb20vRWxlbWVu dEF0dHJpYnV0ZURhdGEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudEF0dHJpYnV0ZURh dGE6OnJlcG9ydE1lbW9yeVVzYWdlKToKKwogMjAxMy0wMi0wNSAgS2VudGFybyBIYXJhICA8aGFy YWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkICNpZiBVU0UoVjgpIHRvIE5vZGU6OlY4 Q29sbGVjdGFibGVEdXJpbmdNaW5vckdDRmxhZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZG9tL0F0dHJpYnV0ZS5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0F0dHJpYnV0ZS5oCmluZGV4IDE0 MzNiMjM1MjRhODAyZGQ1ZDJiYTFkODk5NzgxMTc0ZTVhMmM1MGYuLjk0NjZmN2U0NDJiYmFhNDQz MjAzYWM4MzE5NmQxNDlhM2YwMDBlODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9B dHRyaWJ1dGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQXR0cmlidXRlLmgKQEAgLTI3LDYg KzI3LDcgQEAKIAogI2luY2x1ZGUgIlF1YWxpZmllZE5hbWUuaCIKICNpbmNsdWRlICJXZWJDb3Jl TWVtb3J5SW5zdHJ1bWVudGF0aW9uLmgiCisjaW5jbHVkZSA8d3RmL01lbW9yeU9iamVjdEluZm8u aD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC02NSw2ICs2Niw3IEBAIHB1YmxpYzoKICAg ICB2b2lkIHJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8qIG1lbW9yeU9iamVjdElu Zm8pIGNvbnN0CiAgICAgewogICAgICAgICBNZW1vcnlDbGFzc0luZm8gaW5mbyhtZW1vcnlPYmpl Y3RJbmZvLCB0aGlzLCBXZWJDb3JlTWVtb3J5VHlwZXM6OkRPTSk7CisgICAgICAgIG1lbW9yeU9i amVjdEluZm8tPnNldE5hbWUodmFsdWUoKS5zdHJpbmcoKS51dGY4KCkuZGF0YSgpKTsKICAgICAg ICAgaW5mby5hZGRNZW1iZXIobV9uYW1lLCAibmFtZSIpOwogICAgICAgICBpbmZvLmFkZE1lbWJl cihtX3ZhbHVlLCAidmFsdWUiKTsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9k b20vRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKaW5kZXggNTMy N2MwZDRiNmUxYmM1MDQ0NGQ2N2FmNTJmYTljYWNlZWQxMTMxYi4uNGY3MzdiMDRjNWNhYzA4YzVl YTIzZTdhNjUwM2Y2ZTIzOTgwNGQ4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0Vs ZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcApAQCAtODEsNiAr ODEsNyBAQAogI2luY2x1ZGUgIlhNTE5hbWVzLmgiCiAjaW5jbHVkZSAiaHRtbGVkaXRpbmcuaCIK ICNpbmNsdWRlIDx3dGYvQml0VmVjdG9yLmg+CisjaW5jbHVkZSA8d3RmL01lbW9yeU9iamVjdElu Zm8uaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKICNpZiBFTkFCTEUoU1ZHKQpA QCAtMjc5NSw5ICsyNzk2LDM1IEBAIHZvaWQgRWxlbWVudDo6Y3JlYXRlTXV0YWJsZUF0dHJpYnV0 ZURhdGEoKQogICAgICAgICBtX2F0dHJpYnV0ZURhdGEgPSBtX2F0dHJpYnV0ZURhdGEtPm1ha2VN dXRhYmxlQ29weSgpOwogfQogCitzdGF0aWMgU3RyaW5nIGJ1aWxkRWxlbWVudFNlbGVjdG9yU3Ry aW5nKGNvbnN0IEVsZW1lbnQqIGVsZW1lbnQpCit7CisgICAgYm9vbCBpc1hIVE1MID0gZWxlbWVu dC0+ZG9jdW1lbnQoKS0+aXNYSFRNTERvY3VtZW50KCk7CisgICAgU3RyaW5nQnVpbGRlciBuYW1l QnVpbGRlcjsKKyAgICBuYW1lQnVpbGRlci5hcHBlbmQoaXNYSFRNTCA/IGVsZW1lbnQtPm5vZGVO YW1lKCkgOiBlbGVtZW50LT5ub2RlTmFtZSgpLmxvd2VyKCkpOworICAgIGlmIChlbGVtZW50LT5o YXNJRCgpKSB7CisgICAgICAgIG5hbWVCdWlsZGVyLmFwcGVuZCgnIycpOworICAgICAgICBuYW1l QnVpbGRlci5hcHBlbmQoZWxlbWVudC0+Z2V0SWRBdHRyaWJ1dGUoKSk7CisgICAgfQorICAgIGlm IChlbGVtZW50LT5oYXNDbGFzcygpICYmIGVsZW1lbnQtPmlzU3R5bGVkRWxlbWVudCgpKSB7Cisg ICAgICAgIEhhc2hTZXQ8QXRvbWljU3RyaW5nPiB1c2VkQ2xhc3NOYW1lczsKKyAgICAgICAgY29u c3QgU3BhY2VTcGxpdFN0cmluZyYgY2xhc3NOYW1lc1N0cmluZyA9IHN0YXRpY19jYXN0PGNvbnN0 IFN0eWxlZEVsZW1lbnQqPihlbGVtZW50KS0+Y2xhc3NOYW1lcygpOworICAgICAgICBzaXplX3Qg Y2xhc3NOYW1lQ291bnQgPSBjbGFzc05hbWVzU3RyaW5nLnNpemUoKTsKKyAgICAgICAgZm9yIChz aXplX3QgaSA9IDA7IGkgPCBjbGFzc05hbWVDb3VudDsgKytpKSB7CisgICAgICAgICAgICBjb25z dCBBdG9taWNTdHJpbmcmIGNsYXNzTmFtZSA9IGNsYXNzTmFtZXNTdHJpbmdbaV07CisgICAgICAg ICAgICBpZiAodXNlZENsYXNzTmFtZXMuY29udGFpbnMoY2xhc3NOYW1lKSkKKyAgICAgICAgICAg ICAgICBjb250aW51ZTsKKyAgICAgICAgICAgIHVzZWRDbGFzc05hbWVzLmFkZChjbGFzc05hbWUp OworICAgICAgICAgICAgbmFtZUJ1aWxkZXIuYXBwZW5kKCcuJyk7CisgICAgICAgICAgICBuYW1l QnVpbGRlci5hcHBlbmQoY2xhc3NOYW1lKTsKKyAgICAgICAgfQorICAgIH0KKyAgICByZXR1cm4g bmFtZUJ1aWxkZXIudG9TdHJpbmcoKTsKK30KKwogdm9pZCBFbGVtZW50OjpyZXBvcnRNZW1vcnlV c2FnZShNZW1vcnlPYmplY3RJbmZvKiBtZW1vcnlPYmplY3RJbmZvKSBjb25zdAogewogICAgIE1l bW9yeUNsYXNzSW5mbyBpbmZvKG1lbW9yeU9iamVjdEluZm8sIHRoaXMsIFdlYkNvcmVNZW1vcnlU eXBlczo6RE9NKTsKKyAgICBtZW1vcnlPYmplY3RJbmZvLT5zZXROYW1lKGJ1aWxkRWxlbWVudFNl bGVjdG9yU3RyaW5nKHRoaXMpLnV0ZjgoKS5kYXRhKCkpOwogICAgIENvbnRhaW5lck5vZGU6OnJl cG9ydE1lbW9yeVVzYWdlKG1lbW9yeU9iamVjdEluZm8pOwogICAgIGluZm8uYWRkTWVtYmVyKG1f dGFnTmFtZSwgInRhZ05hbWUiKTsKICAgICBpbmZvLmFkZE1lbWJlcihtX2F0dHJpYnV0ZURhdGEs ICJhdHRyaWJ1dGVEYXRhIik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dEF0dHJpYnV0ZURhdGEuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnRBdHRyaWJ1dGVE YXRhLmNwcAppbmRleCBlNjk3MWI3ZWUzZWNkNmJiODAwNWMxNzRkMzE0OTllODMwNjcxOTdhLi5m YTBhOTViYTI0MGYxNTY1MWQ3YTdiNzZlNjA2ZDNkZDZiOTlkNWNjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vRWxlbWVudEF0dHJpYnV0ZURhdGEuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2RvbS9FbGVtZW50QXR0cmlidXRlRGF0YS5jcHAKQEAgLTE3Myw3ICsxNzMsNyBAQCB2b2lk IEVsZW1lbnRBdHRyaWJ1dGVEYXRhOjpyZXBvcnRNZW1vcnlVc2FnZShNZW1vcnlPYmplY3RJbmZv KiBtZW1vcnlPYmplY3RJbmZvKQogICAgICAgICBpbmZvLmFkZE1lbWJlcihtdXRhYmxlQXR0cmli dXRlVmVjdG9yKCksICJtdXRhYmxlQXR0cmlidXRlVmVjdG9yIik7CiAgICAgfQogICAgIGZvciAo dW5zaWduZWQgaSA9IDAsIGxlbiA9IGxlbmd0aCgpOyBpIDwgbGVuOyBpKyspCi0gICAgICAgIGlu Zm8uYWRkTWVtYmVyKCphdHRyaWJ1dGVJdGVtKGkpLCAiKmF0dHJpYnV0ZUl0ZW0iKTsKKyAgICAg ICAgaW5mby5hZGRNZW1iZXIoKmF0dHJpYnV0ZUl0ZW0oaSksICJhdHRyaWJ1dGUiKTsKIH0KIAog c2l6ZV90IEVsZW1lbnRBdHRyaWJ1dGVEYXRhOjpnZXRBdHRyaWJ1dGVJdGVtSW5kZXhTbG93Q2Fz ZShjb25zdCBBdG9taWNTdHJpbmcmIG5hbWUsIGJvb2wgc2hvdWxkSWdub3JlQXR0cmlidXRlQ2Fz ZSkgY29uc3QK