108992 2013-02-05 17:11:11 -0800 [wk2] TiledCoreAnimationDrawingArea has one more layer in its CAContext when we're in the background 2019-05-02 16:19:54 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca freddie.greenberg sam simon.fraser oldest_to_newest 825948 0 thorton 2013-02-05 17:11:11 -0800 There's one root layer left when we're out-of-window. We should get rid of it! <rdar://problem/13087365> 825956 1 186729 thorton 2013-02-05 17:24:38 -0800 Created attachment 186729 patch 825959 2 thorton 2013-02-05 17:29:40 -0800 Renaming m_isInWindow to m_hasRootCompositingLayer. 825960 3 186730 thorton 2013-02-05 17:30:11 -0800 Created attachment 186730 patch 825961 4 thorton 2013-02-05 17:34:03 -0800 http://trac.webkit.org/changeset/141952 186729 2013-02-05 17:24:38 -0800 2013-02-05 17:30:11 -0800 patch root-layer.diff text/plain 3122 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4YWQ2Yjg3Li5iMGEwNDM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDItMDUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgW3drMl0gVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEgaGFzIG9uZSBtb3Jl IGxheWVyIGluIGl0cyBDQUNvbnRleHQgd2hlbiB3ZSdyZSBpbiB0aGUgYmFja2dyb3VuZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4OTkyCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8xMzA4NzM2NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3Jl QW5pbWF0aW9uRHJhd2luZ0FyZWEuaDoKKyAgICAgICAgKFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdp bmdBcmVhKTogQWRkIHN0b3JhZ2UgZm9yIG1faXNJbldpbmRvdy4KKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tOgorICAgICAg ICAoV2ViS2l0OjpUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6dXBkYXRlTGF5ZXJIb3N0 aW5nQ29udGV4dCk6IE9ubHkgc2V0IHRoZSByb290IGxheWVyIG9uIG91ciBsYXllcgorICAgICAg ICBob3N0aW5nIGNvbnRleHQgaWYgd2UncmUgaW4gdGhlIHdpbmRvdyB3aGVuIHN3YXBwaW5nIG91 dCBjb250ZXh0cy4KKyAgICAgICAgKFdlYktpdDo6VGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0Fy ZWE6OnNldFJvb3RDb21wb3NpdGluZ0xheWVyKTogVXBkYXRlIG1faXNJbldpbmRvdywgYW5kIHNl dCB0aGUgcm9vdCBsYXllcgorICAgICAgICBvZiB0aGUgbGF5ZXIgaG9zdGluZyBjb250ZXh0IChv ciB1bnNldCBpdCBpZiB3ZSdyZSBvdXQgb2YgdGhlIHdpbmRvdykuCisKIDIwMTMtMDItMDUgIEFu ZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJLaXQgY2xp ZW50cyBzaG91bGQgYmUgYWJsZSB0byBvdmVycmlkZSBsb2FkaW5nIG9mIGJsb2NrZWQgcGx1Zy1p bnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGls ZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEuaAppbmRleCBhYzljNTAz Li44MTQyODM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv bWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLmgKKysrIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5oCkBA IC0xMTcsNiArMTE3LDcgQEAgcHJpdmF0ZToKICAgICBtdXRhYmxlIFJldGFpblB0cjxDQUxheWVy PiBtX3BhZ2VPdmVybGF5UGxhdGZvcm1MYXllcjsKIAogICAgIGJvb2wgbV9pc1BhaW50aW5nU3Vz cGVuZGVkOworICAgIGJvb2wgbV9pc0luV2luZG93OwogCiAgICAgV2ViQ29yZTo6SW50UmVjdCBt X2V4cG9zZWRSZWN0OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5t bQppbmRleCA1NWI5NzQyLi42YzJiNGJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tCisrKyBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9u RHJhd2luZ0FyZWEubW0KQEAgLTQ0Niw3ICs0NDYsOSBAQCB2b2lkIFRpbGVkQ29yZUFuaW1hdGlv bkRyYXdpbmdBcmVhOjp1cGRhdGVMYXllckhvc3RpbmdDb250ZXh0KCkKICNlbmRpZgogICAgIH0K IAotICAgIG1fbGF5ZXJIb3N0aW5nQ29udGV4dC0+c2V0Um9vdExheWVyKG1fcm9vdExheWVyLmdl dCgpKTsKKyAgICBpZiAobV9pc0luV2luZG93KQorICAgICAgICBtX2xheWVySG9zdGluZ0NvbnRl eHQtPnNldFJvb3RMYXllcihtX3Jvb3RMYXllci5nZXQoKSk7CisKICAgICBpZiAoY29sb3JTcGFj ZSkKICAgICAgICAgbV9sYXllckhvc3RpbmdDb250ZXh0LT5zZXRDb2xvclNwYWNlKGNvbG9yU3Bh Y2UuZ2V0KCkpOwogfQpAQCAtNDU1LDEwICs0NTcsMTYgQEAgdm9pZCBUaWxlZENvcmVBbmltYXRp b25EcmF3aW5nQXJlYTo6c2V0Um9vdENvbXBvc2l0aW5nTGF5ZXIoQ0FMYXllciAqbGF5ZXIpCiB7 CiAgICAgQVNTRVJUKCFtX2xheWVyVHJlZVN0YXRlSXNGcm96ZW4pOwogCisgICAgYm9vbCB3YXNJ bldpbmRvdyA9IG1faXNJbldpbmRvdzsKKyAgICBtX2lzSW5XaW5kb3cgPSAhIWxheWVyOworCiAg ICAgW0NBVHJhbnNhY3Rpb24gYmVnaW5dOwogICAgIFtDQVRyYW5zYWN0aW9uIHNldERpc2FibGVB Y3Rpb25zOllFU107CiAKLSAgICBtX3Jvb3RMYXllci5nZXQoKS5zdWJsYXllcnMgPSBsYXllciA/ IFtOU0FycmF5IGFycmF5V2l0aE9iamVjdDpsYXllcl0gOiBbTlNBcnJheSBhcnJheV07CisgICAg bV9yb290TGF5ZXIuZ2V0KCkuc3VibGF5ZXJzID0gbV9pc0luV2luZG93ID8gW05TQXJyYXkgYXJy YXlXaXRoT2JqZWN0OmxheWVyXSA6IFtOU0FycmF5IGFycmF5XTsKKworICAgIGlmICh3YXNJbldp bmRvdyAhPSBtX2lzSW5XaW5kb3cpCisgICAgICAgIG1fbGF5ZXJIb3N0aW5nQ29udGV4dC0+c2V0 Um9vdExheWVyKG1faXNJbldpbmRvdyA/IG1fcm9vdExheWVyLmdldCgpIDogMCk7CiAKICAgICBp ZiAobV9wYWdlT3ZlcmxheUxheWVyKQogICAgICAgICBbbV9yb290TGF5ZXIuZ2V0KCkgYWRkU3Vi bGF5ZXI6bV9wYWdlT3ZlcmxheUxheWVyLT5wbGF0Zm9ybUxheWVyKCldOwo= 186730 2013-02-05 17:30:11 -0800 2013-02-05 17:31:02 -0800 patch root-layer.diff text/plain 3213 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4YWQ2Yjg3Li5iMGEwNDM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDItMDUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgW3drMl0gVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEgaGFzIG9uZSBtb3Jl IGxheWVyIGluIGl0cyBDQUNvbnRleHQgd2hlbiB3ZSdyZSBpbiB0aGUgYmFja2dyb3VuZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4OTkyCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8xMzA4NzM2NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3Jl QW5pbWF0aW9uRHJhd2luZ0FyZWEuaDoKKyAgICAgICAgKFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdp bmdBcmVhKTogQWRkIHN0b3JhZ2UgZm9yIG1faXNJbldpbmRvdy4KKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tOgorICAgICAg ICAoV2ViS2l0OjpUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6dXBkYXRlTGF5ZXJIb3N0 aW5nQ29udGV4dCk6IE9ubHkgc2V0IHRoZSByb290IGxheWVyIG9uIG91ciBsYXllcgorICAgICAg ICBob3N0aW5nIGNvbnRleHQgaWYgd2UncmUgaW4gdGhlIHdpbmRvdyB3aGVuIHN3YXBwaW5nIG91 dCBjb250ZXh0cy4KKyAgICAgICAgKFdlYktpdDo6VGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0Fy ZWE6OnNldFJvb3RDb21wb3NpdGluZ0xheWVyKTogVXBkYXRlIG1faXNJbldpbmRvdywgYW5kIHNl dCB0aGUgcm9vdCBsYXllcgorICAgICAgICBvZiB0aGUgbGF5ZXIgaG9zdGluZyBjb250ZXh0IChv ciB1bnNldCBpdCBpZiB3ZSdyZSBvdXQgb2YgdGhlIHdpbmRvdykuCisKIDIwMTMtMDItMDUgIEFu ZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJLaXQgY2xp ZW50cyBzaG91bGQgYmUgYWJsZSB0byBvdmVycmlkZSBsb2FkaW5nIG9mIGJsb2NrZWQgcGx1Zy1p bnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGls ZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEuaAppbmRleCBhYzljNTAz Li42ZDkzNWNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv bWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLmgKKysrIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5oCkBA IC0xMTcsNiArMTE3LDcgQEAgcHJpdmF0ZToKICAgICBtdXRhYmxlIFJldGFpblB0cjxDQUxheWVy PiBtX3BhZ2VPdmVybGF5UGxhdGZvcm1MYXllcjsKIAogICAgIGJvb2wgbV9pc1BhaW50aW5nU3Vz cGVuZGVkOworICAgIGJvb2wgbV9oYXNSb290Q29tcG9zaXRpbmdMYXllcjsKIAogICAgIFdlYkNv cmU6OkludFJlY3QgbV9leHBvc2VkUmVjdDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbSBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9u RHJhd2luZ0FyZWEubW0KaW5kZXggNTViOTc0Mi4uYzQ2NDY0ZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5n QXJlYS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVk Q29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tCkBAIC00NDYsNyArNDQ2LDkgQEAgdm9pZCBUaWxl ZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6dXBkYXRlTGF5ZXJIb3N0aW5nQ29udGV4dCgpCiAj ZW5kaWYKICAgICB9CiAKLSAgICBtX2xheWVySG9zdGluZ0NvbnRleHQtPnNldFJvb3RMYXllciht X3Jvb3RMYXllci5nZXQoKSk7CisgICAgaWYgKG1faGFzUm9vdENvbXBvc2l0aW5nTGF5ZXIpCisg ICAgICAgIG1fbGF5ZXJIb3N0aW5nQ29udGV4dC0+c2V0Um9vdExheWVyKG1fcm9vdExheWVyLmdl dCgpKTsKKwogICAgIGlmIChjb2xvclNwYWNlKQogICAgICAgICBtX2xheWVySG9zdGluZ0NvbnRl eHQtPnNldENvbG9yU3BhY2UoY29sb3JTcGFjZS5nZXQoKSk7CiB9CkBAIC00NTUsMTAgKzQ1Nywx NiBAQCB2b2lkIFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjpzZXRSb290Q29tcG9zaXRp bmdMYXllcihDQUxheWVyICpsYXllcikKIHsKICAgICBBU1NFUlQoIW1fbGF5ZXJUcmVlU3RhdGVJ c0Zyb3plbik7CiAKKyAgICBib29sIHdhc0luV2luZG93ID0gbV9oYXNSb290Q29tcG9zaXRpbmdM YXllcjsKKyAgICBtX2hhc1Jvb3RDb21wb3NpdGluZ0xheWVyID0gISFsYXllcjsKKwogICAgIFtD QVRyYW5zYWN0aW9uIGJlZ2luXTsKICAgICBbQ0FUcmFuc2FjdGlvbiBzZXREaXNhYmxlQWN0aW9u czpZRVNdOwogCi0gICAgbV9yb290TGF5ZXIuZ2V0KCkuc3VibGF5ZXJzID0gbGF5ZXIgPyBbTlNB cnJheSBhcnJheVdpdGhPYmplY3Q6bGF5ZXJdIDogW05TQXJyYXkgYXJyYXldOworICAgIG1fcm9v dExheWVyLmdldCgpLnN1YmxheWVycyA9IG1faGFzUm9vdENvbXBvc2l0aW5nTGF5ZXIgPyBbTlNB cnJheSBhcnJheVdpdGhPYmplY3Q6bGF5ZXJdIDogW05TQXJyYXkgYXJyYXldOworCisgICAgaWYg KHdhc0luV2luZG93ICE9IG1faGFzUm9vdENvbXBvc2l0aW5nTGF5ZXIpCisgICAgICAgIG1fbGF5 ZXJIb3N0aW5nQ29udGV4dC0+c2V0Um9vdExheWVyKG1faGFzUm9vdENvbXBvc2l0aW5nTGF5ZXIg PyBtX3Jvb3RMYXllci5nZXQoKSA6IDApOwogCiAgICAgaWYgKG1fcGFnZU92ZXJsYXlMYXllcikK ICAgICAgICAgW21fcm9vdExheWVyLmdldCgpIGFkZFN1YmxheWVyOm1fcGFnZU92ZXJsYXlMYXll ci0+cGxhdGZvcm1MYXllcigpXTsK