108988 2013-02-05 16:04:05 -0800 Rename ENUM_CLASS_BEGIN() macro to ENUM_CLASS() + make DatabaseType a strong enum 2013-02-05 17:01:40 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107475 1 mark.lam mark.lam andersca ap beidson benjamin ojan.autocc sam webkit.review.bot oldest_to_newest 825910 0 mark.lam 2013-02-05 16:04:05 -0800 Rename ENUM_CLASS_BEGIN() macro to ENUM_CLASS(), and make DatabaseType a strong enum. 825915 1 186720 mark.lam 2013-02-05 16:08:59 -0800 Created attachment 186720 the patch. 825918 2 mark.lam 2013-02-05 16:10:41 -0800 Here's another small EnumClass patch. May I have a review please? Thanks. 825919 3 webkit.review.bot 2013-02-05 16:12:05 -0800 Attachment 186720 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/EnumClass.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webdatabase/DatabaseBackend.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseBackend.h', u'Source/WebCore/Modules/webdatabase/DatabaseBackendAsync.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseBackendSync.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseBasicTypes.h', u'Source/WebCore/Modules/webdatabase/DatabaseError.h']" exit_code: 1 Source/WebCore/Modules/webdatabase/DatabaseError.h:35: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebCore/Modules/webdatabase/DatabaseBasicTypes.h:38: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style. 825942 4 mark.lam 2013-02-05 17:01:40 -0800 Thanks for the review. Landed in r141950: <http://trac.webkit.org/changeset/141950>. 186720 2013-02-05 16:08:59 -0800 2013-02-05 16:52:28 -0800 the patch. bug-108988.patch text/plain 6391 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNDE5NDUpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAyLTA1ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBSZW5hbWUgRU5VTV9DTEFTU19CRUdJTigpIG1hY3JvIHRv IEVOVU1fQ0xBU1MoKSwgYW5kIG1ha2UgRGF0YWJhc2VUeXBlIGEgc3Ryb25nIGVudW0uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg5ODguCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvRW51bUNs YXNzLmg6CisKIDIwMTMtMDItMDUgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxlLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL0Vu dW1DbGFzcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0VudW1DbGFzcy5oCShyZXZp c2lvbiAxNDE5MzMpCisrKyBTb3VyY2UvV1RGL3d0Zi9FbnVtQ2xhc3MuaAkod29ya2luZyBjb3B5 KQpAQCAtNDMsNyArNDMsNyBAQCBuYW1lc3BhY2UgV1RGIHsKIC8vCiAvLyAuLi4gd3JpdGUgdGhp czoKIC8vCi0vLyAgICAgRU5VTV9DTEFTU19CRUdJTihNeUVudW1zKSB7CisvLyAgICAgRU5VTV9D TEFTUyhNeUVudW1zKSB7CiAvLyAgICAgICAgIFZhbHVlMSwKIC8vICAgICAgICAgVmFsdWUyLAog Ly8gICAgICAgICAuLi4KQEAgLTU0LDcgKzU0LDcgQEAgbmFtZXNwYWNlIFdURiB7CiAvLyBPdGhl cndpc2UsIGl0IHdpbGwgdXNlIHRoZSBFbnVtQ2xhc3MgdGVtcGxhdGUgYmVsb3cuCiAKICNpZiBD T01QSUxFUl9TVVBQT1JUUyhDWFhfU1RST05HX0VOVU1TKQotI2RlZmluZSBFTlVNX0NMQVNTX0JF R0lOKF9fZW51bU5hbWUpIFwKKyNkZWZpbmUgRU5VTV9DTEFTUyhfX2VudW1OYW1lKSBcCiAgICAg ZW51bSBjbGFzcyBfX2VudW1OYW1lCiAKICNkZWZpbmUgRU5VTV9DTEFTU19FTkQoX19lbnVtTmFt ZSkKQEAgLTEwNCw3ICsxMDQsNyBAQCBwcml2YXRlOgogICAgIFZhbHVlIG1fdmFsdWU7CiB9Owog Ci0jZGVmaW5lIEVOVU1fQ0xBU1NfQkVHSU4oX19lbnVtTmFtZSkgXAorI2RlZmluZSBFTlVNX0NM QVNTKF9fZW51bU5hbWUpIFwKICAgICBzdHJ1Y3QgX19lbnVtTmFtZSAjIyBEZWZpbml0aW9uIHsg XAogICAgICAgICBlbnVtIEVudW1zCiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MTk0NSkK KysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1 IEBACisyMDEzLTAyLTA1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAg ICBSZW5hbWUgRU5VTV9DTEFTU19CRUdJTigpIG1hY3JvIHRvIEVOVU1fQ0xBU1MoKSwgYW5kIG1h a2UgRGF0YWJhc2VUeXBlIGEgc3Ryb25nIGVudW0uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg5ODguCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogTW9kdWxl cy93ZWJkYXRhYmFzZS9EYXRhYmFzZUJhY2tlbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGF0 YWJhc2VCYWNrZW5kOjpEYXRhYmFzZUJhY2tlbmQpOgorICAgICAgICAqIE1vZHVsZXMvd2ViZGF0 YWJhc2UvRGF0YWJhc2VCYWNrZW5kLmg6CisgICAgICAgIChEYXRhYmFzZUJhY2tlbmQpOgorICAg ICAgICAqIE1vZHVsZXMvd2ViZGF0YWJhc2UvRGF0YWJhc2VCYWNrZW5kQXN5bmMuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RGF0YWJhc2VCYWNrZW5kQXN5bmM6OkRhdGFiYXNlQmFja2VuZEFzeW5j KToKKyAgICAgICAgKiBNb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNlQmFja2VuZFN5bmMuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RGF0YWJhc2VCYWNrZW5kU3luYzo6RGF0YWJhc2VCYWNrZW5k U3luYyk6CisgICAgICAgICogTW9kdWxlcy93ZWJkYXRhYmFzZS9EYXRhYmFzZUJhc2ljVHlwZXMu aDoKKyAgICAgICAgKFdlYkNvcmU6OkVOVU1fQ0xBU1MpOgorICAgICAgICAqIE1vZHVsZXMvd2Vi ZGF0YWJhc2UvRGF0YWJhc2VFcnJvci5oOgorICAgICAgICAoV2ViQ29yZTo6RU5VTV9DTEFTUyk6 CisKIDIwMTMtMDItMDUgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFtWOF0gTWFrZSBhbiBJc29sYXRlIHBhcmFtZXRlciBtYW5kYXRvcnkgaW4gSGFzSW5z dGFuY2UoKQpJbmRleDogU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFzZS9EYXRhYmFz ZUJhY2tlbmQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0 YWJhc2UvRGF0YWJhc2VCYWNrZW5kLmNwcAkocmV2aXNpb24gMTQxOTMzKQorKysgU291cmNlL1dl YkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFzZS9EYXRhYmFzZUJhY2tlbmQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yMTUsNyArMjE1LDcgQEAgRGF0YWJhc2VCYWNrZW5kOjpEYXRhYmFzZUJhY2tlbmQo UGFzc1JlZgogICAgICwgbV9ndWlkKDApCiAgICAgLCBtX29wZW5lZChmYWxzZSkKICAgICAsIG1f bmV3KGZhbHNlKQotICAgICwgbV9pc1N5bmNEYXRhYmFzZShkYXRhYmFzZVR5cGUgPT0gU3luY0Rh dGFiYXNlKQorICAgICwgbV9pc1N5bmNEYXRhYmFzZShkYXRhYmFzZVR5cGUgPT0gRGF0YWJhc2VU eXBlOjpTeW5jKQogewogICAgIG1fY29udGV4dFRocmVhZFNlY3VyaXR5T3JpZ2luID0gbV9kYXRh YmFzZUNvbnRleHQtPnNlY3VyaXR5T3JpZ2luKCktPmlzb2xhdGVkQ29weSgpOwogCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNlQmFja2VuZC5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJhc2UvRGF0YWJhc2VCYWNr ZW5kLmgJKHJldmlzaW9uIDE0MTkzMykKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0 YWJhc2UvRGF0YWJhc2VCYWNrZW5kLmgJKHdvcmtpbmcgY29weSkKQEAgLTk4LDExICs5OCw2IEBA IHByb3RlY3RlZDoKICAgICBmcmllbmQgY2xhc3MgU1FMVHJhbnNhY3Rpb25TeW5jOwogICAgIGZy aWVuZCBjbGFzcyBTUUxUcmFuc2FjdGlvbjsKIAotICAgIGVudW0gRGF0YWJhc2VUeXBlIHsKLSAg ICAgICAgQXN5bmNEYXRhYmFzZSwKLSAgICAgICAgU3luY0RhdGFiYXNlCi0gICAgfTsKLQogICAg IERhdGFiYXNlQmFja2VuZChQYXNzUmVmUHRyPERhdGFiYXNlQmFja2VuZENvbnRleHQ+LCBjb25z dCBTdHJpbmcmIG5hbWUsIGNvbnN0IFN0cmluZyYgZXhwZWN0ZWRWZXJzaW9uLAogICAgICAgICBj b25zdCBTdHJpbmcmIGRpc3BsYXlOYW1lLCB1bnNpZ25lZCBsb25nIGVzdGltYXRlZFNpemUsIERh dGFiYXNlVHlwZSk7CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJhc2Uv RGF0YWJhc2VCYWNrZW5kQXN5bmMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01v ZHVsZXMvd2ViZGF0YWJhc2UvRGF0YWJhc2VCYWNrZW5kQXN5bmMuY3BwCShyZXZpc2lvbiAxNDE5 MzMpCisrKyBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNlQmFja2Vu ZEFzeW5jLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzMsNyArMzMsNyBAQAogbmFtZXNwYWNlIFdl YkNvcmUgewogCiBEYXRhYmFzZUJhY2tlbmRBc3luYzo6RGF0YWJhc2VCYWNrZW5kQXN5bmMoUGFz c1JlZlB0cjxEYXRhYmFzZUJhY2tlbmRDb250ZXh0PiBkYXRhYmFzZUNvbnRleHQsIGNvbnN0IFN0 cmluZyYgbmFtZSwgY29uc3QgU3RyaW5nJiBleHBlY3RlZFZlcnNpb24sIGNvbnN0IFN0cmluZyYg ZGlzcGxheU5hbWUsIHVuc2lnbmVkIGxvbmcgZXN0aW1hdGVkU2l6ZSkKLSAgICA6IERhdGFiYXNl QmFja2VuZChkYXRhYmFzZUNvbnRleHQsIG5hbWUsIGV4cGVjdGVkVmVyc2lvbiwgZGlzcGxheU5h bWUsIGVzdGltYXRlZFNpemUsIEFzeW5jRGF0YWJhc2UpCisgICAgOiBEYXRhYmFzZUJhY2tlbmQo ZGF0YWJhc2VDb250ZXh0LCBuYW1lLCBleHBlY3RlZFZlcnNpb24sIGRpc3BsYXlOYW1lLCBlc3Rp bWF0ZWRTaXplLCBEYXRhYmFzZVR5cGU6OkFzeW5jKQogewogfQogCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNlQmFja2VuZFN5bmMuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJhc2UvRGF0YWJhc2VCYWNrZW5k U3luYy5jcHAJKHJldmlzaW9uIDE0MTkzMykKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vi ZGF0YWJhc2UvRGF0YWJhc2VCYWNrZW5kU3luYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzLDcg KzMzLDcgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogRGF0YWJhc2VCYWNrZW5kU3luYzo6RGF0 YWJhc2VCYWNrZW5kU3luYyhQYXNzUmVmUHRyPERhdGFiYXNlQmFja2VuZENvbnRleHQ+IGRhdGFi YXNlQ29udGV4dCwgY29uc3QgU3RyaW5nJiBuYW1lLCBjb25zdCBTdHJpbmcmIGV4cGVjdGVkVmVy c2lvbiwgY29uc3QgU3RyaW5nJiBkaXNwbGF5TmFtZSwgdW5zaWduZWQgbG9uZyBlc3RpbWF0ZWRT aXplKQotICAgIDogRGF0YWJhc2VCYWNrZW5kKGRhdGFiYXNlQ29udGV4dCwgbmFtZSwgZXhwZWN0 ZWRWZXJzaW9uLCBkaXNwbGF5TmFtZSwgZXN0aW1hdGVkU2l6ZSwgU3luY0RhdGFiYXNlKQorICAg IDogRGF0YWJhc2VCYWNrZW5kKGRhdGFiYXNlQ29udGV4dCwgbmFtZSwgZXhwZWN0ZWRWZXJzaW9u LCBkaXNwbGF5TmFtZSwgZXN0aW1hdGVkU2l6ZSwgRGF0YWJhc2VUeXBlOjpTeW5jKQogewogfQog CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNlQmFzaWNU eXBlcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJhc2Uv RGF0YWJhc2VCYXNpY1R5cGVzLmgJKHJldmlzaW9uIDE0MTkzMykKKysrIFNvdXJjZS9XZWJDb3Jl L01vZHVsZXMvd2ViZGF0YWJhc2UvRGF0YWJhc2VCYXNpY1R5cGVzLmgJKHdvcmtpbmcgY29weSkK QEAgLTI4LDExICsyOCwxOCBAQAogCiAjaWYgRU5BQkxFKFNRTF9EQVRBQkFTRSkKIAorI2luY2x1 ZGUgPHd0Zi9FbnVtQ2xhc3MuaD4KKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiB0eXBlZGVmIGlu dCBEYXRhYmFzZUd1aWQ7CiB0eXBlZGVmIGludCBFeGNlcHRpb25Db2RlOwogCitFTlVNX0NMQVNT KERhdGFiYXNlVHlwZSkgeworICAgIEFzeW5jLAorICAgIFN5bmMKK30gRU5VTV9DTEFTU19FTkQo RGF0YWJhc2VUeXBlKTsKKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gRU5B QkxFKFNRTF9EQVRBQkFTRSkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJh c2UvRGF0YWJhc2VFcnJvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMv d2ViZGF0YWJhc2UvRGF0YWJhc2VFcnJvci5oCShyZXZpc2lvbiAxNDE5MzMpCisrKyBTb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNlRXJyb3IuaAkod29ya2luZyBjb3B5 KQpAQCAtMzIsNyArMzIsNyBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLUVOVU1fQ0xBU1Nf QkVHSU4oRGF0YWJhc2VFcnJvcikgeworRU5VTV9DTEFTUyhEYXRhYmFzZUVycm9yKSB7CiAgICAg Tm9uZSA9IDAsCiAgICAgQ2Fubm90T3BlbkRhdGFiYXNlLAogICAgIERhdGFiYXNlSXNCZWluZ0Rl bGV0ZWQsCg==