108977 2013-02-05 13:34:45 -0800 Make baseWritingDirectionForSelectionStart available to all platforms in the Editor class 2013-02-05 14:39:00 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All Unspecified RESOLVED FIXED P2 Normal --- 1 enrica enrica mifenton webkit.review.bot oldest_to_newest 825774 0 enrica 2013-02-05 13:34:45 -0800 This method used to be Mac specific because it was returning NSWritingDirection. After http://trac.webkit.org/changeset/141513 the same method now returns WritingDirection which is a WebCore type. We want to move this to Editor.cpp so that we can use it for iOS as well. 825813 1 186703 enrica 2013-02-05 14:16:24 -0800 Created attachment 186703 Patch 825817 2 186703 rniwa 2013-02-05 14:21:52 -0800 Comment on attachment 186703 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186703&action=review > Source/WebCore/editing/Editor.cpp:1345 > + result = LeftToRightWritingDirection; > + break; I know you're just moving an existing code but we can just return here. > Source/WebCore/editing/Editor.cpp:1348 > + result = RightToLeftWritingDirection; > + break; Ditto. 825825 3 enrica 2013-02-05 14:34:05 -0800 (In reply to comment #2) > (From update of attachment 186703 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186703&action=review > > > Source/WebCore/editing/Editor.cpp:1345 > > + result = LeftToRightWritingDirection; > > + break; > > I know you're just moving an existing code but we can just return here. > > > Source/WebCore/editing/Editor.cpp:1348 > > + result = RightToLeftWritingDirection; > > + break; > > Ditto. I agree. Thanks for the review! 825832 4 enrica 2013-02-05 14:39:00 -0800 Committed revision 141937. 186703 2013-02-05 14:16:24 -0800 2013-02-05 14:21:52 -0800 Patch moveBaseWritingDirection.txt text/plain 4610 enrica SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MTkyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTA1ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBiYXNlV3JpdGluZ0Rp cmVjdGlvbkZvclNlbGVjdGlvblN0YXJ0IGF2YWlsYWJsZSB0byBhbGwgcGxhdGZvcm1zIGluIHRo ZSBFZGl0b3IgY2xhc3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDg5NzcuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisg ICAgICAgIAorICAgICAgICBOb3cgdGhhdCBiYXNlV3JpdGluZ0RpcmVjdGlvbkZvclNlbGVjdGlv blN0YXJ0IGRvZXNuJ3QgdXNlCisgICAgICAgIHBsYXRmb3JtIHNwZWNpZmljIHR5cGUgYW55bW9y ZSwgd2UgY2FuIG1ha2UgaXQgYXZhaWxhYmxlIGZvcgorICAgICAgICBhbGwgcGxhdGZvcm1zLiBU aGlzIHdheSBpdCBjYW4gYmUgdXNlZCBmb3IgaU9TIGFzIHdlbGwuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLCBubyBmdW5jdGlvbmFsaXR5IGNoYW5nZS4KKworICAgICAgICAqIGVkaXRpbmcvRWRp dG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6YmFzZVdyaXRpbmdEaXJlY3Rpb25G b3JTZWxlY3Rpb25TdGFydCk6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvRWRpdG9yLmg6IE1v dmVkIGZyb20gUExBVEZPUk0oTUFDKS4KKyAgICAgICAgKiBlZGl0aW5nL21hYy9FZGl0b3JNYWMu bW06IGJhc2VXcml0aW5nRGlyZWN0aW9uRm9yU2VsZWN0aW9uU3RhcnQgcmVtb3ZlZC4KKwogMjAx My0wMi0wNSAgTmF5YW4gS3VtYXIgSyAgPG5heWFua2tAbW90b3JvbGEuY29tPgogCiAgICAgICAg IFtXRUJHTF0gUmVuYW1lIFdFQktJVF9XRUJHTF9kZXB0aF90ZXh0dXJlIHRvIFdFQkdMX2RlcHRo X3RleHR1cmUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCShyZXZpc2lvbiAxNDE3 OTgpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTEzMTYsNiArMTMxNiw0MSBAQCB2b2lkIEVkaXRvcjo6c2V0QmFzZVdyaXRpbmdEaXJlY3Rp b24oV3JpCiAgICAgYXBwbHlQYXJhZ3JhcGhTdHlsZVRvU2VsZWN0aW9uKHN0eWxlLmdldCgpLCBF ZGl0QWN0aW9uU2V0V3JpdGluZ0RpcmVjdGlvbik7CiB9CiAKK1dyaXRpbmdEaXJlY3Rpb24gRWRp dG9yOjpiYXNlV3JpdGluZ0RpcmVjdGlvbkZvclNlbGVjdGlvblN0YXJ0KCkgY29uc3QKK3sKKyAg ICBXcml0aW5nRGlyZWN0aW9uIHJlc3VsdCA9IExlZnRUb1JpZ2h0V3JpdGluZ0RpcmVjdGlvbjsK KworICAgIFBvc2l0aW9uIHBvcyA9IG1fZnJhbWUtPnNlbGVjdGlvbigpLT5zZWxlY3Rpb24oKS52 aXNpYmxlU3RhcnQoKS5kZWVwRXF1aXZhbGVudCgpOworICAgIE5vZGUqIG5vZGUgPSBwb3MuZGVw cmVjYXRlZE5vZGUoKTsKKyAgICBpZiAoIW5vZGUpCisgICAgICAgIHJldHVybiByZXN1bHQ7CisK KyAgICBSZW5kZXJPYmplY3QqIHJlbmRlcmVyID0gbm9kZS0+cmVuZGVyZXIoKTsKKyAgICBpZiAo IXJlbmRlcmVyKQorICAgICAgICByZXR1cm4gcmVzdWx0OworCisgICAgaWYgKCFyZW5kZXJlci0+ aXNCbG9ja0Zsb3coKSkgeworICAgICAgICByZW5kZXJlciA9IHJlbmRlcmVyLT5jb250YWluaW5n QmxvY2soKTsKKyAgICAgICAgaWYgKCFyZW5kZXJlcikKKyAgICAgICAgICAgIHJldHVybiByZXN1 bHQ7CisgICAgfQorCisgICAgUmVuZGVyU3R5bGUqIHN0eWxlID0gcmVuZGVyZXItPnN0eWxlKCk7 CisgICAgaWYgKCFzdHlsZSkKKyAgICAgICAgcmV0dXJuIHJlc3VsdDsKKworICAgIHN3aXRjaCAo c3R5bGUtPmRpcmVjdGlvbigpKSB7CisgICAgY2FzZSBMVFI6CisgICAgICAgIHJlc3VsdCA9IExl ZnRUb1JpZ2h0V3JpdGluZ0RpcmVjdGlvbjsKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBSVEw6 CisgICAgICAgIHJlc3VsdCA9IFJpZ2h0VG9MZWZ0V3JpdGluZ0RpcmVjdGlvbjsKKyAgICAgICAg YnJlYWs7CisgICAgfQorICAgIAorICAgIHJldHVybiByZXN1bHQ7Cit9CisKIHZvaWQgRWRpdG9y OjpzZWxlY3RDb21wb3NpdGlvbigpCiB7CiAgICAgUmVmUHRyPFJhbmdlPiByYW5nZSA9IGNvbXBv c2l0aW9uUmFuZ2UoKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuaAkocmV2aXNpb24gMTQx Nzk4KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuaAkod29ya2luZyBjb3B5KQpA QCAtMzczLDExICszNzMsMTEgQEAgcHVibGljOgogICAgIGJvb2wgZG9UZXh0RmllbGRDb21tYW5k RnJvbUV2ZW50KEVsZW1lbnQqLCBLZXlib2FyZEV2ZW50Kik7CiAgICAgdm9pZCB0ZXh0V2lsbEJl RGVsZXRlZEluVGV4dEZpZWxkKEVsZW1lbnQqIGlucHV0KTsKICAgICB2b2lkIHRleHREaWRDaGFu Z2VJblRleHRBcmVhKEVsZW1lbnQqKTsKKyAgICBXcml0aW5nRGlyZWN0aW9uIGJhc2VXcml0aW5n RGlyZWN0aW9uRm9yU2VsZWN0aW9uU3RhcnQoKSBjb25zdDsKIAogI2lmIFBMQVRGT1JNKE1BQykK ICAgICBjb25zdCBTaW1wbGVGb250RGF0YSogZm9udEZvclNlbGVjdGlvbihib29sJikgY29uc3Q7 CiAgICAgTlNEaWN0aW9uYXJ5KiBmb250QXR0cmlidXRlc0ZvclNlbGVjdGlvblN0YXJ0KCkgY29u c3Q7Ci0gICAgV3JpdGluZ0RpcmVjdGlvbiBiYXNlV3JpdGluZ0RpcmVjdGlvbkZvclNlbGVjdGlv blN0YXJ0KCkgY29uc3Q7CiAgICAgYm9vbCBjYW5Db3B5RXhjbHVkaW5nU3RhbmRhbG9uZUltYWdl cygpOwogICAgIHZvaWQgdGFrZUZpbmRTdHJpbmdGcm9tU2VsZWN0aW9uKCk7CiAgICAgdm9pZCB3 cml0ZVNlbGVjdGlvblRvUGFzdGVib2FyZChjb25zdCBTdHJpbmcmIHBhc3RlYm9hcmROYW1lLCBj b25zdCBWZWN0b3I8U3RyaW5nPiYgcGFzdGVib2FyZFR5cGVzKTsKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2VkaXRpbmcvbWFjL0VkaXRvck1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9lZGl0aW5nL21hYy9FZGl0b3JNYWMubW0JKHJldmlzaW9uIDE0MTc5OCkKKysrIFNvdXJjZS9X ZWJDb3JlL2VkaXRpbmcvbWFjL0VkaXRvck1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjUxLDQx ICsyNTEsNiBAQCBOU0RpY3Rpb25hcnkqIEVkaXRvcjo6Zm9udEF0dHJpYnV0ZXNGb3JTCiAgICAg cmV0dXJuIHJlc3VsdDsKIH0KIAotV3JpdGluZ0RpcmVjdGlvbiBFZGl0b3I6OmJhc2VXcml0aW5n RGlyZWN0aW9uRm9yU2VsZWN0aW9uU3RhcnQoKSBjb25zdAotewotICAgIFdyaXRpbmdEaXJlY3Rp b24gcmVzdWx0ID0gTGVmdFRvUmlnaHRXcml0aW5nRGlyZWN0aW9uOwotCi0gICAgUG9zaXRpb24g cG9zID0gbV9mcmFtZS0+c2VsZWN0aW9uKCktPnNlbGVjdGlvbigpLnZpc2libGVTdGFydCgpLmRl ZXBFcXVpdmFsZW50KCk7Ci0gICAgTm9kZSogbm9kZSA9IHBvcy5kZXByZWNhdGVkTm9kZSgpOwot ICAgIGlmICghbm9kZSkKLSAgICAgICAgcmV0dXJuIHJlc3VsdDsKLQotICAgIFJlbmRlck9iamVj dCogcmVuZGVyZXIgPSBub2RlLT5yZW5kZXJlcigpOwotICAgIGlmICghcmVuZGVyZXIpCi0gICAg ICAgIHJldHVybiByZXN1bHQ7Ci0KLSAgICBpZiAoIXJlbmRlcmVyLT5pc0Jsb2NrRmxvdygpKSB7 Ci0gICAgICAgIHJlbmRlcmVyID0gcmVuZGVyZXItPmNvbnRhaW5pbmdCbG9jaygpOwotICAgICAg ICBpZiAoIXJlbmRlcmVyKQotICAgICAgICAgICAgcmV0dXJuIHJlc3VsdDsKLSAgICB9Ci0KLSAg ICBSZW5kZXJTdHlsZSogc3R5bGUgPSByZW5kZXJlci0+c3R5bGUoKTsKLSAgICBpZiAoIXN0eWxl KQotICAgICAgICByZXR1cm4gcmVzdWx0OwotICAgICAgICAKLSAgICBzd2l0Y2ggKHN0eWxlLT5k aXJlY3Rpb24oKSkgewotICAgICAgICBjYXNlIExUUjoKLSAgICAgICAgICAgIHJlc3VsdCA9IExl ZnRUb1JpZ2h0V3JpdGluZ0RpcmVjdGlvbjsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICBj YXNlIFJUTDoKLSAgICAgICAgICAgIHJlc3VsdCA9IFJpZ2h0VG9MZWZ0V3JpdGluZ0RpcmVjdGlv bjsKLSAgICAgICAgICAgIGJyZWFrOwotICAgIH0KLQotICAgIHJldHVybiByZXN1bHQ7Ci19Ci0K IGJvb2wgRWRpdG9yOjpjYW5Db3B5RXhjbHVkaW5nU3RhbmRhbG9uZUltYWdlcygpCiB7CiAgICAg RnJhbWVTZWxlY3Rpb24qIHNlbGVjdGlvbiA9IG1fZnJhbWUtPnNlbGVjdGlvbigpOwo=