108973 2013-02-05 12:59:56 -0800 Negative text indents can break RenderBlock's inline maximum preferred width calculation 2013-02-07 06:50:05 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leviw leviw eae eric mitz ojan.autocc robert webkit.review.bot zan oldest_to_newest 825740 0 leviw 2013-02-05 12:59:56 -0800 This occurs when the negative text indent is larger than the line's inline minimum preferred width. 825742 1 186685 leviw 2013-02-05 13:02:30 -0800 Created attachment 186685 Test case 826624 2 186891 leviw 2013-02-06 12:12:00 -0800 Created attachment 186891 Patch 826697 3 186891 eae 2013-02-06 13:20:34 -0800 Comment on attachment 186891 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186891&action=review Have you tested this for rtl content and with a negative margin-right? > Source/WebCore/rendering/RenderBlock.cpp:5873 > + // Only gets added to the max preffered width once. typo, s/preffered/preferred/ 826748 4 186916 leviw 2013-02-06 14:06:14 -0800 Created attachment 186916 Patch 826792 5 186916 webkit.review.bot 2013-02-06 15:10:36 -0800 Comment on attachment 186916 Patch Clearing flags on attachment: 186916 Committed r142042: <http://trac.webkit.org/changeset/142042> 826793 6 webkit.review.bot 2013-02-06 15:10:39 -0800 All reviewed patches have been landed. Closing bug. 827102 7 zan 2013-02-07 00:23:25 -0800 The layout test added in this patch is failing on GTK. Could the failure be caused by the subpixel layout being disabled? For reference, here's the expected and actual image output. http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r142063%20(34139)/fast/css/negative-text-indent-in-inline-block-diffs.html 827452 8 eae 2013-02-07 06:50:05 -0800 That looks like a subpixel alignment issue. The good news is that there is no line break though. 186685 2013-02-05 13:02:30 -0800 2013-02-05 13:02:30 -0800 Test case temp2.html text/html 219 leviw PGh0bWw+CjxoZWFkPgo8c3R5bGU+CmRpdiB7CiAgZGlzcGxheTogaW5saW5lLWJsb2NrOwogIHBh ZGRpbmctbGVmdDogMzBweDsKICBib3JkZXI6IHNvbGlkIGJsYWNrIDFweDsKICB0ZXh0LWluZGVu dDogLTMwcHg7Cn0KCjwvc3R5bGU+CjwvaGVhZD4KPGJvZHk+CjxkaXYgY2xhc3M9ImNoZWNrYm94 IGlubGluZSIgc3R5bGU9IiI+PHNwYW4+VGhpcyBoZXJlPC9zcGFuPgo8L2Rpdj4K 186891 2013-02-06 12:12:00 -0800 2013-02-06 14:06:11 -0800 Patch bug-108973-20130206120836.patch text/plain 6608 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MjAxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDEzLTAyLTA2ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBOZWdhdGl2ZSB0ZXh0IGlu ZGVudHMgY2FuIGJyZWFrIFJlbmRlckJsb2NrJ3MgaW5saW5lIG1heGltdW0gcHJlZmVycmVkIHdp ZHRoIGNhbGN1bGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDg5NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBDaGFuZ2UgdHdvIHF1aXJrcyBhYm91dCB0byBob3cgd2UgY2FsY3VsYXRlIGEgYmxv Y2sncyBpbmxpbmUgcHJlZmVycmVkIHdpZHRoIHdpdGgKKyAgICAgICAgdGV4dC1pbmRlbnQuCisK KyAgICAgICAgRmlyc3QsIHJlLXVzZSB0ZXh0LWluZGVudCB0aGF0J3MgZmlyc3QgYXBwbGllZCB0 byBmbG9hdHMgb24gdGV4dCB0aGF0IGZvbGxvd3MgaXQuCisgICAgICAgIFRoaXMgbWF0Y2hlcyBM YXlvdXQsIGFzIG90aGVyd2lzZSB3ZSBjYW4gcHJlbWF0dXJlbHkgd3JhcCB0ZXh0IHdoZW4gdGhl cmUncyBhIG5lZ2F0aXZlCisgICAgICAgIG1hcmdpbiBvbiBhIGJsb2NrIHN0YXJ0aW5nIHdpdGgg YSBmbG9hdC4gVGhpcyBhbHNvIG1hdGNoZXMgRmlyZUZveC4KKworICAgICAgICBTZWNvbmQsIGNv cnJlY3QgaG93IHRoZSBtYXggcHJlZmVycmVkIHdpZHRoIGlzIGNhbGN1bGF0ZWQgaW4gdGhlIHBy ZXNlbmNlIG9mIGEgbmVnYXRpdmUKKyAgICAgICAgdGV4dC1pbmRlbnQuIElmIHRoZSB0ZXh0LWlu ZGVudCBpcyBtb3JlIG5lZ2F0aXZlIHRoYW4gdGhlIGZpcnN0IHRleHQgbGluZSBicmVhaywgd2UK KyAgICAgICAgdXBkYXRlIHRoZSB2YWx1ZSB0byBiZSB0aGUgcmVtYWluZGVyLiBQcmV2aW91c2x5 LCB3ZSBhZGRlZCB0aGlzIHJlbWFpbmluZyBuZWdhdGl2ZSB2YWx1ZQorICAgICAgICB0byBzdWJz ZXF1ZW50IG1pbmltdW0gYW5kIG1heGltdW0gcHJlZmVycmVkIHdpZHRoIGNhbGN1bGF0aW9ucyAo dW50aWwgdGhlIHJlbWFpbmRlciB3YXMKKyAgICAgICAgZ29uZSkuIFRoaXMgaXMgd3JvbmcgZm9y IHRoZSBtYXggcHJlZmVycmVkIHdpZHRoLCBhcyB3ZSdyZSBhZGRpbmcgdGhlIG5lZ2F0aXZlIHZh bHVlIG1vcmUKKyAgICAgICAgdGhhbiBvbmNlLCBhbmQgbGVhZHMgdG8gYSBtYXggcHJlZmVycmVk IHdpZHRoIHRoYXQncyBzbWFsbGVyIHRoYW4gb3VyIGxpbmUuCisKKyAgICAgICAgVGVzdDogZmFz dC9jc3MvbmVnYXRpdmUtdGV4dC1pbmRlbnQtaW4taW5saW5lLWJsb2NrLmh0bWwKKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJC bG9jazo6Y29tcHV0ZUlubGluZVByZWZlcnJlZExvZ2ljYWxXaWR0aHMpOgorCiAyMDEzLTAyLTA2 ICBTaGF3biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbmRl ckxheWVyIGhhc1Zpc2libGVDb250ZW50KCkgaGFzIGluY29uc2lzdGVudCBzZW1hbnRpY3MgY2F1 c2luZyBkaXNhcHBlYXJpbmcgY29tcG9zaXRlZCBsYXllcnMKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkocmV2aXNpb24gMTQwNjA2KQorKysgU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTg2OSw3 ICs1ODY5LDEyIEBAIHZvaWQgUmVuZGVyQmxvY2s6OmNvbXB1dGVJbmxpbmVQcmVmZXJyZWQKICAg ICBhdXRvV3JhcCA9IG9sZEF1dG9XcmFwID0gc3R5bGVUb1VzZS0+YXV0b1dyYXAoKTsKIAogICAg IElubGluZU1pbk1heEl0ZXJhdG9yIGNoaWxkSXRlcmF0b3IodGhpcyk7Ci0gICAgYm9vbCBhZGRl ZFRleHRJbmRlbnQgPSBmYWxzZTsgLy8gT25seSBnZXRzIGFkZGVkIGluIG9uY2UuCisKKyAgICAv LyBPbmx5IGdldHMgYWRkZWQgdG8gdGhlIG1heCBwcmVmZmVyZWQgd2lkdGggb25jZS4KKyAgICBi b29sIGFkZGVkVGV4dEluZGVudCA9IGZhbHNlOworICAgIC8vIFNpZ25hbHMgdGhlIHRleHQgaW5k ZW50IHdhcyBtb3JlIG5lZ2F0aXZlIHRoYW4gdGhlIG1pbiBwcmVmZXJyZWQgd2lkdGgKKyAgICBi b29sIGhhc1JlbWFpbmluZ05lZ2F0aXZlVGV4dEluZGVudCA9IGZhbHNlOworCiAgICAgTGF5b3V0 VW5pdCB0ZXh0SW5kZW50ID0gbWluaW11bVZhbHVlRm9yTGVuZ3RoKHN0eWxlVG9Vc2UtPnRleHRJ bmRlbnQoKSwgY3csIHZpZXcoKSk7CiAgICAgUmVuZGVyT2JqZWN0KiBwcmV2RmxvYXQgPSAwOwog ICAgIGJvb2wgaXNQcmV2Q2hpbGRJbmxpbmVGbG93ID0gZmFsc2U7CkBAIC01OTc1LDcgKzU5ODAs NyBAQCB2b2lkIFJlbmRlckJsb2NrOjpjb21wdXRlSW5saW5lUHJlZmVycmVkCiAKICAgICAgICAg ICAgICAgICAvLyBBZGQgaW4gdGV4dC1pbmRlbnQuICBUaGlzIGlzIGFkZGVkIGluIG9ubHkgb25j ZS4KICAgICAgICAgICAgICAgICBMYXlvdXRVbml0IHRpID0gMDsKLSAgICAgICAgICAgICAgICBp ZiAoIWFkZGVkVGV4dEluZGVudCkgeworICAgICAgICAgICAgICAgIGlmICghYWRkZWRUZXh0SW5k ZW50ICYmICFjaGlsZC0+aXNGbG9hdGluZygpKSB7CiAgICAgICAgICAgICAgICAgICAgIHRpID0g dGV4dEluZGVudDsKICAgICAgICAgICAgICAgICAgICAgY2hpbGRNaW4gKz0gdGkuY2VpbFRvRmxv YXQoKTsKICAgICAgICAgICAgICAgICAgICAgY2hpbGRNYXggKz0gdGkuY2VpbFRvRmxvYXQoKTsK QEAgLTYwNTUsMTggKzYwNjAsMjQgQEAgdm9pZCBSZW5kZXJCbG9jazo6Y29tcHV0ZUlubGluZVBy ZWZlcnJlZAogCiAgICAgICAgICAgICAgICAgLy8gQWRkIGluIHRleHQtaW5kZW50LiAgVGhpcyBp cyBhZGRlZCBpbiBvbmx5IG9uY2UuCiAgICAgICAgICAgICAgICAgZmxvYXQgdGkgPSAwOwotICAg ICAgICAgICAgICAgIGlmICghYWRkZWRUZXh0SW5kZW50KSB7CisgICAgICAgICAgICAgICAgaWYg KCFhZGRlZFRleHRJbmRlbnQgfHwgaGFzUmVtYWluaW5nTmVnYXRpdmVUZXh0SW5kZW50KSB7CiAg ICAgICAgICAgICAgICAgICAgIHRpID0gdGV4dEluZGVudC5jZWlsVG9GbG9hdCgpOwotICAgICAg ICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAgY2hpbGRNaW4gKz0gdGk7Ci0gICAg ICAgICAgICAgICAgICAgIGNoaWxkTWF4ICs9IHRpOwogICAgICAgICAgICAgICAgICAgICBiZWdp bk1pbiArPSB0aTsKLSAgICAgICAgICAgICAgICAgICAgYmVnaW5NYXggKz0gdGk7CiAgICAgICAg ICAgICAgICAgICAgIAotICAgICAgICAgICAgICAgICAgICBpZiAoY2hpbGRNaW4gPCAwKQotICAg ICAgICAgICAgICAgICAgICAgICAgdGV4dEluZGVudCA9IGNoaWxkTWluOwotICAgICAgICAgICAg ICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgICAgIC8vIEl0IHRoZSB0ZXh0IGluZGVudCBu ZWdhdGl2ZSBhbmQgbGFyZ2VyIHRoYW4gdGhlIGNoaWxkIG1pbmltdW0sIHdlIHJlLXVzZSB0aGUg cmVtYWluZGVyCisgICAgICAgICAgICAgICAgICAgIC8vIGluIGZ1dHVyZSBtaW5pbXVtIGNhbGN1 bGF0aW9ucywgYnV0IHVzaW5nIHRoZSBuZWdhdGl2ZSB2YWx1ZSBhZ2FpbiBvbiB0aGUgbWF4aW11 bQorICAgICAgICAgICAgICAgICAgICAvLyB3aWxsIGxlYWQgdG8gdW5kZXItY291bnRpbmcgdGhl IG1heCBwcmVmIHdpZHRoLgorICAgICAgICAgICAgICAgICAgICBpZiAoIWFkZGVkVGV4dEluZGVu dCkgeworICAgICAgICAgICAgICAgICAgICAgICAgY2hpbGRNYXggKz0gdGk7CisgICAgICAgICAg ICAgICAgICAgICAgICBiZWdpbk1heCArPSB0aTsKICAgICAgICAgICAgICAgICAgICAgICAgIGFk ZGVkVGV4dEluZGVudCA9IHRydWU7CisgICAgICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAg ICAgICAgICAgCisgICAgICAgICAgICAgICAgICAgIGlmIChjaGlsZE1pbiA8IDApIHsKKyAgICAg ICAgICAgICAgICAgICAgICAgIHRleHRJbmRlbnQgPSBjaGlsZE1pbjsKKyAgICAgICAgICAgICAg ICAgICAgICAgIGhhc1JlbWFpbmluZ05lZ2F0aXZlVGV4dEluZGVudCA9IHRydWU7CisgICAgICAg ICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgCiAgICAg ICAgICAgICAgICAgLy8gSWYgd2UgaGF2ZSBubyBicmVha2FibGUgY2hhcmFjdGVycyBhdCBhbGws CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCShyZXZpc2lvbiAxNDIwMTMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wMi0wNiAgTGV2aSBXZWludHJhdWIg IDxsZXZpd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTmVnYXRpdmUgdGV4dCBpbmRlbnRzIGNh biBicmVhayBSZW5kZXJCbG9jaydzIGlubGluZSBtYXhpbXVtIHByZWZlcnJlZCB3aWR0aCBjYWxj dWxhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA4OTczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBmYXN0L2Nzcy9uZWdhdGl2ZS10ZXh0LWluZGVudC1pbi1pbmxpbmUtYmxvY2stZXhwZWN0ZWQu aHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9jc3MvbmVnYXRpdmUtdGV4dC1pbmRlbnQtaW4t aW5saW5lLWJsb2NrLmh0bWw6IEFkZGVkLgorCiAyMDEzLTAyLTA2ICBTaGF3biBTaW5naCAgPHNo YXduc2luZ2hAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbmRlckxheWVyIGhhc1Zpc2libGVD b250ZW50KCkgaGFzIGluY29uc2lzdGVudCBzZW1hbnRpY3MgY2F1c2luZyBkaXNhcHBlYXJpbmcg Y29tcG9zaXRlZCBsYXllcnMKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY3NzL25lZ2F0aXZlLXRl eHQtaW5kZW50LWluLWlubGluZS1ibG9jay1leHBlY3RlZC5odG1sCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvY3NzL25lZ2F0aXZlLXRleHQtaW5kZW50LWluLWlubGluZS1ibG9jay1l eHBlY3RlZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jc3MvbmVnYXRp dmUtdGV4dC1pbmRlbnQtaW4taW5saW5lLWJsb2NrLWV4cGVjdGVkLmh0bWwJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsMTUgQEAKKzxodG1sPgorPGhlYWQ+Cis8c3R5bGU+CisuaW5saW5lQmxvY2sg eworICBkaXNwbGF5OiBpbmxpbmUtYmxvY2s7CisgIHBhZGRpbmctbGVmdDogMzBweDsKKyAgYm9y ZGVyOiBzb2xpZCBibGFjayAxcHg7CisgIHRleHQtaW5kZW50OiAtMzBweDsKK30KKzwvc3R5bGU+ Cis8L2hlYWQ+Cis8Ym9keT4KKzxwPkFsbCB0aGUgdGV4dCBiZWxvdyBzaG91bGQgYmUgb24gb25l IGxpbmUuPC9wPgorPGRpdiBjbGFzcz0iaW5saW5lQmxvY2siPlRoaXMgaGVyZTwvZGl2PgorPGRp diBjbGFzcz0iaW5saW5lQmxvY2siPlRoaXMgaGVyZTwvZGl2PgpJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC9jc3MvbmVnYXRpdmUtdGV4dC1pbmRlbnQtaW4taW5saW5lLWJsb2NrLmh0bWwKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jc3MvbmVnYXRpdmUtdGV4dC1pbmRlbnQtaW4taW5s aW5lLWJsb2NrLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9uZWdh dGl2ZS10ZXh0LWluZGVudC1pbi1pbmxpbmUtYmxvY2suaHRtbAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSwyNCBAQAorPGh0bWw+Cis8aGVhZD4KKzxzdHlsZT4KKy5pbmxpbmVCbG9jayB7CisgIGRp c3BsYXk6IGlubGluZS1ibG9jazsKKyAgcGFkZGluZy1sZWZ0OiAzMHB4OworICBib3JkZXI6IHNv bGlkIGJsYWNrIDFweDsKKyAgdGV4dC1pbmRlbnQ6IC0zMHB4OworfQorCisuZmxvYXQgeworICBm bG9hdDogbGVmdDsKKyAgbWFyZ2luLWxlZnQ6IC0yMHB4OworICB2aXNpYmlsaXR5OiBoaWRkZW47 Cit9CisKKzwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwPkFsbCB0aGUgdGV4dCBiZWxvdyBz aG91bGQgYmUgb24gb25lIGxpbmUuPC9wPgorPGRpdiBjbGFzcz0iaW5saW5lQmxvY2siPjxzcGFu PlRoaXMgaGVyZTwvc3Bhbj4KKzwvZGl2PgorPGRpdiBjbGFzcz0iaW5saW5lQmxvY2siPjxpbnB1 dCB0eXBlPSJjaGVja2JveCIgY2xhc3M9ImZsb2F0IiAvPiAKK1RoaXMgaGVyZTwvZGl2Pgo= 186916 2013-02-06 14:06:14 -0800 2013-02-06 15:10:36 -0800 Patch bug-108973-20130206140250.patch text/plain 7114 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MjAzMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDEzLTAyLTA2ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBOZWdhdGl2ZSB0ZXh0IGlu ZGVudHMgY2FuIGJyZWFrIFJlbmRlckJsb2NrJ3MgaW5saW5lIG1heGltdW0gcHJlZmVycmVkIHdp ZHRoIGNhbGN1bGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDg5NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBDaGFuZ2UgdHdvIHF1aXJrcyBhYm91dCB0byBob3cgd2UgY2FsY3VsYXRlIGEgYmxv Y2sncyBpbmxpbmUgcHJlZmVycmVkIHdpZHRoIHdpdGgKKyAgICAgICAgdGV4dC1pbmRlbnQuCisK KyAgICAgICAgRmlyc3QsIHJlLXVzZSB0ZXh0LWluZGVudCB0aGF0J3MgZmlyc3QgYXBwbGllZCB0 byBmbG9hdHMgb24gdGV4dCB0aGF0IGZvbGxvd3MgaXQuCisgICAgICAgIFRoaXMgbWF0Y2hlcyBM YXlvdXQsIGFzIG90aGVyd2lzZSB3ZSBjYW4gcHJlbWF0dXJlbHkgd3JhcCB0ZXh0IHdoZW4gdGhl cmUncyBhIG5lZ2F0aXZlCisgICAgICAgIG1hcmdpbiBvbiBhIGJsb2NrIHN0YXJ0aW5nIHdpdGgg YSBmbG9hdC4gVGhpcyBhbHNvIG1hdGNoZXMgRmlyZUZveC4KKworICAgICAgICBTZWNvbmQsIGNv cnJlY3QgaG93IHRoZSBtYXggcHJlZmVycmVkIHdpZHRoIGlzIGNhbGN1bGF0ZWQgaW4gdGhlIHBy ZXNlbmNlIG9mIGEgbmVnYXRpdmUKKyAgICAgICAgdGV4dC1pbmRlbnQuIElmIHRoZSB0ZXh0LWlu ZGVudCBpcyBtb3JlIG5lZ2F0aXZlIHRoYW4gdGhlIGZpcnN0IHRleHQgbGluZSBicmVhaywgd2UK KyAgICAgICAgdXBkYXRlIHRoZSB2YWx1ZSB0byBiZSB0aGUgcmVtYWluZGVyLiBQcmV2aW91c2x5 LCB3ZSBhZGRlZCB0aGlzIHJlbWFpbmluZyBuZWdhdGl2ZSB2YWx1ZQorICAgICAgICB0byBzdWJz ZXF1ZW50IG1pbmltdW0gYW5kIG1heGltdW0gcHJlZmVycmVkIHdpZHRoIGNhbGN1bGF0aW9ucyAo dW50aWwgdGhlIHJlbWFpbmRlciB3YXMKKyAgICAgICAgZ29uZSkuIFRoaXMgaXMgd3JvbmcgZm9y IHRoZSBtYXggcHJlZmVycmVkIHdpZHRoLCBhcyB3ZSdyZSBhZGRpbmcgdGhlIG5lZ2F0aXZlIHZh bHVlIG1vcmUKKyAgICAgICAgdGhhbiBvbmNlLCBhbmQgbGVhZHMgdG8gYSBtYXggcHJlZmVycmVk IHdpZHRoIHRoYXQncyBzbWFsbGVyIHRoYW4gb3VyIGxpbmUuCisKKyAgICAgICAgVGVzdDogZmFz dC9jc3MvbmVnYXRpdmUtdGV4dC1pbmRlbnQtaW4taW5saW5lLWJsb2NrLmh0bWwKKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJC bG9jazo6Y29tcHV0ZUlubGluZVByZWZlcnJlZExvZ2ljYWxXaWR0aHMpOgorCiAyMDEzLTAyLTA2 ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkLCByb2xsaW5nIG91dCByMTQyMDI1LgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJsb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyQmxvY2suY3BwCShyZXZpc2lvbiAxNDA2MDYpCisrKyBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01ODY5LDcgKzU4 NjksMTIgQEAgdm9pZCBSZW5kZXJCbG9jazo6Y29tcHV0ZUlubGluZVByZWZlcnJlZAogICAgIGF1 dG9XcmFwID0gb2xkQXV0b1dyYXAgPSBzdHlsZVRvVXNlLT5hdXRvV3JhcCgpOwogCiAgICAgSW5s aW5lTWluTWF4SXRlcmF0b3IgY2hpbGRJdGVyYXRvcih0aGlzKTsKLSAgICBib29sIGFkZGVkVGV4 dEluZGVudCA9IGZhbHNlOyAvLyBPbmx5IGdldHMgYWRkZWQgaW4gb25jZS4KKworICAgIC8vIE9u bHkgZ2V0cyBhZGRlZCB0byB0aGUgbWF4IHByZWZmZXJlZCB3aWR0aCBvbmNlLgorICAgIGJvb2wg YWRkZWRUZXh0SW5kZW50ID0gZmFsc2U7CisgICAgLy8gU2lnbmFscyB0aGUgdGV4dCBpbmRlbnQg d2FzIG1vcmUgbmVnYXRpdmUgdGhhbiB0aGUgbWluIHByZWZlcnJlZCB3aWR0aAorICAgIGJvb2wg aGFzUmVtYWluaW5nTmVnYXRpdmVUZXh0SW5kZW50ID0gZmFsc2U7CisKICAgICBMYXlvdXRVbml0 IHRleHRJbmRlbnQgPSBtaW5pbXVtVmFsdWVGb3JMZW5ndGgoc3R5bGVUb1VzZS0+dGV4dEluZGVu dCgpLCBjdywgdmlldygpKTsKICAgICBSZW5kZXJPYmplY3QqIHByZXZGbG9hdCA9IDA7CiAgICAg Ym9vbCBpc1ByZXZDaGlsZElubGluZUZsb3cgPSBmYWxzZTsKQEAgLTU5NzUsNyArNTk4MCw3IEBA IHZvaWQgUmVuZGVyQmxvY2s6OmNvbXB1dGVJbmxpbmVQcmVmZXJyZWQKIAogICAgICAgICAgICAg ICAgIC8vIEFkZCBpbiB0ZXh0LWluZGVudC4gIFRoaXMgaXMgYWRkZWQgaW4gb25seSBvbmNlLgog ICAgICAgICAgICAgICAgIExheW91dFVuaXQgdGkgPSAwOwotICAgICAgICAgICAgICAgIGlmICgh YWRkZWRUZXh0SW5kZW50KSB7CisgICAgICAgICAgICAgICAgaWYgKCFhZGRlZFRleHRJbmRlbnQg JiYgIWNoaWxkLT5pc0Zsb2F0aW5nKCkpIHsKICAgICAgICAgICAgICAgICAgICAgdGkgPSB0ZXh0 SW5kZW50OwogICAgICAgICAgICAgICAgICAgICBjaGlsZE1pbiArPSB0aS5jZWlsVG9GbG9hdCgp OwogICAgICAgICAgICAgICAgICAgICBjaGlsZE1heCArPSB0aS5jZWlsVG9GbG9hdCgpOwpAQCAt NjA1NSwxOCArNjA2MCwyNCBAQCB2b2lkIFJlbmRlckJsb2NrOjpjb21wdXRlSW5saW5lUHJlZmVy cmVkCiAKICAgICAgICAgICAgICAgICAvLyBBZGQgaW4gdGV4dC1pbmRlbnQuICBUaGlzIGlzIGFk ZGVkIGluIG9ubHkgb25jZS4KICAgICAgICAgICAgICAgICBmbG9hdCB0aSA9IDA7Ci0gICAgICAg ICAgICAgICAgaWYgKCFhZGRlZFRleHRJbmRlbnQpIHsKKyAgICAgICAgICAgICAgICBpZiAoIWFk ZGVkVGV4dEluZGVudCB8fCBoYXNSZW1haW5pbmdOZWdhdGl2ZVRleHRJbmRlbnQpIHsKICAgICAg ICAgICAgICAgICAgICAgdGkgPSB0ZXh0SW5kZW50LmNlaWxUb0Zsb2F0KCk7Ci0gICAgICAgICAg ICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICBjaGlsZE1pbiArPSB0aTsKLSAgICAgICAg ICAgICAgICAgICAgY2hpbGRNYXggKz0gdGk7CiAgICAgICAgICAgICAgICAgICAgIGJlZ2luTWlu ICs9IHRpOwotICAgICAgICAgICAgICAgICAgICBiZWdpbk1heCArPSB0aTsKICAgICAgICAgICAg ICAgICAgICAgCi0gICAgICAgICAgICAgICAgICAgIGlmIChjaGlsZE1pbiA8IDApCi0gICAgICAg ICAgICAgICAgICAgICAgICB0ZXh0SW5kZW50ID0gY2hpbGRNaW47Ci0gICAgICAgICAgICAgICAg ICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgLy8gSXQgdGhlIHRleHQgaW5kZW50IG5lZ2F0 aXZlIGFuZCBsYXJnZXIgdGhhbiB0aGUgY2hpbGQgbWluaW11bSwgd2UgcmUtdXNlIHRoZSByZW1h aW5kZXIKKyAgICAgICAgICAgICAgICAgICAgLy8gaW4gZnV0dXJlIG1pbmltdW0gY2FsY3VsYXRp b25zLCBidXQgdXNpbmcgdGhlIG5lZ2F0aXZlIHZhbHVlIGFnYWluIG9uIHRoZSBtYXhpbXVtCisg ICAgICAgICAgICAgICAgICAgIC8vIHdpbGwgbGVhZCB0byB1bmRlci1jb3VudGluZyB0aGUgbWF4 IHByZWYgd2lkdGguCisgICAgICAgICAgICAgICAgICAgIGlmICghYWRkZWRUZXh0SW5kZW50KSB7 CisgICAgICAgICAgICAgICAgICAgICAgICBjaGlsZE1heCArPSB0aTsKKyAgICAgICAgICAgICAg ICAgICAgICAgIGJlZ2luTWF4ICs9IHRpOwogICAgICAgICAgICAgICAgICAgICAgICAgYWRkZWRU ZXh0SW5kZW50ID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAg ICAgICAKKyAgICAgICAgICAgICAgICAgICAgaWYgKGNoaWxkTWluIDwgMCkgeworICAgICAgICAg ICAgICAgICAgICAgICAgdGV4dEluZGVudCA9IGNoaWxkTWluOworICAgICAgICAgICAgICAgICAg ICAgICAgaGFzUmVtYWluaW5nTmVnYXRpdmVUZXh0SW5kZW50ID0gdHJ1ZTsKKyAgICAgICAgICAg ICAgICAgICAgfQogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAKICAgICAgICAg ICAgICAgICAvLyBJZiB3ZSBoYXZlIG5vIGJyZWFrYWJsZSBjaGFyYWN0ZXJzIGF0IGFsbCwKSW5k ZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHJldmlzaW9uIDE0MjAzMSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAyLTA2ICBMZXZpIFdlaW50cmF1YiAgPGxl dml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBOZWdhdGl2ZSB0ZXh0IGluZGVudHMgY2FuIGJy ZWFrIFJlbmRlckJsb2NrJ3MgaW5saW5lIG1heGltdW0gcHJlZmVycmVkIHdpZHRoIGNhbGN1bGF0 aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg5 NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZh c3QvY3NzL25lZ2F0aXZlLXRleHQtaW5kZW50LWluLWlubGluZS1ibG9jay1leHBlY3RlZC5odG1s OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9uZWdhdGl2ZS10ZXh0LWluZGVudC1pbi1pbmxp bmUtYmxvY2suaHRtbDogQWRkZWQuCisKIDIwMTMtMDItMDYgIFNoZXJpZmYgQm90ICA8d2Via2l0 LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0 IHIxNDIwMjUuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9uZWdhdGl2ZS10ZXh0LWluZGVu dC1pbi1pbmxpbmUtYmxvY2stZXhwZWN0ZWQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L2Nzcy9uZWdhdGl2ZS10ZXh0LWluZGVudC1pbi1pbmxpbmUtYmxvY2stZXhwZWN0ZWQu aHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvY3NzL25lZ2F0aXZlLXRleHQt aW5kZW50LWluLWlubGluZS1ibG9jay1leHBlY3RlZC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCww ICsxLDMyIEBACis8aHRtbD4KKzxoZWFkPgorPHN0eWxlPgorLmlubGluZUJsb2NrIHsKKyAgZGlz cGxheTogaW5saW5lLWJsb2NrOworICBib3JkZXI6IHNvbGlkIGJsYWNrIDFweDsKKyAgdGV4dC1p bmRlbnQ6IC0zMHB4OworfQorCisjbHRyID4gZGl2IHsKKyAgcGFkZGluZy1sZWZ0OiAzMHB4Owor fQorCisjcnRsIHsKKwlkaXJlY3Rpb246IHJ0bDsKK30KKworI3J0bCA+IGRpdiB7CisgIHBhZGRp bmctcmlnaHQ6IDMwcHg7Cit9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+Cis8cD5Ob25lIG9m IHRoZSBpbmxpbmUgdGV4dCBib3hlcyBiZWxvdyBzaG91bGQgaGF2ZSB3cmFwcGluZyB0ZXh0Ljwv cD4KKzxkaXYgaWQ9Imx0ciI+Cis8ZGl2IGNsYXNzPSJpbmxpbmVCbG9jayI+VGhpcyBoZXJlPC9k aXY+Cis8ZGl2IGNsYXNzPSJpbmxpbmVCbG9jayI+VGhpcyBoZXJlPC9kaXY+Cis8L2Rpdj4KKzxk aXYgaWQ9InJ0bCI+Cis8ZGl2IGNsYXNzPSJpbmxpbmVCbG9jayI+VGhpcyBoZXJlPC9kaXY+Cis8 ZGl2IGNsYXNzPSJpbmxpbmVCbG9jayI+VGhpcyBoZXJlPC9kaXY+Cis8L2Rpdj4KSW5kZXg6IExh eW91dFRlc3RzL2Zhc3QvY3NzL25lZ2F0aXZlLXRleHQtaW5kZW50LWluLWlubGluZS1ibG9jay5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY3NzL25lZ2F0aXZlLXRleHQtaW5k ZW50LWluLWlubGluZS1ibG9jay5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFz dC9jc3MvbmVnYXRpdmUtdGV4dC1pbmRlbnQtaW4taW5saW5lLWJsb2NrLmh0bWwJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEsNDkgQEAKKzxodG1sPgorPGhlYWQ+Cis8c3R5bGU+CisuaW5saW5lQmxv Y2sgeworICBkaXNwbGF5OiBpbmxpbmUtYmxvY2s7CisgIGJvcmRlcjogc29saWQgYmxhY2sgMXB4 OworICB0ZXh0LWluZGVudDogLTMwcHg7Cit9CisKKyNmbG9hdCB7CisgIGZsb2F0OiBsZWZ0Owor ICBtYXJnaW4tbGVmdDogLTIwcHg7CisgIHZpc2liaWxpdHk6IGhpZGRlbjsKK30KKworI2Zsb2F0 UlRMIHsKKyAgZmxvYXQ6IHJpZ2h0OworICBtYXJnaW4tcmlnaHQ6IC0yMHB4OworICB2aXNpYmls aXR5OiBoaWRkZW47Cit9CisKKyNsdHIgPiBkaXYgeworICBwYWRkaW5nLWxlZnQ6IDMwcHg7Cit9 CisKKyNydGwgeworCWRpcmVjdGlvbjogcnRsOworfQorCisjcnRsID4gZGl2IHsKKyAgcGFkZGlu Zy1yaWdodDogMzBweDsKK30KKworPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5PgorPHA+Tm9uZSBv ZiB0aGUgaW5saW5lIHRleHQgYm94ZXMgYmVsb3cgc2hvdWxkIGhhdmUgd3JhcHBpbmcgdGV4dC48 L3A+Cis8ZGl2IGlkPSJsdHIiPgorPGRpdiBjbGFzcz0iaW5saW5lQmxvY2siPjxzcGFuPlRoaXMg aGVyZTwvc3Bhbj4KKzwvZGl2PgorPGRpdiBjbGFzcz0iaW5saW5lQmxvY2siPjxpbnB1dCB0eXBl PSJjaGVja2JveCIgaWQ9ImZsb2F0IiAvPiAKK1RoaXMgaGVyZTwvZGl2PgorPC9kaXY+Cis8ZGl2 IGlkPSJydGwiPgorPGRpdiBjbGFzcz0iaW5saW5lQmxvY2siPjxzcGFuPlRoaXMgaGVyZTwvc3Bh bj4KKzwvZGl2PgorPGRpdiBjbGFzcz0iaW5saW5lQmxvY2siPjxpbnB1dCB0eXBlPSJjaGVja2Jv eCIgaWQ9ImZsb2F0UlRMIiAvPiAKK1RoaXMgaGVyZTwvZGl2PgorPC9kaXY+Cg==